Skip to contentSkip to conversation

am33xx,ddr3: fix ddr3 sdram configuration

PATCH New Samuel Egli 2 participants 4 messages Dec 2, 2015 – Dec 14, 2015 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 am33xx,ddr3: fix ddr3 sdram configuration

This patch fixes the DDR3 initialization procedure in order to comply with DDR3 standard. A 500 us delay is specified between the DDR3 reset and clock enable signal. Until now, this delay was not respected. Some DDR3 chips don't bother but the bigger the RAM becomes the more likely it seems that this delay is needed. We observed that DRAM > 256 MB from the manufacturer Samsung have an issue when the specification is not respected.

Changes:

1) Add a 1 ms wait for L3 timeout error trigger

2) Don't delay DDR3 initialization
Bit 31 of emif_sdram_ref_ctrl shouldn't be set because his suppresses the initialization of DDR3

Cc Tom Rini <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Roger Meier <[email protected]>
Cc Heiko Schocher <[email protected]>
---
 arch/arm/cpu/armv7/am33xx/ddr.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
arch/arm/cpu/armv7/am33xx/ddr.c +10 -1
index b3fb0c4..888cf1f 100644
@@ -164,6 +164,13 @@ void config_sdram(const struct emif_regs *regs, int nr)
 		writel(regs->zq_config, &emif_reg[nr]->emif_zq_config);
 		writel(regs->sdram_config, &cstat->secure_emif_sdram_config);
 		writel(regs->sdram_config, &emif_reg[nr]->emif_sdram_config);
+
+		/* Trigger initialization */
+		writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl);
+		/* Wait 1ms because of L3 timeout error */
+		udelay(1000);
+
+		/* Write proper sdram_ref_cref_ctrl value */
 		writel(regs->ref_ctrl, &emif_reg[nr]->emif_sdram_ref_ctrl);
 		writel(regs->ref_ctrl, &emif_reg[nr]->emif_sdram_ref_ctrl_shdw);
 	}
@@ -292,7 +299,9 @@ void config_ddr_phy(const struct emif_regs *regs, int nr)
 		     EMIF_REG_INITREF_DIS_MASK);
 #endif
 	if (regs->zq_config)
-		writel(0x80003100, &emif_reg[nr]->emif_sdram_ref_ctrl);
+		/* Set time between rising edge of DDR_RESET to rising
+		 * edge of DDR_CKE to > 500us per memory spec. */
+		writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl);
 
 	writel(regs->emif_ddr_phy_ctlr_1,
 		&emif_reg[nr]->emif_ddr_phy_ctrl_1);
Signature · 1 line
2.1.4
#1 lore raw

PATCH 2/2 siemens,am33x: remove ddr3 delay workaround

Cc Roger Meier <[email protected]>
Cc Heiko Schocher <[email protected]>
---
 board/siemens/draco/board.c | 5 -----
 1 file changed, 5 deletions(-)
board/siemens/draco/board.c +0 -5
index 4882314..988c12a 100644
@@ -196,11 +196,6 @@ struct ctrl_ioregs draco_ddr3_ioregs = {
 
 	config_ddr(DDR_PLL_FREQ, &draco_ddr3_ioregs, &draco_ddr3_data,
 		   &draco_ddr3_cmd_ctrl_data, &draco_ddr3_emif_reg_data, 0);
-
-	/* For Samsung 2Gbit RAM we need this delay otherwise config fails after
-	 * soft reset.
-	 */
-	udelay(2000);
 }
 
 static void spl_siemens_board_init(void)
Signature · 1 line
2.1.4
#2 lore raw

PATCH 2/2 siemens, am33x: remove ddr3 delay workaround

Quoted 3 lines · Samuel
Cc Roger Meier <[email protected]>
Cc Heiko Schocher <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151214/b85646c6/attachment.sig>
#3 lore raw

PATCH 1/2 am33xx, ddr3: fix ddr3 sdram configuration

In reply to Samuel Egli
Quoted 17 lines · Samuel

This patch fixes the DDR3 initialization procedure in order to comply with DDR3 standard. A 500 us delay is specified between the DDR3 reset and clock enable signal. Until now, this delay was not respected. Some DDR3 chips don't bother but the bigger the RAM becomes the more likely it seems that this delay is needed. We observed that DRAM > 256 MB from the manufacturer Samsung have an issue when the specification is not respected.

Changes:

1) Add a 1 ms wait for L3 timeout error trigger

2) Don't delay DDR3 initialization
Bit 31 of emif_sdram_ref_ctrl shouldn't be set because his suppresses the initialization of DDR3

Quoted 6 lines
Cc Tom Rini <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Roger Meier <[email protected]>
Cc Heiko Schocher <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151214/65304c74/attachment.sig>