package/nvme: new package

PATCH Superseded Mamatha Inamdar 2 participants 7 messages Jan 21, 2016 – Feb 12, 2016

Share & tools

Mamatha Inamdar

author

2016-01-21 05:36 UTC #0 lore raw

PATCH v7 1/1 package/nvme: new package

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Signed-off-by Mamatha Inamdar <[email protected]>

---
 package/Config.in                             |    1 +
 package/nvme/0001-NVME-Makefile-cleanup.patch |   25 +++++++++++++++++++++++++
 package/nvme/Config.in                        |    6 ++++++
 package/nvme/nvme.hash                        |    2 ++
 package/nvme/nvme.mk                          |   22 ++++++++++++++++++++++
 5 files changed, 56 insertions(+)
 create mode 100644 package/nvme/0001-NVME-Makefile-cleanup.patch
 create mode 100644 package/nvme/Config.in
 create mode 100644 package/nvme/nvme.hash
 create mode 100755 package/nvme/nvme.mk

package/Config.in +1 -0

index e0c2e2a..4d173d4 100644
@@ -380,6 +380,7 @@ endif
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
 	source "package/nvidia-tegra23/Config.in"
+	source "package/nvme/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"

package/nvme/0001-NVME-Makefile-cleanup.patch new file +25 -0

new file mode 100644
index 0000000..74beac9
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar <[email protected]>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar <[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall
+ CPPFLAGS += -I $(SRC) -D_GNU_SOURCE
+ NVME = nvme
+ INSTALL ?= install
+--
+1.9.3
+

package/nvme/Config.in new file +6 -0

new file mode 100644
index 0000000..8b5d37d
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli

package/nvme/nvme.hash new file +2 -0

new file mode 100644
index 0000000..539a2b6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  914319930a51372293c981562b165ae6af0de70f7da37e42da23940fe23aa387 nvme-v0.2.tar.gz

package/nvme/nvme.mk new file +22 -0

new file mode 100755
index 0000000..f06ed47
@@ -0,0 +1,22 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = v0.2
+NVME_SITE = $(call github,linux-nvme,nvme-cli,$(NVME_VERSION))
+NVME_LICENSE = GPLv2+
+NVME_LICENSE_FILES = COPYING
+
+define NVME_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		LIBUDEV=1 -C $(@D)
+endef
+
+define NVME_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
+		PREFIX=/usr install-bin
+endef
+
+$(eval $(generic-package))

Mamatha Inamdar

author

2016-02-04 06:08 UTC #1 lore raw

PATCH v7 1/1 package/nvme: new package

Hi Thomas,

When NVME patch will get into "buildroot" project ?

Quoted 113 lines · Mamatha Inamdar

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Signed-off-by Mamatha Inamdar <[email protected]>

---
  package/Config.in                             |    1 +
  package/nvme/0001-NVME-Makefile-cleanup.patch |   25 +++++++++++++++++++++++++
  package/nvme/Config.in                        |    6 ++++++
  package/nvme/nvme.hash                        |    2 ++
  package/nvme/nvme.mk                          |   22 ++++++++++++++++++++++
  5 files changed, 56 insertions(+)

create mode 100644 package/nvme/0001-NVME-Makefile-cleanup.patch create mode 100644 package/nvme/Config.in
create mode 100644 package/nvme/nvme.hash
create mode 100755 package/nvme/nvme.mk

package/Config.in +1 -0

index e0c2e2a..4d173d4 100644
@@ -380,6 +380,7 @@ endif
  	source "package/neard/Config.in"
  	source "package/nvidia-driver/Config.in"
  	source "package/nvidia-tegra23/Config.in"
+	source "package/nvme/Config.in"
  	source "package/ofono/Config.in"
  	source "package/ola/Config.in"
  	source "package/on2-8170-modules/Config.in"

package/nvme/0001-NVME-Makefile-cleanup.patch new file +25 -0

new file mode 100644
index 0000000..74beac9
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar <[email protected]>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar <[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall
+ CPPFLAGS += -I $(SRC) -D_GNU_SOURCE
+ NVME = nvme
+ INSTALL ?= install
+--
+1.9.3
+

package/nvme/Config.in new file +6 -0

new file mode 100644
index 0000000..8b5d37d
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli

package/nvme/nvme.hash new file +2 -0

new file mode 100644
index 0000000..539a2b6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  914319930a51372293c981562b165ae6af0de70f7da37e42da23940fe23aa387 nvme-v0.2.tar.gz

package/nvme/nvme.mk new file +22 -0

new file mode 100755
index 0000000..f06ed47
@@ -0,0 +1,22 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = v0.2
+NVME_SITE = $(call github,linux-nvme,nvme-cli,$(NVME_VERSION))
+NVME_LICENSE = GPLv2+
+NVME_LICENSE_FILES = COPYING
+
+define NVME_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		LIBUDEV=1 -C $(@D)
+endef
+
+define NVME_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
+		PREFIX=/usr install-bin
+endef
+
+$(eval $(generic-package))

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Mamatha Inamdar

author

2016-02-10 15:07 UTC #2 lore raw

PATCH v7 1/1 package/nvme: new package

Hi Thomas,

Please let us know when NVME patches will get into the build?

Quoted 36 lines · Mamatha Inamdar

Hi Thomas,
When NVME patch will get into "buildroot" project ?
Quoted 19 lines · Mamatha Inamdar
Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.
Signed-off-by Mamatha Inamdar <[email protected]>
---
  package/Config.in                             |    1 +
  package/nvme/0001-NVME-Makefile-cleanup.patch |   25 
+++++++++++++++++++++++++
  package/nvme/Config.in                        |    6 ++++++
  package/nvme/nvme.hash                        |    2 ++
  package/nvme/nvme.mk                          |   22 
++++++++++++++++++++++
  5 files changed, 56 insertions(+)
create mode 100644 package/nvme/0001-NVME-Makefile-cleanup.patch create mode 100644 package/nvme/Config.in
create mode 100644 package/nvme/nvme.hash
create mode 100755 package/nvme/nvme.mk
neric-package))
Quoted 5 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Arnout Vandecappelle

2016-02-10 20:59 UTC #3 lore raw

PATCH v7 1/1 package/nvme: new package

In reply to Mamatha Inamdar

Quoted 2 lines · Mamatha Inamdar

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

This text should be part of the Config.in help text.

Quoted 41 lines

Signed-off-by Mamatha Inamdar <[email protected]>

---
 package/Config.in                             |    1 +
 package/nvme/0001-NVME-Makefile-cleanup.patch |   25 +++++++++++++++++++++++++
 package/nvme/Config.in                        |    6 ++++++
 package/nvme/nvme.hash                        |    2 ++
 package/nvme/nvme.mk                          |   22 ++++++++++++++++++++++
 5 files changed, 56 insertions(+)
 create mode 100644 package/nvme/0001-NVME-Makefile-cleanup.patch
 create mode 100644 package/nvme/Config.in
 create mode 100644 package/nvme/nvme.hash
 create mode 100755 package/nvme/nvme.mk

package/Config.in +1 -0

index e0c2e2a..4d173d4 100644
@@ -380,6 +380,7 @@ endif
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
 	source "package/nvidia-tegra23/Config.in"
+	source "package/nvme/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"

package/nvme/0001-NVME-Makefile-cleanup.patch new file +9 -0

new file mode 100644
index 0000000..74beac9
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar <[email protected]>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar <[email protected]>
+---

package/nvme/0001-NVME-Makefile-cleanup.patch line 19

Quoted 10 lines

package/nvme/0001-NVME-Makefile-cleanup.patch new file +10 -0

+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall

This patch doesn't apply, the CFLAGS line looks completely different. Have you
tested your patch before submitting?

Quoted 12 lines

package/nvme/0001-NVME-Makefile-cleanup.patch new file +6 -0
+ CPPFLAGS += -I $(SRC) -D_GNU_SOURCE
+ NVME = nvme
+ INSTALL ?= install
+--
+1.9.3
+
package/nvme/Config.in new file +0 -0
new file mode 100644
index 0000000..8b5d37d

package/nvme/Config.in line 2

Quoted 2 lines

package/nvme/Config.in new file +2 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"

The CFLAGS explicitly pass -m64, so I guess it should depend on a 64-bit arch.
And since this is hardware support for IBM Power devices, I guess it's best to depend on BR2_powerpc64 || BR2_powerpc64le

Quoted 23 lines

package/nvme/Config.in new file +4 -0

+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli

package/nvme/nvme.hash new file +2 -0

new file mode 100644
index 0000000..539a2b6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  914319930a51372293c981562b165ae6af0de70f7da37e42da23940fe23aa387 nvme-v0.2.tar.gz

package/nvme/nvme.mk new file +5 -0

new file mode 100755
index 0000000..f06ed47
@@ -0,0 +1,22 @@
+################################################################################
+#
+# nvme
+#
+################################################################################

package/nvme/nvme.mk line 15

Quoted 10 lines

package/nvme/nvme.mk new file +10 -0

+
+NVME_VERSION = v0.2
+NVME_SITE = $(call github,linux-nvme,nvme-cli,$(NVME_VERSION))
+NVME_LICENSE = GPLv2+
+NVME_LICENSE_FILES = COPYING
+
+define NVME_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		LIBUDEV=1 -C $(@D)
+endef

This LIBUDEV is a bit counterintuitive, so add a comment saying that LIBUDEV=1
means that libudev is _disabled_.

It would also be good to mention in the commit log that udev handling is for a
later patch.

Regards,
Arnout

Quoted 13 lines

package/nvme/nvme.mk new file +7 -0
+
+define NVME_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
+		PREFIX=/usr install-bin
+endef
+
+$(eval $(generic-package))
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Mamatha Inamdar

author

2016-02-11 11:18 UTC #4 lore raw

PATCH v7 1/1 package/nvme: new package

Hi Arnout,

Thanks for the review comments
updated all your comments and sent new version of Patch.

Quoted 26 lines · Arnout Vandecappelle

package/nvme/0001-NVME-Makefile-cleanup.patch new file +19 -0

new file mode 100644
index 0000000..74beac9
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar <[email protected]>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar <[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall
  This patch doesn't apply, the CFLAGS line looks completely different. Have you

Quoted 1 line

tested your patch before submitting?

yes I have tested my patch and it will apply fine.

Quoted 6 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160211/997ead13/attachment.html>

Mamatha Inamdar

author

2016-02-11 16:35 UTC #5 lore raw

PATCH v7 1/1 package/nvme: new package

Hi Arnout,

please take a look at my comments below

Quoted 27 lines · Mamatha Inamdar

Thanks for the review comments
updated all your comments and sent new version of Patch.

Quoted 21 lines · Arnout Vandecappelle

package/nvme/0001-NVME-Makefile-cleanup.patch new file +15 -0

new file mode 100644
index 0000000..74beac9
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar<[email protected]>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar<[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile

Quoted 8 lines

Quoted 6 lines
package/nvme/0001-NVME-Makefile-cleanup.patch new file +4 -0
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall
  This patch doesn't apply, the CFLAGS line looks completely different. Have you
tested your patch before submitting?
yes I have tested my patch and it will apply fine.

With regard to the above comment, upon checking the patch again, I see some issues in applying the patch due to version mismatch.

While compiling op-build I see nvme-cli version 0.1 code is downloading which is the reason my patch fails to apply.
I have created the patch on version 0.2 (using git clone
https://github.com/linux-nvme/nvme-cli.git)

I am looking into the reason why older version of nvme-cli is getting downloaded during compilation of op-build.

Quoted 10 lines

Quoted 7 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160211/19e17d2e/attachment.html>

Mamatha Inamdar

author

2016-02-12 10:43 UTC #6 lore raw

PATCH v7 1/1 package/nvme: new package

Hi Arnout,

updated all your comments and sending new version of Patch.

Quoted 44 lines · Mamatha Inamdar

Hi Arnout,
please take a look at my comments below
Quoted 27 lines · Mamatha Inamdar
Thanks for the review comments
updated all your comments and sent new version of Patch.
Quoted 21 lines · Arnout Vandecappelle
package/nvme/0001-NVME-Makefile-cleanup.patch new file +15 -0
new file mode 100644
index 0000000..74beac9
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar<[email protected]>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar<[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile
Quoted 8 lines
Quoted 6 lines
package/nvme/0001-NVME-Makefile-cleanup.patch new file +4 -0
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall
  This patch doesn't apply, the CFLAGS line looks completely different. Have you
tested your patch before submitting?
yes I have tested my patch and it will apply fine.
With regard to the above comment, upon checking the patch again, I see some issues in applying the patch due to version mismatch.

Quoted 8 lines

While compiling op-build I see nvme-cli version 0.1 code is downloading which is the reason my patch fails to apply. I have created the patch on version 0.2 (using git clone
https://github.com/linux-nvme/nvme-cli.git)
I am looking into the reason why older version of nvme-cli is getting downloaded during compilation of op-build.

I worked on the above issue and tested the patch.
I am able to compile buildroot successfully with the patch. Sending new version of the patch with all your comments updated.

Thanks
Mamatha

Quoted 17 lines

Quoted 10 lines
Quoted 7 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160212/494f18c4/attachment.html>