Skip to contentSkip to conversation

package/nvme: new package

PATCH Superseded Mamatha Inamdar 2 participants 3 messages Feb 12, 2016 – Feb 14, 2016

v8 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Mamatha Inamdar

author
#0 lore raw

PATCH v8 1/1 package/nvme: new package

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Changes in V8:
/package/nvme/Makefile patch not added:
CFLAGS changes in nvme/Makefile is not required because I did not see any compilation errors after adding "depend on BR2_powerpc64 || BR2_powerpc64le" line in nvme/Config.in for this I have to enable 64-bit arch in config file. after enabling 64-bit arch I do not see any compilation errors in nvme code.

Signed-off-by Mamatha Inamdar <[email protected]>
---
 package/Config.in      |    1 +
 package/nvme/Config.in |   10 ++++++++++
 package/nvme/nvme.hash |    2 ++
 package/nvme/nvme.mk   |   23 +++++++++++++++++++++++
 4 files changed, 36 insertions(+)
 create mode 100644 package/nvme/Config.in
 create mode 100644 package/nvme/nvme.hash
 create mode 100755 package/nvme/nvme.mk
package/Config.in +1 -0
index e0c2e2a..4d173d4 100644
@@ -380,6 +380,7 @@ endif
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
 	source "package/nvidia-tegra23/Config.in"
+	source "package/nvme/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"
package/nvme/Config.in new file +10 -0
new file mode 100644
index 0000000..878bed3
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	depends on BR2_powerpc64 || BR2_powerpc64le
+
+	help
+	  Add support for building NVME utility - a utility
+	  for interacting with standard NVM Express
+	  (optimized PCI Express SSD interface) devices.
+
+	  https://github.com/linux-nvme/nvme-cli
package/nvme/nvme.hash new file +2 -0
new file mode 100644
index 0000000..539a2b6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  914319930a51372293c981562b165ae6af0de70f7da37e42da23940fe23aa387 nvme-v0.2.tar.gz
package/nvme/nvme.mk new file +23 -0
new file mode 100755
index 0000000..7bb4d24
@@ -0,0 +1,23 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = v0.2
+NVME_SITE = $(call github,linux-nvme,nvme-cli,$(NVME_VERSION))
+NVME_LICENSE = GPLv2+
+NVME_LICENSE_FILES = COPYING
+
+# LIBUDEV=1 means that libudev is _disabled_
+define NVME_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		LIBUDEV=1 -C $(@D)
+endef
+
+define NVME_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
+		PREFIX=/usr install-bin
+endef
+
+$(eval $(generic-package))
#1 lore raw

PATCH v8 1/1 package/nvme: new package

Dear Mamatha Inamdar,

Quoted 9 lines · Mamatha Inamdar

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Changes in V8:
/package/nvme/Makefile patch not added:
CFLAGS changes in nvme/Makefile is not required because I did not see any compilation errors after adding "depend on BR2_powerpc64 || BR2_powerpc64le" line in nvme/Config.in for this I have to enable 64-bit arch in config file. after enabling 64-bit arch I do not see any compilation errors in nvme code.

I know Arnout asked you to add the PowerPC64 dependency, but I disagree. I don't see anything in this tool that is PowerPC64 specific.

Moreover, the -m64 that was causing problem has been removed upstream, as part of commit
https://github.com/linux-nvme/nvme-cli/commit/3686759d04825d35fb8d9667c3d4a14e880f5b4d.

In fact, I believe this commit from upstream probably solves a lot of cross-compilation problems, so please use v0.3 instead of v0.2, since v0.3 includes this commit.

package/nvme/Config.in line 3

Quoted 9 lines
package/nvme/Config.in new file +3 -0
new file mode 100644
index 0000000..878bed3
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	depends on BR2_powerpc64 || BR2_powerpc64le

Remove this dependency.

package/nvme/Config.in line 4

Quoted 1 line
package/nvme/Config.in new file +1 -0
+

And this empty line/

package/nvme/Config.in line 6

Quoted 2 lines
package/nvme/Config.in new file +2 -0
+	help
+	  Add support for building NVME utility - a utility

"Add support" is not a proper wording to describe a package. Instead, you should just have something like:

	  NVME utility, a utility for interacting with standard NVM
	  Express ...

package/nvme/Config.in line 10

Quoted 4 lines
package/nvme/Config.in new file +4 -0
+	  for interacting with standard NVM Express
+	  (optimized PCI Express SSD interface) devices.
+
+	  https://github.com/linux-nvme/nvme-cli

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH v8 1/1 package/nvme: new package

Hi Thomas,

Yes nvme V0.3 will solve all compilation issues,
updated your comments and sending
new version of the patch.

Quoted 52 lines · Thomas Petazzoni

Dear Mamatha Inamdar,

Quoted 9 lines · Mamatha Inamdar

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Changes in V8:
/package/nvme/Makefile patch not added:
CFLAGS changes in nvme/Makefile is not required because I did not see any compilation errors after adding "depend on BR2_powerpc64 || BR2_powerpc64le" line in nvme/Config.in for this I have to enable 64-bit arch in config file. after enabling 64-bit arch I do not see any compilation errors in nvme code.

I know Arnout asked you to add the PowerPC64 dependency, but I disagree. I don't see anything in this tool that is PowerPC64 specific.

Moreover, the -m64 that was causing problem has been removed upstream, as part of commit
https://github.com/linux-nvme/nvme-cli/commit/3686759d04825d35fb8d9667c3d4a14e880f5b4d.

In fact, I believe this commit from upstream probably solves a lot of cross-compilation problems, so please use v0.3 instead of v0.2, since v0.3 includes this commit.

package/nvme/Config.in line 3

Quoted 9 lines
package/nvme/Config.in new file +3 -0
new file mode 100644
index 0000000..878bed3
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	depends on BR2_powerpc64 || BR2_powerpc64le

Remove this dependency.

package/nvme/Config.in line 4

Quoted 1 line
package/nvme/Config.in new file +1 -0
+

And this empty line/

package/nvme/Config.in line 6

Quoted 2 lines
package/nvme/Config.in new file +2 -0
+	help
+	  Add support for building NVME utility - a utility

"Add support" is not a proper wording to describe a package. Instead, you should just have something like:

	  NVME utility, a utility for interacting with standard NVM
	  Express ...

package/nvme/Config.in line 10

Quoted 4 lines
package/nvme/Config.in new file +4 -0
+	  for interacting with standard NVM Express
+	  (optimized PCI Express SSD interface) devices.
+
+	  https://github.com/linux-nvme/nvme-cli

Thanks,

Thomas