Skip to contentSkip to conversation

ARM: dts: sun7i: Add dts file for the lamobo-r1 board

PATCH RESEND Superseded Hans de Goede 2 participants 5 messages Jan 27, 2016 – Feb 1, 2016

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: sun7i: Add dts file for the lamobo-r1 board

Hi Maxime,

Here is a resend of the patch to add a dts file for the lamobo-r1 board, this one seems to have fallen through the cracks.

Did you miss it, or did you request changes and did I miss the changes request?

Regards,

Hans

#1 lore raw

PATCH RESEND 1/1 ARM: dts: sun7i: Add dts file for the lamobo-r1 board

From: Jelle de Jong <[email protected]>

The lamobo-r1 board, sometimes called the BPI-R1 but not labelled as such on the PCB, is meant as a A20 based router board. As such the board comes with a built-in switch chip giving it 5 gigabit ethernet boards, and it has a large empty area on the pcb with mounting holes which will fit a 2.5 inch harddisk. To complete its networking features it has a Realtek RTL8192CU for WiFi 802.11 b/g/n.

---
 arch/arm/boot/dts/Makefile                |   1 +
 arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 297 ++++++++++++++++++++++++++++++
 2 files changed, 298 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
arch/arm/boot/dts/Makefile +1 -0
index e062fb3..8954ef9 100644
@@ -668,6 +668,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
 	sun7i-a20-hummingbird.dtb \
 	sun7i-a20-i12-tvbox.dtb \
 	sun7i-a20-icnova-swac.dtb \
+	sun7i-a20-lamobo-r1.dtb \
 	sun7i-a20-m3.dtb \
 	sun7i-a20-mk808c.dtb \
 	sun7i-a20-olimex-som-evb.dtb \
arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts new file +297 -0

297 lines not on this page · raw message

Signature · 1 line
2.5.0
#2 lore raw

PATCH RESEND 1/1 ARM: dts: sun7i: Add dts file for the lamobo-r1 board

Hi Hans,

Quoted 11 lines · Hans de Goede

From: Jelle de Jong <[email protected]>

The lamobo-r1 board, sometimes called the BPI-R1 but not labelled as such on the PCB, is meant as a A20 based router board. As such the board comes with a built-in switch chip giving it 5 gigabit ethernet boards, and it has a large empty area on the pcb with mounting holes which will fit a 2.5 inch harddisk. To complete its networking features it has a Realtek RTL8192CU for WiFi 802.11 b/g/n.

Sorry that I missed it :/

It looks mostly fine, I just have a minor question / comment below.

arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts line 110

Quoted 13 lines

+&cpu0 {

arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts new file +12 -0
+	cpu-supply = <&reg_dcdc2>;
+	operating-points = <
+		/* kHz	  uV */
+		960000	1400000
+		912000	1400000
+		864000	1350000
+		720000	1250000
+		528000	1150000
+		312000	1100000
+		144000	1050000
+		>;
+};

Have you used the default OPPs and it turned out to be unstable, or is it just some copy / paste from the FEX file?

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/58caa72b/attachment.sig>
#3 lore raw

PATCH RESEND 1/1 ARM: dts: sun7i: Add dts file for the lamobo-r1 board

Hi,

Quoted 19 lines · Maxime Ripard

Hi Hans,

Quoted 11 lines · Hans de Goede

From: Jelle de Jong <[email protected]>

The lamobo-r1 board, sometimes called the BPI-R1 but not labelled as such on the PCB, is meant as a A20 based router board. As such the board comes with a built-in switch chip giving it 5 gigabit ethernet boards, and it has a large empty area on the pcb with mounting holes which will fit a 2.5 inch harddisk. To complete its networking features it has a Realtek RTL8192CU for WiFi 802.11 b/g/n.

Sorry that I missed it :/

It looks mostly fine, I just have a minor question / comment below.

Quoted 16 lines

arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts line 110

Quoted 13 lines

+&cpu0 {

arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts new file +12 -0
+	cpu-supply = <&reg_dcdc2>;
+	operating-points = <
+		/* kHz	  uV */
+		960000	1400000
+		912000	1400000
+		864000	1350000
+		720000	1250000
+		528000	1150000
+		312000	1100000
+		144000	1050000
+		>;
+};

Have you used the default OPPs and it turned out to be unstable, or is it just some copy / paste from the FEX file?

Just copy paste from the fex file, let me know if you want a new version with the opp-s removed.

Regards,

Hans

#4 lore raw

PATCH RESEND 1/1 ARM: dts: sun7i: Add dts file for the lamobo-r1 board

Hi,

Quoted 39 lines · Hans de Goede

Hi,

Quoted 19 lines · Maxime Ripard

Hi Hans,

Quoted 11 lines · Hans de Goede

From: Jelle de Jong <[email protected]>

The lamobo-r1 board, sometimes called the BPI-R1 but not labelled as such on the PCB, is meant as a A20 based router board. As such the board comes with a built-in switch chip giving it 5 gigabit ethernet boards, and it has a large empty area on the pcb with mounting holes which will fit a 2.5 inch harddisk. To complete its networking features it has a Realtek RTL8192CU for WiFi 802.11 b/g/n.

Sorry that I missed it :/

It looks mostly fine, I just have a minor question / comment below.

Quoted 16 lines

arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts line 110

Quoted 13 lines

+&cpu0 {

arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts new file +12 -0
+	cpu-supply = <&reg_dcdc2>;
+	operating-points = <
+		/* kHz	  uV */
+		960000	1400000
+		912000	1400000
+		864000	1350000
+		720000	1250000
+		528000	1150000
+		312000	1100000
+		144000	1050000
+		>;
+};

Have you used the default OPPs and it turned out to be unstable, or is it just some copy / paste from the FEX file?

Quoted 2 lines

Just copy paste from the fex file, let me know if you want a new version with the opp-s removed.

Yeah, if it works, please do so.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160201/cd3d9aa4/attachment.sig>