Skip to contentSkip to conversation

x86: dts: ce4100: Use defined compatible string for PCF8575 chip

PATCH In review Ben Hutchings 2 participants 2 messages Mar 16, 2016 – Mar 18, 2016

Subsystems (3)
Device tree bindings x86 I2C subsystem host drivers
lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

PATCH v2 1/1 x86: dts: ce4100: Use defined compatible string for PCF8575 chip

The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.

This is not a problem in practice because the I2C core uses of_modalias_node() before matching drivers and this strips the manufacturer name.

Signed-off-by Ben Hutchings <[email protected]>

---
v2: Correct the claim that this is a practical problem.

 Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++--
 arch/x86/platform/ce4100/falconfalls.dts                     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt +2 -2
index 569b16248514..1ff6f8487a2d 100644
@@ -71,7 +71,7 @@ This is an example which is used on FalconFalls:
 			/* This I2C controller has one gpio controller */
 			gpio@26 {
 				#gpio-cells = <2>;
-				compatible = "ti,pcf8575";
+				compatible = "nxp,pcf8575";
 				reg = <0x26>;
 				gpio-controller;
 			};

@@ -85,7 +85,7 @@ This is an example which is used on FalconFalls:
 
 			gpio@26 {
 				#gpio-cells = <2>;
-				compatible = "ti,pcf8575";
+				compatible = "nxp,pcf8575";
 				reg = <0x26>;
 				gpio-controller;
 			};
arch/x86/platform/ce4100/falconfalls.dts +2 -2
index ce874f872cc6..4958e0045c34 100644
@@ -252,7 +252,7 @@
 
 						gpio@26 {
 							#gpio-cells = <2>;
-							compatible = "ti,pcf8575";
+							compatible = "nxp,pcf8575";
 							reg = <0x26>;
 							gpio-controller;
 						};

@@ -266,7 +266,7 @@
 
 						gpio@26 {
 							#gpio-cells = <2>;
-							compatible = "ti,pcf8575";
+							compatible = "nxp,pcf8575";
 							reg = <0x26>;
 							gpio-controller;
 						};
Signature · 2 lines
Ben Hutchings
Software Developer, Codethink Ltd.
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines · Ben Hutchings

The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.

This is not a problem in practice because the I2C core uses of_modalias_node() before matching drivers and this strips the manufacturer name.

Quoted 7 lines
Signed-off-by Ben Hutchings <[email protected]>

---
v2: Correct the claim that this is a practical problem.

 Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++--
 arch/x86/platform/ce4100/falconfalls.dts                     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Acked-by Rob Herring <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html