Skip to contentSkip to conversation

auxdisplay: Introduce ht16k33 driver

PATCH Superseded Robin van der Gracht 9 participants 15 messages May 18, 2016 – May 20, 2016

Subsystems (5)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Robin van der Gracht

author maintainer
#0 lore raw

v6 cover auxdisplay: Introduce ht16k33 driver

This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree bindings documentation and a new vendor prefix.

I added myself as maintainer to the MAINTAINERS file.

Robin van der Gracht (3):
of: add vendor prefix for Holtek Semiconductor
auxdisplay: ht16k33: Driver for LED controller
MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

 .../devicetree/bindings/display/ht16k33.txt        |  42 ++
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 MAINTAINERS                                        |   6 +
 drivers/auxdisplay/Kconfig                         |   9 +
 drivers/auxdisplay/Makefile                        |   1 +
 drivers/auxdisplay/ht16k33.c                       | 563 +++++++++++++++++++++
 6 files changed, 622 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt
 create mode 100644 drivers/auxdisplay/ht16k33.c
Signature · 1 line
2.7.4
author maintainer
#1 lore raw

PATCH v6 1/3 of: add vendor prefix for Holtek Semiconductor

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 86740d4..84fb85d 100644
@@ -112,6 +112,7 @@ hitex	Hitex Development Tools
 holt	Holt Integrated Circuits, Inc.
 honeywell	Honeywell
 hp	Hewlett Packard
+holtek	Holtek Semiconductor, Inc.
 i2se	I2SE GmbH
 ibm	International Business Machines (IBM)
 idt	Integrated Device Technologies, Inc.
Signature · 1 line
2.7.4
maintainer Acked-by on v6 1/3
#2 lore raw

Re: [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor

Quoted 4 lines · Robin van der Gracht
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#3 lore raw

PATCH v6 2/3 auxdisplay: ht16k33: Driver for LED controller

In reply to Robin van der Gracht

Added a driver for the Holtek HT16K33 LED controller with keyscan.

---
Changes in v6:
- Fixed minor typo in documentation 'KEY_F0' -> 'KEY_F10'

 .../devicetree/bindings/display/ht16k33.txt        |  42 ++
 drivers/auxdisplay/Kconfig                         |   9 +
 drivers/auxdisplay/Makefile                        |   1 +
 drivers/auxdisplay/ht16k33.c                       | 563 +++++++++++++++++++++
 4 files changed, 615 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt
 create mode 100644 drivers/auxdisplay/ht16k33.c
Documentation/devicetree/bindings/display/ht16k33.txt new file +42 -0
new file mode 100644
index 0000000..5c11320
@@ -0,0 +1,42 @@
+Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan
+-------------------------------------------------------------------------------
+
+Required properties:
+- compatible:		"holtek,ht16k33"
+- reg:			I2C slave address of the chip.
+- interrupt-parent:	A phandle pointing to the interrupt controller
+			serving the interrupt for this chip.
+- interrupts:		Interrupt specification for the key pressed interrupt.
+- refresh-rate-hz:	Display update interval in HZ.
+- debounce-delay-ms:	Debouncing interval time in microseconds.
+- linux,keymap: 	The keymap for keys as described in the binding
+			document (devicetree/bindings/input/matrix-keymap.txt).
+
+Optional properties:
+- linux,no-autorepeat:	Disable keyrepeat.
+- default-brightness-level: Initial brightness level [0-15] (default: 15).
+
+Example:
+
+&i2c1 {
+	ht16k33: ht16k33@70 {
+		compatible = "holtek,ht16k33";
+		reg = <0x70>;
+		refresh-rate-hz = <20>;
+		debounce-delay-ms = <50>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <5 (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING)>;
+		linux,keymap = <
+			MATRIX_KEY(2, 0, KEY_F6)
+			MATRIX_KEY(3, 0, KEY_F8)
+			MATRIX_KEY(4, 0, KEY_F10)
+			MATRIX_KEY(5, 0, KEY_F4)
+			MATRIX_KEY(6, 0, KEY_F2)
+			MATRIX_KEY(2, 1, KEY_F5)
+			MATRIX_KEY(3, 1, KEY_F7)
+			MATRIX_KEY(4, 1, KEY_F9)
+			MATRIX_KEY(5, 1, KEY_F3)
+			MATRIX_KEY(6, 1, KEY_F1)
+		>;
+	};
+};
drivers/auxdisplay/Kconfig +9 -0
index c07e725..75ad4f5 100644
@@ -119,4 +119,13 @@ config CFAG12864B_RATE
 	  If you compile this as a module, you can still override this
 	  value using the module parameters.
 
+config HT16K33
+	tristate "Holtek Ht16K33 LED controller with keyscan"
+	depends on FB && OF && I2C && INPUT
+	select INPUT_MATRIXKMAP
+	select FB_BACKLIGHT
+	help
+	  Say yes here to add support for Holtek HT16K33, RAM mapping 16*8
+	  LED controller driver with keyscan.
+
 endif # AUXDISPLAY
drivers/auxdisplay/Makefile +1 -0
index 8a8936a..d7c9ef5 100644
@@ -4,3 +4,4 @@
 
 obj-$(CONFIG_KS0108)		+= ks0108.o
 obj-$(CONFIG_CFAG12864B)	+= cfag12864b.o cfag12864bfb.o
+obj-$(CONFIG_HT16K33)		+= ht16k33.o
drivers/auxdisplay/ht16k33.c new file +563 -0

563 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#4 lore raw

Re: [PATCH v6 2/3] auxdisplay: ht16k33: Driver for LED controller

Quoted 22 lines · Robin van der Gracht

Added a driver for the Holtek HT16K33 LED controller with keyscan.

---
Changes in v6:
- Fixed minor typo in documentation 'KEY_F0' -> 'KEY_F10'

 .../devicetree/bindings/display/ht16k33.txt        |  42 ++
 drivers/auxdisplay/Kconfig                         |   9 +
 drivers/auxdisplay/Makefile                        |   1 +
 drivers/auxdisplay/ht16k33.c                       | 563 +++++++++++++++++++++
 4 files changed, 615 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt
 create mode 100644 drivers/auxdisplay/ht16k33.c
Documentation/devicetree/bindings/display/ht16k33.txt new file +1 -0
new file mode 100644
index 0000000..5c11320
@@ -0,0 +1,42 @@
+Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan

Documentation/devicetree/bindings/display/ht16k33.txt line 11

Quoted 10 lines
Documentation/devicetree/bindings/display/ht16k33.txt new file +10 -0
+-------------------------------------------------------------------------------
+
+Required properties:
+- compatible:		"holtek,ht16k33"
+- reg:			I2C slave address of the chip.
+- interrupt-parent:	A phandle pointing to the interrupt controller
+			serving the interrupt for this chip.
+- interrupts:		Interrupt specification for the key pressed interrupt.
+- refresh-rate-hz:	Display update interval in HZ.
+- debounce-delay-ms:	Debouncing interval time in microseconds.

The units and description still don't match.

I acked the last one. Please add acks when sending new versions (unless of course you don't fix any trivial things noted).

Rob

author maintainer
#5 lore raw

PATCH v6 3/3 MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

In reply to Robin van der Gracht
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
index 9c567a4..54aed16 100644
@@ -2816,6 +2816,12 @@ F:	drivers/usb/host/whci/
 F:	drivers/usb/wusbcore/
 F:	include/linux/usb/wusb*
 
+HT16K33 LED CONTROLLER DRIVER
+M:	Robin van der Gracht <[email protected]>
+S:	Maintained
+F:	drivers/auxdisplay/ht16k33.c
+F:	Documentation/devicetree/bindings/display/ht16k33.txt
+
 CFAG12864B LCD DRIVER
 M:	Miguel Ojeda Sandonis <[email protected]>
 W:	http://miguelojeda.es/auxdisplay.htm
Signature · 1 line
2.7.4
#7 lore raw
In reply to Robin van der Gracht
Quoted 4 lines · Robin van der Gracht

This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree bindings documentation and a new vendor prefix.

I added myself as maintainer to the MAINTAINERS file.

First off, if you want me to apply patches, put me in the to: line, and say so, otherwise I don't know.

Secondly, it's the middle of the merge window, and we can't take new patches into our trees (go read Documentation/development_model please), so this will have to wait until after 4.7-rc1 is out.

Thirdly, I need an ack for the DT-related change before I can accept that, hopefully you included the correct people on it.

And 4th, what is with the insane number of people on cc:? Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

I'll put this in my "to-review" queue to look at after 4.7-rc1 is out.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#8 lore raw
Quoted 8 lines · On Wed, 18 May 2016 08:09:24 -0700 Greg Kroah-Hartman…
Quoted 4 lines · Robin van der Gracht

This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree bindings documentation and a new vendor prefix.

I added myself as maintainer to the MAINTAINERS file.

First off, if you want me to apply patches, put me in the to: line, and say so, otherwise I don't know.

Ack

Quoted 4 lines

Secondly, it's the middle of the merge window, and we can't take new patches into our trees (go read Documentation/development_model please), so this will have to wait until after 4.7-rc1 is out.

Thats fine with me.

Quoted 3 lines

Thirdly, I need an ack for the DT-related change before I can accept that, hopefully you included the correct people on it.

Rob (re)acked the patches this morning. I'll try not to forget to re-add acks when I resubmit patches.

Quoted 4 lines

And 4th, what is with the insane number of people on cc:? Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

I did use the get_maintainer script. I solely passed the patch set as command line argument.

Quoted 2 lines

I'll put this in my "to-review" queue to look at after 4.7-rc1 is out.

Thanks Greg.

Robin van der Gracht

#9 lore raw

get_maintainer.pl and MAINTAINERS file

(Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")

Quoted 6 lines · Robin van der Gracht
Quoted 3 lines

And 4th, what is with the insane number of people on cc:? Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

I did use the get_maintainer script. I solely passed the patch set as command line argument.

I think get_maintainer script should ignore MAINTAINERS file altogether. After I did drivers/net/wireless reorganisation, and had to make numerous changes to MAINTAINERS in the process, I have been CCed to all sorts of patchsets to which I have nothing to do with (this one included). I suspect get_maintainer.pl is to blame here.

Signature · 5 lines
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#10 lore raw

Re: get_maintainer.pl and MAINTAINERS file

Quoted 8 lines · Kalle Valo

(Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")

Quoted 4 lines · Robin van der Gracht
Quoted 3 lines

And 4th, what is with the insane number of people on cc:? Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

Quoted 8 lines
Quoted 2 lines

I did use the get_maintainer script. I solely passed the patch set as command line argument.

I think get_maintainer script should ignore MAINTAINERS file altogether. After I did drivers/net/wireless reorganisation, and had to make numerous changes to MAINTAINERS in the process, I have been CCed to all sorts of patchsets to which I have nothing to do with (this one included). I suspect get_maintainer.pl is to blame here.

Are you sure it is because you are listed as maintainer for specific files? If you are maintain something you have to be CC'ed.
It is rather because get_maintainer.pl tries to be smart and uses git to find people who have touched a file...

I guess instead you want something like:
http://permalink.gmane.org/gmane.linux.kernel.commits.head/538561

Signature · 6 lines
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#11 lore raw

Re: get_maintainer.pl and MAINTAINERS file

Em Thu, 19 May 2016 16:25:45 +0200
Richard Weinberger <[email protected]> escreveu:

Quoted 18 lines · Kalle Valo
Quoted 8 lines

(Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")

Quoted 4 lines · Robin van der Gracht
Quoted 3 lines

And 4th, what is with the insane number of people on cc:? Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

Quoted 8 lines
Quoted 2 lines

I did use the get_maintainer script. I solely passed the patch set as command line argument.

I think get_maintainer script should ignore MAINTAINERS file altogether. After I did drivers/net/wireless reorganisation, and had to make numerous changes to MAINTAINERS in the process, I have been CCed to all sorts of patchsets to which I have nothing to do with (this one included). I suspect get_maintainer.pl is to blame here.

Quoted 7 lines

Are you sure it is because you are listed as maintainer for specific files? If you are maintain something you have to be CC'ed.
It is rather because get_maintainer.pl tries to be smart and uses git to find people who have touched a file...

I guess instead you want something like:
http://permalink.gmane.org/gmane.linux.kernel.commits.head/538561

I guess what Kalle said is that the get_maintainer.pl script should disable, by default, "--git-blame" behavior for some specific files that everyone touches like /MAINTAINERS, Documentation/kernel-parameters.txt, /CREDITS, etc, as random people that touch on those files aren't really interested on being c/c to every change there.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#12 lore raw

Re: get_maintainer.pl and MAINTAINERS file

Quoted 23 lines · Mauro Carvalho Chehab

Em Thu, 19 May 2016 16:25:45 +0200
Richard Weinberger <[email protected]> escreveu:

Quoted 20 lines · Kalle Valo
Quoted 8 lines

(Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")

Quoted 4 lines · Robin van der Gracht
Quoted 3 lines

And 4th, what is with the insane number of people on cc:? Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

Quoted 8 lines
Quoted 2 lines

I did use the get_maintainer script. I solely passed the patch set as command line argument.

I think get_maintainer script should ignore MAINTAINERS file altogether. After I did drivers/net/wireless reorganisation, and had to make numerous changes to MAINTAINERS in the process, I have been CCed to all sorts of patchsets to which I have nothing to do with (this one included). I suspect get_maintainer.pl is to blame here.

Are you sure it is because you are listed as maintainer for specific files? If you are maintain something you have to be CC'ed.

IIRC I have received patches about i2c and graphics stuff and I have no recollection of ever sending even a single patch to those subsystems, let alone maintaining them.

Quoted 11 lines
Quoted 5 lines

It is rather because get_maintainer.pl tries to be smart and uses git to find people who have touched a file...

I guess instead you want something like:
http://permalink.gmane.org/gmane.linux.kernel.commits.head/538561

I guess what Kalle said is that the get_maintainer.pl script should disable, by default, "--git-blame" behavior for some specific files that everyone touches like /MAINTAINERS, Documentation/kernel-parameters.txt, /CREDITS, etc, as random people that touch on those files aren't really interested on being c/c to every change there.

Exactly my point, thank you. No need to pollute people's inboxes unnecessary.

Signature · 1 line
Kalle Valo
#13 lore raw

Re: get_maintainer.pl and MAINTAINERS file

In reply to Kalle Valo
Cc joe
Quoted 8 lines · Kalle Valo

(Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")

Quoted 4 lines · Robin van der Gracht
Quoted 3 lines

And 4th, what is with the insane number of people on cc:? Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

Quoted 8 lines
Quoted 2 lines

I did use the get_maintainer script. I solely passed the patch set as command line argument.

I think get_maintainer script should ignore MAINTAINERS file altogether. After I did drivers/net/wireless reorganisation, and had to make numerous changes to MAINTAINERS in the process, I have been CCed to all sorts of patchsets to which I have nothing to do with (this one included). I suspect get_maintainer.pl is to blame here.

Last time I even tried to fix this up, but failed due to time limitations as the code is a bit complex.

Joe, you seem to be the one who touched the script many times recently. May we ask you to fix this up?

thanks,

Signature · 2 lines
js
suse labs
#14 lore raw

Re: get_maintainer.pl and MAINTAINERS file

Quoted 16 lines · Jiri Slaby
Cc joe
Quoted 13 lines · Kalle Valo

(Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")

Quoted 7 lines · Robin van der Gracht
Quoted 5 lines

And 4th, what is with the insane number of people on cc:?  Use get_maintainer.pl correctly please, and don't just hit everyone you can possibly think of with a cc: for no good reason.

I did use the get_maintainer script. I solely passed the patch set as command line argument.

I think get_maintainer script should ignore MAINTAINERS file altogether.

Maybe, maybe not.
The list of MAINTAINERS names returned by get_maintainer.pl is:

Andrew Morton <[email protected]> (commit_signer:39/504=8%)
"David S. Miller" <[email protected]> (commit_signer:38/504=8%)
Greg Kroah-Hartman <[email protected]> (commit_signer:36/504=7%)
Kalle Valo <[email protected]> (commit_signer:28/504=6%)
Mauro Carvalho Chehab <[email protected]> (added_lines:109/2073=5%,removed_lines:108/779=14%) Guenter Roeck <[email protected]> (removed_lines:48/779=6%)
Jiri Slaby <[email protected]> (removed_lines:46/779=6%)

Quoted 4 lines
Quoted 4 lines

After I did drivers/net/wireless reorganisation, and had to make numerous changes to MAINTAINERS in the process, I have been CCed to all sorts of patchsets to which I have nothing to do with (this one included). I suspect get_maintainer.pl is to blame here.

Doubtful but possible.
I have no idea how many files were modified by whatever patch was checked, but more files, more maintainers.

Unmaintained files have even more "not quite maintainers", but get_maintainer.pl lists the names of people that recently modified those specific files.

Quoted 5 lines

Last time I even tried to fix this up, but failed due to time limitations as the code is a bit complex.

Joe, you seem to be the one who touched the script many times recently. May we ask you to fix this up?

I'm not touching stuff right now.  Maybe next month.