staging: comedi: comedi_fops: coding style fixes

PATCH Superseded Matias Mucciolo 3 participants 3 messages Sep 8, 2016 – Sep 12, 2016 Staging

lore

Share & tools

lore

Matias Mucciolo

author

2016-09-08 18:34 UTC #0 lore raw

PATCH 1/1 staging: comedi: comedi_fops: coding style fixes

- Fixed coding style in comedi_fops.c Symbolic to octal permission.

Signed-off-by Matias Mucciolo <[email protected]>

---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/comedi/comedi_fops.c +3 -3

index 1999eed..bf922ea 100644
@@ -81,20 +81,20 @@ struct comedi_file {
        (COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
 
 static int comedi_num_legacy_minors;
-module_param(comedi_num_legacy_minors, int, S_IRUGO);
+module_param(comedi_num_legacy_minors, int, 0444);
 MODULE_PARM_DESC(comedi_num_legacy_minors,
                 "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
                );
 
 unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
-module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_size_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_size_kb,
                 "default asynchronous buffer size in KiB (default "
                 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
 
 unsigned int comedi_default_buf_maxsize_kb
        = CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
-module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_maxsize_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
                 "default maximum size of asynchronous buffer in KiB (default "
                 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");

Signature · 1 line

2.1.4

Ian Abbott

Reviewed-by on v1 1/1

2016-09-09 10:25 UTC #1 lore raw

Quoted 27 lines · Matias Mucciolo

- Fixed coding style in comedi_fops.c Symbolic to octal permission.

Signed-off-by Matias Mucciolo <[email protected]>

---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/comedi/comedi_fops.c +2 -2

index 1999eed..bf922ea 100644
@@ -81,20 +81,20 @@ struct comedi_file {
        (COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS)
 
 static int comedi_num_legacy_minors;
-module_param(comedi_num_legacy_minors, int, S_IRUGO);
+module_param(comedi_num_legacy_minors, int, 0444);
 MODULE_PARM_DESC(comedi_num_legacy_minors,
                 "number of comedi minor devices to reserve for non-auto-configured devices (default 0)"
                );
 
 unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB;
-module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_size_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_size_kb,

drivers/staging/comedi/comedi_fops.c struct comedi_file { · line 100

Quoted 10 lines

drivers/staging/comedi/comedi_fops.c +1 -1

                 "default asynchronous buffer size in KiB (default "
                 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
 
 unsigned int comedi_default_buf_maxsize_kb
        = CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
-module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR);
+module_param(comedi_default_buf_maxsize_kb, uint, 0644);
 MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
                 "default maximum size of asynchronous buffer in KiB (default "
                 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")");

Thanks. It looks fine. Personally, I find the octal constants more readable, as POSIX octal file permissions have been burned into my brain for >30 years now!

Reviewed-by Ian Abbott <[email protected]>

Signature · 2 lines

-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Greg Kroah-Hartman

maintainer

2016-09-12 11:12 UTC #2 lore raw

In reply to Matias Mucciolo

Quoted 8 lines · Matias Mucciolo

- Fixed coding style in comedi_fops.c Symbolic to octal permission.
Signed-off-by Matias Mucciolo <[email protected]>
Reviewed-by Ian Abbott <[email protected]>
---
 drivers/staging/comedi/comedi_fops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Does not apply to my tree at all, can you rebase it against the staging-next branch of staging.git and resend?

thanks,

greg k-h