Skip to contentSkip to conversation

staging: dgnc: Fix alignment with open parentheses

PATCH In review Rehas Sachdeva 2 participants 3 messages Sep 14, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgnc: Fix alignment with open parentheses

This patch removes the checkpatch.pl warning:
CHECK: Alignment should match open parenthesis.

---
 drivers/staging/dgnc/dgnc_tty.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +3 -2
index 31b18e6..75e0a6b 100644
@@ -1037,8 +1037,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
 	 * ch_flags_wait to wake us back up.
 	 */
 	rc = wait_event_interruptible(ch->ch_flags_wait,
-		(((ch->ch_tun.un_flags | ch->ch_pun.un_flags) &
-		  UN_CLOSING) == 0));
+				      (((ch->ch_tun.un_flags |
+					 ch->ch_pun.un_flags) &
+					UN_CLOSING) == 0));
 
 	/* If ret is non-zero, user ctrl-c'ed us */
 	if (rc)
Signature · 1 line
2.7.4
#1 lore raw
Quoted 13 lines · Rehas Sachdeva

This patch removes the checkpatch.pl warning:
CHECK: Alignment should match open parenthesis.

---
 drivers/staging/dgnc/dgnc_tty.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +0 -0
index 31b18e6..75e0a6b 100644

drivers/staging/dgnc/dgnc_tty.c static int dgnc_tty_open(struct tty_struct *tty, struct file *file) · line 1042

Quoted 8 lines
drivers/staging/dgnc/dgnc_tty.c +3 -2
@@ -1037,8 +1037,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
 	 * ch_flags_wait to wake us back up.
 	 */
 	rc = wait_event_interruptible(ch->ch_flags_wait,
-		(((ch->ch_tun.un_flags | ch->ch_pun.un_flags) &
-		  UN_CLOSING) == 0));
+				      (((ch->ch_tun.un_flags |
+					 ch->ch_pun.un_flags) &
+					UN_CLOSING) == 0));

Bother are not so nice, but maybe it was better before. It's nice to have at least both arguments to | on the same line.

julia

Quoted 13 lines
drivers/staging/dgnc/dgnc_tty.c +0 -1
 	/* If ret is non-zero, user ctrl-c'ed us */
 	if (rc)
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914153331.GA22396%40toblerone.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 27 lines · Julia Lawall
Quoted 13 lines · Rehas Sachdeva

This patch removes the checkpatch.pl warning:
CHECK: Alignment should match open parenthesis.

---
 drivers/staging/dgnc/dgnc_tty.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +0 -0
index 31b18e6..75e0a6b 100644

drivers/staging/dgnc/dgnc_tty.c static int dgnc_tty_open(struct tty_struct *tty, struct file *file) · line 1042

Quoted 8 lines
drivers/staging/dgnc/dgnc_tty.c +3 -2
@@ -1037,8 +1037,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
 	 * ch_flags_wait to wake us back up.
 	 */
 	rc = wait_event_interruptible(ch->ch_flags_wait,
-		(((ch->ch_tun.un_flags | ch->ch_pun.un_flags) &
-		  UN_CLOSING) == 0));
+				      (((ch->ch_tun.un_flags |
+					 ch->ch_pun.un_flags) &
+					UN_CLOSING) == 0));

Bother are not so nice, but maybe it was better before. It's nice to have at least both arguments to | on the same line.

Quoted 2 lines

julia

Alright. I'll keep that in mind.

Thanks

Rehas

Quoted 13 lines
Quoted 13 lines
drivers/staging/dgnc/dgnc_tty.c +0 -1
 	/* If ret is non-zero, user ctrl-c'ed us */
 	if (rc)
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914153331.GA22396%40toblerone.
For more options, visit https://groups.google.com/d/optout.