Staging: ethernet: Fixes checkpatch blank lines warnings

PATCH Superseded Ronald Rojas 2 participants 2 messages Sep 14, 2016 Staging

lore

Share & tools

lore

Ronald Rojas

author

2016-09-14 19:46 UTC #0 lore raw

PATCH v3 1/1 Staging: ethernet: Fixes checkpatch blank lines warnings

This patch fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank lines

v3: changes to commit log

Signed-off-by Ronald Rojas <[email protected]>

---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/staging/octeon/ethernet.c +0 -3

index e9cd5f2..79571d6 100644
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *

@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();

@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();

Signature · 1 line

2.7.4

Julia Lawall

2016-09-14 20:25 UTC #1 lore raw

Quoted 4 lines · Ronald Rojas

This patch fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank lines
v3: changes to commit log

Actually the v3 should go below the --- not above. Any text below the --- and above the diff is discarded in the patch application process. This is desirable for the vn explanations, because the person looking at the patch history does not see the previous versions. So the information about the change since the previous version is not interesting any more.

julia

Quoted 44 lines

Signed-off-by Ronald Rojas <[email protected]>
---
 drivers/staging/octeon/ethernet.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/octeon/ethernet.c +0 -4
index e9cd5f2..79571d6 100644
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;
 module_param(rx_napi_weight, int, 0444);
 MODULE_PARM_DESC(rx_napi_weight, "The NAPI WEIGHT parameter.");
 
-
 /*
  * cvm_oct_poll_queue_stopping - flag to indicate polling should stop.
  *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914194630.GA2546%40fedora.
For more options, visit https://groups.google.com/d/optout.