Staging: ethernet: Fixes checkpatch blank lines warnings
PATCH v4 1/1 Staging: ethernet: Fixes checkpatch blank lines warnings
This patch fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank lines
v4: changes to commit log
--- drivers/staging/octeon/ethernet.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/octeon/ethernet.c +0 -3
@@ -86,7 +86,6 @@ int rx_napi_weight = 32;module_param (rx_napi_weight, int,0444 );MODULE_PARM_DESC (rx_napi_weight,"The NAPI WEIGHT parameter." ); -/* * cvm_oct_poll_queue_stopping - flag to indicate polling should stop. *
@@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)return -EINVAL ; } -cvm_oct_configure_common_hw ();cvmx_helper_initialize_packet_io_global ();
@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev) } } -cvmx_pko_shutdown ();cvmx_ipd_free_ptr ();
Signature · 1 line
2.7.4
Quoted 5 lines · Ronald Rojas
This patch fixes several of the checkpatch.pl warning
CHECK: Please don't use multiple blank linesSigned-off-by Ronald Rojas <[email protected]>v4: changes to commit log
The v4 goes under the ---, not above it. It needs to be in the part of the patch that will disappear when the patch is committed.
The commit log message should also be written using the imperative. "This patch" is noise. We know that what we are looking at is a patch. One wants to get to the important part as quickly as possible.
julia
Quoted 42 lines
--- drivers/staging/octeon/ethernet.c | 3 --- 1 file changed, 3 deletions(-)drivers/staging/octeon/ethernet.c +0
-4@@ -86,7 +86,6 @@ int rx_napi_weight = 32;module_param (rx_napi_weight, int,0444 );MODULE_PARM_DESC (rx_napi_weight,"The NAPI WEIGHT parameter." ); -/* * cvm_oct_poll_queue_stopping - flag to indicate polling should stop. * @@ -665,7 +664,6 @@ static int cvm_oct_probe(struct platform_device *pdev)return -EINVAL ; } -cvm_oct_configure_common_hw ();cvmx_helper_initialize_packet_io_global ();@@ -878,7 +876,6 @@ static int cvm_oct_remove(struct platform_device *pdev) } } -cvmx_pko_shutdown ();cvmx_ipd_free_ptr (); --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160915010230.GA15390%40fedora.
For more options, visit https://groups.google.com/d/optout.