perf: remove orphan DEBUG_PERF_USE_VMALLOC
PATCH 1/1 perf: remove orphan DEBUG_PERF_USE_VMALLOC
This doesn't seem to be used anywhere
--- init/Kconfig | 13 ------------- 1 file changed, 13 deletions(-)
init/Kconfig +0 -13
@@ -1707,19 +1707,6 @@ config PERF_EVENTS Say Y if unsure. -config DEBUG_PERF_USE_VMALLOC - default n - bool "Debug: use vmalloc to back perf mmap() buffers" - depends on PERF_EVENTS && DEBUG_KERNEL && !PPC - select PERF_USE_VMALLOC - help - Use vmalloc memory to back perf mmap() buffers. - - Mostly useful for debugging the vmalloc code on platforms - that don't require it. - - Say N if unsure. - endmenu config VM_EVENT_COUNTERS
Signature · 1 line
2.7.4
Quoted 1 line · On Tue, 27 Sep 2016 07:53:56 -0700 Vineet Gupta <[email protected]>…
This doesn't seem to be used anywhere
I thought so too, until I got this response for an equivalent patch:
https://lkml.org/lkml/2016/8/31/53
Kim
Quoted 7 lines · Kim Phillips
Quoted 1 line · On Tue, 27 Sep 2016 07:53:56 -0700 Vineet Gupta <[email protected]>…
Quoted 1 line
This doesn't seem to be used anywhere
I thought so too, until I got this response for an equivalent patch:
So this is some sort of "developer shortcut" to quickly enable 2 options with one option. Purpose seems dubious to me ! It would still be possible to enable vmalloc backed mmap on x86 by simply enabling that option from Kconfig.
-Vineet
Quoted 4 lines · Vineet Gupta
Quoted 3 lines · Kim Phillips
On Tue, 27 Sep 2016 07:53:56 -0700
Vineet Gupta <[email protected]> wrote:
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
This doesn't seem to be used anywhere
I thought so too, until I got this response for an equivalent patch:
So this is some sort of "developer shortcut" to quickly enable 2 options with one option. Purpose seems dubious to me ! It would still be possible to enable vmalloc backed mmap on x86 by simply enabling that option from
Kconfig.
PERF_USE_VMALLOC is not a user selectable option. Also DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck, even the help text says what its for.