Skip to contentSkip to conversation

perf: remove orphan DEBUG_PERF_USE_VMALLOC

PATCH In review Vineet Gupta 3 participants 4 messages Sep 27, 2016 – Sep 28, 2016 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf: remove orphan DEBUG_PERF_USE_VMALLOC

This doesn't seem to be used anywhere

Cc Andrew Morton <akpm at linux-foundation.org>
Cc Kees Cook <keescook at chromium.org>
Cc Johannes Weiner <hannes at cmpxchg.org>
Cc Tejun Heo <tj at kernel.org>
Cc Arnd Bergmann <arnd at arndb.de>
Cc Petr Mladek <pmladek at suse.com>
Cc Ard Biesheuvel <ard.biesheuvel at linaro.org>
Cc Thomas Garnier <thgarnie at google.com>
Cc Nicolas Pitre <nicolas.pitre at linaro.org>
Cc Peter Zijlstra <peterz at infradead.org>
Cc linux-snps-arc at lists.infradead.org
Cc linux-kernel at vger.kernel.org
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
---
 init/Kconfig | 13 -------------
 1 file changed, 13 deletions(-)
init/Kconfig +0 -13
index cac3f096050d..934a61f6e2cc 100644
@@ -1707,19 +1707,6 @@ config PERF_EVENTS
 
 	  Say Y if unsure.
 
-config DEBUG_PERF_USE_VMALLOC
-	default n
-	bool "Debug: use vmalloc to back perf mmap() buffers"
-	depends on PERF_EVENTS && DEBUG_KERNEL && !PPC
-	select PERF_USE_VMALLOC
-	help
-	 Use vmalloc memory to back perf mmap() buffers.
-
-	 Mostly useful for debugging the vmalloc code on platforms
-	 that don't require it.
-
-	 Say N if unsure.
-
 endmenu
 
 config VM_EVENT_COUNTERS
Signature · 1 line
2.7.4
#2 lore raw
Quoted 7 lines · Kim Phillips
Quoted 1 line · On Tue, 27 Sep 2016 07:53:56 -0700 Vineet Gupta <[email protected]>…
Quoted 1 line

This doesn't seem to be used anywhere

I thought so too, until I got this response for an equivalent patch:

https://lkml.org/lkml/2016/8/31/53

So this is some sort of "developer shortcut" to quickly enable 2 options with one option. Purpose seems dubious to me ! It would still be possible to enable vmalloc backed mmap on x86 by simply enabling that option from Kconfig.

-Vineet

#3 lore raw
Quoted 4 lines · Vineet Gupta
Quoted 3 lines · Kim Phillips

On Tue, 27 Sep 2016 07:53:56 -0700
Vineet Gupta <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line

This doesn't seem to be used anywhere

I thought so too, until I got this response for an equivalent patch:

https://lkml.org/lkml/2016/8/31/53

So this is some sort of "developer shortcut" to quickly enable 2 options with one option. Purpose seems dubious to me ! It would still be possible to enable vmalloc backed mmap on x86 by simply enabling that option from Kconfig.

PERF_USE_VMALLOC is not a user selectable option. Also DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck, even the help text says what its for.