staging: iio: cdc: ad7152: Add blank line after

PATCH Superseded Anchal Jain 3 participants 5 messages Oct 2, 2016

Subsystems (4)

Staging IIO Analog Devices IIO drivers Staging - industrial io

lore

Share & tools

lore

Anchal Jain

author

2016-10-02 15:26 UTC #0 lore raw

PATCH v3 1/2 staging: iio: cdc: ad7152: Add blank line after

declarations to increase readability
Reply-To:

Add a blank line after a function declaration because local variable declarations should be seprated from the function's statments by a blank line to increase the readability of a code.

Signed-off-by Anchal Jain <[email protected]>

---
 drivers/staging/iio/cdc/ad7152.c | 4 ++++
 1 file changed, 4 insertions(+)

drivers/staging/iio/cdc/ad7152.c +4 -0

index 1962052..f9767e9 100644
@@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
 	mutex_unlock(&indio_dev->mlock);
 	return len;
 }
+
 static ssize_t ad7152_start_offset_calib(struct device *dev,
 					 struct device_attribute *attr,
 					 const char *buf,

@@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
 	return ad7152_start_calib(dev, attr, buf, len,
 				  AD7152_CONF_MODE_OFFS_CAL);
 }
+
 static ssize_t ad7152_start_gain_calib(struct device *dev,
 				       struct device_attribute *attr,
 				       const char *buf,

@@ -317,6 +319,7 @@ out:
 	mutex_unlock(&indio_dev->mlock);
 	return ret;
 }
+
 static int ad7152_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan,
 			   int *val, int *val2,

@@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
 		BIT(IIO_CHAN_INFO_SCALE),
 	}
 };
+
 /*
  * device probe and remove
  */

Signature · 1 line

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161002152635.GA4163%40life-desktop.
For more options, visit https://groups.google.com/d/optout.

Anchal Jain

author

2016-10-02 15:36 UTC #2 lore raw

yes,

I used the get_maintainer command but In CC I need to add maintainers only or everyone which listed there?

Quoted 81 lines · Julia Lawall

Quoted 5 lines · Anchal Jain
declarations to increase readability
Reply-To:
Add a blank line after a function declaration because local variable declarations should be seprated from the function's statments by a blank
line
Quoted 1 line
to increase the readability of a code.
The log message is not formatted properly. It looks like a newline ended up in the subject line, and the Reply-to is not needed.
There are people who should be on the CC list who are not. Are you using the get_maintainer command shown in the Submit a patch section of the tutorial?
julia
drivers/staging/iio/cdc/
Quoted 7 lines
Signed-off-by Anchal Jain <[email protected]>
---
 drivers/staging/iio/cdc/ad7152.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/iio/cdc/ renamed from drivers/staging/iio/cdc/ad7152.c +0 -0
ad7152.c
drivers/staging/iio/cdc/ad7152.c static inline ssize_t ad7152_start_calib(struct
Quoted 4 lines
index 1962052..f9767e9 100644
drivers/staging/iio/cdc/ad7152.c +0 -0
@@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct
device *dev,
drivers/staging/iio/cdc/ad7152.c static ssize_t ad7152_start_offset_calib(struct
Quoted 8 lines
drivers/staging/iio/cdc/ad7152.c +1 -0
      mutex_unlock(&indio_dev->mlock);
      return len;
 }
+
 static ssize_t ad7152_start_offset_calib(struct device *dev,
                                       struct device_attribute *attr,
                                       const char *buf,
@@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct
device *dev,
drivers/staging/iio/cdc/ad7152.c static const struct iio_chan_spec ad7152_channels[]
Quoted 16 lines
drivers/staging/iio/cdc/ad7152.c +2 -0
      return ad7152_start_calib(dev, attr, buf, len,
                                AD7152_CONF_MODE_OFFS_CAL);
 }
+
 static ssize_t ad7152_start_gain_calib(struct device *dev,
                                     struct device_attribute *attr,
                                     const char *buf,
@@ -317,6 +319,7 @@ out:
      mutex_unlock(&indio_dev->mlock);
      return ret;
 }
+
 static int ad7152_read_raw(struct iio_dev *indio_dev,
                         struct iio_chan_spec const *chan,
                         int *val, int *val2,
@@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[]
= {
Quoted 10 lines
drivers/staging/iio/cdc/ad7152.c +1 -1
              BIT(IIO_CHAN_INFO_SCALE),
      }
 };
+
 /*
  * device probe and remove
  */
--
1.9.1
Quoted 2 lines
--
You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/
msgid/outreachy-kernel/20161002152635.GA4163%40life-desktop.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.

Julia Lawall

2016-10-02 15:48 UTC #3 lore raw

Quoted 4 lines · Anchal Jain

yes,
I used the get_maintainer command but In CC I need to add maintainers only or everyone which listed there?

The command that is shown in the Submit a patch section only gives maintainers. If you run get_maintainer in some other way, you will indeed get people who are not maintainers.

julia

Quoted 93 lines · Julia Lawall


      On Sun, 2 Oct 2016, Anchal Jain wrote:

      > declarations to increase readability
      > Reply-To:
      >
      > Add a blank line after a function declaration because local
      variable
      > declarations should be seprated from the function's statments
      by a blank line
      > to increase the readability of a code.

      The log message is not formatted properly.  It looks like a
      newline ended
      up in the subject line, and the Reply-to is not needed.

      There are people who should be on the CC list who are not.  Are
      you using
      the get_maintainer command shown in the Submit a patch section
      of the
      tutorial?

      julia

      >
      > Signed-off-by: Anchal Jain <[email protected]>
      > ---
      >  drivers/staging/iio/cdc/ad7152.c | 4 ++++
      >  1 file changed, 4 insertions(+)
      >
      > diff --git a/drivers/staging/iio/cdc/ad7152.c
      b/drivers/staging/iio/cdc/ad7152.c
      > index 1962052..f9767e9 100644
      > --- a/drivers/staging/iio/cdc/ad7152.c
      > +++ b/drivers/staging/iio/cdc/ad7152.c
      > @@ -134,6 +134,7 @@ static inline ssize_t
      ad7152_start_calib(struct device *dev,
      >       mutex_unlock(&indio_dev->mlock);
      >       return len;
      >  }
      > +
      >  static ssize_t ad7152_start_offset_calib(struct device *dev,
      >                                        struct
      device_attribute *attr,
      >                                        const char *buf,
      > @@ -142,6 +143,7 @@ static ssize_t
      ad7152_start_offset_calib(struct device *dev,
      >       return ad7152_start_calib(dev, attr, buf, len,
      >                                 AD7152_CONF_MODE_OFFS_CAL);
      >  }
      > +
      >  static ssize_t ad7152_start_gain_calib(struct device *dev,
      >                                      struct device_attribute
      *attr,
      >                                      const char *buf,
      > @@ -317,6 +319,7 @@ out:
      >       mutex_unlock(&indio_dev->mlock);
      >       return ret;
      >  }
      > +
      >  static int ad7152_read_raw(struct iio_dev *indio_dev,
      >                          struct iio_chan_spec const *chan,
      >                          int *val, int *val2,
      > @@ -470,6 +473,7 @@ static const struct iio_chan_spec
      ad7152_channels[] = {
      >               BIT(IIO_CHAN_INFO_SCALE),
      >       }
      >  };
      > +
      >  /*
      >   * device probe and remove
      >   */
      > --
      > 1.9.1
      >

Quoted 2 lines

--
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it,

send an email to [email protected].

Quoted 1 line

To post to this group, send email to

[email protected].

Quoted 1 line

To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20161002152635.GA4163%4

0life-desktop.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

Greg KH

maintainer

2016-10-02 15:38 UTC #4 lore raw

In reply to Anchal Jain

Quoted 2 lines · Anchal Jain

declarations to increase readability
Reply-To:

What are these lines for? They shouldn't be here :(

thanks,

greg k-h