Skip to contentSkip to conversation

x86/entry64: remove unused audit related macros

PATCH Superseded Alexander Kuleshov 2 participants 3 messages Oct 22, 2016 – Oct 23, 2016

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/entry64: remove unused audit related macros

which are ocured in the 86a1c34a929f commit (x86_64 syscall audit fast-path by Roland McGrath <[email protected]>) and now they are not used anymore.

---
 arch/x86/entry/entry_64.S | 6 ------
 1 file changed, 6 deletions(-)
arch/x86/entry/entry_64.S +0 -6
index ef766a3..4362f1c 100644
@@ -38,12 +38,6 @@
 #include <asm/export.h>
 #include <linux/err.h>
 
-/* Avoid __ASSEMBLER__'ifying <linux/audit.h> just for this.  */
-#include <linux/elf-em.h>
-#define AUDIT_ARCH_X86_64			(EM_X86_64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
-#define __AUDIT_ARCH_64BIT			0x80000000
-#define __AUDIT_ARCH_LE				0x40000000
-
 .code64
 .section .entry.text, "ax"
 
Signature · 1 line
2.8.0.rc3.1353.gea9bdc0
maintainer
#1 lore raw
Quoted 3 lines · Alexander Kuleshov

which are ocured in the 86a1c34a929f commit (x86_64 syscall audit fast-path by Roland McGrath <[email protected]>) and now they are not used anymore.

I'd prefer it if you said which patch *removed* them and made those defines unused again.

What would be even better is if your commit message explained *why* they were removed in that patch and that because of <insert reason here> we don't need them here anymore.

This should give people looking at your patch the warm and fuzzy feeling they need in order to apply it. :-)

Thanks.

Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
#2 lore raw

Hello Borislav,

Quoted 9 lines · Borislav Petkov

I'd prefer it if you said which patch *removed* them and made those defines unused again.

What would be even better is if your commit message explained *why* they were removed in that patch and that because of <insert reason here> we don't need them here anymore.

This should give people looking at your patch the warm and fuzzy feeling they need in order to apply it. :-)

I will describe this in V2.

Thanks.