scsi: libfc: Remove an unneeded condition
Subsystems (3)
PATCH 1/1 scsi: libfc: Remove an unneeded condition
We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need to check again here.
Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/libfc/fc_rport.c +0 -1
@@ -1196,7 +1196,6 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp,* Check if the image pair could be established */ if (rdata->spp_type !=FC_TYPE_FCP || - resp_code !=FC_SPP_RESP_ACK || !(pp->spp.spp_flags &FC_SPP_EST_IMG_PAIR )) {/* * Nope; we can't use this port as a target.
Quoted 5 lines · Dan Carpenter
We verified that
resp_codeisFC_SPP_RESP_ACKearlier so we don't need to check again here.Signed-off-by Dan Carpenter <[email protected]>
Looks good,
Signature · 10 lines
Johannes Thumshirn Storage [email protected] +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Martin K. Petersen
AppliedQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Dan" = Dan Carpenter <[email protected]> writes:
Dan> We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't Dan> need to check again here.
Applied to 4.10/scsi-queue.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering