Skip to contentSkip to conversation

scsi: libfc: Remove an unneeded condition

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 24, 2016 – Nov 25, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: libfc: Remove an unneeded condition

We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need to check again here.

drivers/scsi/libfc/fc_rport.c +0 -1
index 110a707..c991f3b 100644
@@ -1196,7 +1196,6 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp,
 		 * Check if the image pair could be established
 		 */
 		if (rdata->spp_type != FC_TYPE_FCP ||
-		    resp_code != FC_SPP_RESP_ACK ||
 		    !(pp->spp.spp_flags & FC_SPP_EST_IMG_PAIR)) {
 			/*
 			 * Nope; we can't use this port as a target.
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need to check again here.

Looks good,

Signature · 10 lines
Johannes Thumshirn                                          Storage
[email protected]                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Dan Carpenter
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Dan" = Dan Carpenter <[email protected]> writes:

Dan> We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't Dan> need to check again here.

Applied to 4.10/scsi-queue.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering