Skip to contentSkip to conversation

su01: do pre-checking to avoid annoying warnings

PATCH New Ning 3 participants 3 messages Dec 12, 2016 – Dec 16, 2016

lore
Share & tools
lore

Ning

#0 lore raw

PATCH 1/1 su01: do pre-checking to avoid annoying warnings

From: Ning Han <[email protected]>

Signed-off-by Ning Han <[email protected]>
---
 testcases/commands/su/su01 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
testcases/commands/su/su01 +4 -4
index dd1517f..5e59eff 100755
@@ -86,7 +86,7 @@ rm -f $TEST_ENV_FILE > /dev/null 2>&1
 #Create 1st test user
     #erase user if he may exist , so we can have a clean en
         rm -rf /home/$TEST_USER1
-        userdel $TEST_USER1
+        getent passwd $TEST_USER1 && userdel $TEST_USER1
 	sleep 1
 
         useradd -m -g users $TEST_USER1

@@ -105,7 +105,7 @@ rm -f $TEST_ENV_FILE > /dev/null 2>&1
 	then {
           USER_UID=`id -u $TEST_USER1`
           USER_GID=`id -g $TEST_USER1`
-          mkdir $TEST_USER1_HOMEDIR
+          mkdir -p $TEST_USER1_HOMEDIR
           chown -R $USER_UID.$USER_GID $TEST_USER1_HOMEDIR
 	}
 	fi

@@ -121,7 +121,7 @@ rm -f $TEST_ENV_FILE > /dev/null 2>&1
 #Create 2nd test user
 	#erase user if he may exist , so we can have a clean en
         rm -rf /home/$TEST_USER2
-        userdel $TEST_USER2
+        getent passwd $TEST_USER2 && userdel $TEST_USER2
 	sleep 1
 
         useradd -m -g users $TEST_USER2

@@ -141,7 +141,7 @@ rm -f $TEST_ENV_FILE > /dev/null 2>&1
         then {
           USER_UID=`id -u $TEST_USER2`
           USER_GID=`id -g $TEST_USER2`
-          mkdir $TEST_USER2_HOMEDIR
+          mkdir -p $TEST_USER2_HOMEDIR
           chown -R $USER_UID.$USER_GID $TEST_USER2_HOMEDIR
 	}
 	fi
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 su01: do pre-checking to avoid annoying warnings

Hi!

testcases/commands/su/su01 rm -f $TEST_ENV_FILE > /dev/null 2>&1 · line 89

Quoted 2 lines
testcases/commands/su/su01 +1 -1
-        userdel $TEST_USER1
+        getent passwd $TEST_USER1 && userdel $TEST_USER1

Shouldn't we redirect the output from getent to /dev/null here?

Otherwise it looks fine.

Signature · 2 lines
Cyril Hrubis
[email protected]
#2 lore raw

PATCH 1/1 su01: do pre-checking to avoid annoying warnings

Quoted 5 lines · Cyril Hrubis

Hi!

testcases/commands/su/su01 rm -f $TEST_ENV_FILE > /dev/null 2>&1 · line 89

Quoted 2 lines
testcases/commands/su/su01 +1 -1
-        userdel $TEST_USER1
+        getent passwd $TEST_USER1 && userdel $TEST_USER1

Shouldn't we redirect the output from getent to /dev/null here?

Yes, we should. I'll send another patch for this.

Quoted 6 lines

Otherwise it looks fine.

Signature · 2 lines
Cyril Hrubis
[email protected]