Skip to contentSkip to conversation

serdev: ttyport: check whether tty_init_dev() fails

PATCH In review Dan Carpenter 2 participants 2 messages Feb 8, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serdev: ttyport: check whether tty_init_dev() fails

My static checker complains that we don't have any error handling here. It's simple enough to add it.

Fixes bed35c6dfa6a ("serdev: add a tty port controller driver")
drivers/tty/serdev/serdev-ttyport.c +2 -0
index 683320b81a2b..d05393594f15 100644
@@ -97,6 +97,8 @@ static int ttyport_open(struct serdev_controller *ctrl)
 	struct ktermios ktermios;
 
 	tty = tty_init_dev(serport->tty_drv, serport->tty_idx);
+	if (IS_ERR(tty))
+		return PTR_ERR(tty);
 	serport->tty = tty;
 
 	serport->port->client_ops = &client_ops;