serdev: ttyport: check whether tty_init_dev() fails
Subsystems (3)
PATCH 1/1 serdev: ttyport: check whether tty_init_dev() fails
My static checker complains that we don't have any error handling here. It's simple enough to add it.
Fixes bed35c6dfa6a ("serdev: add a tty port controller driver")
Signed-off-by Dan Carpenter <[email protected]>
drivers/tty/serdev/serdev-ttyport.c +2 -0
@@ -97,6 +97,8 @@ static int ttyport_open(struct serdev_controller *ctrl)struct ktermios ktermios; tty =tty_init_dev (serport->tty_drv, serport->tty_idx); +if (IS_ERR (tty)) +return PTR_ERR (tty); serport->tty = tty; serport->port->client_ops = &client_ops;
Quoted 5 lines · Dan Carpenter
My static checker complains that we don't have any error handling here. It's simple enough to add it.
Fixes bed35c6dfa6a ("serdev: add a tty port controller driver")Signed-off-by Dan Carpenter <[email protected]>
Acked-by Rob Herring <[email protected]>