staging: rtl8192u: Replace symbolic permissions with octal permissions
PATCH 1/3 staging: rtl8192u: Replace symbolic permissions with octal permissions
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl
--- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +1 -1
@@ -283,7 +283,7 @@ int __init ieee80211_debug_init(void) " proc directory\n");return -EIO ; } - e =proc_create ("debug_level" ,S_IRUGO |S_IWUSR , + e =proc_create ("debug_level" ,0644 , ieee80211_proc, &fops);if (!e) {remove_proc_entry (DRV_NAME , init_net.proc_net);
Signature · 1 line
2.7.4
Quoted 3 lines · simran singhal
WARNING: Symbolic permissions '
S_IRUGO|S_IWUSR' are not preferred. Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl
This one has all the pieces in the right place, but please redo with the suggestions on the previous version.
julia
Quoted 28 lines
Signed-off-by simran singhal <[email protected]>--- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +1
-2@@ -283,7 +283,7 @@ int __init ieee80211_debug_init(void) " proc directory\n");return -EIO ; } - e =proc_create ("debug_level" ,S_IRUGO |S_IWUSR , + e =proc_create ("debug_level" ,0644 , ieee80211_proc, &fops);if (!e) {remove_proc_entry (DRV_NAME , init_net.proc_net); --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170216194556.GA30632%40singhal-Inspiron-5558.
For more options, visit https://groups.google.com/d/optout.