qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
PATCH 1/1 qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
In the vhost-user example, a chardev with id chr0 is referenced by the vhost-user net backend, but the id is not specified in the chardev option.
Signed-off-by Vincenzo Maffione <[email protected]>
--- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
qemu-options.hx +1 -1
@@ -2127,7 +2127,7 @@ Example: @example qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \ -numa node,memdev=mem \ - -chardev socket,path=/path/to/socket \ + -chardev socket,id=chr0,path=/path/to/socket \ -netdev type=vhost-user,id=net0,chardev=chr0 \ -device virtio-net-pci,netdev=net0 @end example
Signature · 1 line
2.11.1
Quoted 13 lines · Vincenzo Maffione
In the vhost-user example, a chardev with id chr0 is referenced by the vhost-user net backend, but the id is not specified in the chardev option.
Signed-off-by Vincenzo Maffione <[email protected]>--- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)qemu-options.hx +0
-0
qemu-options.hx Example: · line 2133
Quoted 8 lines
qemu-options.hx +1
-1@@ -2127,7 +2127,7 @@ Example: @example qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \ -numa node,memdev=mem \ - -chardev socket,path=/path/to/socket \ + -chardev socket,id=chr0,path=/path/to/socket \ -netdev type=vhost-user,id=net0,chardev=chr0 \ -device virtio-net-pci,netdev=net0 @end example
Reviewed-by Markus Armbruster <[email protected]>
Aside: a test that extracts its test cases out of qemu-options.hx and verifies they at least don't make startup fail would be nice. Bit-sized task only if you have a really big jaw, I'm afraid.
Michael Tokarev
AppliedApplied to -trivial, thanks!
/mjt