Skip to contentSkip to conversation

staging: rtl8192e: Removed unnecessary parentheses

PATCH In review simran singhal 3 participants 5 messages Feb 20, 2017 – Feb 25, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 6/6 staging: rtl8192e: Removed unnecessary parentheses

Extra parentheses were causing checkpatch issues
and were removed.

---

v2:
-Removed parentheses around argument of cast
-Removed cast

 drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +6 -6
index cded0f4..0a9234e 100644
@@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
 		u8	EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
 
 		memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
-		pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
+		pCapELE = (struct ht_capab_ele *)&posHTCap[4];
 		*len = 30 + 2;
 	} else {
 		pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
 	pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
 	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
 
-	memset((void *)(&(pHTInfo->SelfHTCap)), 0,
+	memset(&pHTInfo->SelfHTCap, 0,
 		sizeof(pHTInfo->SelfHTCap));
-	memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
+	memset(&pHTInfo->SelfHTInfo, 0,
 		sizeof(pHTInfo->SelfHTInfo));
-	memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
+	memset(&pHTInfo->PeerHTCapBuf, 0,
 		sizeof(pHTInfo->PeerHTCapBuf));
-	memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
+	memset(&pHTInfo->PeerHTInfoBuf, 0,
 		sizeof(pHTInfo->PeerHTInfoBuf));
 
 	pHTInfo->bSwBwInProgress = false;
@@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
 	pHTInfo->IOTRaFunc = 0;
 
 	{
-		u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
+		u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
 
 		RegHTSuppRateSets[0] = 0xFF;
 		RegHTSuppRateSets[1] = 0xFF;
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 9 lines · simran singhal

Extra parentheses were causing checkpatch issues
and were removed.

---

v2:
-Removed parentheses around argument of cast
-Removed cast

I can't keep track of random patches in the middle of a series that is updated.

Please fix up and resend the whole series, as a series, that are linked together in an email client, not as independent emails (i.e. use git-send-email properly).

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg KH
Quoted 9 lines · simran singhal

Extra parentheses were causing checkpatch issues
and were removed.

---

v2:
-Removed parentheses around argument of cast
-Removed cast

Quoted 6 lines

I can't keep track of random patches in the middle of a series that is updated.

Please fix up and resend the whole series, as a series, that are linked together in an email client, not as independent emails (i.e. use git-send-email properly).

I am using mutt for sending patches. In mutt I have to send each patch of a particular patch series one by one. So, they come as independent emails.

And, they all get mix because of the reason, if I started sending new patch series and at the same time sending new versions of patches of previous patch series, so because of which their order changes.

So, please suggest me some better way, considering I am using mutt.

Thanks,
Simran SInghal

Quoted 4 lines

thanks,

greg k-h

#3 lore raw
Quoted 23 lines · SIMRAN SINGHAL
Quoted 11 lines · Greg KH
Quoted 9 lines · simran singhal

Extra parentheses were causing checkpatch issues
and were removed.

---

v2:
-Removed parentheses around argument of cast
-Removed cast

Quoted 6 lines

I can't keep track of random patches in the middle of a series that is updated.

Please fix up and resend the whole series, as a series, that are linked together in an email client, not as independent emails (i.e. use git-send-email properly).

I am using mutt for sending patches. In mutt I have to send each patch of a particular patch series one by one. So, they come as independent emails.

Quoted 5 lines

And, they all get mix because of the reason, if I started sending new patch series and at the same time sending new versions of patches of previous patch series, so because of which their order changes.

So, please suggest me some better way, considering I am using mutt.

git send-email

maintainer
#4 lore raw
In reply to SIMRAN SINGHAL
Quoted 19 lines · SIMRAN SINGHAL
Quoted 11 lines · Greg KH
Quoted 9 lines · simran singhal

Extra parentheses were causing checkpatch issues
and were removed.

---

v2:
-Removed parentheses around argument of cast
-Removed cast

Quoted 6 lines

I can't keep track of random patches in the middle of a series that is updated.

Please fix up and resend the whole series, as a series, that are linked together in an email client, not as independent emails (i.e. use git-send-email properly).

Quoted 7 lines

I am using mutt for sending patches. In mutt I have to send each patch of a particular patch series one by one. So, they come as independent emails.

And, they all get mix because of the reason, if I started sending new patch series and at the same time sending new versions of patches of previous patch series, so because of which their order changes.

Please do not do that. Would you like to receive patches out of order, not threaded, and all mixed up in the middle of hundreds of other patches? How would you be able to figure it out? Please consider that someone has to read what you send out :)

Quoted 1 line

So, please suggest me some better way, considering I am using mutt.

You can use mutt for that, but you need to know what you are doing and how to thread emails with it. It's not simple, so please just use git send-email for now until you learn mutt better.

good luck!

greg k-h