staging: rtl8192e: Removed unnecessary parentheses
PATCH 6/6 staging: rtl8192e: Removed unnecessary parentheses
Extra parentheses were causing checkpatch issues
and were removed.
--- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +6 -6
@@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,u8 EWC11NHTCap[] = {0x00 ,0x90 ,0x4c ,0x33 };memcpy (posHTCap, EWC11NHTCap,sizeof (EWC11NHTCap)); - pCapELE = (struct ht_capab_ele *)&(posHTCap[4 ]); + pCapELE = (struct ht_capab_ele *)&posHTCap[4 ]; *len =30 +2 ; }else { pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; -memset ((void *)(&(pHTInfo->SelfHTCap)),0 , +memset ((void *)(&pHTInfo->SelfHTCap),0 ,sizeof (pHTInfo->SelfHTCap)); -memset ((void *)(&(pHTInfo->SelfHTInfo)),0 , +memset ((void *)(&pHTInfo->SelfHTInfo),0 ,sizeof (pHTInfo->SelfHTInfo)); -memset ((void *)(&(pHTInfo->PeerHTCapBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTCapBuf),0 ,sizeof (pHTInfo->PeerHTCapBuf)); -memset ((void *)(&(pHTInfo->PeerHTInfoBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTInfoBuf),0 ,sizeof (pHTInfo->PeerHTInfoBuf)); pHTInfo->bSwBwInProgress = false;
@@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->IOTRaFunc =0 ; { -u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0 ]); +u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0 ]; RegHTSuppRateSets[0 ] =0xFF ; RegHTSuppRateSets[1 ] =0xFF ;
Signature · 1 line
2.7.4
Quoted 22 lines · simran singhal
Extra parentheses were causing checkpatch issues
and were removed.Signed-off-by simran singhal <[email protected]>--- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/staging/rtl8192e/rtl819x_HTProc.c +1
-1@@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,u8 EWC11NHTCap[] = {0x00 ,0x90 ,0x4c ,0x33 };memcpy (posHTCap, EWC11NHTCap,sizeof (EWC11NHTCap)); - pCapELE = (struct ht_capab_ele *)&(posHTCap[4 ]); + pCapELE = (struct ht_capab_ele *)&posHTCap[4 ]; *len =30 +2 ; }else { pCapELE = (struct ht_capab_ele *)posHTCap;
drivers/staging/rtl8192e/rtl819x_HTProc.c void HTInitializeHTInfo(struct rtllib_device *ieee) · line 666
Quoted 5 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c +1
-1@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; - memset((void *)(&(pHTInfo->SelfHTCap)), 0, + memset((void *)(&pHTInfo->SelfHTCap), 0,
You don't need the parens around the argument of the cast either.
julia
Quoted 31 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c +4
-5sizeof(pHTInfo->SelfHTCap)); -memset ((void *)(&(pHTInfo->SelfHTInfo)),0 , +memset ((void *)(&pHTInfo->SelfHTInfo),0 ,sizeof (pHTInfo->SelfHTInfo)); -memset ((void *)(&(pHTInfo->PeerHTCapBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTCapBuf),0 ,sizeof (pHTInfo->PeerHTCapBuf)); -memset ((void *)(&(pHTInfo->PeerHTInfoBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTInfoBuf),0 ,sizeof (pHTInfo->PeerHTInfoBuf)); pHTInfo->bSwBwInProgress = false;@@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->IOTRaFunc =0 ; { -u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0 ]); +u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0 ]; RegHTSuppRateSets[0 ] =0xFF ; RegHTSuppRateSets[1 ] =0xFF ; --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218183648.GA2680%40singhal-Inspiron-5558.
For more options, visit https://groups.google.com/d/optout.
Quoted 3 lines · Julia Lawall
Quoted 2 lines · simran singhal
Extra parentheses were causing checkpatch issues
and were removed.
[]
Quoted 1 line
drivers/staging/rtl8192e/rtl819x_HTProc.c
Quoted 1 line
drivers/staging/rtl8192e/rtl819x_HTProc.c +0
-0
[]
Quoted 8 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c void HTInitializeHTInfo(struct rtllib_device *ieee) · line 666
Quoted 6 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c +1
-1@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; - memset((void *)(&(pHTInfo->SelfHTCap)), 0, + memset((void *)(&pHTInfo->SelfHTCap), 0,You don't need the parens around the argument of the cast either.
Nor need the cast at all.
memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));
etc...
Quoted 16 lines · Joe Perches
Quoted 3 lines · Julia Lawall
Quoted 2 lines · simran singhal
Extra parentheses were causing checkpatch issues
and were removed.[]
Quoted 1 line
drivers/staging/rtl8192e/rtl819x_HTProc.c
Quoted 1 line
drivers/staging/rtl8192e/rtl819x_HTProc.c +0
-0[]
Quoted 8 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c void HTInitializeHTInfo(struct rtllib_device *ieee) · line 666
Quoted 6 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c +1
-1@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; - memset((void *)(&(pHTInfo->SelfHTCap)), 0, + memset((void *)(&pHTInfo->SelfHTCap), 0,You don't need the parens around the argument of the cast either.
Quoted 5 lines
Nor need the cast at all.
memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));etc...
Indeed. Thanks!
julia