Skip to contentSkip to conversation

staging: xgifb: function prototype argument should also have an identifier name

PATCH In review Arushi Singhal 3 participants 3 messages Feb 22, 2017 – Feb 24, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: xgifb: function prototype argument should also have an identifier name

function prototype argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name.

---
changes in v3
-make the subject title more relevant.
-change the identifier of struct vb_device_info to XGI_Pr.

---
 drivers/staging/xgifb/vb_init.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/xgifb/vb_init.h +1 -2
index 500cabe41a3c..e835054b87bf 100644
@@ -1,6 +1,5 @@
 #ifndef _VBINIT_
 #define _VBINIT_
 unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr);
 #endif
-
Signature · 1 line
2.11.0
#1 lore raw

Please use the imperative mood in the subject line i.e the short form of git commit log.

A couple of example Subjects::

Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching
Subject: [PATCH v2 01/27] x86: fix eflags tracking

Awesome work on you patches!

thanks,
Tobin.

#2 lore raw
In reply to Arushi Singhal
Quoted 11 lines · Arushi Singhal

function prototype argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name.

---
changes in v3
-make the subject title more relevant.
-change the identifier of struct vb_device_info to XGI_Pr.

---
 drivers/staging/xgifb/vb_init.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Does not apply to my tree :(