staging: xgifb: function prototype argument should also have an identifier name
PATCH v3 1/1 staging: xgifb: function prototype argument should also have an identifier name
function prototype argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name.
---
changes in v3
-make the subject title more relevant.
-change the identifier of struct vb_device_info to XGI_Pr.
--- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/xgifb/vb_init.h +1 -2
@@ -1,6 +1,5 @@#ifndef _VBINIT_#define _VBINIT_unsigned char XGIInitNew (struct pci_dev *pdev); -void XGIRegInit (struct vb_device_info *,unsigned long ); +void XGIRegInit (struct vb_device_info *XGI_Pr,unsigned long BaseAddr);#endif -
Signature · 1 line
2.11.0
Please use the imperative mood in the subject line i.e the short form of git commit log.
A couple of example Subjects::
Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching
Subject: [PATCH v2 01/27] x86: fix eflags tracking
Awesome work on you patches!
thanks,
Tobin.
Greg Kroah-Hartman
maintainerQuoted 11 lines · Arushi Singhal
function prototype argument 'struct
vb_device_info*' and 'unsigned long' should also have an identifier name.Signed-off-by Arushi Singhal <[email protected]>---
changes in v3
-make the subject title more relevant.
-change the identifier of structvb_device_infotoXGI_Pr.--- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Does not apply to my tree :(