Skip to contentSkip to conversation

staging: xgifb: correct the multiple line dereference

PATCH Superseded Arushi Singhal 4 participants 7 messages Feb 28, 2017 Staging

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 staging: xgifb: correct the multiple line dereference

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters.

---
changes in v6
- changes done such that no other errors can generate.
- Improve the coding style.
- Introduced new variables.
- type of the variable is changed.

 drivers/staging/xgifb/XGI_main_26.c | 29 ++++++-----------------------
 drivers/staging/xgifb/vb_setmode.c  | 17 +++++++++++------
 2 files changed, 17 insertions(+), 29 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +6 -23
index 69ed137337ce..9870ea3b76b4 100644
@@ -878,30 +878,13 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
 			}
 
 			if ((filter >= 0) && (filter <= 7)) {
+				const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
 				pr_debug("FilterTable[%d]-%d: %*ph\n",
-					 filter_tb, filter,
-					 4, XGI_TV_filter[filter_tb].
-						   filter[filter]);
-				xgifb_reg_set(
-					XGIPART2,
-					0x35,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][0]));
-				xgifb_reg_set(
-					XGIPART2,
-					0x36,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][1]));
-				xgifb_reg_set(
-					XGIPART2,
-					0x37,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][2]));
-				xgifb_reg_set(
-					XGIPART2,
-					0x38,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][3]));
+					 filter_tb, filter, 4, f);
+				xgifb_reg_set(XGIPART2, 0x35, f[0]);
+				xgifb_reg_set(XGIPART2, 0x36, f[1]);
+				xgifb_reg_set(XGIPART2, 0x37, f[2]);
+				xgifb_reg_set(XGIPART2, 0x38, f[3]);
 			}
 		}
 	}
drivers/staging/xgifb/vb_setmode.c +11 -6
index 7c7c8c8f1df3..249a32804c06 100644
@@ -221,8 +221,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 
 	for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
 	       tempbx; (*i)--) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		unsigned short j;
+
+		j = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
+		infoflag = j;
+
 		if (infoflag & tempax)
 			return 1;
 
@@ -231,8 +234,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 	}
 
 	for ((*i) = 0;; (*i)++) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		unsigned short m;
+
+		m = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
+		infoflag = m;
+
 		if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
 				!= tempbx) {
 			return 0;
@@ -5092,8 +5098,7 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
 
 	i = 0;
 	do {
-		if (XGI330_RefIndex[RefreshRateTableIndex + i].
-			ModeID != ModeNo)
+		if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID != ModeNo)
 			break;
 		temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag;
 		temp &= ModeTypeMask;
Signature · 1 line
2.11.0
#1 lore raw
Quoted 65 lines · Arushi Singhal

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters.

---
changes in v6
- changes done such that no other errors can generate.
- Improve the coding style.
- Introduced new variables.
- type of the variable is changed.

 drivers/staging/xgifb/XGI_main_26.c | 29 ++++++-----------------------
 drivers/staging/xgifb/vb_setmode.c  | 17 +++++++++++------
 2 files changed, 17 insertions(+), 29 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +6 -23
index 69ed137337ce..9870ea3b76b4 100644
@@ -878,30 +878,13 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
 			}
 
 			if ((filter >= 0) && (filter <= 7)) {
+				const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
 				pr_debug("FilterTable[%d]-%d: %*ph\n",
-					 filter_tb, filter,
-					 4, XGI_TV_filter[filter_tb].
-						   filter[filter]);
-				xgifb_reg_set(
-					XGIPART2,
-					0x35,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][0]));
-				xgifb_reg_set(
-					XGIPART2,
-					0x36,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][1]));
-				xgifb_reg_set(
-					XGIPART2,
-					0x37,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][2]));
-				xgifb_reg_set(
-					XGIPART2,
-					0x38,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][3]));
+					 filter_tb, filter, 4, f);
+				xgifb_reg_set(XGIPART2, 0x35, f[0]);
+				xgifb_reg_set(XGIPART2, 0x36, f[1]);
+				xgifb_reg_set(XGIPART2, 0x37, f[2]);
+				xgifb_reg_set(XGIPART2, 0x38, f[3]);
 			}
 		}
 	}
drivers/staging/xgifb/vb_setmode.c +0 -0
index 7c7c8c8f1df3..249a32804c06 100644
@@ -221,8 +221,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 
 	for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, · line 230

Quoted 10 lines
drivers/staging/xgifb/vb_setmode.c +5 -2
 	       tempbx; (*i)--) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		unsigned short j;
+
+		j = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
+		infoflag = j;
+
 		if (infoflag & tempax)
 			return 1;

Why are you using a temporary variable 'j' here? It's not needed at all, and just is confusing to read the code now, don't you agree?

Quoted 4 lines
drivers/staging/xgifb/vb_setmode.c +0 -0
@@ -231,8 +234,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 	}
 
 	for ((*i) = 0;; (*i)++) {

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, · line 244

Quoted 10 lines
drivers/staging/xgifb/vb_setmode.c +5 -2
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		unsigned short m;
+
+		m = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
+		infoflag = m;
+
 		if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
 				!= tempbx) {
 			return 0;

Same here, why add a new variable that isn't used more than once? You are trying to work around something that doesn't make sense to work around.

Remember, coding style cleanups are to be done to make the code easier to understand and follow. Not to blindly follow a perl script that can not think. Sometimes it is not right...

thanks,

greg k-h

#2 lore raw
Quoted 5 lines · Greg Kroah-Hartman
Quoted 4 lines · Arushi Singhal

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters.

[]

Quoted 3 lines

Remember, coding style cleanups are to be done to make the code easier to understand and follow. Not to blindly follow a perl script that can not think. Sometimes it is not right...

Yeah, what Greg said.

Also very long identifier names like RefreshRateTableIndex and simple dereferences like
XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag
make using 80 columns silly.

Just ignore 80 column limits when there are 20+ character identifiers. Ideally shorten the identifiers to something less verbose and/or use temporaries where appropriate like I showed in my reply to your suggested V5 patch.

#3 lore raw
In reply to Greg Kroah-Hartman
Quoted 78 lines · Greg Kroah-Hartman
Quoted 13 lines · Arushi Singhal

Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters.

---
changes in v6
- changes done such that no other errors can generate.
- Improve the coding style.
- Introduced new variables.
- type of the variable is changed.

Review

Quoted 5 lines
 drivers/staging/xgifb/XGI_main_26.c | 29 ++++++-----------------------
 drivers/staging/xgifb/vb_setmode.c  | 17 +++++++++++------
 2 files changed, 17 insertions(+), 29 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/xgifb/XGI_main_26.c

drivers/staging/xgifb/XGI_main_26.c static void XGIfb_post_setmode(struct

Quoted 4 lines

index 69ed137337ce..9870ea3b76b4 100644

drivers/staging/xgifb/XGI_main_26.c +0 -0
@@ -878,30 +878,13 @@ static void XGIfb_post_setmode(struct

xgifb_video_info *xgifb_info)

drivers/staging/xgifb/XGI_main_26.c static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)

Quoted 4 lines
drivers/staging/xgifb/XGI_main_26.c +1 -0
                      }
 
                      if ((filter >= 0) && (filter <= 7)) {
+                             const u8 *f = XGI_TV_filter[filter_tb].

filter[filter];

Review

Quoted 33 lines
drivers/staging/xgifb/XGI_main_26.c +5 -23
                              pr_debug("FilterTable[%d]-%d: %*ph\n",
-                                      filter_tb, filter,
-                                      4, XGI_TV_filter[filter_tb].
-                                                filter[filter]);
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x35,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][0]));
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x36,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][1]));
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x37,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][2]));
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x38,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][3]));
+                                      filter_tb, filter, 4, f);
+                             xgifb_reg_set(XGIPART2, 0x35, f[0]);
+                             xgifb_reg_set(XGIPART2, 0x36, f[1]);
+                             xgifb_reg_set(XGIPART2, 0x37, f[2]);
+                             xgifb_reg_set(XGIPART2, 0x38, f[3]);
                      }
              }
      }
(quoted diff) +0 -0

b/drivers/staging/xgifb/vb_setmode.c

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned

Quoted 4 lines

index 7c7c8c8f1df3..249a32804c06 100644

drivers/staging/xgifb/vb_setmode.c +0 -0
@@ -221,8 +221,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned

short ModeIdIndex,

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,

Quoted 8 lines
drivers/staging/xgifb/vb_setmode.c +3 -2
      for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
             tempbx; (*i)--) {
-             infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-                             Ext_InfoFlag;
+             unsigned short j;
+
+             j = XGI330_RefIndex[RefreshRateTableIndex +

(*i)].Ext_InfoFlag;

Quoted 10 lines

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, · line 230

Quoted 4 lines
drivers/staging/xgifb/vb_setmode.c +2 -0
+             infoflag = j;
+
              if (infoflag & tempax)
                      return 1;

Why are you using a temporary variable 'j' here? It's not needed at all, and just is confusing to read the code now, don't you agree?

I am using temporary variable of small size(character) so that when I fixed the multiple line dereference then the line number of characters in a line will
not increase by 80.

Quoted 17 lines

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned

Quoted 1 line
drivers/staging/xgifb/vb_setmode.c +0 -0
@@ -231,8 +234,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned

short ModeIdIndex,

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,

Quoted 8 lines
drivers/staging/xgifb/vb_setmode.c +3 -2
      }0
 
      for ((*i) = 0;; (*i)++) {
-             infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-                             Ext_InfoFlag;
+             unsigned short m;
+
+             m = XGI330_RefIndex[RefreshRateTableIndex +

(*i)].Ext_InfoFlag;

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, · line 244

Quoted 5 lines
drivers/staging/xgifb/vb_setmode.c +2 -0
+             infoflag = m;
+
              if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
                              != tempbx) {
                      return 0;
Quoted 5 lines

Same here, why add a new variable that isn't used more than once? You are trying to work around something that doesn't make sense to work around.

Same reason as above.

Thanks
Arushi

Quoted 8 lines

Remember, coding style cleanups are to be done to make the code easier to understand and follow. Not to blindly follow a perl script that can not think. Sometimes it is not right...

thanks,

greg k-h

#4 lore raw
Quoted 81 lines · Arushi Singhal

On Tue, Feb 28, 2017 at 11:21 AM, Greg Kroah-Hartman <[email protected]> wrote:

      On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote:
      > Error reported by checkpatch.pl as "avoid multiple line dereference".
      > Addition of new variables to make the code more readable and also to
      > correct about mentioned error as by itroducing new variables line is
      > not exceeding 80 characters.
      >
      > Signed-off-by: Arushi Singhal <[email protected]>
      > ---
      > changes in v6
      >   - changes done such that no other errors can generate.
      >   - Improve the coding style.
      >   - Introduced new variables.
      >   - type of the variable is changed.
      >
      >  drivers/staging/xgifb/XGI_main_26.c | 29 ++++++-----------------------
      >  drivers/staging/xgifb/vb_setmode.c  | 17 +++++++++++------
      >  2 files changed, 17 insertions(+), 29 deletions(-)
      >
      > diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
      > index 69ed137337ce..9870ea3b76b4 100644
      > --- a/drivers/staging/xgifb/XGI_main_26.c
      > +++ b/drivers/staging/xgifb/XGI_main_26.c
      > @@ -878,30 +878,13 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
      >                       }
      >
      >                       if ((filter >= 0) && (filter <= 7)) {
      > +                             const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
      >                               pr_debug("FilterTable[%d]-%d: %*ph\n",
      > -                                      filter_tb, filter,
      > -                                      4, XGI_TV_filter[filter_tb].
      > -                                                filter[filter]);
      > -                             xgifb_reg_set(
      > -                                     XGIPART2,
      > -                                     0x35,
      > -                                     (XGI_TV_filter[filter_tb].
      > -                                             filter[filter][0]));
      > -                             xgifb_reg_set(
      > -                                     XGIPART2,
      > -                                     0x36,
      > -                                     (XGI_TV_filter[filter_tb].
      > -                                             filter[filter][1]));
      > -                             xgifb_reg_set(
      > -                                     XGIPART2,
      > -                                     0x37,
      > -                                     (XGI_TV_filter[filter_tb].
      > -                                             filter[filter][2]));
      > -                             xgifb_reg_set(
      > -                                     XGIPART2,
      > -                                     0x38,
      > -                                     (XGI_TV_filter[filter_tb].
      > -                                             filter[filter][3]));
      > +                                      filter_tb, filter, 4, f);
      > +                             xgifb_reg_set(XGIPART2, 0x35, f[0]);
      > +                             xgifb_reg_set(XGIPART2, 0x36, f[1]);
      > +                             xgifb_reg_set(XGIPART2, 0x37, f[2]);
      > +                             xgifb_reg_set(XGIPART2, 0x38, f[3]);
      >                       }
      >               }
      >       }
      > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
      > index 7c7c8c8f1df3..249a32804c06 100644
      > --- a/drivers/staging/xgifb/vb_setmode.c
      > +++ b/drivers/staging/xgifb/vb_setmode.c
      > @@ -221,8 +221,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
      >
      >       for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
      >              tempbx; (*i)--) {
      > -             infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
      > -                             Ext_InfoFlag;
      > +             unsigned short j;
      > +
      > +             j = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
      > +             infoflag = j;
      > +
      >               if (infoflag & tempax)
      >                       return 1;
Quoted 7 lines

Why are you using a temporary variable 'j' here?  It's not needed at all, and just is confusing to read the code now, don't you agree?

I am using temporary variable of small size(character) so that when
I fixed the multiple line dereference then the line number of characters in a line will not increase by 80.

I agree with Greg that this is not a readable solution. Putting the whole thing on one line would be better, even if it goes over 80 characters. Having the field on a line by itself is much worse, because then it looks like a variable name - one doesn't easily see the connection to the structure. Hopefully someone will come up with a shorter name for RefreshRateTableIndex and then the problem will be completely solved. Maybe ref_table_index? Although to me ref looks like reference, not refresh...

julia

Quoted 44 lines

      > @@ -231,8 +234,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
      >       }0
      >
      >       for ((*i) = 0;; (*i)++) {
      > -             infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
      > -                             Ext_InfoFlag;
      > +             unsigned short m;
      > +
      > +             m = XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
      > +             infoflag = m;
      > +
      >               if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
      >                               != tempbx) {
      >                       return 0;

      Same here, why add a new variable that isn't used more than once?  You
      are trying to work around something that doesn't make sense to work
      around.

Same reason as above.
Thanks
Arushi

Remember, coding style cleanups are to be done to make the code easier to understand and follow.  Not to blindly follow a perl script that can not think.  Sometimes it is not right...

thanks,

greg k-h

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9B9dNXb0q2aZTeWMuLPSXh4mqi8LYNyxGvp1%3DvHw3HYQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

#5 lore raw
In reply to Arushi Singhal

On Tue, Feb 28, 2017 at 01:59:53PM +0530, Arushi Singhal wrote:

Please fix your email client to not send html mail, otherwise the mailing lists reject them, and your quoting is all messed up :(

Quoted 90 lines

On Tue, Feb 28, 2017 at 11:21 AM, Greg Kroah-Hartman < [email protected]> wrote:

    On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote:
    > Error reported by checkpatch.pl as "avoid multiple line dereference".
    > Addition of new variables to make the code more readable and also to
    > correct about mentioned error as by itroducing new variables line is
    > not exceeding 80 characters.
    >
    > Signed-off-by: Arushi Singhal <[email protected]>
    > ---
    > changes in v6
    >� �- changes done such that no other errors can generate.
    >� �- Improve the coding style.
    >� �- Introduced new variables.
    >� �- type of the variable is changed.
    >
    >� drivers/staging/xgifb/XGI_main_26.c | 29 ++++++-----------------------
    >� drivers/staging/xgifb/vb_setmode.c� | 17 +++++++++++------
    >� 2 files changed, 17 insertions(+), 29 deletions(-)
    >
    > diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/
    XGI_main_26.c
    > index 69ed137337ce..9870ea3b76b4 100644
    > --- a/drivers/staging/xgifb/XGI_main_26.c
    > +++ b/drivers/staging/xgifb/XGI_main_26.c
    > @@ -878,30 +878,13 @@ static void XGIfb_post_setmode(struct
    xgifb_video_info *xgifb_info)
    >� � � � � � � � � � � �}
    >
    >� � � � � � � � � � � �if ((filter >= 0) && (filter <= 7)) {
    > +� � � � � � � � � � � � � � �const u8 *f = XGI_TV_filter[filter_tb].
    filter[filter];
    >� � � � � � � � � � � � � � � �pr_debug("FilterTable[%d]-%d: %*ph\n",
    > -� � � � � � � � � � � � � � � � � � � filter_tb, filter,
    > -� � � � � � � � � � � � � � � � � � � 4, XGI_TV_filter[filter_tb].
    > -� � � � � � � � � � � � � � � � � � � � � � � � filter[filter]);
    > -� � � � � � � � � � � � � � �xgifb_reg_set(
    > -� � � � � � � � � � � � � � � � � � �XGIPART2,
    > -� � � � � � � � � � � � � � � � � � �0x35,
    > -� � � � � � � � � � � � � � � � � � �(XGI_TV_filter[filter_tb].
    > -� � � � � � � � � � � � � � � � � � � � � � �filter[filter][0]));
    > -� � � � � � � � � � � � � � �xgifb_reg_set(
    > -� � � � � � � � � � � � � � � � � � �XGIPART2,
    > -� � � � � � � � � � � � � � � � � � �0x36,
    > -� � � � � � � � � � � � � � � � � � �(XGI_TV_filter[filter_tb].
    > -� � � � � � � � � � � � � � � � � � � � � � �filter[filter][1]));
    > -� � � � � � � � � � � � � � �xgifb_reg_set(
    > -� � � � � � � � � � � � � � � � � � �XGIPART2,
    > -� � � � � � � � � � � � � � � � � � �0x37,
    > -� � � � � � � � � � � � � � � � � � �(XGI_TV_filter[filter_tb].
    > -� � � � � � � � � � � � � � � � � � � � � � �filter[filter][2]));
    > -� � � � � � � � � � � � � � �xgifb_reg_set(
    > -� � � � � � � � � � � � � � � � � � �XGIPART2,
    > -� � � � � � � � � � � � � � � � � � �0x38,
    > -� � � � � � � � � � � � � � � � � � �(XGI_TV_filter[filter_tb].
    > -� � � � � � � � � � � � � � � � � � � � � � �filter[filter][3]));
    > +� � � � � � � � � � � � � � � � � � � filter_tb, filter, 4, f);
    > +� � � � � � � � � � � � � � �xgifb_reg_set(XGIPART2, 0x35, f[0]);
    > +� � � � � � � � � � � � � � �xgifb_reg_set(XGIPART2, 0x36, f[1]);
    > +� � � � � � � � � � � � � � �xgifb_reg_set(XGIPART2, 0x37, f[2]);
    > +� � � � � � � � � � � � � � �xgifb_reg_set(XGIPART2, 0x38, f[3]);
    >� � � � � � � � � � � �}
    >� � � � � � � �}
    >� � � �}
    > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/
    vb_setmode.c
    > index 7c7c8c8f1df3..249a32804c06 100644
    > --- a/drivers/staging/xgifb/vb_setmode.c
    > +++ b/drivers/staging/xgifb/vb_setmode.c
    > @@ -221,8 +221,11 @@ static unsigned char XGI_AjustCRT2Rate(unsigned
    short ModeIdIndex,
    >
    >� � � �for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
    >� � � � � � � tempbx; (*i)--) {
    > -� � � � � � �infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
    > -� � � � � � � � � � � � � � �Ext_InfoFlag;
    > +� � � � � � �unsigned short j;
    > +
    > +� � � � � � �j = XGI330_RefIndex[RefreshRateTableIndex +
    (*i)].Ext_InfoFlag;
    > +� � � � � � �infoflag = j;
    > +
    >� � � � � � � �if (infoflag & tempax)
    >� � � � � � � � � � � �return 1;


    Why are you using a temporary variable 'j' here?� It's not needed at
    all, and just is confusing to read the code now, don't you agree?
Quoted 3 lines

I am using temporary variable of small size(character) so that when I fixed the multiple line dereference then the line number of characters in a line will not increase by 80.

I know _why_ you are doing it, sorry, the point is that it makes no sense at all to _do_ that. Please don't just blindly make random code changes to shut the checkpatch.pl script up. You have to think, and use it as a guide.

Remember, coding style changes are to be made to make the code easier to read and understand by humans, not to quite a random perl script's output.

thanks,

greg k-h

#6 lore raw

Thanks Julia, Greg and Joe for always making it clear where I going wrong and guiding me.
Thanks
Arushi

Quoted 124 lines · Greg Kroah-Hartman

On Tue, Feb 28, 2017 at 01:59:53PM +0530, Arushi Singhal wrote:

Please fix your email client to not send html mail, otherwise the mailing lists reject them, and your quoting is all messed up :(

Quoted 5 lines

On Tue, Feb 28, 2017 at 11:21 AM, Greg Kroah-Hartman < [email protected]> wrote:

On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote:
> Error reported by checkpatch.pl as "avoid multiple line

dereference".

Quoted 1 line
Quoted 1 line

Addition of new variables to make the code more readable and also

to

Quoted 1 line
Quoted 1 line

correct about mentioned error as by itroducing new variables line

is

Quoted 11 lines
Quoted 11 lines

not exceeding 80 characters.

---
changes in v6
- changes done such that no other errors can generate.
- Improve the coding style.
- Introduced new variables.
- type of the variable is changed.

 drivers/staging/xgifb/XGI_main_26.c | 29

++++++-----------------------

Quoted 4 lines

Review

Quoted 4 lines
 drivers/staging/xgifb/vb_setmode.c  | 17 +++++++++++------
 2 files changed, 17 insertions(+), 29 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/xgifb/

Quoted 10 lines
    XGI_main_26.c
    > index 69ed137337ce..9870ea3b76b4 100644
    > --- a/drivers/staging/xgifb/XGI_main_26.c
    > +++ b/drivers/staging/xgifb/XGI_main_26.c
    > @@ -878,30 +878,13 @@ static void XGIfb_post_setmode(struct
    xgifb_video_info *xgifb_info)
    >                       }
    >
    >                       if ((filter >= 0) && (filter <= 7)) {
    > +                             const u8 *f =

XGI_TV_filter[filter_tb].

Quoted 2 lines
    filter[filter];
    >                               pr_debug("FilterTable[%d]-%d:

%*ph\n",

Quoted 24 lines
Quoted 24 lines
drivers/staging/xgifb/XGI_main_26.c +1 -23
-                                      filter_tb, filter,
-                                      4, XGI_TV_filter[filter_tb].
-                                                filter[filter]);
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x35,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][0]));
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x36,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][1]));
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x37,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][2]));
-                             xgifb_reg_set(
-                                     XGIPART2,
-                                     0x38,
-                                     (XGI_TV_filter[filter_tb].
-                                             filter[filter][3]));
+                                      filter_tb, filter, 4, f);
Quoted 8 lines

Review

Quoted 8 lines
drivers/staging/xgifb/XGI_main_26.c +4 -0
+                             xgifb_reg_set(XGIPART2, 0x35, f[0]);
+                             xgifb_reg_set(XGIPART2, 0x36, f[1]);
+                             xgifb_reg_set(XGIPART2, 0x37, f[2]);
+                             xgifb_reg_set(XGIPART2, 0x38, f[3]);
                      }
              }
      }
(quoted diff) +0 -0

b/drivers/staging/xgifb/

Quoted 5 lines

vb_setmode.c
> index 7c7c8c8f1df3..249a32804c06 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -221,8 +221,11 @@ static unsigned char

XGI_AjustCRT2Rate(unsigned

Quoted 3 lines

short ModeIdIndex,
>
> for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID

==

Quoted 2 lines
Quoted 2 lines
             tempbx; (*i)--) {

- infoflag = XGI330_RefIndex[RefreshRateTableIndex +

(*i)].

Quoted 14 lines

drivers/staging/xgifb/vb_setmode.c static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,

Quoted 4 lines
drivers/staging/xgifb/vb_setmode.c +3 -1
-                             Ext_InfoFlag;
+             unsigned short j;
+
+             j = XGI330_RefIndex[RefreshRateTableIndex +
    (*i)].Ext_InfoFlag;
    > +             infoflag = j;
    > +
    >               if (infoflag & tempax)
    >                       return 1;


    Why are you using a temporary variable 'j' here?  It's not needed at
    all, and just is confusing to read the code now, don't you agree?
Quoted 2 lines

I am using temporary variable of small size(character) so that when I fixed the multiple line dereference then the line number of characters

in a

Quoted 1 line

line will not increase by 80.

I know _why_ you are doing it, sorry, the point is that it makes no sense at all to _do_ that. Please don't just blindly make random code changes to shut the checkpatch.pl script up. You have to think, and use it as a guide.

Remember, coding style changes are to be made to make the code easier to read and understand by humans, not to quite a random perl script's output.

thanks,

greg k-h