Skip to contentSkip to conversation

staging: xgifb: correct the multiple line dereference

PATCH Superseded Arushi Singhal 3 participants 3 messages Feb 24, 2017 – Feb 25, 2017 Staging

v2 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: xgifb: correct the multiple line dereference

Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference...
And If there is boolean operator then it is fixed by Splitting line at boolean operator.This is a coding style error.
The changes are made such that the other errors does not generate beacause of this change like line exceeding 80 characters length.

---
changes in v2
- changes done such that no other errors can generate.

---
 drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------
 drivers/staging/xgifb/vb_setmode.c  | 14 +++++++-------
 2 files changed, 16 insertions(+), 19 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +9 -12
index 6930f7eb741b..651987398d42 100644
@@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
 			}
 
 			if ((filter >= 0) && (filter <= 7)) {
+				const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
+
 				pr_debug("FilterTable[%d]-%d: %*ph\n",
 					 filter_tb, filter,
-					 4, XGI_TV_filter[filter_tb].
-						   filter[filter]);
+					 4, f);
 				xgifb_reg_set(
 					XGIPART2,
 					0x35,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][0]));
-				xgifb_reg_set(
+					(f[0]));
+			        xgifb_reg_set(
 					XGIPART2,
 					0x36,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][1]));
-				xgifb_reg_set(
+					(f[1]));
+			        xgifb_reg_set(
 					XGIPART2,
 					0x37,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][2]));
+					(f[2]));
 				xgifb_reg_set(
 					XGIPART2,
 					0x38,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][3]));
+					(f[3]));
 			}
 		}
 	}
drivers/staging/xgifb/vb_setmode.c +7 -7
index 7c7c8c8f1df3..1220d0cea87d 100644
@@ -221,8 +221,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 
 	for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
 	       tempbx; (*i)--) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		infoflag =
+		XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
 		if (infoflag & tempax)
 			return 1;
 
@@ -231,8 +231,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 	}
 
 	for ((*i) = 0;; (*i)++) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		infoflag =
+		XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
 		if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
 				!= tempbx) {
 			return 0;
@@ -5092,8 +5092,8 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
 
 	i = 0;
 	do {
-		if (XGI330_RefIndex[RefreshRateTableIndex + i].
-			ModeID != ModeNo)
+		if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID
+				!= ModeNo)
 			break;
 		temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag;
 		temp &= ModeTypeMask;
@@ -5484,7 +5484,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
 				return 0;
 
 		pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex].
-						Ext_ModeFlag & ModeTypeMask;
+				Ext_ModeFlag & ModeTypeMask;
 
 		pVBInfo->SetFlag = 0;
 		pVBInfo->VBInfo = DisableCRT2Display;
Signature · 1 line
2.11.0
#1 lore raw
Quoted 21 lines · Arushi Singhal

Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference...
And If there is boolean operator then it is fixed by Splitting line at boolean operator.This is a coding style error.
The changes are made such that the other errors does not generate beacause of this change like line exceeding 80 characters length.

---
changes in v2
- changes done such that no other errors can generate.

---
 drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------
 drivers/staging/xgifb/vb_setmode.c  | 14 +++++++-------
 2 files changed, 16 insertions(+), 19 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +0 -0
index 6930f7eb741b..651987398d42 100644

drivers/staging/xgifb/XGI_main_26.c static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) · line 885

Quoted 10 lines
drivers/staging/xgifb/XGI_main_26.c +3 -2
@@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
 			}
 
 			if ((filter >= 0) && (filter <= 7)) {
+				const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
+
 				pr_debug("FilterTable[%d]-%d: %*ph\n",
 					 filter_tb, filter,
-					 4, XGI_TV_filter[filter_tb].
-						   filter[filter]);
+					 4, f);

Do please rewrap these appropriately. i.e.:

				pr_debug(""FilterTable[%d]-%d: %*ph\n",

� �filter_tb, filter, 4, f);

drivers/staging/xgifb/XGI_main_26.c static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) · line 889

Quoted 7 lines
drivers/staging/xgifb/XGI_main_26.c +1 -3
 				xgifb_reg_set(
 					XGIPART2,
 					0x35,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][0]));
-				xgifb_reg_set(
+					(f[0]));

and:

				xgifb_reg_set(XGIPART2, 0x35, f[0]);

drivers/staging/xgifb/XGI_main_26.c static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) · line 893

Quoted 7 lines
drivers/staging/xgifb/XGI_main_26.c +2 -3
+			        xgifb_reg_set(
 					XGIPART2,
 					0x36,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][1]));
-				xgifb_reg_set(
+					(f[1]));
				xgifb_reg_set(XGIPART2, 0x36, f[1]);

etc...

#2 lore raw
In reply to Arushi Singhal
Quoted 4 lines · Arushi Singhal

Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference...
And If there is boolean operator then it is fixed by Splitting line at boolean operator.This is a coding style error.

There is strange spacing and capitalization in the above two lines. Only the first word in a sentence should be capitalized. There should be at least one space after a period.

Quoted 2 lines

The changes are made such that the other errors does not generate beacause of this change like line exceeding 80 characters length.

This doesn't say anything about what you did.

Quoted 5 lines

---
changes in v2
- changes done such that no other errors can generate.
---

You don't need --- here. Only the one just below the Signed off by.

julia

Quoted 104 lines
 drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------
 drivers/staging/xgifb/vb_setmode.c  | 14 +++++++-------
 2 files changed, 16 insertions(+), 19 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +9 -12
index 6930f7eb741b..651987398d42 100644
@@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
 			}
 
 			if ((filter >= 0) && (filter <= 7)) {
+				const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
+
 				pr_debug("FilterTable[%d]-%d: %*ph\n",
 					 filter_tb, filter,
-					 4, XGI_TV_filter[filter_tb].
-						   filter[filter]);
+					 4, f);
 				xgifb_reg_set(
 					XGIPART2,
 					0x35,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][0]));
-				xgifb_reg_set(
+					(f[0]));
+			        xgifb_reg_set(
 					XGIPART2,
 					0x36,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][1]));
-				xgifb_reg_set(
+					(f[1]));
+			        xgifb_reg_set(
 					XGIPART2,
 					0x37,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][2]));
+					(f[2]));
 				xgifb_reg_set(
 					XGIPART2,
 					0x38,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][3]));
+					(f[3]));
 			}
 		}
 	}
drivers/staging/xgifb/vb_setmode.c +7 -8
index 7c7c8c8f1df3..1220d0cea87d 100644
@@ -221,8 +221,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 
 	for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
 	       tempbx; (*i)--) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		infoflag =
+		XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
 		if (infoflag & tempax)
 			return 1;
 
@@ -231,8 +231,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 	}
 
 	for ((*i) = 0;; (*i)++) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		infoflag =
+		XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
 		if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
 				!= tempbx) {
 			return 0;
@@ -5092,8 +5092,8 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
 
 	i = 0;
 	do {
-		if (XGI330_RefIndex[RefreshRateTableIndex + i].
-			ModeID != ModeNo)
+		if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID
+				!= ModeNo)
 			break;
 		temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag;
 		temp &= ModeTypeMask;
@@ -5484,7 +5484,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
 				return 0;
 
 		pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex].
-						Ext_ModeFlag & ModeTypeMask;
+				Ext_ModeFlag & ModeTypeMask;
 
 		pVBInfo->SetFlag = 0;
 		pVBInfo->VBInfo = DisableCRT2Display;
--

2.11.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170224234130.GA608%40arushi-HP-Pavilion-Notebook.
For more options, visit https://groups.google.com/d/optout.