Skip to contentSkip to conversation

staging: sm750fb: function prototype argument should have an identifier name

PATCH Superseded Arushi Singhal 2 participants 2 messages Mar 11, 2017

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: sm750fb: function prototype argument should have an identifier name

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name.

---
changes in v2
-Add the identifier name of one more function prototype

 drivers/staging/sm750fb/ddk750_display.h | 2 +-
 drivers/staging/sm750fb/ddk750_mode.h    | 2 +-
 drivers/staging/sm750fb/ddk750_power.h   | 2 +-
 drivers/staging/sm750fb/sm750.h          | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_display.h +1 -1
index e2a3f84ca4c5..609bf742efff 100644
@@ -102,6 +102,6 @@ typedef enum _disp_output_t {
 }
 disp_output_t;
 
-void ddk750_setLogicalDispOut(disp_output_t);
+void ddk750_setLogicalDispOut(disp_output_t output);
 
 #endif
drivers/staging/sm750fb/ddk750_mode.h +1 -1
index 2183e664cf4b..6d204b8b4a01 100644
@@ -34,6 +34,6 @@ typedef struct _mode_parameter_t {
 }
 mode_parameter_t;
 
-int ddk750_setModeTiming(mode_parameter_t *, clock_type_t);
+int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock);
 
 #endif
drivers/staging/sm750fb/ddk750_power.h +1 -1
index ec0b99d6a7ad..44c4fc587e96 100644
@@ -14,7 +14,7 @@ DPMS_t;
 	       (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
 
-void ddk750_set_dpms(DPMS_t);
+void ddk750_set_dpms(DPMS_t state);
 void sm750_set_power_mode(unsigned int powerMode);
 void sm750_set_current_gate(unsigned int gate);
 
drivers/staging/sm750fb/sm750.h +2 -2
index 306711ed55f9..f60565cae80c 100644
@@ -184,8 +184,8 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
 }
 
 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
-int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *);
-void hw_sm750_initAccel(struct sm750_dev *);
+int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
+void hw_sm750_initAccel(struct sm750_dev *hw_sm750_initAccel);
 int hw_sm750_deWait(void);
 int hw_sm750le_deWait(void);
 
Signature · 1 line
2.11.0
#1 lore raw

drivers/staging/sm750fb/sm750.h static inline unsigned long ps_to_hz(unsigned int psvalue) · line 188

Quoted 10 lines · Arushi Singhal
drivers/staging/sm750fb/sm750.h +2 -2
@@ -184,8 +184,8 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
 }
 
 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
-int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *);
-void hw_sm750_initAccel(struct sm750_dev *);
+int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
+void hw_sm750_initAccel(struct sm750_dev *hw_sm750_initAccel);

"sm750_dev", like the implementation uses.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds