Skip to contentSkip to conversation

staging: checkpatch cleanups

PATCH In review Arushi Singhal 2 participants 7 messages Mar 13, 2017 – Mar 16, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover staging: checkpatch cleanups

Improve readability by fixing multiple checkpatch.pl issues in drivers.

Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.

 drivers/media/dvb-frontends/drxk_hard.c  |   1 -
 drivers/staging/speakup/speakup_dtlk.h   |  10 +++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)
Signature · 4 lines
Changes since v3:
 -change the subject of cover letter.

2.11.0
#1 lore raw

PATCH v3 1/2 staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces.

---
 drivers/staging/speakup/speakup_dtlk.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/speakup/speakup_dtlk.h +5 -5
index b3b3cfc3db07..46d885fcfb20 100644
@@ -24,11 +24,11 @@
 				 * usec later.
 				 */
 #define TTS_ALMOST_FULL	0x08	/* mask for AF bit: When set to 1,
-				         * indicates that less than 300 bytes
-				         * are available in the TTS input
-				         * buffer. AF is always 0 in the PCM,
-				         * TGN and CVSD modes.
-				         */
+					 * indicates that less than 300 bytes
+					 * are available in the TTS input
+					 * buffer. AF is always 0 in the PCM,
+					 * TGN and CVSD modes.
+					 */
 #define TTS_ALMOST_EMPTY 0x04	/* mask for AE bit: When set to 1,
 				 * indicates that less than 300 bytes
 				 * are remaining in DoubleTalk's input
Signature · 1 line
2.11.0
maintainer
#2 lore raw

Re: [PATCH v3 1/2] staging: speakup: identation should use tabs

Quoted 6 lines · Arushi Singhal

Indentation should always use tabs and never spaces.

---
 drivers/staging/speakup/speakup_dtlk.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

What changed from v2?

Always list it, even if nothing changed...

thanks,

greg k-h

#3 lore raw

PATCH v3 2/2 staging: dvb-frontends: removed code in comments.

In reply to Arushi Singhal

Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them.
So in this patch codes in the comments are removed.

---
changes in v3
- Improve the commit message

 drivers/media/dvb-frontends/drxk_hard.c | 1 -
 1 file changed, 1 deletion(-)
drivers/media/dvb-frontends/drxk_hard.c +0 -1
index 7e1bbbaad625..2fe493768003 100644
@@ -5283,7 +5283,6 @@ static int qam_set_symbolrate(struct drxk_state *state)
 	/* Select & calculate correct IQM rate */
 	adc_frequency = (state->m_sys_clock_freq * 1000) / 3;
 	ratesel = 0;
-	/* printk(KERN_DEBUG "drxk: SR %d\n", state->props.symbol_rate); */
 	if (state->props.symbol_rate <= 1188750)
 		ratesel = 3;
 	else if (state->props.symbol_rate <= 2377500)
Signature · 1 line
2.11.0
maintainer
#4 lore raw
In reply to Arushi Singhal
Quoted 6 lines · Arushi Singhal

Improve readability by fixing multiple checkpatch.pl issues in drivers.

Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.

What changed from v2?

thanks,

greg k-h

#5 lore raw
Quoted 10 lines · Greg KH
Quoted 6 lines · Arushi Singhal

Improve readability by fixing multiple checkpatch.pl issues in drivers.

Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.

What changed from v2?

In this patch nothing is changed from v2 but it is a patch series so have
to write v2 everywhere.
Thanks
Arushi

Quoted 5 lines

thanks,

greg k-h

maintainer
#6 lore raw
Quoted 8 lines · Arushi Singhal

On Tue, Mar 14, 2017 at 3:35 AM, Greg KH <[email protected]> wrote:

On Tue, Mar 14, 2017 at 01:49:52AM +0530, Arushi Singhal wrote:
> Improve readability by fixing multiple checkpatch.pl > issues in drivers.
>

Quoted 8 lines

> Arushi Singhal (2):
>� �staging: speakup: identation should use tabs >� �staging: dvb-frontends: removed code in comments.

What changed from v2?

�In this patch nothing is changed from v2 but it is a patch series so have to write v2 everywhere.

And everywhere you also need to say why it is v2, otherwise we have no idea :(

thanks,

greg k-h