Skip to contentSkip to conversation

sunxi: Pine64: defconfig: enable SPL FIT support

PATCH New Icenowy Zheng 1 participant 1 message Mar 29, 2017

lore
Share & tools
lore
#0 lore raw

PATCH v2 14/18 sunxi: Pine64: defconfig: enable SPL FIT support

Quoted 39 lines · 2017年3月29日 19:17于 Andre Przywara <[email protected]>写道:

Hi,

Quoted 26 lines · Maxime Ripard
Quoted 25 lines · Andre Przywara

The Pine64 (and all other 64-bit Allwinner boards) need to load an ARM Trusted Firmware image beside the actual U-Boot proper. This can now be easily achieved by using the just extended SPL FIT loading support, so enable it in the Pine64 defconfig. Also add the FIT image as a build target to 64-bit sunxi board to trigger the respective Makefile rules.

---
  configs/pine64_plus_defconfig  | 6 ++++++
  include/configs/sunxi-common.h | 4 ++++

  2 files changed, 10 insertions(+) 
configs/pine64_plus_defconfig +0 -0
index 92bda60..8a90579 100644 
@@ -3,9 +3,14 @@ CONFIG_ARCH_SUNXI=y 

  CONFIG_MACH_SUN50I=y CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus" +CONFIG_OF_LIST="sun50i-a64-pine64 sun50i-a64-pine64-plus" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_CONSOLE_MUX=y
  CONFIG_SPL=y

Quoted 8 lines

configs/pine64_plus_defconfig

Quoted 4 lines
configs/pine64_plus_defconfig +4 -0
+CONFIG_FIT=y 
+CONFIG_SPL_FIT=y 
+CONFIG_SPL_LOAD_FIT=y 
+CONFIG_SPL_OF_LIBFDT=y 

Again, this doesn't make any sense to enable it in *all* our defconfigs. If this is something that should be enabled by default for the A64 support, then do so in Kconfig directly.

Quoted 7 lines

Oh sorry, I think I completely misunderstood you last time. Indeed this makes sense, especially with more defconfigs for A64/H5 boards coming up.

I will think about a solution that makes Icenowy happy as well, something like BOARD_NEEDS_SPL_FIT or so - though a simple "select" sounds tempting ;-)

In fact I don't need an environment without ATF. I just mentioned the possibility ;-)

Quoted 3 lines

Cheers,
Andre.