Skip to contentSkip to conversation

sunxi: Pine64: defconfig: enable SPL FIT support

PATCH Superseded Icenowy Zheng 1 participant 1 message Mar 29, 2017

lore
Share & tools
lore
#0 lore raw

PATCH v2 14/18 sunxi: Pine64: defconfig: enable SPL FIT support

Quoted 27 lines · 2017年3月29日 14:57于 Maxime Ripard <[email protected]>写道:
Quoted 25 lines · Andre Przywara

The Pine64 (and all other 64-bit Allwinner boards) need to load an ARM Trusted Firmware image beside the actual U-Boot proper. This can now be easily achieved by using the just extended SPL FIT loading support, so enable it in the Pine64 defconfig. Also add the FIT image as a build target to 64-bit sunxi board to trigger the respective Makefile rules.

---
  configs/pine64_plus_defconfig  | 6 ++++++
  include/configs/sunxi-common.h | 4 ++++

  2 files changed, 10 insertions(+) 
configs/pine64_plus_defconfig +0 -0
index 92bda60..8a90579 100644 
@@ -3,9 +3,14 @@ CONFIG_ARCH_SUNXI=y 

  CONFIG_MACH_SUN50I=y CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus" +CONFIG_OF_LIST="sun50i-a64-pine64 sun50i-a64-pine64-plus" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_CONSOLE_MUX=y
  CONFIG_SPL=y

Quoted 8 lines

configs/pine64_plus_defconfig

Quoted 4 lines
configs/pine64_plus_defconfig +4 -0
+CONFIG_FIT=y 
+CONFIG_SPL_FIT=y 
+CONFIG_SPL_LOAD_FIT=y 
+CONFIG_SPL_OF_LIBFDT=y 

Again, this doesn't make any sense to enable it in *all* our defconfigs. If this is something that should be enabled by default for the A64 support, then do so in Kconfig directly.

Here it's "strongly recommended" to use SPL FIT support, but not "must", as someone may use U-Boot to execute their own code that wants EL3. In that situation SPL FIT support shouldn't be present. U-Boot is not Linux Loader, so we should give people the permission to disable it; however, U-Boot is mostly used to load and execute Linux, so this should be defaultly enabled -- is this correctly the meaning of defconfig?

Quoted 7 lines

Maxime

Signature · 3 lines
Maxime Ripard, Free Electrons 
Embedded Linux and Kernel engineering 
http://free-electrons.com