Skip to contentSkip to conversation

pitft: Add support for pitft35r

PATCH Applied Rob Woolley 2 participants 7 messages Apr 6, 2017 – Apr 17, 2017 Broadcom BCM2711/BCM2835 Arm architecture

lore
Share & tools
lore
#0 lore raw

v2 cover pitft: Add support for pitft35r

As requested, I have split the patch into separate commits for:

1. dtbo inclusion
2. rpi-config changes
3. Documentation commit

I ordered them this way in case a user ever walked through the commits in the git tree. This way the prerequisites are present before the feature is advertised in the documentation.

Hope this works for you. Let me know if there are any additional changes that need to be made.

Regards,
Rob

#1 lore raw

PATCH v2 1/3 pitft: Include the pitft35r dtbo files

Include the pitft35r device tree blobs in the filesystem of the image.

---
 conf/machine/include/rpi-base.inc | 1 +
 conf/machine/raspberrypi3-64.conf | 1 +
 2 files changed, 2 insertions(+)
conf/machine/include/rpi-base.inc +1 -0
index 092cbeb..9bcb91d 100644
@@ -31,6 +31,7 @@ KERNEL_DEVICETREE ?= " \
     overlays/lirc-rpi.dtbo \
     overlays/pitft22.dtbo \
     overlays/pitft28-resistive.dtbo \
+    overlays/pitft35-resistive.dtbo \
     overlays/pps-gpio.dtbo \
     overlays/rpi-ft5406.dtbo \
     overlays/w1-gpio.dtbo \
conf/machine/raspberrypi3-64.conf +1 -0
index ca10ed9..0efe3ff 100644
@@ -23,6 +23,7 @@ KERNEL_DEVICETREE = " \
     overlays/lirc-rpi.dtbo \
     overlays/pitft22.dtbo \
     overlays/pitft28-resistive.dtbo \
+    overlays/pitft35-resistive.dtbo \
     overlays/pps-gpio.dtbo \
     overlays/rpi-ft5406.dtbo \
     overlays/w1-gpio.dtbo \
Signature · 1 line
2.11.0
#2 lore raw

PATCH v2 2/3 pitft: Include a pitft35r MACHINE_FEATURE

In reply to Rob Woolley

This MACHINE_FEATURE will automatically add the recommended Adafruit configuration line to the Raspberry Pi config.txt.

---
 recipes-bsp/bootfiles/rpi-config_git.bb | 6 ++++++
 1 file changed, 6 insertions(+)
recipes-bsp/bootfiles/rpi-config_git.bb +6 -0
index af55983..b3c5084 100644
@@ -18,6 +18,7 @@ PR = "r5"
 PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft", "1", "0", d)}"
 PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0", d)}"
 PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0", d)}"
+PITFT35r="${@bb.utils.contains("MACHINE_FEATURES", "pitft35r", "1", "0", d)}"
 
 VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1", "0", d)}"
 
@@ -99,6 +100,11 @@ do_deploy() {
         echo "dtoverlay=pitft28-resistive,rotate=90,speed=32000000,txbuflen=32768" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
     fi
 
+    if [ "${PITFT35r}" = "1" ]; then
+        echo "# Enable PITFT35r display" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+        echo "dtoverlay=pitft35-resistive,rotate=90,speed=42000000,fps=20" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+    fi
+
     # UART support
     if [ "${ENABLE_UART}" = "1" ]; then
         echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
Signature · 1 line
2.11.0
#3 lore raw

PATCH v2 3/3 pitft: Add documentation for pitft35r in README

In reply to Rob Woolley

The support for the PiTFT 3.5 inch resistive touchscreen is optional. It may be enabled by adding the following line in local.conf:

    MACHINE_FEATURES += "pitft pitft35r"
---
 README | 1 +
 1 file changed, 1 insertion(+)
README +1 -0
index 9fdd5eb..e44475c 100644
@@ -241,6 +241,7 @@ the modelname should be added as a MACHINE_FEATURES in local.conf like below:
 List of currently supported models:
     - pitft22
     - pitft28r
+    - pitft35r
 
 3.O. Misc. display
 ==================
Signature · 1 line
2.11.0
#4 lore raw
In reply to Rob Woolley

Hi Andrei,

Does this patchset look okay?

Are there any further changes you would like me to make?

Regards,
Rob

Quoted 21 lines · Rob Woolley

As requested, I have split the patch into separate commits for:

1. dtbo inclusion
2. rpi-config changes
3. Documentation commit

I ordered them this way in case a user ever walked through the commits in the git tree. This way the prerequisites are present before the feature is advertised in the documentation.

Hope this works for you. Let me know if there are any additional changes that need to be made.

Regards,
Rob
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#5 lore raw

Hi Rob,

Quoted 5 lines · Rob Woolley

Hi Andrei,

Does this patchset look okay?

Are there any further changes you would like me to make?

Looks good. I'll test it and merge it soon.

#6 lore raw
Quoted 10 lines · Andrei Gherzan

Hi Rob,

Quoted 5 lines · Rob Woolley

Hi Andrei,

Does this patchset look okay?

Are there any further changes you would like me to make?

Looks good. I'll test it and merge it soon.

Merged to master. Thanks.

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan