staging: lustre: llite: Replace the symbolic file permission mode with the numeric one
PATCH v3 1/1 staging: lustre: llite: Replace the symbolic file permission mode with the numeric one
Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions considered harmful:
https://lwn.net/Articles/696229/
Signed-off-by Roman Storozhenko <[email protected]>
--- drivers/staging/lustre/lustre/llite/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/llite/dir.c +1 -1
@@ -1141,7 +1141,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg) }#if OBD_OCD_VERSION (2 ,9 ,50 ,0 ) >LUSTRE_VERSION_CODE - mode = data->ioc_type !=0 ? data->ioc_type :S_IRWXUGO ; + mode = data->ioc_type !=0 ? data->ioc_type :0777 ;#else mode = data->ioc_type;#endif
Signature · 1 line
2.7.4
Greg KH
maintainerPATCH v3 1/1 staging: lustre: llite: Replace the symbolic file permission mode with the numeric one
Quoted 8 lines · Roman Storozhenko
Replaces
S_IRWXUGOwith 0777. The reason is that symbolic permissions considered harmful:
https://lwn.net/Articles/696229/Signed-off-by Roman Storozhenko <[email protected]>--- drivers/staging/lustre/lustre/llite/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What changed in this version of the patch? You always have to say that below the --- line, like the documentation says to do.
Please fix, make a v4, and resend.
thanks,
greg k-h