Skip to contentSkip to conversation

staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

PATCH Superseded Roman Storozhenko 2 participants 2 messages Jun 13, 2017 Staging

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions considered harmful:
https://lwn.net/Articles/696229/

---
 drivers/staging/lustre/lustre/llite/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/llite/dir.c +1 -1
index 13b3592..de5b4bf 100644
@@ -1141,7 +1141,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 		}
 
 #if OBD_OCD_VERSION(2, 9, 50, 0) > LUSTRE_VERSION_CODE
-		mode = data->ioc_type != 0 ? data->ioc_type : S_IRWXUGO;
+		mode = data->ioc_type != 0 ? data->ioc_type : 0777;
 #else
 		mode = data->ioc_type;
 #endif
Signature · 1 line
2.7.4
maintainer
#1 lore raw

PATCH v3 1/1 staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

Quoted 8 lines · Roman Storozhenko

Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions considered harmful:
https://lwn.net/Articles/696229/

---
 drivers/staging/lustre/lustre/llite/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What changed in this version of the patch? You always have to say that below the --- line, like the documentation says to do.

Please fix, make a v4, and resend.

thanks,

greg k-h