stm32-dcmi: constify vb2_ops structure
Subsystems (2)
PATCH 1/1 stm32-dcmi: constify vb2_ops structure
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i at p = { ... };
@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i at p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e at i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
--- drivers/media/platform/stm32/stm32-dcmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/stm32/stm32-dcmi.c +1 -1
@@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq) dcmi->errors_count, dcmi->buffers_count); } -static struct vb2_ops dcmi_video_qops = { +static const struct vb2_ops dcmi_video_qops = { .queue_setup = dcmi_queue_setup, .buf_init = dcmi_buf_init, .buf_prepare = dcmi_buf_prepare,
Signature · 1 line
2.5.0
Quoted 52 lines · Gustavo A. R. Silva
Check for
vb2_opsstructures that are only stored in the ops field of avb2_queuestructure. That field is declared const, sovb2_opsstructures that have this property can be declared as const also.This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static structvb2_opsi at p = { ... };@ok@
identifier r.i;
structvb2_queuee;
position p;
@@
e.ops = &i at p;@bad@
position p != {r.p,ok.p};
identifier r.i;
structvb2_opse;
@@
e at i@p@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
structvb2_opsi = { ... };Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/media/platform/stm32/stm32-dcmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/stm32/stm32-dcmi.c +1
-1@@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq) dcmi->errors_count, dcmi->buffers_count); } -static struct vb2_ops dcmi_video_qops = { +static const struct vb2_ops dcmi_video_qops = { .queue_setup = dcmi_queue_setup, .buf_init = dcmi_buf_init, .buf_prepare = dcmi_buf_prepare,
Quoted 1 line · Hugues FRUCHET
Acked-by Hugues Fruchet <[email protected]>
Thank you, Hugues.
Quoted 52 lines · Gustavo A. R. Silva
Quoted 51 lines
Check for
vb2_opsstructures that are only stored in the ops field of avb2_queuestructure. That field is declared const, sovb2_opsstructures that have this property can be declared as const also.This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static structvb2_opsi at p = { ... };@ok@
identifier r.i;
structvb2_queuee;
position p;
@@
e.ops = &i at p;@bad@
position p != {r.p,ok.p};
identifier r.i;
structvb2_opse;
@@
e at i@p@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
structvb2_opsi = { ... };Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/media/platform/stm32/stm32-dcmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/stm32/stm32-dcmi.c +1
-1@@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq) dcmi->errors_count, dcmi->buffers_count); } -static struct vb2_ops dcmi_video_qops = { +static const struct vb2_ops dcmi_video_qops = { .queue_setup = dcmi_queue_setup, .buf_init = dcmi_buf_init, .buf_prepare = dcmi_buf_prepare,
Signature · 1 line
Gustavo A. R. Silva