Skip to contentSkip to conversation

stm32-dcmi: constify vb2_ops structure

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Jul 6, 2017 – Jul 17, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stm32-dcmi: constify vb2_ops structure

Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i at p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i at p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e at i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };

---
 drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/stm32/stm32-dcmi.c +1 -1
index 83d32a5..24ef888 100644
@@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq)
 		dcmi->errors_count, dcmi->buffers_count);
 }
 
-static struct vb2_ops dcmi_video_qops = {
+static const struct vb2_ops dcmi_video_qops = {
 	.queue_setup		= dcmi_queue_setup,
 	.buf_init		= dcmi_buf_init,
 	.buf_prepare		= dcmi_buf_prepare,
Signature · 1 line
2.5.0
Acked-by on v1 1/1
#1 lore raw
Quoted 52 lines · Gustavo A. R. Silva

Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i at p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i at p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e at i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };

---
  drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/stm32/stm32-dcmi.c +1 -1
index 83d32a5..24ef888 100644
@@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq)
  		dcmi->errors_count, dcmi->buffers_count);
  }
 
-static struct vb2_ops dcmi_video_qops = {
+static const struct vb2_ops dcmi_video_qops = {
  	.queue_setup		= dcmi_queue_setup,
  	.buf_init		= dcmi_buf_init,
  	.buf_prepare		= dcmi_buf_prepare,
#2 lore raw
Quoted 1 line · Hugues FRUCHET

Thank you, Hugues.

Quoted 52 lines · Gustavo A. R. Silva
Quoted 51 lines

Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i at p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i at p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e at i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };

---
   drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/stm32/stm32-dcmi.c +1 -1
index 83d32a5..24ef888 100644
@@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq)
   		dcmi->errors_count, dcmi->buffers_count);
   }
 
-static struct vb2_ops dcmi_video_qops = {
+static const struct vb2_ops dcmi_video_qops = {
   	.queue_setup		= dcmi_queue_setup,
   	.buf_init		= dcmi_buf_init,
   	.buf_prepare		= dcmi_buf_prepare,
Signature · 1 line
Gustavo A. R. Silva