Skip to contentSkip to conversation

Staging: android/ion: fix sparse warnings

PATCH In review Joseph Wright 2 participants 4 messages Jul 17, 2017 – Jul 18, 2017 Staging

lore
Share & tools
lore

Joseph Wright

author
#0 lore raw

v3 cover Staging: android/ion: fix sparse warnings

Improve commit message.

Previous version included a patch to add declarations to ion.h, but I have dropped that as the same declarations were recently removed.

Joseph Wright (1):
Staging: android/ion: declare function static

 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.9.3
author
#1 lore raw

PATCH v3 1/1 Staging: android/ion: declare function static

Declare private function static to fix sparse warning:

ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?

Signed-off-by Joseph Wright <[email protected]>

---
Changes in v3:
- Make subject clearer

 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ion/ion_cma_heap.c +1 -1
index a0949bc..c6db9b7 100644
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
 	return &cma_heap->heap;
 }
 
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
 	struct ion_heap *heap;
Signature · 1 line
2.9.3
maintainer
#2 lore raw

Re: [PATCH v3 1/1] Staging: android/ion: declare function static

Quoted 5 lines · Joseph Wright

Declare private function static to fix sparse warning:

ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?

Quoted 7 lines
Signed-off-by Joseph Wright <[email protected]>

---
Changes in v3:
- Make subject clearer

 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, does not apply to my tree as I think someone else already did this before you did :(

author
#3 lore raw

Re: [PATCH v3 1/1] Staging: android/ion: declare function static

Quoted 11 lines · Greg KH
Quoted 10 lines · Joseph Wright

Declare private function static to fix sparse warning:

ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?

Signed-off-by Joseph Wright <[email protected]>

---
Changes in v3:
- Make subject clearer

Quoted 5 lines
Quoted 2 lines
 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, does not apply to my tree as I think someone else already did this before you did :(

Okay, thanks anyway.

Joseph