Staging: android/ion: fix sparse warnings

PATCH Superseded Joseph Wright 2 participants 2 messages Jul 5, 2017 – Jul 11, 2017 Staging

Share & tools

Joseph Wright

author

2017-07-05 01:40 UTC #0 lore raw

PATCH 1/1 Staging: android/ion: fix sparse warnings

ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
was not declared. Should it be static?
ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
was not declared. Should it be static?
ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?

Signed-off-by Joseph Wright <[email protected]>

---
 drivers/staging/android/ion/ion.h          | 4 ++++
 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

drivers/staging/android/ion/ion.h +4 -0

index fa9ed81..fda1e91 100644
@@ -358,4 +358,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
 
 int ion_query_heaps(struct ion_heap_query *query);
 
+struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data);
+
+struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data);
+
 #endif /* _ION_H */

drivers/staging/android/ion/ion_cma_heap.c +1 -1

index a0949bc..c6db9b7 100644
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
 	return &cma_heap->heap;
 }
 
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
 	struct ion_heap *heap;

Signature · 1 line

2.9.3

Greg KH

maintainer

2017-07-11 18:05 UTC #1 lore raw

Quoted 6 lines · Joseph Wright

ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
was not declared. Should it be static?
ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
was not declared. Should it be static?
ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?

You are doing two different types of things here, please break this up into multiple patches.

thanks,

greg k-h