drm/i915: Explicit the connector name for DP link training result
Subsystems (2)
PATCH v2 1/1 drm/i915: Explicit the connector name for DP link training result
This adds the connector name when printing a debug message about the DP link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.
--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp_link_training.c +6 -2
@@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count);return ; failure_handling: -DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate,
Signature · 1 line
2.13.2
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Explicit the connector name for DP link training result (rev2)
== Series Details ==
== Series Details ==
Series: drm/i915: Explicit the connector name for DP link training result (rev2)
URL : https://patchwork.freedesktop.org/series/27410/
State : success
== Summary ==
Series 27410v2 drm/i915: Explicit the connector name for DP link training result
https://patchwork.freedesktop.org/api/1.0/series/27410/revisions/2/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-kbl-7560u) k.org#196399 +1
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> DMESG-WARN (fi-pnv-d510) fdo#101597k.org#196399 https://bugzilla.kernel.org/show_bug.cgi?id=196399
fdo#101597 https://bugs.freedesktop.org/show_bug.cgi?id=101597
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:444s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:434s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:353s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:536s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:514s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:495s fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:491s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:593s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:437s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:410s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:415s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:490s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:494s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:469s fi-kbl-7560u total:279 pass:268 dwarn:1 dfail:0 fail:0 skip:10 time:572s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:592s fi-pnv-d510 total:279 pass:222 dwarn:2 dfail:0 fail:0 skip:55 time:559s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:458s fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:582s fi-skl-6700k total:279 pass:257 dwarn:4 dfail:0 fail:0 skip:18 time:469s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:482s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:441s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:466s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:405s
10de1e17faaab452782e5a1baffd1b30a639a261 drm-tip: 2017y-07m-18d-10h-08m-42s UTC integration manifest 53ca378 drm/i915: Explicit the connector name for DP link training result
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_5220/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 22 lines · Paul Kocialkowski
This adds the connector name when printing a debug message about the DP link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +3
-1@@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count);
drivers/gpu/drm/i915/intel_dp_link_training.c intel_dp_start_link_train(struct intel_dp *intel_dp) · line 336
Quoted 10 lines
drivers/gpu/drm/i915/intel_dp_link_training.c +3
-1return ; failure_handling: -DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate,
The choice of upper v/s lower case letters in these debug messages is a bit odd.
Passed/failed
Link rate/link rate
Lane count/lane count
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Paul Kocialkowski
This adds the connector name when printing a debug message about the DP link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.
Thanks for the patch, this does make sense during the link training failure debugging to know the connector name.
While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case in the failure_handling case to be consistent with the pass case.
Manasi
Quoted 31 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +6
-2@@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count);return ; failure_handling: -DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate,Signature · 1 line
2.13.2
Daniel Vetter
AppliedQuoted 6 lines · Manasi Navare
Quoted 4 lines · Paul Kocialkowski
This adds the connector name when printing a debug message about the DP link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.
Quoted 6 lines
Thanks for the patch, this does make sense during the link training failure debugging to know the connector name.
While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case in thefailure_handlingcase to be consistent with the pass case.Reviewed-by Manasi Navare <[email protected]>
Applied, thanks.
-Daniel
Quoted 38 lines
Manasi
Quoted 31 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +6
-2@@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count);return ; failure_handling: -DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d" , +DRM_DEBUG_KMS ("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d" , + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate,Signature · 1 line
2.13.2_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 7 lines · Manasi Navare
Quoted 5 lines · Paul Kocialkowski
This adds the connector name when printing a debug message about the DP
link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.
Quoted 5 lines
Thanks for the patch, this does make sense during the link training failure debugging to know the connector name.
While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case
in thefailure_handlingcase to be consistent with the pass case.
Thanks for the review!
Now that the patch was merged, do you feel like I should make a follow- up patch to fix consistency in the upper case use or is it enough of a detail that we can just forget about it?
Quoted 42 lines
Reviewed-by Manasi Navare <[email protected]>Manasi
Quoted 38 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +3
-2@@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d", + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d", + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count);return ; failure_handling: - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lanecount = %d",
drivers/gpu/drm/i915/intel_dp_link_training.c +1
-0+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed atlink rate = %d, lane count = %d",
drivers/gpu/drm/i915/intel_dp_link_training.c +2
-0+ intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp-Quoted 1 line
link_rate,Signature · 1 line
2.13.2
Signature · 6 lines
Paul Kocialkowski <[email protected]> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Jani Nikula
maintainerQuoted 14 lines · Paul Kocialkowski
Quoted 7 lines · Manasi Navare
Quoted 5 lines · Paul Kocialkowski
This adds the connector name when printing a debug message about the DP
link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.Quoted 5 lines
Thanks for the patch, this does make sense during the link training failure debugging to know the connector name.
While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case
in thefailure_handlingcase to be consistent with the pass case.
Quoted 5 lines
Thanks for the review!
Now that the patch was merged, do you feel like I should make a follow- up patch to fix consistency in the upper case use or is it enough of a detail that we can just forget about it?
If it bothers you, send a patch, otherwise wait for it to bother someone else enough to send a patch. ;)
But please avoid the overuse of all caps for regular words, or capitalization except at the beginning of sentences. I'd go with something like this all over the place:
"Link training failed, link rate %d, lane count %d\n"
But it hasn't bothered me enough to send a patch. ;)
BR,
Jani.
Quoted 43 lines
Quoted 43 lines
Reviewed-by Manasi Navare <[email protected]>Manasi
Quoted 38 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +3
-2@@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d", + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d", + intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count);return ; failure_handling: - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lanecount = %d",
drivers/gpu/drm/i915/intel_dp_link_training.c +1
-0+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed atlink rate = %d, lane count = %d",
drivers/gpu/drm/i915/intel_dp_link_training.c +2
-0+ intel_connector->base.base.id, + intel_connector->base.name, intel_dp->link_rate, intel_dp->lane_count); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp-Quoted 1 line
link_rate,Signature · 1 line
2.13.2
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel