drm/i915: Explicit the connector name for DP link training result
Subsystems (2)
PATCH 1/1 drm/i915: Explicit the connector name for DP link training result
This adds the connector name when printing a debug message about the DP link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.
--- drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dp_link_training.c +6 -4
@@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d" , - intel_dp->link_rate, intel_dp->lane_count); +DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s" , + intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name);return ; failure_handling: -DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d" , - intel_dp->link_rate, intel_dp->lane_count); +DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d for connector %s" , + intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name);if (!intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Explicit the connector name for DP link training result
== Series Details ==
== Series Details ==
Series: drm/i915: Explicit the connector name for DP link training result
URL : https://patchwork.freedesktop.org/series/27410/
State : success
== Summary ==
Series 27410v1 drm/i915: Explicit the connector name for DP link training result
https://patchwork.freedesktop.org/api/1.0/series/27410/revisions/1/mbox/
Test kms_flip:
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-x1585l) fdo#101781fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:445s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:428s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:353s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:534s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:506s fi-byt-j1900 total:279 pass:255 dwarn:0 dfail:0 fail:0 skip:24 time:482s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:487s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:596s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:436s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:414s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:425s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:495s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:468s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:463s fi-kbl-7560u total:279 pass:268 dwarn:1 dfail:0 fail:0 skip:10 time:575s fi-kbl-r total:279 pass:260 dwarn:1 dfail:0 fail:0 skip:18 time:584s fi-pnv-d510 total:279 pass:221 dwarn:3 dfail:0 fail:0 skip:55 time:567s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:461s fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:592s fi-skl-6700k total:279 pass:257 dwarn:4 dfail:0 fail:0 skip:18 time:472s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:484s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:438s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:487s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:540s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:404s
d93246177cf41d1731dae587923544b7a28659a6 drm-tip: 2017y-07m-17d-11h-27m-05s UTC integration manifest cfc64cd drm/i915: Explicit the connector name for DP link training result
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_5210/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 3 lines · Paul Kocialkowski
This adds the connector name when printing a debug message about the DP link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.
Perhaps more consistent would be using a prefix like this:
DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n",
connector->base.base.id, connector->base.name);BR,
Jani.
Quoted 30 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +6
-4@@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d" , - intel_dp->link_rate, intel_dp->lane_count); +DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s" , + intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name);return ; failure_handling: -DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d" , - intel_dp->link_rate, intel_dp->lane_count); +DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d for connector %s" , + intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name);if (!intel_dp_get_link_train_fallback_values (intel_dp, intel_dp->link_rate, intel_dp->lane_count))
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hey,
Quoted 11 lines · Jani Nikula
Quoted 4 lines · Paul Kocialkowski
This adds the connector name when printing a debug message about the DP
link training result. It is useful to figure out what connector is failing when multiple DP connectors are used.Perhaps more consistent would be using a prefix like this:
DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n", connector->base.base.id, connector->base.name);
You are definitely right, this is what is used all over the place in the driver, so I should stick to it.
Thanks for the suggestion, I will send out v2 in that direction shortly.
Cheers,
Paul
Quoted 39 lines
Quoted 37 lines
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +4
-4@@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)if (!intel_dp_link_training_channel_equalization (intel_dp)) goto failure_handling; -DRM_DEBUG_KMS ("Link Training Passed at Link Rate = %d, Lane count = %d", - intel_dp->link_rate, intel_dp->lane_count); + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s", + intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name);return ; failure_handling: -DRM_DEBUG_KMS ("Link Training failed at link rate = %d, lane count = %d", - intel_dp->link_rate, intel_dp->lane_count); + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lanecount = %d for connector %s",
drivers/gpu/drm/i915/intel_dp_link_training.c +2
-0+ intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp-Quoted 1 line
link_rate,intel_dp-
Quoted 1 line
lane_count))
Signature · 6 lines
Paul Kocialkowski <[email protected]> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx