Skip to contentSkip to conversation

Convert CONFIG_NAND_OMAP_GPMC et al to Kconfig

PATCH Superseded Adam Ford 2 participants 3 messages Aug 13, 2017 – Sep 1, 2017

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v3 1/1 Convert CONFIG_NAND_OMAP_GPMC et al to Kconfig

This converts the following to Kconfig:
CONFIG_NAND_OMAP_GPMC
CONFIG_NAND_OMAP_GPMC_PREFETCH
CONFIG_NAND_OMAP_ELM
CONFIG_SYS_NAND_BUSWIDTH_16BIT
CONFIG_SPL_NAND_AM33XX_BCH
CONFIG_SPL_NAND_SIMPLE (ARCH_OMAP2PLUS only)

V3:
Remove selection from CMD_NAND

Changes since V1:
Rebased on latest Master
Fixed a few missing entries where some features lacked dependancies

---
 configs/am3517_crane_defconfig    | 6 ++++--
 configs/cm_t3517_defconfig        | 1 +
 configs/cm_t35_defconfig          | 1 +
 configs/omap3_evm_defconfig       | 1 +
 configs/omap3_ha_defconfig        | 6 ++++--
 configs/tao3530_defconfig         | 6 ++++--
 configs/tricorder_defconfig       | 1 +
 include/configs/ti_omap3_common.h | 1 -
 8 files changed, 16 insertions(+), 7 deletions(-)
configs/am3517_crane_defconfig +4 -2
index 396aadd..e7d92b6 100644
@@ -13,11 +13,11 @@ CONFIG_SYS_PROMPT="AM3517_CRANE # "
 # CONFIG_CMD_IMI is not set
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
-CONFIG_CMD_I2C=y
 CONFIG_CMD_USB=y
-# CONFIG_CMD_FPGA is not set
 # CONFIG_CMD_SETEXPR is not set
 # CONFIG_CMD_NET is not set
 CONFIG_CMD_DHCP=y
@@ -26,6 +26,8 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_JFFS2=y
 CONFIG_MMC_OMAP_HS=y
+CONFIG_NAND=y
+CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
configs/cm_t3517_defconfig +1 -0
index d5550fe..66cdc19 100644
@@ -37,6 +37,7 @@ CONFIG_LED_STATUS_STATE=2
 CONFIG_LED_STATUS_BOOT_ENABLE=y
 CONFIG_LED_STATUS_BOOT=0
 CONFIG_MMC_OMAP_HS=y
+CONFIG_NAND=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_MUSB_HOST=y
configs/cm_t35_defconfig +1 -0
index 16f1eab..21bf5c3 100644
@@ -39,6 +39,7 @@ CONFIG_LED_STATUS_STATE=2
 CONFIG_LED_STATUS_BOOT_ENABLE=y
 CONFIG_LED_STATUS_BOOT=0
 CONFIG_MMC_OMAP_HS=y
+CONFIG_NAND=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
configs/omap3_evm_defconfig +1 -0
index 9bbc980..40a91dd 100644
@@ -45,6 +45,7 @@ CONFIG_SPL_DM=y
 CONFIG_DM_GPIO=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_MTD=y
+CONFIG_NAND=y
 CONFIG_DM_SERIAL=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
configs/omap3_ha_defconfig +4 -2
index f88c2e1..2884d5a 100644
@@ -12,11 +12,11 @@ CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_IMI is not set
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
-CONFIG_CMD_I2C=y
 CONFIG_CMD_USB=y
-# CONFIG_CMD_FPGA is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y
@@ -25,6 +25,8 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_MMC_OMAP_HS=y
+CONFIG_NAND=y
+CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
configs/tao3530_defconfig +4 -2
index e6c7e60..f8c9596 100644
@@ -12,11 +12,11 @@ CONFIG_SYS_PROMPT="TAO-3530 # "
 # CONFIG_CMD_IMI is not set
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
-CONFIG_CMD_I2C=y
 CONFIG_CMD_USB=y
-# CONFIG_CMD_FPGA is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y
@@ -25,6 +25,8 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_MMC_OMAP_HS=y
+CONFIG_NAND=y
+CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
configs/tricorder_defconfig +1 -0
index de42b4d..ad07dbc 100644
@@ -35,5 +35,6 @@ CONFIG_LED_STATUS_BIT2=4
 CONFIG_LED_STATUS_STATE2=2
 CONFIG_LED_STATUS_CMD=y
 CONFIG_MMC_OMAP_HS=y
+CONFIG_NAND=y
 CONFIG_SYS_NS16550=y
 CONFIG_OF_LIBFDT=y
include/configs/ti_omap3_common.h +0 -1
index 393d867..2373727 100644
@@ -65,7 +65,6 @@
 					 (64 << 20))
 
 #ifdef CONFIG_NAND
-#define CONFIG_SPL_NAND_SIMPLE
 #define CONFIG_SYS_NAND_BASE		0x30000000
 #endif
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/1 Convert CONFIG_NAND_OMAP_GPMC et al to Kconfig

Quoted 10 lines · Adam Ford

This converts the following to Kconfig:
CONFIG_NAND_OMAP_GPMC
CONFIG_NAND_OMAP_GPMC_PREFETCH
CONFIG_NAND_OMAP_ELM
CONFIG_SYS_NAND_BUSWIDTH_16BIT
CONFIG_SPL_NAND_AM33XX_BCH
CONFIG_SPL_NAND_SIMPLE (ARCH_OMAP2PLUS only)

Quoted 7 lines

V3:
Remove selection from CMD_NAND

Changes since V1:
Rebased on latest Master
Fixed a few missing entries where some features lacked dependancies
---

The changelog goes below the '---' :) And more importantly..

Quoted 9 lines
 configs/am3517_crane_defconfig    | 6 ++++--
 configs/cm_t3517_defconfig        | 1 +
 configs/cm_t35_defconfig          | 1 +
 configs/omap3_evm_defconfig       | 1 +
 configs/omap3_ha_defconfig        | 6 ++++--
 configs/tao3530_defconfig         | 6 ++++--
 configs/tricorder_defconfig       | 1 +
 include/configs/ti_omap3_common.h | 1 -
 8 files changed, 16 insertions(+), 7 deletions(-)

You forgot the Kconfig part of these changes.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170901/0986ca29/attachment.sig>
author
#2 lore raw

PATCH v3 1/1 Convert CONFIG_NAND_OMAP_GPMC et al to Kconfig

Quoted 32 lines · Tom Rini
Quoted 10 lines · Adam Ford

This converts the following to Kconfig:
CONFIG_NAND_OMAP_GPMC
CONFIG_NAND_OMAP_GPMC_PREFETCH
CONFIG_NAND_OMAP_ELM
CONFIG_SYS_NAND_BUSWIDTH_16BIT
CONFIG_SPL_NAND_AM33XX_BCH
CONFIG_SPL_NAND_SIMPLE (ARCH_OMAP2PLUS only)

Quoted 7 lines

V3:
Remove selection from CMD_NAND

Changes since V1:
Rebased on latest Master
Fixed a few missing entries where some features lacked dependancies
---

The changelog goes below the '---' :) And more importantly..

Quoted 9 lines
 configs/am3517_crane_defconfig    | 6 ++++--
 configs/cm_t3517_defconfig        | 1 +
 configs/cm_t35_defconfig          | 1 +
 configs/omap3_evm_defconfig       | 1 +
 configs/omap3_ha_defconfig        | 6 ++++--
 configs/tao3530_defconfig         | 6 ++++--
 configs/tricorder_defconfig       | 1 +
 include/configs/ti_omap3_common.h | 1 -
 8 files changed, 16 insertions(+), 7 deletions(-)
Quoted 1 line

You forgot the Kconfig part of these changes.

My bad. I didn't add the '--amend' to my git commit, so version 2 &3 totally missed the vast majority of what I had in V1. Sorry about that. I just re-sent V4 with everything from V1-V3 combined into 1 patch.

adam

Quoted 3 lines

--
Tom