Skip to contentSkip to conversation

hw_random: Include device.h instead of declaring struct device

PATCH In review PrasannaKumar Muralidharan 2 participants 3 messages Oct 26, 2017 – Oct 30, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw_random: Include device.h instead of declaring struct device

Include linux/device.h instead of declaring struct device.

---
 include/linux/hw_random.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/hw_random.h +1 -2
index bee0827..2ec9af7 100644
@@ -13,6 +13,7 @@
 #define LINUX_HWRANDOM_H_
 
 #include <linux/completion.h>
+#include <linux/device.h>
 #include <linux/types.h>
 #include <linux/list.h>
 #include <linux/kref.h>
@@ -51,8 +52,6 @@ struct hwrng {
 	struct completion cleanup_done;
 };
 
-struct device;
-
 /** Register a new Hardware Random Number Generator driver. */
 extern int hwrng_register(struct hwrng *rng);
 extern int devm_hwrng_register(struct device *dev, struct hwrng *rng);
Signature · 1 line
2.10.0
maintainer
#1 lore raw
Quoted 3 lines · PrasannaKumar Muralidharan

Include linux/device.h instead of declaring struct device.

Nack. We should not include a header file when a simple forward declaration is enough.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt