hw_random: Include device.h instead of declaring struct device
Subsystems (2)
PATCH 1/1 hw_random: Include device.h instead of declaring struct device
Include linux/device.h instead of declaring struct device.
Signed-off-by PrasannaKumar Muralidharan <[email protected]>
--- include/linux/hw_random.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/hw_random.h +1 -2
@@ -13,6 +13,7 @@#define LINUX_HWRANDOM_H_ #include <linux/completion.h> +#include <linux/device.h> #include <linux/types.h> #include <linux/list.h> #include <linux/kref.h>
@@ -51,8 +52,6 @@ struct hwrng {struct completion cleanup_done; }; -struct device ; -/** Register a new Hardware Random Number Generator driver. */ extern int hwrng_register (struct hwrng *rng);extern int devm_hwrng_register (struct device *dev,struct hwrng *rng);
Signature · 1 line
2.10.0
Herbert Xu
maintainerQuoted 3 lines · PrasannaKumar Muralidharan
Include
linux/device.hinstead of declaring struct device.Signed-off-by PrasannaKumar Muralidharan <[email protected]>
Nack. We should not include a header file when a simple forward declaration is enough.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Herbert,
Quoted 7 lines · Herbert Xu
Quoted 3 lines · PrasannaKumar Muralidharan
Include
linux/device.hinstead of declaring struct device.Signed-off-by PrasannaKumar Muralidharan <[email protected]>Nack. We should not include a header file when a simple forward declaration is enough.
No issues.
Regards,
PrasannaKumar