Skip to contentSkip to conversation

ARM: dts: exynos: add bcm4334 device node to trats2

PATCH Superseded Simon Shields 2 participants 2 messages Nov 9, 2017 – Nov 10, 2017

Subsystems (2)
Device tree bindings Arm Samsung Exynos

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Simon Shields

author
#0 lore raw

PATCH v4 1/1 ARM: dts: exynos: add bcm4334 device node to trats2

This patch allows the bcm4334 to power on and enables wifi functionality on trats2.

Signed-off-by Simon Shields <[email protected]>
---
 arch/arm/boot/dts/exynos4412-trats2.dts | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
arch/arm/boot/dts/exynos4412-trats2.dts +28 -0
index bceb919ac637..1bf1943ba7a1 100644
@@ -241,6 +241,13 @@
 
 	};
 
+	wlan_pwrseq: sdhci3-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&gpj0 0 GPIO_ACTIVE_LOW>;
+		clocks = <&max77686 MAX77686_CLK_PMIC>;
+		clock-names = "ext_clock";
+	};
+
 	sound {
 		compatible = "samsung,trats2-audio";
 		samsung,i2s-controller = <&i2s0>;

@@ -1239,6 +1246,27 @@
 	status = "okay";
 };
 
+&sdhci_3 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	non-removable;
+	bus-width = <4>;
+
+	mmc-pwrseq = <&wlan_pwrseq>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd3_clk &sd3_cmd &sd3_bus4>;
+	vmmc-supply = <&ldo21_reg>;
+	status = "okay";
+
+	brcmf: brcmf at 1 {
+		reg = <1>;
+		compatible = "brcm,bcm4329-fmac";
+		interrupt-parent = <&gpx2>;
+		interrupts = <5 IRQ_TYPE_NONE>;
+		interrupt-names = "host-wake";
+	};
+};
+
 &serial_0 {
 	status = "okay";
 };
Signature · 1 line
2.15.0
maintainer
#1 lore raw

PATCH v4 1/1 ARM: dts: exynos: add bcm4334 device node to trats2

Quoted 30 lines · Simon Shields

This patch allows the bcm4334 to power on and enables wifi functionality on trats2.

Signed-off-by Simon Shields <[email protected]>
---
 arch/arm/boot/dts/exynos4412-trats2.dts | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
arch/arm/boot/dts/exynos4412-trats2.dts +7 -0
index bceb919ac637..1bf1943ba7a1 100644
@@ -241,6 +241,13 @@
 
 	};
 
+	wlan_pwrseq: sdhci3-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&gpj0 0 GPIO_ACTIVE_LOW>;
+		clocks = <&max77686 MAX77686_CLK_PMIC>;
+		clock-names = "ext_clock";
+	};
+
 	sound {
 		compatible = "samsung,trats2-audio";
 		samsung,i2s-controller = <&i2s0>;

@@ -1239,6 +1246,27 @@
 	status = "okay";
 };

arch/arm/boot/dts/exynos4412-trats2.dts line 1258

Quoted 10 lines
arch/arm/boot/dts/exynos4412-trats2.dts +10 -0
+&sdhci_3 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	non-removable;
+	bus-width = <4>;
+
+	mmc-pwrseq = <&wlan_pwrseq>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd3_clk &sd3_cmd &sd3_bus4>;
+	vmmc-supply = <&ldo21_reg>;

How did you get LDO21 here? It does not look correct.

arch/arm/boot/dts/exynos4412-trats2.dts line 1261

Quoted 3 lines
arch/arm/boot/dts/exynos4412-trats2.dts +3 -0
+	status = "okay";
+
+	brcmf: brcmf at 1 {

The node name should be generic class of device, thus maybe "wifi"? Label can stay although I see it is not used now.

Best regards,
Krzysztof

Quoted 14 lines
arch/arm/boot/dts/exynos4412-trats2.dts +8 -0
+		reg = <1>;
+		compatible = "brcm,bcm4329-fmac";
+		interrupt-parent = <&gpx2>;
+		interrupts = <5 IRQ_TYPE_NONE>;
+		interrupt-names = "host-wake";
+	};
+};
+
 &serial_0 {
 	status = "okay";
 };
Signature · 1 line
2.15.0