mtd: spi-nor: add support for ISSI is25lp128
Subsystems (2)
PATCH v3 1/1 mtd: spi-nor: add support for ISSI is25lp128
Add support for ISSI is25lp128 spi nor flash.
---
Changes for v2:
- add commit message.
Changes for v3:
- add SPI_NOR_DUAL_READ flag.
--- drivers/mtd/spi-nor/spi-nor.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +2 -0
@@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {/* ISSI */ { "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) }, + { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256, + SECT_4K | SPI_NOR_DUAL_READ) },/* Macronix */ { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },
Signature · 1 line
2.15.0
Hi Angelo,
Le 19/11/2017 à 00:48, Angelo Dureghello a écrit :
Quoted 17 lines
Add support for ISSI is25lp128 spi nor flash.
Signed-off-by Angelo Dureghello <[email protected]>---
Changes for v2:
- add commit message.
Changes for v3:
- addSPI_NOR_DUAL_READflag.--- drivers/mtd/spi-nor/spi-nor.c | 2 ++ 1 file changed, 2 insertions(+)drivers/mtd/spi-nor/spi-nor.c +0
-0
drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1008
Quoted 4 lines
drivers/mtd/spi-nor/spi-nor.c +1
-0@@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {/* ISSI */ { "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) }, + { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
If you don't mind, I will align figures in the column for the number of sectors before applying your patch.
Otherwise, it looks good.
Best regards,
Cyrille
Quoted 5 lines
drivers/mtd/spi-nor/spi-nor.c +1
-0+ SECT_4K | SPI_NOR_DUAL_READ) },/* Macronix */ { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },
Cyrille Pitchen
AppliedLe 29/11/2017 à 11:58, Cyrille Pitchen a écrit :
Quoted 6 lines
Hi Angelo,
Le 19/11/2017 à 00:48, Angelo Dureghello a écrit :
Quoted 3 lines
Add support for ISSI is25lp128 spi nor flash.
Signed-off-by Angelo Dureghello <[email protected]>
Applied to the spi-nor/next branch of l2-mtd
Thanks
Quoted 38 lines
Quoted 14 lines
---
Changes for v2:
- add commit message.
Changes for v3:
- addSPI_NOR_DUAL_READflag.--- drivers/mtd/spi-nor/spi-nor.c | 2 ++ 1 file changed, 2 insertions(+)drivers/mtd/spi-nor/spi-nor.c +0
-0drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1008
Quoted 4 lines
drivers/mtd/spi-nor/spi-nor.c +1
-0@@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {/* ISSI */ { "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) }, + { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,If you don't mind, I will align figures in the column for the number of sectors before applying your patch.
Otherwise, it looks good.
Best regards,
Cyrille
drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1012
Quoted 5 lines
drivers/mtd/spi-nor/spi-nor.c +1
-0+ SECT_4K | SPI_NOR_DUAL_READ) },/* Macronix */ { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Cyrille,
thanks for reviewing,
Quoted 21 lines · Cyrille Pitchen
Hi Angelo,
Le 19/11/2017 à 00:48, Angelo Dureghello a écrit :
Quoted 18 lines
Add support for ISSI is25lp128 spi nor flash.
Signed-off-by Angelo Dureghello <[email protected]>---
Changes for v2:
- add commit message.
Changes for v3:
- addSPI_NOR_DUAL_READflag.--- drivers/mtd/spi-nor/spi-nor.c | 2 ++ 1 file changed, 2 insertions(+)drivers/mtd/spi-nor/spi-nor.c +0
-0@@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {
Quoted 9 lines
drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1008
Quoted 3 lines
drivers/mtd/spi-nor/spi-nor.c +1
-0/* ISSI */ { "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) }, + { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,If you don't mind, I will align figures in the column for the number of sectors before applying your patch.
Otherwise, it looks good.
Feel free to realign the code as you prefer, or if you prefer i can also send v4.
Quoted 5 lines
Best regards,
Cyrille
drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 1010
Quoted 2 lines
drivers/mtd/spi-nor/spi-nor.c +1
-0+ SECT_4K | SPI_NOR_DUAL_READ) },
Best regards,
Angelo Dureghello
Quoted 4 lines
Quoted 3 lines
drivers/mtd/spi-nor/spi-nor.c +0
-0/* Macronix */ { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },