Skip to contentSkip to conversation

Add Exynos4412-based midas boards support

PATCH Superseded Simon Shields 5 participants 9 messages Dec 14, 2017 – Dec 15, 2017 3 messages not in the archive

Subsystems (5)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add Exynos4412-based midas boards support

Hi,

This patch series adds support for a new set of boards, codenamed "midas". These are the Galaxy S3 (m0/m3) and the Galaxy Note 2 (t0). These boards are closely related to trats2 - m0 is a trats2 but with a bootloader geared towards booting Android rather than a traditional Linux distribution - and because of this, the dts files are largely based off what is already in-place for trats2. Trats2 is modified to use the dts files added by this series.

Patch #1 adds documentation for the bindings used by the boards. Patch #2 splits the existing trats2 DTS into the common midas, m0/m3/trats2-specific, and trats2-specific parts. Patch #3 adds the device-tree files for the other boards. Patch #4 enables cpuidle support for all added boards.

Changes since v1:
* Include trats2 in inheritance
* Add the new dtbs to the makefile
* Cleanup style per Krzysztof's comments

Cheers,
Simon

Simon Shields (4):
dt-bindings: samsung: document bindings for Midas family boards
ARM: dts: split trats2 dts in preparation for midas boards
ARM: dts: add Samsung's exynos4412-based midas boards
ARM: exynos: extend cpuidle support to midas boards

 .../bindings/arm/samsung/samsung-boards.txt        |    4 +
 arch/arm/boot/dts/Makefile                         |    3 +
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi        |  144 +++
 arch/arm/boot/dts/exynos4412-m0.dts                |   14 +
 arch/arm/boot/dts/exynos4412-m3.dts                |   19 +
 arch/arm/boot/dts/exynos4412-midas.dtsi            | 1291 ++++++++++++++++++
 arch/arm/boot/dts/exynos4412-t0.dts                |   50 +
 arch/arm/boot/dts/exynos4412-trats2.dts            | 1364 +-------------------
 arch/arm/mach-exynos/exynos.c                      |    2 +-
 9 files changed, 1532 insertions(+), 1359 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-midas.dtsi
 create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts
Signature · 1 line
2.15.1

A message that is not in the archive (sent off-list or not yet received): 20171214125015.2611-1-simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org

#2 lore raw

PATCH v2 1/4 dt-bindings: samsung: document bindings for Midas family boards

Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along with the shared "midas" binding.

---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +4 -0
index e13459618581..e6765af5cf48 100644
@@ -9,7 +9,11 @@ Required root node properties:
 	- "samsung,smdkv310"	- for Exynos4210-based Samsung SMDKV310 eval board.
 	- "samsung,trats"	- for Exynos4210-based Tizen Reference board.
 	- "samsung,universal_c210" - for Exynos4210-based Samsung board.
+	- "samsung,m0"          - for Exynos4412-based Samsung GT-I9300 board.
+	- "samsung,m3"          - for Exynos4412-based Samsung GT-I9305 board.
+	- "samsung,midas"       - for Exynos4412-based Samsung Midas board.
 	- "samsung,smdk4412",	- for Exynos4412-based Samsung SMDK4412 eval board.
+	- "samsung,t0"          - for Exynos4412-based Samsung GT-N7100/GT-N7105 board.
 	- "samsung,trats2"	- for Exynos4412-based Tizen Reference board.
 	- "samsung,smdk5250"	- for Exynos5250-based Samsung SMDK5250 eval board.
 	- "samsung,xyref5260"	- for Exynos5260-based Samsung board.
Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20171214125015.2611-2-simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org

#4 lore raw

Re: [PATCH v2 1/4] dt-bindings: samsung: document bindings for Midas family boards

Quoted 13 lines · Simon Shields

Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along with the shared "midas" binding.

---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +0 -0
index e13459618581..e6765af5cf48 100644

Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt Required root node properties: · line 13

Quoted 5 lines
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +2 -0
@@ -9,7 +9,11 @@ Required root node properties:
 	- "samsung,smdkv310"	- for Exynos4210-based Samsung SMDKV310 eval board.
 	- "samsung,trats"	- for Exynos4210-based Tizen Reference board.
 	- "samsung,universal_c210" - for Exynos4210-based Samsung board.
+	- "samsung,m0"          - for Exynos4412-based Samsung GT-I9300 board.
+	- "samsung,m3"          - for Exynos4412-based Samsung GT-I9305 board.

Kind of short and it is not clear how "m3" relates to GT-I9305

Quoted 13 lines
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +2 -0
+	- "samsung,midas"       - for Exynos4412-based Samsung Midas board.
 	- "samsung,smdk4412",	- for Exynos4412-based Samsung SMDK4412 eval board.
+	- "samsung,t0"          - for Exynos4412-based Samsung GT-N7100/GT-N7105 board.
 	- "samsung,trats2"	- for Exynos4412-based Tizen Reference board.
 	- "samsung,smdk5250"	- for Exynos5250-based Samsung SMDK5250 eval board.
 	- "samsung,xyref5260"	- for Exynos5260-based Samsung board.
Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw

PATCH v2 2/4 ARM: dts: split trats2 dts in preparation for midas boards

In reply to Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi |  144 +++
 arch/arm/boot/dts/exynos4412-midas.dtsi     | 1291 +++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-trats2.dts     | 1364 +--------------------------
 3 files changed, 1441 insertions(+), 1358 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 create mode 100644 arch/arm/boot/dts/exynos4412-midas.dtsi
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +144 -0
new file mode 100644
index 000000000000..088e8d7fa257
@@ -0,0 +1,144 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+	regulators {
+		lcd_vdd3_reg: voltage-regulator-10 {
+			compatible = "regulator-fixed";
+			regulator-name = "LCD_VDD_2.2V";
+			regulator-min-microvolt = <2200000>;
+			regulator-max-microvolt = <2200000>;
+			enable-active-high;
+			gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
+		};
+
+		ps_als_reg: voltage-regulator-11 {
+			compatible = "regulator-fixed";
+			regulator-name = "LED_A_3.0V";
+			regulator-min-microvolt = <3000000>;
+			regulator-max-microvolt = <3000000>;
+			enable-active-high;
+			gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
+	i2c_ak8975: i2c-gpio-10 {
+		compatible = "i2c-gpio";
+		gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
+		i2c-gpio,delay-us = <2>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ak8975@c {
+			compatible = "asahi-kasei,ak8975";
+			reg = <0x0c>;
+			gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
+	i2c_cm36651: i2c-gpio-11 {
+		compatible = "i2c-gpio";
+		gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
+		i2c-gpio,delay-us = <2>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cm36651@18 {
+			compatible = "capella,cm36651";
+			reg = <0x18>;
+			interrupt-parent = <&gpx0>;
+			interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+			vled-supply = <&ps_als_reg>;
+		};
+	};
+};
+
+&buck9_reg {
+	maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>;
+};
+
+&cam_af_reg {
+	gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&cam_io_reg {
+	gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&dsi_0 {
+	vddcore-supply = <&ldo8_reg>;
+	vddio-supply = <&ldo10_reg>;
+	samsung,burst-clock-frequency = <500000000>;
+	samsung,esc-clock-frequency = <20000000>;
+	samsung,pll-clock-frequency = <24000000>;
+	status = "okay";
+
+	panel@0 {
+		compatible = "samsung,s6e8aa0";
+		reg = <0>;
+		vdd3-supply = <&lcd_vdd3_reg>;
+		vci-supply = <&ldo25_reg>;
+		reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
+		power-on-delay= <50>;
+		reset-delay = <100>;
+		init-delay = <100>;
+		flip-horizontal;
+		flip-vertical;
+		panel-width-mm = <58>;
+		panel-height-mm = <103>;
+
+		display-timings {
+			timing-0 {
+				clock-frequency = <57153600>;
+				hactive = <720>;
+				vactive = <1280>;
+				hfront-porch = <5>;
+				hback-porch = <5>;
+				hsync-len = <5>;
+				vfront-porch = <13>;
+				vback-porch = <1>;
+				vsync-len = <2>;
+			};
+		};
+	};
+};
+
+&i2c_0 {
+	status = "okay";
+};
+
+&i2c_3 {
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-slave-addr = <0x10>;
+	samsung,i2c-max-bus-freq = <400000>;
+	pinctrl-0 = <&i2c3_bus>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	mms114-touchscreen@48 {
+		compatible = "melfas,mms114";
+		reg = <0x48>;
+		interrupt-parent = <&gpm2>;
+		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+		x-size = <720>;
+		y-size = <1280>;
+		avdd-supply = <&ldo23_reg>;
+		vdd-supply = <&ldo24_reg>;
+	};
+};
+
+&ldo17_reg {
+	regulator-name = "CAM_SENSOR_CORE_1.2V";
+	regulator-min-microvolt = <1200000>;
+	regulator-max-microvolt = <1200000>;
+};
+
+&ldo25_reg {
+	regulator-name = "LCD_VCC_3.3V";
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+};
+
arch/arm/boot/dts/exynos4412-midas.dtsi new file +1291 -0

1,291 lines not on this page · raw message

arch/arm/boot/dts/exynos4412-trats2.dts +6 -1358

1,380 lines not on this page · raw message

Signature · 1 line
2.15.1
#6 lore raw

Re: [PATCH v2 2/4] ARM: dts: split trats2 dts in preparation for midas boards

Quoted 8 lines · Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi |  144 +++
 arch/arm/boot/dts/exynos4412-midas.dtsi     | 1291 +++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-trats2.dts     | 1364 +--------------------------

Manual review whether you copied the contents directly or with any errors would be a quite big task. Run format-patch with -B30% or try to experiment with other options (most important is -B, but also you can play with -M and -C).

arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi line 1

Quoted 11 lines
 3 files changed, 1441 insertions(+), 1358 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
 create mode 100644 arch/arm/boot/dts/exynos4412-midas.dtsi
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +1 -0
new file mode 100644
index 000000000000..088e8d7fa257
@@ -0,0 +1,144 @@
+// SPDX-License-Identifier: GPL-2.0

You need to retain original copyrights because the contents is directly copied.

Quoted 149 lines
arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi new file +143 -0
+/dts-v1/;
+#include "exynos4412-midas.dtsi"
+
+/ {
+       regulators {
+               lcd_vdd3_reg: voltage-regulator-10 {
+                       compatible = "regulator-fixed";
+                       regulator-name = "LCD_VDD_2.2V";
+                       regulator-min-microvolt = <2200000>;
+                       regulator-max-microvolt = <2200000>;
+                       enable-active-high;
+                       gpio = <&gpc0 1 GPIO_ACTIVE_HIGH>;
+               };
+
+               ps_als_reg: voltage-regulator-11 {
+                       compatible = "regulator-fixed";
+                       regulator-name = "LED_A_3.0V";
+                       regulator-min-microvolt = <3000000>;
+                       regulator-max-microvolt = <3000000>;
+                       enable-active-high;
+                       gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
+               };
+       };
+
+       i2c_ak8975: i2c-gpio-10 {
+               compatible = "i2c-gpio";
+               gpios = <&gpy2 4 GPIO_ACTIVE_HIGH>, <&gpy2 5 GPIO_ACTIVE_HIGH>;
+               i2c-gpio,delay-us = <2>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               ak8975@c {
+                       compatible = "asahi-kasei,ak8975";
+                       reg = <0x0c>;
+                       gpios = <&gpj0 7 GPIO_ACTIVE_HIGH>;
+               };
+       };
+
+       i2c_cm36651: i2c-gpio-11 {
+               compatible = "i2c-gpio";
+               gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>;
+               i2c-gpio,delay-us = <2>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               cm36651@18 {
+                       compatible = "capella,cm36651";
+                       reg = <0x18>;
+                       interrupt-parent = <&gpx0>;
+                       interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+                       vled-supply = <&ps_als_reg>;
+               };
+       };
+};
+
+&buck9_reg {
+       maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>;
+};
+
+&cam_af_reg {
+       gpio = <&gpm0 4 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};
+
+&cam_io_reg {
+       gpio = <&gpm0 2 GPIO_ACTIVE_HIGH>;
+       status = "okay";
+};
+
+&dsi_0 {
+       vddcore-supply = <&ldo8_reg>;
+       vddio-supply = <&ldo10_reg>;
+       samsung,burst-clock-frequency = <500000000>;
+       samsung,esc-clock-frequency = <20000000>;
+       samsung,pll-clock-frequency = <24000000>;
+       status = "okay";
+
+       panel@0 {
+               compatible = "samsung,s6e8aa0";
+               reg = <0>;
+               vdd3-supply = <&lcd_vdd3_reg>;
+               vci-supply = <&ldo25_reg>;
+               reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
+               power-on-delay= <50>;
+               reset-delay = <100>;
+               init-delay = <100>;
+               flip-horizontal;
+               flip-vertical;
+               panel-width-mm = <58>;
+               panel-height-mm = <103>;
+
+               display-timings {
+                       timing-0 {
+                               clock-frequency = <57153600>;
+                               hactive = <720>;
+                               vactive = <1280>;
+                               hfront-porch = <5>;
+                               hback-porch = <5>;
+                               hsync-len = <5>;
+                               vfront-porch = <13>;
+                               vback-porch = <1>;
+                               vsync-len = <2>;
+                       };
+               };
+       };
+};
+
+&i2c_0 {
+       status = "okay";
+};
+
+&i2c_3 {
+       samsung,i2c-sda-delay = <100>;
+       samsung,i2c-slave-addr = <0x10>;
+       samsung,i2c-max-bus-freq = <400000>;
+       pinctrl-0 = <&i2c3_bus>;
+       pinctrl-names = "default";
+       status = "okay";
+
+       mms114-touchscreen@48 {
+               compatible = "melfas,mms114";
+               reg = <0x48>;
+               interrupt-parent = <&gpm2>;
+               interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+               x-size = <720>;
+               y-size = <1280>;
+               avdd-supply = <&ldo23_reg>;
+               vdd-supply = <&ldo24_reg>;
+       };
+};
+
+&ldo17_reg {
+       regulator-name = "CAM_SENSOR_CORE_1.2V";
+       regulator-min-microvolt = <1200000>;
+       regulator-max-microvolt = <1200000>;
+};
+
+&ldo25_reg {
+       regulator-name = "LCD_VCC_3.3V";
+       regulator-min-microvolt = <3300000>;
+       regulator-max-microvolt = <3300000>;
+};
+
arch/arm/boot/dts/exynos4412-midas.dtsi new file +0 -0
new file mode 100644
index 000000000000..ad2824933951

arch/arm/boot/dts/exynos4412-midas.dtsi line 1

Quoted 1 line
arch/arm/boot/dts/exynos4412-midas.dtsi new file +1 -0
@@ -0,0 +1,1291 @@
+// SPDX-License-Identifier: GPL-2.0

You need to retain original copyrights because the contents is directly copied.

Quickly looking at other differences this seems to be a rewrite, not a copy. Basically you are changing Trats2 without mentioning even the changes.

I did not run dtx_diff but I have doubts that it is okay. I expect the same output between two DTBs (if not the same then at least equivalent from functional point of view).

Best regards,
Krzysztof

#7 lore raw

Re: [PATCH v2 2/4] ARM: dts: split trats2 dts in preparation for midas boards

Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Simon Shields

The midas boards share a lot with trats2. Split the common parts out of trats2 into a common midas dtsi and a common "galaxy s3" dts.

---
 arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi |  144 +++
 arch/arm/boot/dts/exynos4412-midas.dtsi     | 1291 +++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-trats2.dts     | 1364 +--------------------------
Quoted 5 lines

Manual review whether you copied the contents directly or with any errors would be a quite big task. Run format-patch with -B30% or try to experiment with other options (most important is -B, but also you can play with -M and -C).

BTW, you have some whitespace errors:
150: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Krzysztof

#8 lore raw

PATCH v2 3/4 ARM: dts: add Samsung's exynos4412-based midas boards

In reply to Simon Shields

"midas" is the codename for a family of smartphones released by Samsung Mobile. It includes the Galaxy S3 (GT-I9300/I9305) and the Galaxy Note 2 (GT-N7100/N7105). The boards largely have the same peripherals:
the main differences are touchscreen, display panel and cellular modem.

---
 arch/arm/boot/dts/Makefile          |  3 +++
 arch/arm/boot/dts/exynos4412-m0.dts | 14 +++++++++++
 arch/arm/boot/dts/exynos4412-m3.dts | 19 ++++++++++++++
 arch/arm/boot/dts/exynos4412-t0.dts | 50 +++++++++++++++++++++++++++++++++++++
 4 files changed, 86 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4412-m0.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-m3.dts
 create mode 100644 arch/arm/boot/dts/exynos4412-t0.dts
arch/arm/boot/dts/Makefile +3 -0
index d0381e9caf21..b7efaeba78cb 100644
@@ -164,11 +164,14 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
 	exynos4210-trats.dtb \
 	exynos4210-universal_c210.dtb \
 	exynos4412-itop-elite.dtb \
+	exynos4412-m0.dtb \
+	exynos4412-m3.dtb \
 	exynos4412-odroidu3.dtb \
 	exynos4412-odroidx.dtb \
 	exynos4412-odroidx2.dtb \
 	exynos4412-origen.dtb \
 	exynos4412-smdk4412.dtb \
+	exynos4412-t0.dtb \
 	exynos4412-tiny4412.dtb \
 	exynos4412-trats2.dtb
 dtb-$(CONFIG_ARCH_EXYNOS5) += \
arch/arm/boot/dts/exynos4412-m0.dts new file +14 -0
new file mode 100644
index 000000000000..18aff81682a9
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"
+
+/ {
+	compatible = "samsung,m0", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+	model = "Samsung M0 (GT-I9300) based on Exynos4412";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg =  <0x40000000 0x40000000>;
+	};
+};
+
arch/arm/boot/dts/exynos4412-m3.dts new file +19 -0
new file mode 100644
index 000000000000..fb8997b5fdb5
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+#include "exynos4412-galaxy-s3.dtsi"
+
+/ {
+	compatible = "samsung,m3", "samsung,midas", "samsung,exynos4412", "samsung,exynos4";
+	model = "Samsung M3 (GT-I9305) based on Exynos4412";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg =  <0x40000000 0x80000000>;
+	};
+};
+
+&i2c0_bus {
+	/* SCL and SDA pins are swapped */
+	samsung,pins = "gpd1-1", "gpd1-0";
+};
+
arch/arm/boot/dts/exynos4412-t0.dts new file +50 -0

50 lines not on this page · raw message

Signature · 1 line
2.15.1
#9 lore raw

PATCH v2 4/4 ARM: exynos: extend cpuidle support to midas boards

In reply to Simon Shields

Exynos4412 can only use cpuidle when running under a compatible bootloader/firmware. The midas family of boards, including trats2, have such a firmware, so allow them to use cpuidle.

---
 arch/arm/mach-exynos/exynos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-exynos/exynos.c +1 -1
index 9a9caac1125a..bfd119d7b63f 100644
@@ -196,7 +196,7 @@ static void __init exynos_dt_machine_init(void)
 #endif
 	if (of_machine_is_compatible("samsung,exynos4210") ||
 	    (of_machine_is_compatible("samsung,exynos4412") &&
-	     of_machine_is_compatible("samsung,trats2")) ||
+	     of_machine_is_compatible("samsung,midas")) ||
 	    of_machine_is_compatible("samsung,exynos3250") ||
 	    of_machine_is_compatible("samsung,exynos5250"))
 		platform_device_register(&exynos_cpuidle);
Signature · 1 line
2.15.1

A message that is not in the archive (sent off-list or not yet received): 20171214125015.2611-5-simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org

#11 lore raw

Re: [PATCH v2 4/4] ARM: exynos: extend cpuidle support to midas boards

Quoted 14 lines · Simon Shields

Exynos4412 can only use cpuidle when running under a compatible bootloader/firmware. The midas family of boards, including trats2, have such a firmware, so allow them to use cpuidle.

---
 arch/arm/mach-exynos/exynos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-exynos/exynos.c +0 -0
index 9a9caac1125a..bfd119d7b63f 100644

arch/arm/mach-exynos/exynos.c static void __init exynos_dt_machine_init(void) · line 199

Quoted 4 lines
arch/arm/mach-exynos/exynos.c +0 -1
@@ -196,7 +196,7 @@ static void __init exynos_dt_machine_init(void)
 #endif
        if (of_machine_is_compatible("samsung,exynos4210") ||
            (of_machine_is_compatible("samsung,exynos4412") &&
-            of_machine_is_compatible("samsung,trats2")) ||

Please leave trats2 compatible for compatibility with older DTBs, as part of ABI.

Best regards,
Krzysztof

Quoted 7 lines
arch/arm/mach-exynos/exynos.c +1 -1
+            of_machine_is_compatible("samsung,midas")) ||
            of_machine_is_compatible("samsung,exynos3250") ||
            of_machine_is_compatible("samsung,exynos5250"))
                platform_device_register(&exynos_cpuidle);
--

2.15.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html