i40e: Fix kdump failure
Subsystems (2)
PATCH 10/13 i40e: Fix kdump failure
From: Avinash Dayanand <[email protected]>
kdump fails in the system when used in conjunction with Ethernet driver X722/X710. This is mainly because when we are resource constrained i.e. when we have just one online_cpus, we are enabling VMDq and iWARP. It doesn't make sense to enable them with just one cpu and starve kdump for lack of IRQs.
So don't enable VMDq or iWARP when we just have a single cpu.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +2 -2
@@ -11115,13 +11115,13 @@ static int i40e_sw_init(struct i40e_pf *pf) pf->hw.aq.fw_maj_ver >= 6) pf->hw_features |=I40E_HW_PTP_L4_CAPABLE ; -if (pf->hw.func_caps.vmdq) { +if (pf->hw.func_caps.vmdq &&num_online_cpus () !=1 ) { pf->num_vmdq_vsis =I40E_DEFAULT_NUM_VMDQ_VSI ; pf->flags |=I40E_FLAG_VMDQ_ENABLED ; pf->num_vmdq_qps =i40e_default_queues_per_vmdq (pf); } -if (pf->hw.func_caps.iwarp) { +if (pf->hw.func_caps.iwarp &&num_online_cpus () !=1 ) { pf->flags |=I40E_FLAG_IWARP_ENABLED ;/* IWARP needs one extra vector for CQP just like MISC.*/ pf->num_iwarp_msix = (int )num_online_cpus () +1 ;
Signature · 1 line
2.9.5
Bowers
PATCH 10/13 i40e: Fix kdump failure
Quoted 16 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Wednesday, December 27, 2017 5:22 AM
To: Michael, Alice <[email protected]>; intel-wired-
lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S84-V2 10/13] i40e: Fix kdump failureFrom: Avinash Dayanand <[email protected]>
kdump fails in the system when used in conjunction with Ethernet driver X722/X710. This is mainly because when we are resource constrained i.e. when we have just one
online_cpus, we are enabling VMDq and iWARP. It doesn't make sense to enable them with just one cpu and starve kdump for lack of IRQs.
Quoted 6 lines
So don't enable VMDq or iWARP when we just have a single cpu.
Signed-off-by Avinash Dayanand <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)