add byte-based block_status driver callbacks
v7 cover add byte-based block_status driver callbacks
There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a byte granularity rather than sectors.
These patches have been around for a while, but it's time to finish it now that 2.12 is open for patches.
Based-on: <[email protected]> (Kevin's [PULL v3 00/35] Block layer patches)
The overall conversion currently looks like:
part 1: bdrv_is_allocated (merged, commit 51b0a488, 2.10) part 2: dirty-bitmap (merged, commit ca759622, 2.11) part 3: bdrv_get_block_status (merged, commit f0a9c18f, 2.11) part 4: .bdrv_co_block_status (this series, v5 was here [1])
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg01246.html
Available as a tag at:
git fetch git://repo.or.cz/qemu/ericb.git nbd-byte-callback-v7
Since v6:
- add R-bs
- improve some commit messages, comments, and variable types [Fam]
- fix conversion bugs [Vladimir]
- rebase to master (well, Kevin's pull request) [Jeff]
001/20:[----] [--] 'block: Add .bdrv_co_block_status() callback' 002/20:[----] [--] 'block: Switch passthrough drivers to .bdrv_co_block_status()' 003/20:[----] [--] 'file-posix: Switch to .bdrv_co_block_status()' 004/20:[----] [--] 'gluster: Switch to .bdrv_co_block_status()' 005/20:[----] [--] 'iscsi: Switch cluster_sectors to byte-based' 006/20:[0004] [FC] 'iscsi: Switch iscsi_allocmap_update() to byte-based' 007/20:[0006] [FC] 'iscsi: Switch to .bdrv_co_block_status()' 008/20:[----] [--] 'null: Switch to .bdrv_co_block_status()' 009/20:[0002] [FC] 'parallels: Switch to .bdrv_co_block_status()' 010/20:[----] [--] 'qcow: Switch to .bdrv_co_block_status()' 011/20:[----] [--] 'qcow2: Switch to .bdrv_co_block_status()' 012/20:[----] [--] 'qed: Switch to .bdrv_co_block_status()' 013/20:[----] [--] 'raw: Switch to .bdrv_co_block_status()' 014/20:[0012] [FC] 'sheepdog: Switch to .bdrv_co_block_status()' 015/20:[----] [--] 'vdi: Avoid bitrot of debugging code' 016/20:[----] [--] 'vdi: Switch to .bdrv_co_block_status()' 017/20:[----] [--] 'vmdk: Switch to .bdrv_co_block_status()' 018/20:[0002] [FC] 'vpc: Switch to .bdrv_co_block_status()' 019/20:[----] [--] 'vvfat: Switch to .bdrv_co_block_status()' 020/20:[----] [--] 'block: Drop unused .bdrv_co_get_block_status()'
Eric Blake (20):
block: Add .bdrv_co_block_status() callback
block: Switch passthrough drivers to .bdrv_co_block_status()
file-posix: Switch to .bdrv_co_block_status()
gluster: Switch to .bdrv_co_block_status()
iscsi: Switch cluster_sectors to byte-based
iscsi: Switch iscsi_allocmap_update() to byte-based
iscsi: Switch to .bdrv_co_block_status()
null: Switch to .bdrv_co_block_status()
parallels: Switch to .bdrv_co_block_status()
qcow: Switch to .bdrv_co_block_status()
qcow2: Switch to .bdrv_co_block_status()
qed: Switch to .bdrv_co_block_status()
raw: Switch to .bdrv_co_block_status() sheepdog: Switch to .bdrv_co_block_status() vdi: Avoid bitrot of debugging code vdi: Switch to .bdrv_co_block_status() vmdk: Switch to .bdrv_co_block_status() vpc: Switch to .bdrv_co_block_status() vvfat: Switch to .bdrv_co_block_status() block: Drop unused .bdrv_co_get_block_status()
include/block/block.h | 14 ++--- include/block/block_int.h | 51 +++++++++------ block/io.c | 86 +++++++++++-------------- block/blkdebug.c | 20 +++--- block/commit.c | 2 +- block/file-posix.c | 62 +++++++++--------- block/gluster.c | 70 ++++++++++----------- block/iscsi.c | 157 ++++++++++++++++++++++++---------------------- block/mirror.c | 2 +- block/null.c | 23 +++---- block/parallels.c | 22 ++++--- block/qcow.c | 27 ++++---- block/qcow2.c | 24 +++---- block/qed.c | 84 +++++++++---------------- block/raw-format.c | 16 ++--- block/sheepdog.c | 26 ++++---- block/throttle.c | 2 +- block/vdi.c | 45 +++++++------ block/vmdk.c | 38 +++++------ block/vpc.c | 45 ++++++------- block/vvfat.c | 16 +++-- 21 files changed, 404 insertions(+), 428 deletions(-)
Signature · 1 line
2.14.3
PATCH v7 1/20 block: Add .bdrv_co_block_status() callback
We are gradually moving away from sector-based interfaces, towards byte-based. Now that the block layer exposes byte-based allocation, it's time to tackle the drivers. Add a new callback that operates on as small as byte boundaries. Subsequent patches will then update individual drivers, then finally remove .bdrv_co_get_block_status().
The new code also passes through the 'want_zero' hint, which will allow subsequent patches to further optimize callers that only care about how much of the image is allocated (want_zero is false), rather than full details about runs of zeroes and which offsets the allocation actually maps to (want_zero is true). As part of this effort, fix another part of the documentation: the claim in commit 4c41cb4 that BDRV_BLOCK_ALLOCATED is short for 'DATA || ZERO' is a lie at the block layer (see commit e88ae2264), even though it is how the bit is computed from the driver layer. After all, there are intentionally cases where we return ZERO but not ALLOCATED at the block layer, when we know that a read sees zero because the backing file is too short. Note that the driver interface is thus slightly different than the public interface with regards to which bits will be set, and what guarantees are provided on input.
We also add an assertion that any driver using the new callback will make progress (the only time pnum will be 0 is if the block layer already handled an out-of-bounds request, or if there is an error); the old driver interface did not provide this guarantee, which could lead to some inf-loops in drastic corner-case failures.
---
v7: add R-b
v6: drop now-useless rounding of mid-sector end-of-file hole [Kevin], better documentation of 'want_zero' [Kevin]
v5: rebase to master, typo fix, document more block layer guarantees
v4: rebase to master
v3: no change
v2: improve alignment handling, ensure all iotests still pass
--- include/block/block.h | 14 +++++++------- include/block/block_int.h | 20 +++++++++++++++----- block/io.c | 28 +++++++++++++++++++--------- 3 files changed, 41 insertions(+), 21 deletions(-)
include/block/block.h +7 -7
@@ -128,19 +128,19 @@ typedef struct HDGeometry {* BDRV_BLOCK_ZERO: offset reads as zero * BDRV_BLOCK_OFFSET_VALID: an associated offset exists for accessing raw data * BDRV_BLOCK_ALLOCATED: the content of the block is determined by this -* layer (short for DATA || ZERO), set by block layer -* BDRV_BLOCK_EOF: the returned pnum covers through end of file for this layer +* layer rather than any backing, set by block layer +* BDRV_BLOCK_EOF: the returned pnum covers through end of file for this +* layer, set by block layer * * Internal flag: * BDRV_BLOCK_RAW: for use by passthrough drivers, such as raw, to request * that the block layer recompute the answer from the returned * BDS; must be accompanied by just BDRV_BLOCK_OFFSET_VALID. * -* If BDRV_BLOCK_OFFSET_VALID is set, bits 9-62 (BDRV_BLOCK_OFFSET_MASK) of -* the return value (old interface) or the entire map parameter (new -* interface) represent the offset in the returned BDS that is allocated for -* the corresponding raw data. However, whether that offset actually -* contains data also depends on BDRV_BLOCK_DATA, as follows: +* If BDRV_BLOCK_OFFSET_VALID is set, the map parameter represents the +* host offset within the returned BDS that is allocated for the +* corresponding raw guest data. However, whether that offset +* actually contains data also depends on BDRV_BLOCK_DATA, as follows: * * DATA ZERO OFFSET_VALID * t t t sectors read as zero, returned file is zero at offset
include/block/block_int.h +15 -5
@@ -204,15 +204,25 @@ struct BlockDriver {/* * Building block for bdrv_block_status[_above] and * bdrv_is_allocated[_above]. The driver should answer only -* according to the current layer, and should not set -* BDRV_BLOCK_ALLOCATED, but may set BDRV_BLOCK_RAW. See block.h -* for the meaning of _DATA, _ZERO, and _OFFSET_VALID. The block -* layer guarantees input aligned to request_alignment, as well as -* non-NULL pnum and file. +* according to the current layer, and should only need to set +* BDRV_BLOCK_DATA, BDRV_BLOCK_ZERO, BDRV_BLOCK_OFFSET_VALID, +* and/or BDRV_BLOCK_RAW; if the current layer defers to a backing +* layer, the result should be 0 (and not BDRV_BLOCK_ZERO). See +* block.h for the overall meaning of the bits. As a hint, the +* flag want_zero is true if the caller cares more about precise +* mappings (favor accurate _OFFSET_VALID/_ZERO) or false for +* overall allocation (favor larger *pnum, perhaps by reporting +* _DATA instead of _ZERO). The block layer guarantees input +* clamped to bdrv_getlength() and aligned to request_alignment, +* as well as non-NULL pnum, map, and file; in turn, the driver +* must return an error or set pnum to an aligned non-zero value. */ int64_t coroutine_fn (*bdrv_co_get_block_status)(BlockDriverState *bs,int64_t sector_num,int nb_sectors,int *pnum,BlockDriverState **file); + int coroutine_fn (*bdrv_co_block_status)(BlockDriverState *bs, +bool want_zero,int64_t offset,int64_t bytes,int64_t *pnum, +int64_t *map,BlockDriverState **file);/* * Invalidate any cached meta-data.
block/io.c +19 -9
@@ -1899,10 +1899,10 @@ int64_t coroutine_fn bdrv_co_get_block_status_from_backing(BlockDriverState *bs,* Drivers not implementing the functionality are assumed to not support * backing files, hence all their sectors are reported as allocated. * -* If 'want_zero' is true, the caller is querying for mapping purposes, -* and the result should include BDRV_BLOCK_OFFSET_VALID and -* BDRV_BLOCK_ZERO where possible; otherwise, the result may omit those -* bits particularly if it allows for a larger value in 'pnum'. +* If 'want_zero' is true, the caller is querying for mapping +* purposes, with a focus on valid BDRV_BLOCK_OFFSET_VALID, _DATA, and +* _ZERO where possible; otherwise, the result favors larger 'pnum', +* with a focus on accurate BDRV_BLOCK_ALLOCATED. * * If 'offset' is beyond the end of the disk image the return value is * BDRV_BLOCK_EOF and 'pnum' is set to 0.
@@ -1959,7 +1959,7 @@ static int coroutine_fn bdrv_co_block_status(BlockDriverState *bs,/* Must be non-NULL or bdrv_getlength() would have failed */ assert (bs->drv); -if (!bs->drv->bdrv_co_get_block_status) { +if (!bs->drv->bdrv_co_get_block_status && !bs->drv->bdrv_co_block_status) { *pnum = bytes; ret =BDRV_BLOCK_DATA |BDRV_BLOCK_ALLOCATED ;if (offset + bytes == total_size) {
@@ -1976,13 +1976,14 @@ static int coroutine_fn bdrv_co_block_status(BlockDriverState *bs,bdrv_inc_in_flight (bs);/* Round out to request_alignment boundaries */ -/* TODO: until we have a byte-based driver callback, we also have to -* round out to sectors, even if that is bigger than request_alignment */ - align =MAX (bs->bl.request_alignment,BDRV_SECTOR_SIZE ); + align = bs->bl.request_alignment; +if (bs->drv->bdrv_co_get_block_status && align <BDRV_SECTOR_SIZE ) { + align =BDRV_SECTOR_SIZE ; + } aligned_offset =QEMU_ALIGN_DOWN (offset, align); aligned_bytes =ROUND_UP (offset + bytes, align) - aligned_offset; - { +if (bs->drv->bdrv_co_get_block_status) {int count;/* sectors */ int64_t longret;
@@ -2007,6 +2008,15 @@ static int coroutine_fn bdrv_co_block_status(BlockDriverState *bs, } ret = longret & ~BDRV_BLOCK_OFFSET_MASK ; *pnum = count *BDRV_SECTOR_SIZE ; + }else { + ret = bs->drv->bdrv_co_block_status (bs, want_zero, aligned_offset, + aligned_bytes, pnum, &local_map, + &local_file); +if (ret <0 ) { + *pnum =0 ; + goto out; + } +assert (*pnum);/* The block driver must make progress */ }/*
Signature · 1 line
2.14.3
PATCH v7 2/20 block: Switch passthrough drivers to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the generic helpers, and all passthrough clients (blkdebug, commit, mirror, throttle) accordingly.
---
v6-v7: no change
v5: rebase to master
v4: rebase to interface tweak
v3: rebase to addition of throttle driver
v2: rebase to master, retitle while merging blkdebug, commit, and mirror
--- include/block/block_int.h | 28 ++++++++++++++++------------ block/io.c | 36 ++++++++++++++++++++---------------- block/blkdebug.c | 20 +++++++++++--------- block/commit.c | 2 +- block/mirror.c | 2 +- block/throttle.c | 2 +- 6 files changed, 50 insertions(+), 40 deletions(-)
include/block/block_int.h +16 -12
@@ -1034,23 +1034,27 @@ void bdrv_format_default_perms(BlockDriverState *bs, BdrvChild *c, uint64_t *nperm, uint64_t *nshared);/* -* Default implementation for drivers to pass bdrv_co_get_block_status() to +* Default implementation for drivers to pass bdrv_co_block_status() to * their file. */ -int64_t coroutine_fn bdrv_co_get_block_status_from_file(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors, -int *pnum, -BlockDriverState **file); +int coroutine_fn bdrv_co_block_status_from_file(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes, +int64_t *pnum, +int64_t *map, +BlockDriverState **file);/* -* Default implementation for drivers to pass bdrv_co_get_block_status() to +* Default implementation for drivers to pass bdrv_co_block_status() to * their backing file. */ -int64_t coroutine_fn bdrv_co_get_block_status_from_backing(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors, -int *pnum, -BlockDriverState **file); +int coroutine_fn bdrv_co_block_status_from_backing(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes, +int64_t *pnum, +int64_t *map, +BlockDriverState **file);const char *bdrv_get_parent_name (const BlockDriverState *bs);void blk_dev_change_media_cb (BlockBackend *blk,bool load,Error **errp);bool blk_dev_has_removable_media (BlockBackend *blk);
block/io.c +20 -16
@@ -1868,30 +1868,34 @@ typedef struct BdrvCoBlockStatusData {bool done; } BdrvCoBlockStatusData; -int64_t coroutine_fn bdrv_co_get_block_status_from_file(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors, -int *pnum, -BlockDriverState **file) +int coroutine_fn bdrv_co_block_status_from_file(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes, +int64_t *pnum, +int64_t *map, +BlockDriverState **file) {assert (bs->file && bs->file->bs); - *pnum = nb_sectors; + *pnum = bytes; + *map = offset; *file = bs->file->bs; -return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID | - (sector_num <<BDRV_SECTOR_BITS ); +return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID ; } -int64_t coroutine_fn bdrv_co_get_block_status_from_backing(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors, -int *pnum, -BlockDriverState **file) +int coroutine_fn bdrv_co_block_status_from_backing(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes, +int64_t *pnum, +int64_t *map, +BlockDriverState **file) {assert (bs->backing && bs->backing->bs); - *pnum = nb_sectors; + *pnum = bytes; + *map = offset; *file = bs->backing->bs; -return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID | - (sector_num <<BDRV_SECTOR_BITS ); +return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID ; }/*
block/blkdebug.c +11 -9
@@ -627,15 +627,17 @@ static int coroutine_fn blkdebug_co_pdiscard(BlockDriverState *bs,return bdrv_co_pdiscard (bs->file->bs, offset, bytes); } -static int64_t coroutine_fn blkdebug_co_get_block_status( -BlockDriverState *bs,int64_t sector_num,int nb_sectors,int *pnum, -BlockDriverState **file) +static int coroutine_fn blkdebug_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes, +int64_t *pnum, +int64_t *map, +BlockDriverState **file) { -assert (QEMU_IS_ALIGNED (sector_num | nb_sectors, -DIV_ROUND_UP (bs->bl.request_alignment, -BDRV_SECTOR_SIZE ))); -return bdrv_co_get_block_status_from_file (bs, sector_num, nb_sectors, - pnum, file); +assert (QEMU_IS_ALIGNED (offset | bytes, bs->bl.request_alignment)); +return bdrv_co_block_status_from_file (bs, want_zero, offset, bytes, + pnum, map, file); }static void blkdebug_close (BlockDriverState *bs)
@@ -907,7 +909,7 @@ static BlockDriver bdrv_blkdebug = { .bdrv_co_flush_to_disk = blkdebug_co_flush, .bdrv_co_pwrite_zeroes = blkdebug_co_pwrite_zeroes, .bdrv_co_pdiscard = blkdebug_co_pdiscard, - .bdrv_co_get_block_status = blkdebug_co_get_block_status, + .bdrv_co_block_status = blkdebug_co_block_status, .bdrv_debug_event = blkdebug_debug_event, .bdrv_debug_breakpoint = blkdebug_debug_breakpoint,
block/commit.c +1 -1
@@ -265,7 +265,7 @@ static void bdrv_commit_top_child_perm(BlockDriverState *bs, BdrvChild *c,static BlockDriver bdrv_commit_top = { .format_name ="commit_top" , .bdrv_co_preadv = bdrv_commit_top_preadv, - .bdrv_co_get_block_status = bdrv_co_get_block_status_from_backing, + .bdrv_co_block_status = bdrv_co_block_status_from_backing, .bdrv_refresh_filename = bdrv_commit_top_refresh_filename, .bdrv_close = bdrv_commit_top_close, .bdrv_child_perm = bdrv_commit_top_child_perm,
block/mirror.c +1 -1
@@ -1094,7 +1094,7 @@ static BlockDriver bdrv_mirror_top = { .bdrv_co_pwrite_zeroes = bdrv_mirror_top_pwrite_zeroes, .bdrv_co_pdiscard = bdrv_mirror_top_pdiscard, .bdrv_co_flush = bdrv_mirror_top_flush, - .bdrv_co_get_block_status = bdrv_co_get_block_status_from_backing, + .bdrv_co_block_status = bdrv_co_block_status_from_backing, .bdrv_refresh_filename = bdrv_mirror_top_refresh_filename, .bdrv_close = bdrv_mirror_top_close, .bdrv_child_perm = bdrv_mirror_top_child_perm,
block/throttle.c +1 -1
@@ -239,7 +239,7 @@ static BlockDriver bdrv_throttle = { .bdrv_reopen_prepare = throttle_reopen_prepare, .bdrv_reopen_commit = throttle_reopen_commit, .bdrv_reopen_abort = throttle_reopen_abort, - .bdrv_co_get_block_status = bdrv_co_get_block_status_from_file, + .bdrv_co_block_status = bdrv_co_block_status_from_file, .bdrv_co_drain_begin = throttle_co_drain_begin, .bdrv_co_drain_end = throttle_co_drain_end,
Signature · 1 line
2.14.3
PATCH v7 3/20 file-posix: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the file protocol driver accordingly.
In want_zero mode, we continue to report fine-grained hole information (the caller wants as much mapping detail as possible); but when not in that mode, the caller prefers larger *pnum and merely cares about what offsets are allocated at this layer, rather than where the holes live. Since holes still read as zeroes at this layer (rather than deferring to a backing layer), we can take the shortcut of skipping lseek(), and merely state that all bytes are allocated.
We can also drop redundant bounds checks that are already guaranteed by the block layer.
---
v6-v7: no change
v5: drop redundant code
v4: tweak commit message [Fam], rebase to interface tweak
v3: no change
v2: tweak comment, add mapping support
--- block/file-posix.c | 62 +++++++++++++++++++++++++----------------------------- 1 file changed, 29 insertions(+), 33 deletions(-)
block/file-posix.c +29 -33
@@ -2128,25 +2128,24 @@ static int find_allocation(BlockDriverState *bs, off_t start, }/* -* Returns the allocation status of the specified sectors. +* Returns the allocation status of the specified offset. * -* If 'sector_num' is beyond the end of the disk image the return value is 0 -* and 'pnum' is set to 0. +* The block layer guarantees 'offset' and 'bytes' are within bounds. * -* 'pnum' is set to the number of sectors (including and immediately following -* the specified sector) that are known to be in the same +* 'pnum' is set to the number of bytes (including and immediately following +* the specified offset) that are known to be in the same * allocated/unallocated state. * -* 'nb_sectors' is the max value 'pnum' should be set to. If nb_sectors goes -* beyond the end of the disk image it will be clamped. +* 'bytes' is the max value 'pnum' should be set to. */ -static int64_t coroutine_fn raw_co_get_block_status(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors,int *pnum, -BlockDriverState **file) +static int coroutine_fn raw_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes,int64_t *pnum, +int64_t *map, +BlockDriverState **file) { -off_t start, data =0 , hole =0 ; -int64_t total_size; +off_t data =0 , hole =0 ;int ret; ret =fd_open (bs);
@@ -2154,39 +2153,36 @@ static int64_t coroutine_fn raw_co_get_block_status(BlockDriverState *bs,return ret; } - start = sector_num *BDRV_SECTOR_SIZE ; - total_size =bdrv_getlength (bs); -if (total_size <0 ) { -return total_size; - }else if (start >= total_size) { - *pnum =0 ; -return 0 ; - }else if (start + nb_sectors *BDRV_SECTOR_SIZE > total_size) { - nb_sectors =DIV_ROUND_UP (total_size - start,BDRV_SECTOR_SIZE ); +if (!want_zero) { + *pnum = bytes; + *map = offset; + *file = bs; +return BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; } - ret =find_allocation (bs, start, &data, &hole); + ret =find_allocation (bs, offset, &data, &hole);if (ret == -ENXIO ) {/* Trailing hole */ - *pnum = nb_sectors; + *pnum = bytes; ret =BDRV_BLOCK_ZERO ; }else if (ret <0 ) {/* No info available, so pretend there are no holes */ - *pnum = nb_sectors; + *pnum = bytes; ret =BDRV_BLOCK_DATA ; - }else if (data == start) { -/* On a data extent, compute sectors to the end of the extent, + }else if (data == offset) { +/* On a data extent, compute bytes to the end of the extent, * possibly including a partial sector at EOF. */ - *pnum =MIN (nb_sectors,DIV_ROUND_UP (hole - start,BDRV_SECTOR_SIZE )); + *pnum =MIN (bytes, hole - offset); ret =BDRV_BLOCK_DATA ; }else { -/* On a hole, compute sectors to the beginning of the next extent. */ -assert (hole == start); - *pnum =MIN (nb_sectors, (data - start) /BDRV_SECTOR_SIZE ); +/* On a hole, compute bytes to the beginning of the next extent. */ +assert (hole == offset); + *pnum =MIN (bytes, data - offset); ret =BDRV_BLOCK_ZERO ; } + *map = offset; *file = bs; -return ret |BDRV_BLOCK_OFFSET_VALID | start; +return ret |BDRV_BLOCK_OFFSET_VALID ; } static coroutine_fn BlockAIOCB *raw_aio_pdiscard(BlockDriverState *bs,
@@ -2280,7 +2276,7 @@ BlockDriver bdrv_file = { .bdrv_close = raw_close, .bdrv_create = raw_create, .bdrv_has_zero_init = bdrv_has_zero_init_1, - .bdrv_co_get_block_status = raw_co_get_block_status, + .bdrv_co_block_status = raw_co_block_status, .bdrv_co_pwrite_zeroes = raw_co_pwrite_zeroes, .bdrv_co_preadv = raw_co_preadv,
Signature · 1 line
2.14.3
PATCH v7 4/20 gluster: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the gluster driver accordingly.
In want_zero mode, we continue to report fine-grained hole information (the caller wants as much mapping detail as possible); but when not in that mode, the caller prefers larger *pnum and merely cares about what offsets are allocated at this layer, rather than where the holes live. Since holes still read as zeroes at this layer (rather than deferring to a backing layer), we can take the shortcut of skipping find_allocation(), and merely state that all bytes are allocated.
We can also drop redundant bounds checks that are already guaranteed by the block layer.
---
v6-v7: no change
v5: drop redundant code
v4: tweak commit message [Fam], rebase to interface tweak
v3: no change
v2: tweak comments [Prasanna], add mapping, drop R-b
--- block/gluster.c | 70 ++++++++++++++++++++++++++++----------------------------- 1 file changed, 34 insertions(+), 36 deletions(-)
block/gluster.c +34 -36
@@ -1349,68 +1349,66 @@ exit: }/* -* Returns the allocation status of the specified sectors. +* Returns the allocation status of the specified offset. * -* If 'sector_num' is beyond the end of the disk image the return value is 0 -* and 'pnum' is set to 0. +* The block layer guarantees 'offset' and 'bytes' are within bounds. * -* 'pnum' is set to the number of sectors (including and immediately following -* the specified sector) that are known to be in the same +* 'pnum' is set to the number of bytes (including and immediately following +* the specified offset) that are known to be in the same * allocated/unallocated state. * -* 'nb_sectors' is the max value 'pnum' should be set to. If nb_sectors goes -* beyond the end of the disk image it will be clamped. +* 'bytes' is the max value 'pnum' should be set to. * -* (Based on raw_co_get_block_status() from file-posix.c.) +* (Based on raw_co_block_status() from file-posix.c.) */ -static int64_t coroutine_fn qemu_gluster_co_get_block_status( -BlockDriverState *bs,int64_t sector_num,int nb_sectors,int *pnum, -BlockDriverState **file) +static int coroutine_fn qemu_gluster_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes, +int64_t *pnum, +int64_t *map, +BlockDriverState **file) {BDRVGlusterState *s = bs->opaque; -off_t start, data =0 , hole =0 ; -int64_t total_size; +off_t data =0 , hole =0 ;int ret = -EINVAL ;if (!s->fd) {return ret; } - start = sector_num *BDRV_SECTOR_SIZE ; - total_size =bdrv_getlength (bs); -if (total_size <0 ) { -return total_size; - }else if (start >= total_size) { - *pnum =0 ; -return 0 ; - }else if (start + nb_sectors *BDRV_SECTOR_SIZE > total_size) { - nb_sectors =DIV_ROUND_UP (total_size - start,BDRV_SECTOR_SIZE ); +if (!want_zero) { + *pnum = bytes; + *map = offset; + *file = bs; +return BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; } - ret =find_allocation (bs, start, &data, &hole); + ret =find_allocation (bs, offset, &data, &hole);if (ret == -ENXIO ) {/* Trailing hole */ - *pnum = nb_sectors; + *pnum = bytes; ret =BDRV_BLOCK_ZERO ; }else if (ret <0 ) {/* No info available, so pretend there are no holes */ - *pnum = nb_sectors; + *pnum = bytes; ret =BDRV_BLOCK_DATA ; - }else if (data == start) { -/* On a data extent, compute sectors to the end of the extent, + }else if (data == offset) { +/* On a data extent, compute bytes to the end of the extent, * possibly including a partial sector at EOF. */ - *pnum =MIN (nb_sectors,DIV_ROUND_UP (hole - start,BDRV_SECTOR_SIZE )); + *pnum =MIN (bytes, hole - offset); ret =BDRV_BLOCK_DATA ; }else { -/* On a hole, compute sectors to the beginning of the next extent. */ -assert (hole == start); - *pnum =MIN (nb_sectors, (data - start) /BDRV_SECTOR_SIZE ); +/* On a hole, compute bytes to the beginning of the next extent. */ +assert (hole == offset); + *pnum =MIN (bytes, data - offset); ret =BDRV_BLOCK_ZERO ; } + *map = offset; *file = bs; -return ret |BDRV_BLOCK_OFFSET_VALID | start; +return ret |BDRV_BLOCK_OFFSET_VALID ; }
@@ -1438,7 +1436,7 @@ static BlockDriver bdrv_gluster = {#ifdef CONFIG_GLUSTERFS_ZEROFILL .bdrv_co_pwrite_zeroes = qemu_gluster_co_pwrite_zeroes, #endif - .bdrv_co_get_block_status = qemu_gluster_co_get_block_status, + .bdrv_co_block_status = qemu_gluster_co_block_status, .create_opts = &qemu_gluster_create_opts, };
@@ -1466,7 +1464,7 @@ static BlockDriver bdrv_gluster_tcp = {#ifdef CONFIG_GLUSTERFS_ZEROFILL .bdrv_co_pwrite_zeroes = qemu_gluster_co_pwrite_zeroes, #endif - .bdrv_co_get_block_status = qemu_gluster_co_get_block_status, + .bdrv_co_block_status = qemu_gluster_co_block_status, .create_opts = &qemu_gluster_create_opts, };
@@ -1494,7 +1492,7 @@ static BlockDriver bdrv_gluster_unix = {#ifdef CONFIG_GLUSTERFS_ZEROFILL .bdrv_co_pwrite_zeroes = qemu_gluster_co_pwrite_zeroes, #endif - .bdrv_co_get_block_status = qemu_gluster_co_get_block_status, + .bdrv_co_block_status = qemu_gluster_co_block_status, .create_opts = &qemu_gluster_create_opts, };
@@ -1528,7 +1526,7 @@ static BlockDriver bdrv_gluster_rdma = {#ifdef CONFIG_GLUSTERFS_ZEROFILL .bdrv_co_pwrite_zeroes = qemu_gluster_co_pwrite_zeroes, #endif - .bdrv_co_get_block_status = qemu_gluster_co_get_block_status, + .bdrv_co_block_status = qemu_gluster_co_block_status, .create_opts = &qemu_gluster_create_opts, };
Signature · 1 line
2.14.3
PATCH v7 5/20 iscsi: Switch cluster_sectors to byte-based
In reply to Eric BlakeWe are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the cluster size in sectors, along with adding assertions that we are not dividing by zero.
Improve some comment grammar while in the area.
---
v2-v7: no change
--- block/iscsi.c | 56 +++++++++++++++++++++++++++++++++++--------------------- 1 file changed, 35 insertions(+), 21 deletions(-)
block/iscsi.c +35 -21
@@ -84,7 +84,7 @@ typedef struct IscsiLun {unsigned long *allocmap;unsigned long *allocmap_valid;long allocmap_size; -int cluster_sectors; +int cluster_size;bool use_16_for_rw;bool write_protected;bool lbpme;
@@ -428,9 +428,10 @@ static int iscsi_allocmap_init(IscsiLun *iscsilun, int open_flags) {iscsi_allocmap_free (iscsilun); +assert (iscsilun->cluster_size); iscsilun->allocmap_size = -DIV_ROUND_UP (sector_lun2qemu (iscsilun->num_blocks, iscsilun), - iscsilun->cluster_sectors); +DIV_ROUND_UP (iscsilun->num_blocks * iscsilun->block_size, + iscsilun->cluster_size); iscsilun->allocmap =bitmap_try_new (iscsilun->allocmap_size);if (!iscsilun->allocmap) {
@@ -438,7 +439,7 @@ static int iscsi_allocmap_init(IscsiLun *iscsilun, int open_flags) }if (open_flags &BDRV_O_NOCACHE ) { -/* in case that cache.direct = on all allocmap entries are +/* when cache.direct = on all allocmap entries are * treated as invalid to force a relookup of the block * status on every read request */ return 0 ;
@@ -459,17 +460,19 @@ iscsi_allocmap_update(IscsiLun *iscsilun, int64_t sector_num, int nb_sectors, bool allocated, bool valid) { int64_t cl_num_expanded, nb_cls_expanded, cl_num_shrunk, nb_cls_shrunk; +int cluster_sectors = iscsilun->cluster_size >>BDRV_SECTOR_BITS ;if (iscsilun->allocmap ==NULL ) {return ; }/* expand to entirely contain all affected clusters */ - cl_num_expanded = sector_num / iscsilun->cluster_sectors; +assert (cluster_sectors); + cl_num_expanded = sector_num / cluster_sectors; nb_cls_expanded =DIV_ROUND_UP (sector_num + nb_sectors, - iscsilun->cluster_sectors) - cl_num_expanded; + cluster_sectors) - cl_num_expanded;/* shrink to touch only completely contained clusters */ - cl_num_shrunk =DIV_ROUND_UP (sector_num, iscsilun->cluster_sectors); - nb_cls_shrunk = (sector_num + nb_sectors) / iscsilun->cluster_sectors + cl_num_shrunk =DIV_ROUND_UP (sector_num, cluster_sectors); + nb_cls_shrunk = (sector_num + nb_sectors) / cluster_sectors - cl_num_shrunk;if (allocated) {bitmap_set (iscsilun->allocmap, cl_num_expanded, nb_cls_expanded);
@@ -533,9 +536,12 @@ iscsi_allocmap_is_allocated(IscsiLun *iscsilun, int64_t sector_num,if (iscsilun->allocmap ==NULL ) {return true; } - size =DIV_ROUND_UP (sector_num + nb_sectors, iscsilun->cluster_sectors); +assert (iscsilun->cluster_size); + size =DIV_ROUND_UP (sector_num + nb_sectors, + iscsilun->cluster_size >>BDRV_SECTOR_BITS );return !(find_next_bit (iscsilun->allocmap, size, - sector_num / iscsilun->cluster_sectors) == size); + sector_num *BDRV_SECTOR_SIZE / + iscsilun->cluster_size) == size); } static inline bool iscsi_allocmap_is_valid(IscsiLun *iscsilun,
@@ -545,9 +551,12 @@ static inline bool iscsi_allocmap_is_valid(IscsiLun *iscsilun,if (iscsilun->allocmap_valid ==NULL ) {return false; } - size =DIV_ROUND_UP (sector_num + nb_sectors, iscsilun->cluster_sectors); +assert (iscsilun->cluster_size); + size =DIV_ROUND_UP (sector_num + nb_sectors, + iscsilun->cluster_size >>BDRV_SECTOR_BITS );return (find_next_zero_bit (iscsilun->allocmap_valid, size, - sector_num / iscsilun->cluster_sectors) == size); + sector_num *BDRV_SECTOR_SIZE / + iscsilun->cluster_size) == size); }static int coroutine_fn
@@ -790,16 +799,21 @@ static int coroutine_fn iscsi_co_readv(BlockDriverState *bs,BlockDriverState *file;/* check the block status from the beginning of the cluster * containing the start sector */ -int64_t ret =iscsi_co_get_block_status (bs, - sector_num - sector_num % iscsilun->cluster_sectors, -BDRV_REQUEST_MAX_SECTORS , &pnum, &file); +int cluster_sectors = iscsilun->cluster_size >>BDRV_SECTOR_BITS ; +int head; +int64_t ret; + +assert (cluster_sectors); + head = sector_num % cluster_sectors; + ret =iscsi_co_get_block_status (bs, sector_num - head, +BDRV_REQUEST_MAX_SECTORS , &pnum, + &file);if (ret <0 ) {return ret; }/* if the whole request falls into an unallocated area we can avoid -* to read and directly return zeroes instead */ -if (ret &BDRV_BLOCK_ZERO && - pnum >= nb_sectors + sector_num % iscsilun->cluster_sectors) { +* reading and directly return zeroes instead */ +if (ret &BDRV_BLOCK_ZERO && pnum >= nb_sectors + head) {qemu_iovec_memset (iov,0 ,0x00 , iov->size);return 0 ; }
@@ -1951,8 +1965,8 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,* reasonable size */ if (iscsilun->bl.opt_unmap_gran * iscsilun->block_size >=4 *1024 && iscsilun->bl.opt_unmap_gran * iscsilun->block_size <=16 *1024 *1024 ) { - iscsilun->cluster_sectors = (iscsilun->bl.opt_unmap_gran * - iscsilun->block_size) >>BDRV_SECTOR_BITS ; + iscsilun->cluster_size = iscsilun->bl.opt_unmap_gran * + iscsilun->block_size;if (iscsilun->lbprz) { ret =iscsi_allocmap_init (iscsilun, bs->open_flags); }
@@ -2158,7 +2172,7 @@ static int iscsi_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)IscsiLun *iscsilun = bs->opaque; bdi->unallocated_blocks_are_zero = iscsilun->lbprz; bdi->can_write_zeroes_with_unmap = iscsilun->lbprz && iscsilun->lbp.lbpws; - bdi->cluster_size = iscsilun->cluster_sectors *BDRV_SECTOR_SIZE ; + bdi->cluster_size = iscsilun->cluster_size;return 0 ; }
Signature · 1 line
2.14.3
PATCH v7 6/20 iscsi: Switch iscsi_allocmap_update() to byte-based
In reply to Eric BlakeWe are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the allocmap (no semantic change). Callers that already had bytes available are simpler, and callers that now scale to bytes will be easier to switch to byte-based in the future.
---
v7: rebase to master, simple enough to keep ack
v3-v6: no change
v2: rebase to count/bytes rename
--- block/iscsi.c | 90 +++++++++++++++++++++++++++++------------------------------ 1 file changed, 44 insertions(+), 46 deletions(-)
block/iscsi.c +44 -46
@@ -456,24 +456,22 @@ static int iscsi_allocmap_init(IscsiLun *iscsilun, int open_flags) }static void -iscsi_allocmap_update (IscsiLun *iscsilun,int64_t sector_num, -int nb_sectors,bool allocated,bool valid) +iscsi_allocmap_update (IscsiLun *iscsilun,int64_t offset, +int64_t bytes,bool allocated,bool valid) {int64_t cl_num_expanded, nb_cls_expanded, cl_num_shrunk, nb_cls_shrunk; -int cluster_sectors = iscsilun->cluster_size >>BDRV_SECTOR_BITS ;if (iscsilun->allocmap ==NULL ) {return ; }/* expand to entirely contain all affected clusters */ -assert (cluster_sectors); - cl_num_expanded = sector_num / cluster_sectors; - nb_cls_expanded =DIV_ROUND_UP (sector_num + nb_sectors, - cluster_sectors) - cl_num_expanded; +assert (iscsilun->cluster_size); + cl_num_expanded = offset / iscsilun->cluster_size; + nb_cls_expanded =DIV_ROUND_UP (offset + bytes, + iscsilun->cluster_size) - cl_num_expanded;/* shrink to touch only completely contained clusters */ - cl_num_shrunk =DIV_ROUND_UP (sector_num, cluster_sectors); - nb_cls_shrunk = (sector_num + nb_sectors) / cluster_sectors - - cl_num_shrunk; + cl_num_shrunk =DIV_ROUND_UP (offset, iscsilun->cluster_size); + nb_cls_shrunk = (offset + bytes) / iscsilun->cluster_size - cl_num_shrunk;if (allocated) {bitmap_set (iscsilun->allocmap, cl_num_expanded, nb_cls_expanded); }else {
@@ -496,26 +494,26 @@ iscsi_allocmap_update(IscsiLun *iscsilun, int64_t sector_num, }static void -iscsi_allocmap_set_allocated (IscsiLun *iscsilun,int64_t sector_num, -int nb_sectors) +iscsi_allocmap_set_allocated (IscsiLun *iscsilun,int64_t offset, +int64_t bytes) { -iscsi_allocmap_update (iscsilun, sector_num, nb_sectors, true, true); +iscsi_allocmap_update (iscsilun, offset, bytes, true, true); }static void -iscsi_allocmap_set_unallocated (IscsiLun *iscsilun,int64_t sector_num, -int nb_sectors) +iscsi_allocmap_set_unallocated (IscsiLun *iscsilun,int64_t offset, +int64_t bytes) {/* Note: if cache.direct=on the fifth argument to iscsi_allocmap_update * is ignored, so this will in effect be an iscsi_allocmap_set_invalid. */ -iscsi_allocmap_update (iscsilun, sector_num, nb_sectors, false, true); +iscsi_allocmap_update (iscsilun, offset, bytes, false, true); } -static void iscsi_allocmap_set_invalid (IscsiLun *iscsilun,int64_t sector_num, -int nb_sectors) +static void iscsi_allocmap_set_invalid (IscsiLun *iscsilun,int64_t offset, +int64_t bytes) { -iscsi_allocmap_update (iscsilun, sector_num, nb_sectors, false, false); +iscsi_allocmap_update (iscsilun, offset, bytes, false, false); }static void iscsi_allocmap_invalidate (IscsiLun *iscsilun)
@@ -529,34 +527,30 @@ static void iscsi_allocmap_invalidate(IscsiLun *iscsilun) }static inline bool -iscsi_allocmap_is_allocated (IscsiLun *iscsilun,int64_t sector_num, -int nb_sectors) +iscsi_allocmap_is_allocated (IscsiLun *iscsilun,int64_t offset, +int64_t bytes) {unsigned long size;if (iscsilun->allocmap ==NULL ) {return true; }assert (iscsilun->cluster_size); - size =DIV_ROUND_UP (sector_num + nb_sectors, - iscsilun->cluster_size >>BDRV_SECTOR_BITS ); + size =DIV_ROUND_UP (offset + bytes, iscsilun->cluster_size);return !(find_next_bit (iscsilun->allocmap, size, - sector_num *BDRV_SECTOR_SIZE / - iscsilun->cluster_size) == size); + offset / iscsilun->cluster_size) == size); }static inline bool iscsi_allocmap_is_valid (IscsiLun *iscsilun, -int64_t sector_num,int nb_sectors) +int64_t offset,int64_t bytes) {unsigned long size;if (iscsilun->allocmap_valid ==NULL ) {return false; }assert (iscsilun->cluster_size); - size =DIV_ROUND_UP (sector_num + nb_sectors, - iscsilun->cluster_size >>BDRV_SECTOR_BITS ); + size =DIV_ROUND_UP (offset + bytes, iscsilun->cluster_size);return (find_next_zero_bit (iscsilun->allocmap_valid, size, - sector_num *BDRV_SECTOR_SIZE / - iscsilun->cluster_size) == size); + offset / iscsilun->cluster_size) == size); }static int coroutine_fn
@@ -638,14 +632,16 @@ retry: }if (iTask.status !=SCSI_STATUS_GOOD ) { -iscsi_allocmap_set_invalid (iscsilun, sector_num, nb_sectors); +iscsi_allocmap_set_invalid (iscsilun, sector_num *BDRV_SECTOR_SIZE , + nb_sectors *BDRV_SECTOR_SIZE );error_report ("iSCSI WRITE10/16 failed at lba %" PRIu64": %s" , lba, iTask.err_str); r = iTask.err_code; goto out_unlock; } -iscsi_allocmap_set_allocated (iscsilun, sector_num, nb_sectors); +iscsi_allocmap_set_allocated (iscsilun, sector_num *BDRV_SECTOR_SIZE , + nb_sectors *BDRV_SECTOR_SIZE ); out_unlock:qemu_mutex_unlock (&iscsilun->mutex);
@@ -744,9 +740,11 @@ retry: }if (ret &BDRV_BLOCK_ZERO ) { -iscsi_allocmap_set_unallocated (iscsilun, sector_num, *pnum); +iscsi_allocmap_set_unallocated (iscsilun, sector_num *BDRV_SECTOR_SIZE , + *pnum *BDRV_SECTOR_SIZE ); }else { -iscsi_allocmap_set_allocated (iscsilun, sector_num, *pnum); +iscsi_allocmap_set_allocated (iscsilun, sector_num *BDRV_SECTOR_SIZE , + *pnum *BDRV_SECTOR_SIZE ); }if (*pnum > nb_sectors) {
@@ -786,15 +784,19 @@ static int coroutine_fn iscsi_co_readv(BlockDriverState *bs,/* if cache.direct is off and we have a valid entry in our allocation map * we can skip checking the block status and directly return zeroes if * the request falls within an unallocated area */ -if (iscsi_allocmap_is_valid (iscsilun, sector_num, nb_sectors) && - !iscsi_allocmap_is_allocated (iscsilun, sector_num, nb_sectors)) { +if (iscsi_allocmap_is_valid (iscsilun, sector_num *BDRV_SECTOR_SIZE , + nb_sectors *BDRV_SECTOR_SIZE ) && + !iscsi_allocmap_is_allocated (iscsilun, sector_num *BDRV_SECTOR_SIZE , + nb_sectors *BDRV_SECTOR_SIZE )) {qemu_iovec_memset (iov,0 ,0x00 , iov->size);return 0 ; }if (nb_sectors >=ISCSI_CHECKALLOC_THRES && - !iscsi_allocmap_is_valid (iscsilun, sector_num, nb_sectors) && - !iscsi_allocmap_is_allocated (iscsilun, sector_num, nb_sectors)) { + !iscsi_allocmap_is_valid (iscsilun, sector_num *BDRV_SECTOR_SIZE , + nb_sectors *BDRV_SECTOR_SIZE ) && + !iscsi_allocmap_is_allocated (iscsilun, sector_num *BDRV_SECTOR_SIZE , + nb_sectors *BDRV_SECTOR_SIZE )) {int pnum;BlockDriverState *file;/* check the block status from the beginning of the cluster
@@ -1157,8 +1159,7 @@ retry: goto retry; } -iscsi_allocmap_set_invalid (iscsilun, offset >>BDRV_SECTOR_BITS , - bytes >>BDRV_SECTOR_BITS ); +iscsi_allocmap_set_invalid (iscsilun, offset, bytes);if (iTask.status ==SCSI_STATUS_CHECK_CONDITION ) {/* the target might fail with a check condition if it
@@ -1271,8 +1272,7 @@ retry: }if (iTask.status !=SCSI_STATUS_GOOD ) { -iscsi_allocmap_set_invalid (iscsilun, offset >>BDRV_SECTOR_BITS , - bytes >>BDRV_SECTOR_BITS ); +iscsi_allocmap_set_invalid (iscsilun, offset, bytes);error_report ("iSCSI WRITESAME10/16 failed at lba %" PRIu64": %s" , lba, iTask.err_str); r = iTask.err_code;
@@ -1280,11 +1280,9 @@ retry: }if (flags &BDRV_REQ_MAY_UNMAP ) { -iscsi_allocmap_set_invalid (iscsilun, offset >>BDRV_SECTOR_BITS , - bytes >>BDRV_SECTOR_BITS ); +iscsi_allocmap_set_invalid (iscsilun, offset, bytes); }else { -iscsi_allocmap_set_allocated (iscsilun, offset >>BDRV_SECTOR_BITS , - bytes >>BDRV_SECTOR_BITS ); +iscsi_allocmap_set_allocated (iscsilun, offset, bytes); } out_unlock:
Signature · 1 line
2.14.3
Re: [Qemu-devel] [PATCH v7 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based
Quoted 9 lines · Eric Blake
We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the allocmap (no semantic change). Callers that already had bytes available are simpler, and callers that now scale to bytes will be easier to switch to byte-based in the future.
Signed-off-by Eric Blake <[email protected]>Acked-by Paolo Bonzini <[email protected]>
PATCH v7 7/20 iscsi: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the iscsi driver accordingly. In this case, it is handy to teach iscsi_co_block_status() to handle a NULL map and file parameter, even though the block layer passes non-NULL values, because we also call the function directly. For now, there are no optimizations done based on the want_zero flag.
We can also make the simplification of asserting that the block layer passed in aligned values.
---
v7: rebase to master
v6: no change
v5: assert rather than check for alignment
v4: rebase to interface tweaks
v3: no change
v2: rebase to mapping parameter
--- block/iscsi.c | 67 ++++++++++++++++++++++++++++------------------------------- 1 file changed, 32 insertions(+), 35 deletions(-)
block/iscsi.c +32 -35
@@ -651,34 +651,34 @@ out_unlock: -static int64_t coroutine_fn iscsi_co_get_block_status(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors,int *pnum, -BlockDriverState **file) +static int coroutine_fn iscsi_co_block_status(BlockDriverState *bs, +bool want_zero,int64_t offset, +int64_t bytes,int64_t *pnum, +int64_t *map, +BlockDriverState **file) {IscsiLun *iscsilun = bs->opaque;struct scsi_get_lba_status *lbas =NULL ;struct scsi_lba_status_descriptor *lbasd =NULL ;struct IscsiTask iTask;uint64_t lba; -int64_t ret; +int ret; -if (!is_sector_request_lun_aligned (sector_num, nb_sectors, iscsilun)) { - ret = -EINVAL ; - goto out; - } +assert (QEMU_IS_ALIGNED (offset | bytes, iscsilun->block_size));/* default to all sectors allocated */ - ret =BDRV_BLOCK_DATA ; - ret |= (sector_num <<BDRV_SECTOR_BITS ) |BDRV_BLOCK_OFFSET_VALID ; - *pnum = nb_sectors; + ret =BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; +if (map) { + *map = offset; + } + *pnum = bytes;/* LUN does not support logical block provisioning */ if (!iscsilun->lbpme) { goto out; } - lba =sector_qemu2lun (sector_num, iscsilun); + lba = offset / iscsilun->block_size;iscsi_co_init_iscsitask (iscsilun, &iTask);qemu_mutex_lock (&iscsilun->mutex);
@@ -724,12 +724,12 @@ retry: lbasd = &lbas->descriptors[0 ]; -if (sector_qemu2lun (sector_num, iscsilun) != lbasd->lba) { +if (lba != lbasd->lba) { ret = -EIO ; goto out_unlock; } - *pnum =sector_lun2qemu (lbasd->num_blocks, iscsilun); + *pnum = lbasd->num_blocks * iscsilun->block_size;if (lbasd->provisioning ==SCSI_PROVISIONING_TYPE_DEALLOCATED || lbasd->provisioning ==SCSI_PROVISIONING_TYPE_ANCHORED ) {
@@ -740,15 +740,13 @@ retry: }if (ret &BDRV_BLOCK_ZERO ) { -iscsi_allocmap_set_unallocated (iscsilun, sector_num *BDRV_SECTOR_SIZE , - *pnum *BDRV_SECTOR_SIZE ); +iscsi_allocmap_set_unallocated (iscsilun, offset, *pnum); }else { -iscsi_allocmap_set_allocated (iscsilun, sector_num *BDRV_SECTOR_SIZE , - *pnum *BDRV_SECTOR_SIZE ); +iscsi_allocmap_set_allocated (iscsilun, offset, *pnum); } -if (*pnum > nb_sectors) { - *pnum = nb_sectors; +if (*pnum > bytes) { + *pnum = bytes; } out_unlock:qemu_mutex_unlock (&iscsilun->mutex);
@@ -757,7 +755,7 @@ out:if (iTask.task !=NULL ) {scsi_free_scsi_task (iTask.task); } -if (ret >0 && ret &BDRV_BLOCK_OFFSET_VALID ) { +if (ret >0 && ret &BDRV_BLOCK_OFFSET_VALID && file) { *file = bs; }return ret;
@@ -797,25 +795,24 @@ static int coroutine_fn iscsi_co_readv(BlockDriverState *bs, nb_sectors * BDRV_SECTOR_SIZE) && !iscsi_allocmap_is_allocated(iscsilun, sector_num * BDRV_SECTOR_SIZE, nb_sectors * BDRV_SECTOR_SIZE)) { -int pnum; -BlockDriverState *file; +int64_t pnum;/* check the block status from the beginning of the cluster * containing the start sector */ -int cluster_sectors = iscsilun->cluster_size >>BDRV_SECTOR_BITS ; -int head; -int64_t ret; +int64_t head; +int ret; -assert (cluster_sectors); - head = sector_num % cluster_sectors; - ret =iscsi_co_get_block_status (bs, sector_num - head, -BDRV_REQUEST_MAX_SECTORS , &pnum, - &file); +assert (iscsilun->cluster_size); + head = (sector_num *BDRV_SECTOR_SIZE ) % iscsilun->cluster_size; + ret =iscsi_co_block_status (bs, false, + sector_num *BDRV_SECTOR_SIZE - head, +BDRV_REQUEST_MAX_BYTES , &pnum,NULL ,NULL );if (ret <0 ) {return ret; }/* if the whole request falls into an unallocated area we can avoid * reading and directly return zeroes instead */ -if (ret &BDRV_BLOCK_ZERO && pnum >= nb_sectors + head) { +if (ret &BDRV_BLOCK_ZERO && + pnum >= nb_sectors *BDRV_SECTOR_SIZE + head) {qemu_iovec_memset (iov,0 ,0x00 , iov->size);return 0 ; }
@@ -2213,7 +2210,7 @@ static BlockDriver bdrv_iscsi = { .bdrv_truncate = iscsi_truncate, .bdrv_refresh_limits = iscsi_refresh_limits, - .bdrv_co_get_block_status = iscsi_co_get_block_status, + .bdrv_co_block_status = iscsi_co_block_status, .bdrv_co_pdiscard = iscsi_co_pdiscard, .bdrv_co_pwrite_zeroes = iscsi_co_pwrite_zeroes, .bdrv_co_readv = iscsi_co_readv,
@@ -2248,7 +2245,7 @@ static BlockDriver bdrv_iser = { .bdrv_truncate = iscsi_truncate, .bdrv_refresh_limits = iscsi_refresh_limits, - .bdrv_co_get_block_status = iscsi_co_get_block_status, + .bdrv_co_block_status = iscsi_co_block_status, .bdrv_co_pdiscard = iscsi_co_pdiscard, .bdrv_co_pwrite_zeroes = iscsi_co_pwrite_zeroes, .bdrv_co_readv = iscsi_co_readv,
Signature · 1 line
2.14.3
Re: [Qemu-devel] [PATCH v7 07/20] iscsi: Switch to .bdrv_co_block_status()
Quoted 11 lines · Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the iscsi driver accordingly. In this case, it is handy to teach
iscsi_co_block_status()to handle a NULL map and file parameter, even though the block layer passes non-NULL values, because we also call the function directly. For now, there are no optimizations done based on thewant_zeroflag.We can also make the simplification of asserting that the block layer passed in aligned values.
Signed-off-by Eric Blake <[email protected]>
PATCH v7 8/20 null: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the null driver accordingly.
---
v6-v7: no change
v5: minor fix to type of 'ret'
v4: rebase to interface tweak
v3: no change
v2: rebase to mapping parameter
--- block/null.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-)
block/null.c +12 -11
@@ -222,22 +222,23 @@ static int null_reopen_prepare(BDRVReopenState *reopen_state,return 0 ; } -static int64_t coroutine_fn null_co_get_block_status(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors,int *pnum, -BlockDriverState **file) +static int coroutine_fn null_co_block_status(BlockDriverState *bs, +bool want_zero,int64_t offset, +int64_t bytes,int64_t *pnum, +int64_t *map, +BlockDriverState **file) {BDRVNullState *s = bs->opaque; -off_t start = sector_num *BDRV_SECTOR_SIZE ; +int ret =BDRV_BLOCK_OFFSET_VALID ; - *pnum = nb_sectors; + *pnum = bytes; + *map = offset; *file = bs;if (s->read_zeroes) { -return BDRV_BLOCK_OFFSET_VALID | start |BDRV_BLOCK_ZERO ; - }else { -return BDRV_BLOCK_OFFSET_VALID | start; + ret |=BDRV_BLOCK_ZERO ; } +return ret; }static void null_refresh_filename (BlockDriverState *bs,QDict *opts)
@@ -269,7 +270,7 @@ static BlockDriver bdrv_null_co = { .bdrv_co_flush_to_disk = null_co_flush, .bdrv_reopen_prepare = null_reopen_prepare, - .bdrv_co_get_block_status = null_co_get_block_status, + .bdrv_co_block_status = null_co_block_status, .bdrv_refresh_filename = null_refresh_filename, };
@@ -289,7 +290,7 @@ static BlockDriver bdrv_null_aio = { .bdrv_aio_flush = null_aio_flush, .bdrv_reopen_prepare = null_reopen_prepare, - .bdrv_co_get_block_status = null_co_get_block_status, + .bdrv_co_block_status = null_co_block_status, .bdrv_refresh_filename = null_refresh_filename, };
Signature · 1 line
2.14.3
PATCH v7 9/20 parallels: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the parallels driver accordingly. Note that the internal function block_status() is still sector-based, because it is still in use by other sector-based functions; but that's okay because request_alignment is 512 as a result of those functions. For now, no optimizations are added based on the mapping hint.
---
v7: fix bug in *map [Vladimir]
v6: no change
v5: fix pnum when return is 0
v4: rebase to interface tweak, R-b dropped
v3: no change
v2: rebase to mapping parameter; it is ignored, so R-b kept
--- block/parallels.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-)
block/parallels.c +15 -7
@@ -280,23 +280,31 @@ static coroutine_fn int parallels_co_flush_to_os(BlockDriverState *bs) } -static int64_t coroutine_fn parallels_co_get_block_status(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *pnum,BlockDriverState **file) +static int coroutine_fn parallels_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset, +int64_t bytes, +int64_t *pnum, +int64_t *map, +BlockDriverState **file) {BDRVParallelsState *s = bs->opaque; -int64_t offset; +int count; +assert (QEMU_IS_ALIGNED (offset | bytes,BDRV_SECTOR_SIZE ));qemu_co_mutex_lock (&s->lock); - offset =block_status (s, sector_num, nb_sectors, pnum); + offset =block_status (s, offset >>BDRV_SECTOR_BITS , + bytes >>BDRV_SECTOR_BITS , &count);qemu_co_mutex_unlock (&s->lock); + *pnum = count *BDRV_SECTOR_SIZE ;if (offset <0 ) {return 0 ; } + *map = offset *BDRV_SECTOR_SIZE ; *file = bs->file->bs; -return (offset <<BDRV_SECTOR_BITS ) | -BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; +return BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; } static coroutine_fn int parallels_co_writev(BlockDriverState *bs,
@@ -793,7 +801,7 @@ static BlockDriver bdrv_parallels = { .bdrv_open = parallels_open, .bdrv_close = parallels_close, .bdrv_child_perm = bdrv_format_default_perms, - .bdrv_co_get_block_status = parallels_co_get_block_status, + .bdrv_co_block_status = parallels_co_block_status, .bdrv_has_zero_init = bdrv_has_zero_init_1, .bdrv_co_flush_to_os = parallels_co_flush_to_os, .bdrv_co_readv = parallels_co_readv,
Signature · 1 line
2.14.3
Re: [Qemu-devel] [PATCH v7 09/20] parallels: Switch to .bdrv_co_block_status()
Quoted 10 lines · Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the parallels driver accordingly. Note that the internal function
block_status()is still sector-based, because it is still in use by other sector-based functions; but that's okay becauserequest_alignmentis 512 as a result of those functions. For now, no optimizations are added based on the mapping hint.Signed-off-by Eric Blake <[email protected]>Reviewed-by Vladimir Sementsov-Ogievskiy <[email protected]>
PATCH v7 10/20 qcow: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow driver accordingly. There is no intent to optimize based on the want_zero flag for this format.
---
v5-v7: no change
v4: rebase to interface tweak
v3: rebase to master
v2: rebase to mapping flag
--- block/qcow.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-)
block/qcow.c +16 -11
@@ -513,23 +513,28 @@ static int get_cluster_offset(BlockDriverState *bs,return 1 ; } -static int64_t coroutine_fn qcow_co_get_block_status(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *pnum,BlockDriverState **file) +static int coroutine_fn qcow_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset,int64_t bytes, +int64_t *pnum,int64_t *map, +BlockDriverState **file) {BDRVQcowState *s = bs->opaque; -int index_in_cluster, n, ret; +int index_in_cluster, ret; +int64_t n;uint64_t cluster_offset;qemu_co_mutex_lock (&s->lock); - ret =get_cluster_offset (bs, sector_num <<9 ,0 ,0 ,0 ,0 , &cluster_offset); + ret =get_cluster_offset (bs, offset,0 ,0 ,0 ,0 , &cluster_offset);qemu_co_mutex_unlock (&s->lock);if (ret <0 ) {return ret; } - index_in_cluster = sector_num & (s->cluster_sectors -1 ); - n = s->cluster_sectors - index_in_cluster; -if (n > nb_sectors) - n = nb_sectors; + index_in_cluster = offset & (s->cluster_size -1 ); + n = s->cluster_size - index_in_cluster; +if (n > bytes) { + n = bytes; + } *pnum = n;if (!cluster_offset) {return 0 ;
@@ -537,9 +542,9 @@ static int64_t coroutine_fn qcow_co_get_block_status(BlockDriverState *bs,if ((cluster_offset &QCOW_OFLAG_COMPRESSED ) || s->crypto) {return BDRV_BLOCK_DATA ; } - cluster_offset |= (index_in_cluster <<BDRV_SECTOR_BITS ); + *map = cluster_offset | index_in_cluster; *file = bs->file->bs; -return BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID | cluster_offset; +return BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; } static int decompress_buffer(uint8_t *out_buf, int out_buf_size,
@@ -1111,7 +1116,7 @@ static BlockDriver bdrv_qcow = { .bdrv_co_readv = qcow_co_readv, .bdrv_co_writev = qcow_co_writev, - .bdrv_co_get_block_status = qcow_co_get_block_status, + .bdrv_co_block_status = qcow_co_block_status, .bdrv_make_empty = qcow_make_empty, .bdrv_co_pwritev_compressed = qcow_co_pwritev_compressed,
Signature · 1 line
2.14.3
PATCH v7 11/20 qcow2: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow2 driver accordingly.
For now, we are ignoring the 'want_zero' hint. However, it should be relatively straightforward to honor the hint as a way to return larger *pnum values when we have consecutive clusters with the same data/zero status but which differ only in having non-consecutive mappings.
---
v5-v7: no change
v4: update to interface tweak
v3: no change
v2: rebase to mapping flag
--- block/qcow2.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
block/qcow2.c +13 -11
@@ -1637,32 +1637,34 @@ static void qcow2_join_options(QDict *options, QDict *old_options) } } -static int64_t coroutine_fn qcow2_co_get_block_status(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *pnum,BlockDriverState **file) +static int coroutine_fn qcow2_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset,int64_t count, +int64_t *pnum,int64_t *map, +BlockDriverState **file) {BDRVQcow2State *s = bs->opaque;uint64_t cluster_offset;int index_in_cluster, ret;unsigned int bytes; -int64_t status =0 ; +int status =0 ; - bytes =MIN (INT_MAX , nb_sectors *BDRV_SECTOR_SIZE ); + bytes =MIN (INT_MAX , count);qemu_co_mutex_lock (&s->lock); - ret =qcow2_get_cluster_offset (bs, sector_num <<BDRV_SECTOR_BITS , &bytes, - &cluster_offset); + ret =qcow2_get_cluster_offset (bs, offset, &bytes, &cluster_offset);qemu_co_mutex_unlock (&s->lock);if (ret <0 ) {return ret; } - *pnum = bytes >>BDRV_SECTOR_BITS ; + *pnum = bytes;if (cluster_offset !=0 && ret !=QCOW2_CLUSTER_COMPRESSED && !s->crypto) { - index_in_cluster = sector_num & (s->cluster_sectors -1 ); - cluster_offset |= (index_in_cluster <<BDRV_SECTOR_BITS ); + index_in_cluster = offset & (s->cluster_size -1 ); + *map = cluster_offset | index_in_cluster; *file = bs->file->bs; - status |=BDRV_BLOCK_OFFSET_VALID | cluster_offset; + status |=BDRV_BLOCK_OFFSET_VALID ; }if (ret ==QCOW2_CLUSTER_ZERO_PLAIN || ret ==QCOW2_CLUSTER_ZERO_ALLOC ) { status |=BDRV_BLOCK_ZERO ;
@@ -4320,7 +4322,7 @@ BlockDriver bdrv_qcow2 = { .bdrv_child_perm = bdrv_format_default_perms, .bdrv_create = qcow2_create, .bdrv_has_zero_init = bdrv_has_zero_init_1, - .bdrv_co_get_block_status = qcow2_co_get_block_status, + .bdrv_co_block_status = qcow2_co_block_status, .bdrv_co_preadv = qcow2_co_preadv, .bdrv_co_pwritev = qcow2_co_pwritev,
Signature · 1 line
2.14.3
PATCH v7 12/20 qed: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the qed driver accordingly, taking the opportunity to inline qed_is_allocated_cb() into its lone caller (the callback used to be important, until we switched qed to coroutines). There is no intent to optimize based on the want_zero flag for this format.
---
v6-v7: no change
v5: initialize len before qed_find_cluster() [Vladimir]
v4: rebase to interface change, inline pointless callback
v3: no change
v2: rebase to mapping flag, fix mask in qed_is_allocated_cb
--- block/qed.c | 84 +++++++++++++++++++++---------------------------------------- 1 file changed, 28 insertions(+), 56 deletions(-)
block/qed.c +28 -56
@@ -688,74 +688,46 @@ finish:return ret; } -typedef struct { -BlockDriverState *bs; -Coroutine *co; -uint64_t pos; -int64_t status; -int *pnum; -BlockDriverState **file; -}QEDIsAllocatedCB ; - -/* Called with table_lock held. */ -static void qed_is_allocated_cb (void *opaque,int ret,uint64_t offset,size_t len) -{ -QEDIsAllocatedCB *cb = opaque; -BDRVQEDState *s = cb->bs->opaque; - *cb->pnum = len /BDRV_SECTOR_SIZE ; -switch (ret) { -case QED_CLUSTER_FOUND : - offset |=qed_offset_into_cluster (s, cb->pos); - cb->status =BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID | offset; - *cb->file = cb->bs->file->bs; -break ; -case QED_CLUSTER_ZERO : - cb->status =BDRV_BLOCK_ZERO ; -break ; -case QED_CLUSTER_L2 : -case QED_CLUSTER_L1 : - cb->status =0 ; -break ; -default : -assert (ret <0 ); - cb->status = ret; -break ; - } - -if (cb->co) { -aio_co_wake (cb->co); - } -} - -static int64_t coroutine_fn bdrv_qed_co_get_block_status(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors,int *pnum, +static int coroutine_fn bdrv_qed_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t pos,int64_t bytes, +int64_t *pnum,int64_t *map,BlockDriverState **file) {BDRVQEDState *s = bs->opaque; -size_t len = (size_t )nb_sectors *BDRV_SECTOR_SIZE ; -QEDIsAllocatedCB cb = { - .bs = bs, - .pos = (uint64_t )sector_num *BDRV_SECTOR_SIZE , - .status =BDRV_BLOCK_OFFSET_MASK , - .pnum = pnum, - .file = file, - }; +size_t len =MIN (bytes,SIZE_MAX ); +int status;QEDRequest request = { .l2_table =NULL };uint64_t offset;int ret;qemu_co_mutex_lock (&s->table_lock); - ret =qed_find_cluster (s, &request, cb.pos, &len, &offset); -qed_is_allocated_cb (&cb, ret, offset, len); + ret =qed_find_cluster (s, &request, pos, &len, &offset); -/* The callback was invoked immediately */ -assert (cb.status !=BDRV_BLOCK_OFFSET_MASK ); + *pnum = len; +switch (ret) { +case QED_CLUSTER_FOUND : + *map = offset |qed_offset_into_cluster (s, pos); + status =BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; + *file = bs->file->bs; +break ; +case QED_CLUSTER_ZERO : + status =BDRV_BLOCK_ZERO ; +break ; +case QED_CLUSTER_L2 : +case QED_CLUSTER_L1 : + status =0 ; +break ; +default : +assert (ret <0 ); + status = ret; +break ; + }qed_unref_l2_cache_entry (request.l2_table);qemu_co_mutex_unlock (&s->table_lock); -return cb.status; +return status; }static BDRVQEDState *acb_to_s (QEDAIOCB *acb)
@@ -1595,7 +1567,7 @@ static BlockDriver bdrv_qed = { .bdrv_child_perm = bdrv_format_default_perms, .bdrv_create = bdrv_qed_create, .bdrv_has_zero_init = bdrv_has_zero_init_1, - .bdrv_co_get_block_status = bdrv_qed_co_get_block_status, + .bdrv_co_block_status = bdrv_qed_co_block_status, .bdrv_co_readv = bdrv_qed_co_readv, .bdrv_co_writev = bdrv_qed_co_writev, .bdrv_co_pwrite_zeroes = bdrv_qed_co_pwrite_zeroes,
Signature · 1 line
2.14.3
PATCH v7 13/20 raw: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the raw driver accordingly.
---
v5-v7: no change
v4: rebase to interface tweak
v3: no change
v2: rebase to mapping
--- block/raw-format.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
block/raw-format.c +8 -8
@@ -250,17 +250,17 @@ fail:return ret; } -static int64_t coroutine_fn raw_co_get_block_status(BlockDriverState *bs, -int64_t sector_num, -int nb_sectors,int *pnum, +static int coroutine_fn raw_co_block_status(BlockDriverState *bs, +bool want_zero,int64_t offset, +int64_t bytes,int64_t *pnum, +int64_t *map,BlockDriverState **file) {BDRVRawState *s = bs->opaque; - *pnum = nb_sectors; + *pnum = bytes; *file = bs->file->bs; - sector_num += s->offset /BDRV_SECTOR_SIZE ; -return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID | - (sector_num <<BDRV_SECTOR_BITS ); + *map = offset + s->offset; +return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID ; } static int coroutine_fn raw_co_pwrite_zeroes(BlockDriverState *bs,
@@ -496,7 +496,7 @@ BlockDriver bdrv_raw = { .bdrv_co_pwritev = &raw_co_pwritev, .bdrv_co_pwrite_zeroes = &raw_co_pwrite_zeroes, .bdrv_co_pdiscard = &raw_co_pdiscard, - .bdrv_co_get_block_status = &raw_co_get_block_status, + .bdrv_co_block_status = &raw_co_block_status, .bdrv_truncate = &raw_truncate, .bdrv_getlength = &raw_getlength, .has_variable_length = true,
Signature · 1 line
2.14.3
PATCH v7 14/20 sheepdog: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the sheepdog driver accordingly.
---
v7: rebase to minor spacing changes in master
v5-v6: no change
v4: update to interface tweak
v3: no change
v2: rebase to mapping flag
--- block/sheepdog.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)
block/sheepdog.c +13 -13
@@ -2987,19 +2987,19 @@ static coroutine_fn int sd_co_pdiscard(BlockDriverState *bs, int64_t offset,return acb.ret; } -static coroutine_fn int64_t -sd_co_get_block_status (BlockDriverState *bs,int64_t sector_num,int nb_sectors, -int *pnum,BlockDriverState **file) +static coroutine_fn int +sd_co_block_status (BlockDriverState *bs,bool want_zero,int64_t offset, +int64_t bytes,int64_t *pnum,int64_t *map, +BlockDriverState **file) {BDRVSheepdogState *s = bs->opaque;SheepdogInode *inode = &s->inode;uint32_t object_size = (UINT32_C (1 ) << inode->block_size_shift); -uint64_t offset = sector_num *BDRV_SECTOR_SIZE ;unsigned long start = offset / object_size, - end =DIV_ROUND_UP ((sector_num + nb_sectors) * -BDRV_SECTOR_SIZE , object_size); + end =DIV_ROUND_UP (offset + bytes, object_size);unsigned long idx; -int64_t ret =BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID | offset; + *map = offset; +int ret =BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ;for (idx = start; idx < end; idx++) {if (inode->data_vdi_id[idx] ==0 ) {
@@ -3016,9 +3016,9 @@ sd_co_get_block_status(BlockDriverState *bs, int64_t sector_num, int nb_sectors, } } - *pnum = (idx - start) * object_size /BDRV_SECTOR_SIZE ; -if (*pnum > nb_sectors) { - *pnum = nb_sectors; + *pnum = (idx - start) * object_size; +if (*pnum > bytes) { + *pnum = bytes; }if (ret >0 && ret &BDRV_BLOCK_OFFSET_VALID ) { *file = bs;
@@ -3096,7 +3096,7 @@ static BlockDriver bdrv_sheepdog = { .bdrv_co_writev = sd_co_writev, .bdrv_co_flush_to_disk = sd_co_flush_to_disk, .bdrv_co_pdiscard = sd_co_pdiscard, - .bdrv_co_get_block_status = sd_co_get_block_status, + .bdrv_co_block_status = sd_co_block_status, .bdrv_snapshot_create = sd_snapshot_create, .bdrv_snapshot_goto = sd_snapshot_goto,
@@ -3132,7 +3132,7 @@ static BlockDriver bdrv_sheepdog_tcp = { .bdrv_co_writev = sd_co_writev, .bdrv_co_flush_to_disk = sd_co_flush_to_disk, .bdrv_co_pdiscard = sd_co_pdiscard, - .bdrv_co_get_block_status = sd_co_get_block_status, + .bdrv_co_block_status = sd_co_block_status, .bdrv_snapshot_create = sd_snapshot_create, .bdrv_snapshot_goto = sd_snapshot_goto,
@@ -3168,7 +3168,7 @@ static BlockDriver bdrv_sheepdog_unix = { .bdrv_co_writev = sd_co_writev, .bdrv_co_flush_to_disk = sd_co_flush_to_disk, .bdrv_co_pdiscard = sd_co_pdiscard, - .bdrv_co_get_block_status = sd_co_get_block_status, + .bdrv_co_block_status = sd_co_block_status, .bdrv_snapshot_create = sd_snapshot_create, .bdrv_snapshot_goto = sd_snapshot_goto,
Signature · 1 line
2.14.3
PATCH v7 15/20 vdi: Avoid bitrot of debugging code
In reply to Eric BlakeRework the debug define so that we always get -Wformat checking, even when debugging is disabled.
---
v2-v7: no change
--- block/vdi.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
block/vdi.c +9 -3
@@ -86,12 +86,18 @@#define DEFAULT_CLUSTER_SIZE (1 * MiB)#if defined(CONFIG_VDI_DEBUG ) -#define logout (fmt, ...) \ - fprintf(stderr, "vdi\t%-24s" fmt, __func__, ##__VA_ARGS__) +#define VDI_DEBUG 1#else -#define logout (fmt, ...) ((void)0) +#define VDI_DEBUG 0#endif +#define logout (fmt, ...) \ + do { \ + if (VDI_DEBUG) { \ + fprintf(stderr, "vdi\t%-24s" fmt, __func__, ##__VA_ARGS__); \ + } \ + } while (0) +/* Image signature. */ #define VDI_SIGNATURE 0xbeda107f
Signature · 1 line
2.14.3
PATCH v7 16/20 vdi: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the vdi driver accordingly. Note that the TODO is already covered (the block layer guarantees bounds of its requests), and that we can remove the now-unused s->block_sectors.
---
v6-v7: no change
v5: fix pnum when offset rounded down to block_size [Vladimir]
v4: rebase to interface tweak
v3: no change
v2: rebase to mapping flag
--- block/vdi.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-)
block/vdi.c +13 -20
@@ -171,8 +171,6 @@ typedef struct {uint32_t *bmap;/* Size of block (bytes). */ uint32_t block_size; -/* Size of block (sectors). */ -uint32_t block_sectors;/* First sector of block map. */ uint32_t bmap_sector;/* VDI header (converted to host endianness). */
@@ -462,7 +460,6 @@ static int vdi_open(BlockDriverState *bs, QDict *options, int flags, bs->total_sectors = header.disk_size /SECTOR_SIZE ; s->block_size = header.block_size; - s->block_sectors = header.block_size /SECTOR_SIZE ; s->bmap_sector = header.offset_bmap /SECTOR_SIZE ; s->header = header;
@@ -508,33 +505,29 @@ static int vdi_reopen_prepare(BDRVReopenState *state,return 0 ; } -static int64_t coroutine_fn vdi_co_get_block_status(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *pnum,BlockDriverState **file) +static int coroutine_fn vdi_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset,int64_t bytes, +int64_t *pnum,int64_t *map, +BlockDriverState **file) { -/* TODO: Check for too large sector_num (in bdrv_is_allocated or here). */ BDRVVdiState *s = (BDRVVdiState *)bs->opaque; -size_t bmap_index = sector_num / s->block_sectors; -size_t sector_in_block = sector_num % s->block_sectors; -int n_sectors = s->block_sectors - sector_in_block; +size_t bmap_index = offset / s->block_size; +size_t index_in_block = offset % s->block_size;uint32_t bmap_entry =le32_to_cpu (s->bmap[bmap_index]); -uint64_t offset;int result; -logout ("%p, %" PRId64", %d, %p\n" , bs, sector_num, nb_sectors, pnum); -if (n_sectors > nb_sectors) { - n_sectors = nb_sectors; - } - *pnum = n_sectors; +logout ("%p, %" PRId64", %" PRId64", %p\n" , bs, offset, bytes, pnum); + *pnum =MIN (s->block_size - index_in_block, bytes); result =VDI_IS_ALLOCATED (bmap_entry);if (!result) {return 0 ; } - offset = s->header.offset_data + - (uint64_t )bmap_entry * s->block_size + - sector_in_block *SECTOR_SIZE ; + *map = s->header.offset_data + (uint64_t )bmap_entry * s->block_size + + index_in_block; *file = bs->file->bs; -return BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID | offset; +return BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ; }static int coroutine_fn
@@ -902,7 +895,7 @@ static BlockDriver bdrv_vdi = { .bdrv_child_perm = bdrv_format_default_perms, .bdrv_create = vdi_create, .bdrv_has_zero_init = bdrv_has_zero_init_1, - .bdrv_co_get_block_status = vdi_co_get_block_status, + .bdrv_co_block_status = vdi_co_block_status, .bdrv_make_empty = vdi_make_empty, .bdrv_co_preadv = vdi_co_preadv,
Signature · 1 line
2.14.3
PATCH v7 17/20 vmdk: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the vmdk driver accordingly. Drop the now-unused vmdk_find_index_in_cluster().
Also, fix a pre-existing bug: if find_extent() fails (unlikely, since the block layer did a bounds check), then we must return a failure, rather than 0.
---
v6-v7: no change
v5: drop dead code [Vladimir], return error on find_extent() failure
v4: rebase to interface tweak
v3: no change
v2: rebase to mapping flag
--- block/vmdk.c | 38 ++++++++++++++------------------------ 1 file changed, 14 insertions(+), 24 deletions(-)
block/vmdk.c +14 -24
@@ -1295,33 +1295,27 @@ static inline uint64_t vmdk_find_offset_in_cluster(VmdkExtent *extent,return extent_relative_offset % cluster_size; } -static inline uint64_t vmdk_find_index_in_cluster (VmdkExtent *extent, -int64_t sector_num) -{ -uint64_t offset; - offset =vmdk_find_offset_in_cluster (extent, sector_num *BDRV_SECTOR_SIZE ); -return offset /BDRV_SECTOR_SIZE ; -} - -static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *pnum,BlockDriverState **file) +static int coroutine_fn vmdk_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset,int64_t bytes, +int64_t *pnum,int64_t *map, +BlockDriverState **file) {BDRVVmdkState *s = bs->opaque;int64_t index_in_cluster, n, ret; -uint64_t offset; +uint64_t cluster_offset;VmdkExtent *extent; - extent =find_extent (s, sector_num,NULL ); + extent =find_extent (s, offset >>BDRV_SECTOR_BITS ,NULL );if (!extent) { -return 0 ; +return -EIO ; }qemu_co_mutex_lock (&s->lock); - ret =get_cluster_offset (bs, extent,NULL , - sector_num *512 , false, &offset, + ret =get_cluster_offset (bs, extent,NULL , offset, false, &cluster_offset,0 ,0 );qemu_co_mutex_unlock (&s->lock); - index_in_cluster =vmdk_find_index_in_cluster (extent, sector_num); + index_in_cluster =vmdk_find_offset_in_cluster (extent, offset);switch (ret) {case VMDK_ERROR : ret = -EIO ;
@@ -1336,18 +1330,14 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs, ret =BDRV_BLOCK_DATA ;if (!extent->compressed) { ret |=BDRV_BLOCK_OFFSET_VALID ; - ret |= (offset + (index_in_cluster <<BDRV_SECTOR_BITS )) - &BDRV_BLOCK_OFFSET_MASK ; + *map = cluster_offset + index_in_cluster; } *file = extent->file->bs;break ; } - n = extent->cluster_sectors - index_in_cluster; -if (n > nb_sectors) { - n = nb_sectors; - } - *pnum = n; + n = extent->cluster_sectors *BDRV_SECTOR_SIZE - index_in_cluster; + *pnum =MIN (n, bytes);return ret; }
@@ -2393,7 +2383,7 @@ static BlockDriver bdrv_vmdk = { .bdrv_close = vmdk_close, .bdrv_create = vmdk_create, .bdrv_co_flush_to_disk = vmdk_co_flush, - .bdrv_co_get_block_status = vmdk_co_get_block_status, + .bdrv_co_block_status = vmdk_co_block_status, .bdrv_get_allocated_file_size = vmdk_get_allocated_file_size, .bdrv_has_zero_init = vmdk_has_zero_init, .bdrv_get_specific_info = vmdk_get_specific_info,
Signature · 1 line
2.14.3
PATCH v7 18/20 vpc: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the vpc driver accordingly.
---
v7: tweak commit message and type of 'n' [Fam]
v6: no change
v5: fix incorrect rounding in 'map' and bad loop condition [Vladimir]
v4: rebase to interface tweak
v3: rebase to master
v2: drop get_sector_offset() [Kevin], rebase to mapping flag
--- block/vpc.c | 45 +++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 22 deletions(-)
block/vpc.c +23 -22
@@ -705,53 +705,54 @@ fail:return ret; } -static int64_t coroutine_fn vpc_co_get_block_status(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *pnum,BlockDriverState **file) +static int coroutine_fn vpc_co_block_status(BlockDriverState *bs, +bool want_zero, +int64_t offset,int64_t bytes, +int64_t *pnum,int64_t *map, +BlockDriverState **file) {BDRVVPCState *s = bs->opaque;VHDFooter *footer = (VHDFooter *) s->footer_buf; -int64_t start, offset; +int64_t image_offset;bool allocated; -int64_t ret; -int n; +int ret; +int64_t n;if (be32_to_cpu (footer->type) ==VHD_FIXED ) { - *pnum = nb_sectors; + *pnum = bytes; + *map = offset; *file = bs->file->bs; -return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID | - (sector_num <<BDRV_SECTOR_BITS ); +return BDRV_BLOCK_RAW |BDRV_BLOCK_OFFSET_VALID ; }qemu_co_mutex_lock (&s->lock); - offset =get_image_offset (bs, sector_num <<BDRV_SECTOR_BITS , false,NULL ); - start = offset; - allocated = (offset !=-1 ); + image_offset =get_image_offset (bs, offset, false,NULL ); + allocated = (image_offset !=-1 ); *pnum =0 ; ret =0 ;do {/* All sectors in a block are contiguous (without using the bitmap) */ - n =ROUND_UP (sector_num +1 , s->block_size /BDRV_SECTOR_SIZE ) - - sector_num; - n =MIN (n, nb_sectors); + n =ROUND_UP (offset +1 , s->block_size) - offset; + n =MIN (n, bytes); *pnum += n; - sector_num += n; - nb_sectors -= n; + offset += n; + bytes -= n;/* *pnum can't be greater than one block for allocated * sectors since there is always a bitmap in between. */ if (allocated) { *file = bs->file->bs; - ret =BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID | start; + *map = image_offset; + ret =BDRV_BLOCK_DATA |BDRV_BLOCK_OFFSET_VALID ;break ; } -if (nb_sectors ==0 ) { +if (bytes ==0 ) {break ; } - offset =get_image_offset (bs, sector_num <<BDRV_SECTOR_BITS , false, -NULL ); - }while (offset ==-1 ); + image_offset =get_image_offset (bs, offset, false,NULL ); + }while (image_offset ==-1 );qemu_co_mutex_unlock (&s->lock);return ret;
@@ -1097,7 +1098,7 @@ static BlockDriver bdrv_vpc = { .bdrv_co_preadv = vpc_co_preadv, .bdrv_co_pwritev = vpc_co_pwritev, - .bdrv_co_get_block_status = vpc_co_get_block_status, + .bdrv_co_block_status = vpc_co_block_status, .bdrv_get_info = vpc_get_info,
Signature · 1 line
2.14.3
Re: [Qemu-devel] [PATCH v7 18/20] vpc: Switch to .bdrv_co_block_status()
Quoted 5 lines · Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the vpc driver accordingly.
Signed-off-by Eric Blake <[email protected]>Reviewed-by Vladimir Sementsov-Ogievskiy <[email protected]>
PATCH v7 19/20 vvfat: Switch to .bdrv_co_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Update the vvfat driver accordingly. Note that we can rely on the block driver having already clamped limits to our block size, and simplify accordingly.
---
v5-v7: no change
v4: rebase to interface tweak
v3: no change
v2: rebase to earlier changes, simplify
--- block/vvfat.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)
block/vvfat.c +7 -9
@@ -3086,15 +3086,13 @@ vvfat_co_pwritev(BlockDriverState *bs, uint64_t offset, uint64_t bytes,return ret; } -static int64_t coroutine_fn vvfat_co_get_block_status(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *n,BlockDriverState **file) +static int coroutine_fn vvfat_co_block_status(BlockDriverState *bs, +bool want_zero,int64_t offset, +int64_t bytes,int64_t *n, +int64_t *map, +BlockDriverState **file) { - *n = bs->total_sectors - sector_num; -if (*n > nb_sectors) { - *n = nb_sectors; - }else if (*n <0 ) { -return 0 ; - } + *n = bytes;return BDRV_BLOCK_DATA ; }
@@ -3255,7 +3253,7 @@ static BlockDriver bdrv_vvfat = { .bdrv_co_preadv = vvfat_co_preadv, .bdrv_co_pwritev = vvfat_co_pwritev, - .bdrv_co_get_block_status = vvfat_co_get_block_status, + .bdrv_co_block_status = vvfat_co_block_status, };static void bdrv_vvfat_init (void )
Signature · 1 line
2.14.3
PATCH v7 20/20 block: Drop unused .bdrv_co_get_block_status()
In reply to Eric BlakeWe are gradually moving away from sector-based interfaces, towards byte-based. Now that all drivers have been updated to provide the byte-based .bdrv_co_block_status(), we can delete the sector-based interface.
---
v7: no change
v6: rebase to changes in patch 1, drop R-b
v5: rebase to master
v4: rebase to interface tweak
v3: no change
v2: rebase to earlier changes
--- include/block/block_int.h | 3 --- block/io.c | 50 ++++++++++------------------------------------- 2 files changed, 10 insertions(+), 43 deletions(-)
include/block/block_int.h +0 -3
@@ -217,9 +217,6 @@ struct BlockDriver {* as well as non-NULL pnum, map, and file; in turn, the driver * must return an error or set pnum to an aligned non-zero value. */ - int64_t coroutine_fn (*bdrv_co_get_block_status)(BlockDriverState *bs, -int64_t sector_num,int nb_sectors,int *pnum, -BlockDriverState **file); int coroutine_fn (*bdrv_co_block_status)(BlockDriverState *bs,bool want_zero,int64_t offset,int64_t bytes,int64_t *pnum,int64_t *map,BlockDriverState **file);
block/io.c +10 -40
70 lines not on this page · raw message
Signature · 1 line
2.14.3
This series failed build test on s390x host. Please find the details below.
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: [email protected]
Subject: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base"
# branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build echo -n "Using CC: " realpath $CC mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install === TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'585e5b35cc block: Drop unused .bdrv_co_get_block_status() c5ccc86da3 vvfat: Switch to .bdrv_co_block_status() e3c98d2e60 vpc: Switch to .bdrv_co_block_status()3eefdb6d61 vmdk: Switch to .bdrv_co_block_status() cd52e7a4f3 vdi: Switch to .bdrv_co_block_status()a17638db38 vdi: Avoid bitrot of debugging code23f83984c5 sheepdog: Switch to .bdrv_co_block_status() 4411fddff1 raw: Switch to .bdrv_co_block_status()0223444c76 qed: Switch to .bdrv_co_block_status()39d8ceef87 qcow2: Switch to .bdrv_co_block_status() 58872d167c qcow: Switch to .bdrv_co_block_status() cbfa34d79a parallels: Switch to .bdrv_co_block_status() a334cc5164 null: Switch to .bdrv_co_block_status() 20cc681f63 iscsi: Switch to .bdrv_co_block_status() 2ec228ec62 iscsi: Switch iscsi_allocmap_update() to byte-based 536ee7f45a iscsi: Switch cluster_sectors to byte-based 6cc4d83f3c gluster: Switch to .bdrv_co_block_status() 98fbcc7fd8 file-posix: Switch to .bdrv_co_block_status() 5b4a250849 block: Switch passthrough drivers to .bdrv_co_block_status() b928d30bef block: Add .bdrv_co_block_status() callback
=== OUTPUT BEGIN ===
=== ENV ===
LANG=en_US.UTF-8
XDG_SESSION_ID=7
USER=fam
PWD=/var/tmp/patchew-tester-tmp-zu_flv2_/src
HOME=/home/fam
SHELL=/bin/sh
SHLVL=2
PATCHEW=/home/fam/patchew/patchew-cli -s http://patchew.org --nodebug LOGNAME=fam DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus XDG_RUNTIME_DIR=/run/user/1012
PATH=/usr/bin:/bin
_=/usr/bin/env
=== PACKAGES ===
gpg-pubkey-873529b8-54e386ff glibc-debuginfo-common-2.24-10.fc25.s390x fedora-release-26-1.noarch dejavu-sans-mono-fonts-2.35-4.fc26.noarch xemacs-filesystem-21.5.34-22.20170124hgf412e9f093d4.fc26.noarch bash-4.4.12-7.fc26.s390x
freetype-2.7.1-9.fc26.s390x
libSM-1.2.2-5.fc26.s390x
libmpc-1.0.2-6.fc26.s390x
libaio-0.3.110-7.fc26.s390x
libverto-0.2.6-7.fc26.s390x perl-Scalar-List-Utils-1.48-1.fc26.s390x iptables-libs-1.6.1-2.fc26.s390x perl-threads-shared-1.57-1.fc26.s390x p11-kit-trust-0.23.9-2.fc26.s390x
tcl-8.6.6-2.fc26.s390x
libxshmfence-1.2-4.fc26.s390x
expect-5.45-23.fc26.s390x perl-Thread-Queue-3.12-1.fc26.noarch perl-encoding-2.19-6.fc26.s390x
keyutils-1.5.10-1.fc26.s390x
gmp-devel-6.1.2-4.fc26.s390x
enchant-1.6.0-16.fc26.s390x net-snmp-libs-5.7.3-17.fc26.s390x python-gobject-base-3.24.1-1.fc26.s390x python3-distro-1.0.3-1.fc26.noarch python3-enchant-1.6.10-1.fc26.noarch python-lockfile-0.11.0-6.fc26.noarch python2-pyparsing-2.1.10-3.fc26.noarch python2-lxml-4.1.1-1.fc26.s390x librados2-10.2.7-2.fc26.s390x trousers-lib-0.3.13-7.fc26.s390x libpaper-1.1.24-14.fc26.s390x
libdatrie-0.2.9-4.fc26.s390x
libsoup-2.58.2-1.fc26.s390x
passwd-0.79-9.fc26.s390x
bind99-libs-9.9.10-3.P3.fc26.s390x python3-rpm-4.13.0.2-1.fc26.s390x mock-core-configs-27.4-1.fc26.noarch systemd-233-7.fc26.s390x virglrenderer-0.6.0-1.20170210git76b3da97b.fc26.s390x s390utils-ziomon-1.36.1-3.fc26.s390x s390utils-osasnmpd-1.36.1-3.fc26.s390x libXrandr-1.5.1-2.fc26.s390x
libglvnd-glx-1.0.0-1.fc26.s390x texlive-ifxetex-svn19685.0.5-33.fc26.2.noarch texlive-psnfss-svn33946.9.2a-33.fc26.2.noarch texlive-dvipdfmx-def-svn40328-33.fc26.2.noarch texlive-natbib-svn20668.8.31b-33.fc26.2.noarch texlive-xdvi-bin-svn40750-33.20160520.fc26.2.s390x texlive-cm-svn32865.0-33.fc26.2.noarch texlive-beton-svn15878.0-33.fc26.2.noarch texlive-fpl-svn15878.1.002-33.fc26.2.noarch texlive-mflogo-svn38628-33.fc26.2.noarch texlive-texlive-docindex-svn41430-33.fc26.2.noarch texlive-luaotfload-bin-svn34647.0-33.20160520.fc26.2.noarch texlive-koma-script-svn41508-33.fc26.2.noarch texlive-pst-tree-svn24142.1.12-33.fc26.2.noarch texlive-breqn-svn38099.0.98d-33.fc26.2.noarch texlive-xetex-svn41438-33.fc26.2.noarch gstreamer1-plugins-bad-free-1.12.3-1.fc26.s390x xorg-x11-font-utils-7.5-33.fc26.s390x ghostscript-fonts-5.50-36.fc26.noarch libXext-devel-1.3.3-5.fc26.s390x libusbx-devel-1.0.21-2.fc26.s390x libglvnd-devel-1.0.0-1.fc26.s390x
emacs-25.3-3.fc26.s390x
alsa-lib-devel-1.1.4.1-1.fc26.s390x
kbd-2.0.4-2.fc26.s390x
dconf-0.26.0-2.fc26.s390x
ccache-3.3.4-1.fc26.s390x
glibc-static-2.25-12.fc26.s390x
mc-4.8.19-5.fc26.s390x
doxygen-1.8.13-9.fc26.s390x
dpkg-1.18.24-1.fc26.s390x
libtdb-1.3.13-1.fc26.s390x
python2-pynacl-1.1.1-1.fc26.s390x nss-sysinit-3.34.0-1.0.fc26.s390x kernel-4.13.16-202.fc26.s390x
perl-Filter-1.58-1.fc26.s390x python2-pip-9.0.1-11.fc26.noarch
dnf-2.7.5-2.fc26.noarch
pcre2-utf16-10.23-11.fc26.s390x glusterfs-devel-3.10.8-1.fc26.s390x sssd-common-1.16.0-4.fc26.s390x python2-sssdconfig-1.16.0-4.fc26.noarch acpica-tools-20171110-1.fc26.s390x glibc-debuginfo-2.24-10.fc25.s390x
fedora-repos-26-1.noarch dejavu-fonts-common-2.35-4.fc26.noarch bind99-license-9.9.10-3.P3.fc26.noarch ncurses-libs-6.0-8.20170212.fc26.s390x libpng-1.6.28-2.fc26.s390x
libICE-1.0.9-9.fc26.s390x
kmod-24-1.fc26.s390x
libseccomp-2.3.2-1.fc26.s390x perl-Text-ParseWords-3.30-366.fc26.noarch libtool-ltdl-2.4.6-17.fc26.s390x perl-threads-2.16-1.fc26.s390x libselinux-utils-2.6-7.fc26.s390x userspace-rcu-0.9.3-2.fc26.s390x
libXfont-1.5.2-5.fc26.s390x perl-Class-Inspector-1.31-3.fc26.noarch perl-open-1.10-395.fc26.noarch keyutils-libs-devel-1.5.10-1.fc26.s390x isl-0.16.1-1.fc26.s390x
libsecret-0.18.5-3.fc26.s390x compat-openssl10-1.0.2m-1.fc26.s390x python3-iniparse-0.4-24.fc26.noarch python3-dateutil-2.6.0-3.fc26.noarch python3-firewall-0.4.4.5-1.fc26.noarch python-enum34-1.1.6-1.fc26.noarch python2-pygments-2.2.0-7.fc26.noarch python2-dockerfile-parse-0.0.7-1.fc26.noarch perl-Net-SSLeay-1.81-1.fc26.s390x
hostname-3.18-2.fc26.s390x
libtirpc-1.0.2-0.fc26.s390x rpm-build-libs-4.13.0.2-1.fc26.s390x libutempter-1.1.6-9.fc26.s390x
systemd-pam-233-7.fc26.s390x
pcre-utf16-8.41-3.fc26.s390x
libXinerama-1.1.3-7.fc26.s390x mesa-libGL-17.2.4-2.fc26.s390x texlive-amsfonts-svn29208.3.04-33.fc26.2.noarch texlive-caption-svn41409-33.fc26.2.noarch texlive-enumitem-svn24146.3.5.2-33.fc26.2.noarch texlive-pdftex-def-svn22653.0.06d-33.fc26.2.noarch texlive-xdvi-svn40768-33.fc26.2.noarch texlive-courier-svn35058.0-33.fc26.2.noarch texlive-charter-svn15878.0-33.fc26.2.noarch texlive-graphics-def-svn41879-33.fc26.2.noarch texlive-mfnfss-svn19410.0-33.fc26.2.noarch texlive-texlive-en-svn41185-33.fc26.2.noarch texlive-ifplatform-svn21156.0.4-33.fc26.2.noarch texlive-ms-svn29849.0-33.fc26.2.noarch texlive-pst-tools-svn34067.0.05-33.fc26.2.noarch texlive-powerdot-svn38984-33.fc26.2.noarch texlive-xetexconfig-svn41133-33.fc26.2.noarch libvdpau-1.1.1-4.fc26.s390x
zlib-devel-1.2.11-2.fc26.s390x gdk-pixbuf2-devel-2.36.9-1.fc26.s390x libX11-devel-1.6.5-2.fc26.s390x libtasn1-devel-4.12-1.fc26.s390x libglvnd-core-devel-1.0.0-1.fc26.s390x SDL2-devel-2.0.7-2.fc26.s390x
webkitgtk3-2.4.11-5.fc26.s390x
grubby-8.40-4.fc26.s390x
uboot-tools-2017.05-4.fc26.s390x cracklib-dicts-2.9.6-5.fc26.s390x
texinfo-6.3-3.fc26.s390x
time-1.7-52.fc26.s390x
python2-deltarpm-3.6-19.fc26.s390x
nss-3.34.0-1.0.fc26.s390x
webkitgtk4-2.18.3-1.fc26.s390x net-tools-2.0-0.43.20160912git.fc26.s390x python2-setuptools-37.0.0-1.fc26.noarch python2-dnf-2.7.5-2.fc26.noarch
pcre2-10.23-11.fc26.s390x
groff-base-1.22.3-10.fc26.s390x python2-devel-2.7.14-4.fc26.s390x python2-GitPython-2.1.7-2.fc26.noarch boost-iostreams-1.63.0-10.fc26.s390x gpg-pubkey-efe550f5-5220ba41
gpg-pubkey-81b46521-55b3ca9a
filesystem-3.2-40.fc26.s390x
basesystem-11-3.fc26.noarch
js-jquery-3.2.1-1.fc26.noarch
pcre-8.41-3.fc26.s390x
elfutils-libelf-0.169-1.fc26.s390x
libidn-1.33-2.fc26.s390x
libogg-1.3.2-6.fc26.s390x
slang-2.3.1a-2.fc26.s390x
apr-1.6.3-1.fc26.s390x
libxkbcommon-0.7.1-3.fc26.s390x
perl-IO-1.36-395.fc26.s390x
libvorbis-1.3.5-2.fc26.s390x
less-487-3.fc26.s390x
lttng-ust-2.9.0-2.fc26.s390x
OpenEXR-libs-2.2.0-6.fc26.s390x
ipset-libs-6.29-3.fc26.s390x perl-XML-XPath-1.42-1.fc26.noarch lua-filesystem-1.6.3-3.fc24.s390x
sqlite-3.20.1-1.fc26.s390x
gstreamer1-1.12.3-1.fc26.s390x libpwquality-1.3.0-8.fc26.s390x gettext-libs-0.19.8.1-9.fc26.s390x python3-chardet-2.3.0-3.fc26.noarch python3-slip-dbus-0.6.4-6.fc26.noarch python-chardet-2.3.0-3.fc26.noarch python2-pyasn1-0.2.3-1.fc26.noarch python-slip-dbus-0.6.4-6.fc26.noarch libarchive-3.2.2-4.fc26.s390x libbabeltrace-1.5.2-2.fc26.s390x cdparanoia-libs-10.2-22.fc26.s390x krb5-workstation-1.15.2-4.fc26.s390x python3-requests-kerberos-0.10.0-4.fc26.noarch gpgme-1.8.0-12.fc26.s390x
python2-gpg-1.8.0-12.fc26.s390x shadow-utils-4.3.1-3.fc26.s390x cryptsetup-libs-1.7.5-1.fc26.s390x kpartx-0.4.9-88.fc26.s390x net-snmp-agent-libs-5.7.3-17.fc26.s390x libXi-1.7.9-2.fc26.s390x texlive-tetex-svn41059-33.fc26.2.noarch texlive-tools-svn40934-33.fc26.2.noarch texlive-bibtex-bin-svn40473-33.20160520.fc26.2.s390x texlive-mfware-bin-svn40473-33.20160520.fc26.2.s390x texlive-underscore-svn18261.0-33.fc26.2.noarch texlive-avantgar-svn31835.0-33.fc26.2.noarch texlive-anysize-svn15878.0-33.fc26.2.noarch texlive-lineno-svn21442.4.41-33.fc26.2.noarch texlive-mathpazo-svn15878.1.003-33.fc26.2.noarch texlive-soul-svn15878.2.4-33.fc26.2.noarch texlive-luatexbase-svn38550-33.fc26.2.noarch texlive-listings-svn37534.1.6-33.fc26.2.noarch texlive-pstricks-svn41321-33.fc26.2.noarch texlive-metalogo-svn18611.0.12-33.fc26.2.noarch texlive-dvipdfmx-svn41149-33.fc26.2.noarch kbd-legacy-2.0.4-2.fc26.noarch nspr-devel-4.17.0-1.fc26.s390x ghostscript-x11-9.20-10.fc26.s390x libXrender-devel-0.9.10-2.fc26.s390x libxkbcommon-devel-0.7.1-3.fc26.s390x mesa-libGL-devel-17.2.4-2.fc26.s390x sqlite-devel-3.20.1-1.fc26.s390x usbredir-devel-0.7.1-3.fc26.s390x libcap-devel-2.25-5.fc26.s390x brlapi-devel-0.6.6-5.fc26.s390x fedora-upgrade-27.1-1.fc26.noarch python3-pygpgme-0.3-22.fc26.s390x pinentry-0.9.7-3.fc26.s390x perl-Test-Harness-3.39-1.fc26.noarch qemu-sanity-check-nodeps-1.1.5-6.fc26.s390x libldb-1.1.29-5.fc26.s390x
python-libxml2-2.9.4-2.fc26.s390x nss-util-devel-3.34.0-1.0.fc26.s390x vim-filesystem-8.0.1360-1.fc26.s390x webkitgtk4-plugin-process-gtk2-2.18.3-1.fc26.s390x python2-2.7.14-4.fc26.s390x libwayland-cursor-1.13.0-3.fc26.s390x mariadb-config-10.1.29-1.fc26.s390x gdb-headless-8.0.1-33.fc26.s390x pulseaudio-libs-devel-11.1-7.fc26.s390x curl-7.53.1-13.fc26.s390x
json-c-0.12.1-5.fc26.s390x
gpg-pubkey-34ec9cba-54e38751
gpg-pubkey-030d5aed-55b577f0
setup-2.10.5-2.fc26.noarch
lato-fonts-2.015-3.fc26.noarch web-assets-filesystem-5-5.fc26.noarch libsepol-2.6-2.fc26.s390x
libcap-2.25-5.fc26.s390x
tcp_wrappers-libs-7.6-85.fc26.s390x libnl3-3.3.0-1.fc26.s390x
pixman-0.34.0-3.fc26.s390x
lzo-2.08-9.fc26.s390x
perl-5.24.3-395.fc26.s390x
libnl3-cli-3.3.0-1.fc26.s390x
gpm-libs-1.20.7-10.fc26.s390x
libgo-7.2.1-2.fc26.s390x
iso-codes-3.74-2.fc26.noarch
ipset-6.29-3.fc26.s390x
lua-term-0.07-1.fc25.s390x
libdb-utils-5.3.28-24.fc26.s390x system-python-libs-3.6.3-2.fc26.s390x dbus-glib-0.108-2.fc26.s390x
pam-1.3.0-2.fc26.s390x
avahi-glib-0.6.32-7.fc26.s390x python2-dateutil-2.6.0-3.fc26.noarch python3-asn1crypto-0.23.0-1.fc26.noarch python3-slip-0.6.4-6.fc26.noarch python-backports-ssl_match_hostname-3.5.0.1-4.fc26.noarch python2-pyOpenSSL-16.2.0-6.fc26.noarch python-slip-0.6.4-6.fc26.noarch
nss-pem-1.0.3-3.fc26.s390x
fipscheck-1.5.0-1.fc26.s390x
elfutils-0.169-1.fc26.s390x cyrus-sasl-lib-2.1.26-32.fc26.s390x libkadm5-1.15.2-4.fc26.s390x python3-kerberos-1.2.5-3.fc26.s390x rpmconf-1.0.19-1.fc26.noarch
libsemanage-2.6-4.fc26.s390x device-mapper-libs-1.02.137-6.fc26.s390x yum-3.4.3-512.fc26.noarch device-mapper-multipath-0.4.9-88.fc26.s390x net-snmp-5.7.3-17.fc26.s390x
libXtst-1.2.3-2.fc26.s390x
libXxf86vm-1.1.4-4.fc26.s390x texlive-amsmath-svn41561-33.fc26.2.noarch texlive-xkeyval-svn35741.2.7a-33.fc26.2.noarch texlive-bibtex-svn40768-33.fc26.2.noarch texlive-mfware-svn40768-33.fc26.2.noarch texlive-wasy-svn35831.0-33.fc26.2.noarch texlive-bookman-svn31835.0-33.fc26.2.noarch texlive-babel-english-svn30264.3.3p-33.fc26.2.noarch texlive-fix2col-svn38770-33.fc26.2.noarch texlive-mdwtools-svn15878.1.05.4-33.fc26.2.noarch texlive-tex-gyre-math-svn41264-33.fc26.2.noarch texlive-luaotfload-svn40902-33.fc26.2.noarch texlive-showexpl-svn32737.v0.3l-33.fc26.2.noarch texlive-pstricks-add-svn40744-33.fc26.2.noarch texlive-l3experimental-svn41163-33.fc26.2.noarch texlive-xetex-bin-svn41091-33.20160520.fc26.2.s390x kbd-misc-2.0.4-2.fc26.noarch libpng-devel-1.6.28-2.fc26.s390x ghostscript-core-9.20-10.fc26.s390x libXfixes-devel-5.0.3-2.fc26.s390x libverto-devel-0.2.6-7.fc26.s390x mesa-libEGL-devel-17.2.4-2.fc26.s390x popt-devel-1.16-12.fc26.s390x readline-devel-7.0-5.fc26.s390x cyrus-sasl-devel-2.1.26-32.fc26.s390x sendmail-8.15.2-19.fc26.s390x systemd-bootchart-231-3.fc26.s390x perl-IO-Socket-SSL-2.049-1.fc26.noarch python2-enchant-1.6.10-1.fc26.noarch perl-generators-1.10-2.fc26.noarch createrepo-0.10.3-11.fc26.noarch webkitgtk4-jsc-2.18.3-1.fc26.s390x vim-common-8.0.1360-1.fc26.s390x nss-tools-3.34.0-1.0.fc26.s390x glusterfs-api-3.10.8-1.fc26.s390x pulseaudio-libs-glib2-11.1-7.fc26.s390x mariadb-common-10.1.29-1.fc26.s390x dhcp-libs-4.3.5-10.fc26.s390x pcre2-devel-10.23-11.fc26.s390x
libtiff-4.0.9-1.fc26.s390x kernel-headers-4.14.8-200.fc26.s390x fontpackages-filesystem-1.44-18.fc26.noarch vte-profile-0.48.4-1.fc26.s390x texlive-kpathsea-doc-svn41139-33.fc26.2.noarch zlib-1.2.11-2.fc26.s390x
readline-7.0-5.fc26.s390x
libattr-2.4.47-18.fc26.s390x
libgomp-7.2.1-2.fc26.s390x
libglvnd-1.0.0-1.fc26.s390x
lz4-libs-1.8.0-1.fc26.s390x
libcrypt-nss-2.25-12.fc26.s390x
jansson-2.10-2.fc26.s390x perl-File-Path-2.12-367.fc26.noarch perl-Unicode-EastAsianWidth-1.33-9.fc26.noarch hunspell-1.5.4-2.fc26.s390x
libasyncns-0.8-11.fc26.s390x libnetfilter_conntrack-1.0.6-2.fc26.s390x perl-Storable-2.56-368.fc26.s390x autoconf-2.69-24.fc26.noarch device-mapper-persistent-data-0.6.3-5.fc26.s390x quota-4.03-9.fc26.s390x crypto-policies-20170606-1.git7c32281.fc26.noarch glib2-2.52.3-2.fc26.s390x
python2-idna-2.5-1.fc26.noarch python2-libcomps-0.1.8-3.fc26.s390x gsettings-desktop-schemas-3.24.1-1.fc26.s390x javapackages-tools-4.7.0-17.fc26.noarch libselinux-python3-2.6-7.fc26.s390x python-backports-1.0-9.fc26.s390x python2-cryptography-2.0.2-2.fc26.s390x libselinux-python-2.6-7.fc26.s390x
Lmod-7.5.3-1.fc26.s390x
fipscheck-lib-1.5.0-1.fc26.s390x elfutils-libs-0.169-1.fc26.s390x krb5-libs-1.15.2-4.fc26.s390x
libuser-0.62-6.fc26.s390x python2-requests-kerberos-0.10.0-4.fc26.noarch npth-1.5-1.fc26.s390x
packagedb-cli-2.14.1-2.fc26.noarch
ustr-1.0.4-22.fc26.s390x
device-mapper-1.02.137-6.fc26.s390x polkit-pkla-compat-0.1-8.fc26.s390x fakeroot-1.22-1.fc26.s390x
libXmu-1.1.2-5.fc26.s390x
cairo-gobject-1.14.10-1.fc26.s390x texlive-booktabs-svn40846-33.fc26.2.noarch texlive-dvips-bin-svn40987-33.20160520.fc26.2.s390x texlive-float-svn15878.1.3d-33.fc26.2.noarch texlive-tex-svn40793-33.fc26.2.noarch texlive-fancyref-svn15878.0.9c-33.fc26.2.noarch texlive-manfnt-font-svn35799.0-33.fc26.2.noarch texlive-cmap-svn41168-33.fc26.2.noarch texlive-hyph-utf8-svn41189-33.fc26.2.noarch texlive-paralist-svn39247-33.fc26.2.noarch texlive-trimspaces-svn15878.1.1-33.fc26.2.noarch texlive-tipa-svn29349.1.3-33.fc26.2.noarch texlive-l3packages-svn41246-33.fc26.2.noarch texlive-pst-pdf-svn31660.1.1v-33.fc26.2.noarch texlive-tex-gyre-svn18651.2.004-33.fc26.2.noarch texlive-beamer-svn36461.3.36-33.fc26.2.noarch gd-2.2.5-1.fc26.s390x elfutils-libelf-devel-0.169-1.fc26.s390x gc-devel-7.6.0-2.fc26.s390x
libXft-devel-2.3.2-5.fc26.s390x krb5-devel-1.15.2-4.fc26.s390x rpm-devel-4.13.0.2-1.fc26.s390x pcre-static-8.41-3.fc26.s390x bluez-libs-devel-5.46-6.fc26.s390x systemtap-3.2-2.fc26.s390x
trousers-0.3.13-7.fc26.s390x
iproute-tc-4.11.0-1.fc26.s390x python2-sphinx-1.5.5-1.fc26.noarch libgnome-keyring-3.12.0-8.fc26.s390x perl-File-ShareDir-1.102-8.fc26.noarch python2-paramiko-2.2.1-1.fc26.noarch python2-openidc-client-0.4.0-1.20171113git54dee6e.fc26.noarch openssh-server-7.5p1-4.fc26.s390x pulseaudio-libs-11.1-7.fc26.s390x python2-bodhi-2.12.2-3.fc26.noarch lua-libs-5.3.4-7.fc26.s390x
dhcp-common-4.3.5-10.fc26.noarch python3-pip-9.0.1-11.fc26.noarch python3-sssdconfig-1.16.0-4.fc26.noarch gpg-pubkey-95a43f54-5284415a
gpg-pubkey-fdb19c98-56fd6333
gpg-pubkey-64dab85d-57d33e22
tzdata-2017c-1.fc26.noarch firewalld-filesystem-0.4.4.5-1.fc26.noarch xkeyboard-config-2.21-3.fc26.noarch texlive-texlive-common-doc-svn40682-33.fc26.2.noarch ncurses-base-6.0-8.20170212.fc26.noarch libselinux-2.6-7.fc26.s390x
bzip2-libs-1.0.6-22.fc26.s390x
libdb-5.3.28-24.fc26.s390x
mpfr-3.1.5-3.fc26.s390x
file-libs-5.30-11.fc26.s390x
libunistring-0.9.7-1.fc26.s390x
libxslt-1.1.29-1.fc26.s390x
libtasn1-4.12-1.fc26.s390x
gdbm-1.13-1.fc26.s390x
libepoxy-1.4.3-1.fc26.s390x
libpsl-0.18.0-1.fc26.s390x
perl-Carp-1.40-366.fc26.noarch e2fsprogs-libs-1.43.4-2.fc26.s390x
libmnl-1.0.4-2.fc26.s390x
openjpeg2-2.2.0-3.fc26.s390x perl-PathTools-3.63-367.fc26.s390x perl-File-Temp-0.230.400-2.fc26.noarch perl-XML-Parser-2.44-6.fc26.s390x
libss-1.43.4-2.fc26.s390x
ilmbase-2.2.0-8.fc26.s390x
fuse-libs-2.9.7-2.fc26.s390x
libdaemon-0.14-11.fc26.s390x libbasicobjects-0.1.1-34.fc26.s390x iptables-1.6.1-2.fc26.s390x perl-TermReadKey-2.37-2.fc26.s390x perl-Term-ANSIColor-4.06-2.fc26.noarch perl-libintl-perl-1.26-2.fc26.s390x usbredir-0.7.1-3.fc26.s390x fftw-libs-double-3.3.5-4.fc26.s390x
rsync-3.1.2-5.fc26.s390x
libiscsi-1.15.0-3.fc26.s390x
ttmkfdir-3.0.9-49.fc26.s390x texlive-base-2016-33.20160520.fc26.1.noarch python2-six-1.10.0-9.fc26.noarch
atk-2.24.0-1.fc26.s390x
python2-kitchen-1.2.4-6.fc26.noarch guile-2.0.14-1.fc26.s390x desktop-file-utils-0.23-3.fc26.s390x pyxattr-0.5.3-10.fc26.s390x shared-mime-info-1.8-2.fc26.s390x
libyaml-0.1.7-2.fc26.s390x
python3-PyYAML-3.12-3.fc26.s390x
openssh-7.5p1-4.fc26.s390x kernel-core-4.13.16-202.fc26.s390x perl-Git-2.13.6-2.fc26.noarch python3-dnf-plugins-extras-common-2.0.4-1.fc26.noarch openssl-1.1.0g-1.fc26.s390x
gawk-4.1.4-6.fc26.s390x
gnutls-3.5.16-4.fc26.s390x
openldap-2.4.45-2.fc26.s390x bind-license-9.11.1-4.P3.fc26.noarch python2-gluster-3.10.8-1.fc26.s390x selinux-policy-3.13.1-260.17.fc26.noarch linux-firmware-20171215-81.git2451bb22.fc26.noarch libpkgconf-1.3.12-1.fc26.s390x NetworkManager-libnm-1.8.2-4.fc26.s390x gnutls-devel-3.5.16-4.fc26.s390x mariadb-libs-10.1.29-1.fc26.s390x python2-urllib3-1.20-2.fc26.noarch sssd-nfs-idmap-1.16.0-4.fc26.s390x libsss_sudo-1.16.0-4.fc26.s390x
libgudev-232-1.fc26.s390x
python3-libs-3.6.3-2.fc26.s390x python3-javapackages-4.7.0-17.fc26.noarch python3-ply-3.9-3.fc26.noarch python3-systemd-234-1.fc26.s390x python3-requests-2.13.0-1.fc26.noarch blktrace-1.1.0-4.fc26.s390x python2-asn1crypto-0.23.0-1.fc26.noarch python2-cffi-1.9.1-2.fc26.s390x python2-sphinx_rtd_theme-0.2.4-1.fc26.noarch lua-json-1.3.2-7.fc26.noarch
libcephfs1-10.2.7-2.fc26.s390x glib-networking-2.50.0-2.fc26.s390x elfutils-default-yama-scope-0.169-1.fc26.noarch GeoIP-GeoLite-data-2017.10-1.fc26.noarch libedit-3.1-17.20160618cvs.fc26.s390x libverto-libev-0.2.6-7.fc26.s390x
libserf-1.3.9-3.fc26.s390x
createrepo_c-0.10.0-9.fc26.s390x python2-kerberos-1.2.5-3.fc26.s390x libsrtp-1.5.4-4.fc26.s390x
lzo-minilzo-2.08-9.fc26.s390x
librepo-1.8.0-1.fc26.s390x
koji-1.14.0-1.fc26.noarch
sg3_utils-1.42-1.fc26.s390x
libobjc-7.2.1-2.fc26.s390x
policycoreutils-2.6-6.fc26.s390x
libdrm-2.4.88-1.fc26.s390x kernel-core-4.13.13-200.fc26.s390x systemtap-client-3.2-2.fc26.s390x
lvm2-2.02.168-6.fc26.s390x device-mapper-multipath-libs-0.4.9-88.fc26.s390x libfdt-1.4.5-1.fc26.s390x s390utils-cmsfs-1.36.1-3.fc26.s390x libXdamage-1.1.4-9.fc26.s390x
libXaw-1.0.13-5.fc26.s390x
brltty-5.5-5.fc26.s390x
librsvg2-2.40.18-1.fc26.s390x texlive-tetex-bin-svn36770.0-33.20160520.fc26.2.noarch texlive-etex-pkg-svn39355-33.fc26.2.noarch texlive-graphics-svn41015-33.fc26.2.noarch texlive-dvips-svn41149-33.fc26.2.noarch texlive-zapfding-svn31835.0-33.fc26.2.noarch texlive-footmisc-svn23330.5.5b-33.fc26.2.noarch texlive-makeindex-svn40768-33.fc26.2.noarch texlive-pst-ovl-svn40873-33.fc26.2.noarch texlive-texlive-scripts-svn41433-33.fc26.2.noarch texlive-ltabptch-svn17533.1.74d-33.fc26.2.noarch texlive-euro-svn22191.1.1-33.fc26.2.noarch texlive-mflogo-font-svn36898.1.002-33.fc26.2.noarch texlive-zapfchan-svn31835.0-33.fc26.2.noarch texlive-cmextra-svn32831.0-33.fc26.2.noarch texlive-finstrut-svn21719.0.5-33.fc26.2.noarch texlive-hyphen-base-svn41138-33.fc26.2.noarch texlive-marginnote-svn41382-33.fc26.2.noarch texlive-parallel-svn15878.0-33.fc26.2.noarch texlive-sepnum-svn20186.2.0-33.fc26.2.noarch texlive-environ-svn33821.0.3-33.fc26.2.noarch texlive-type1cm-svn21820.0-33.fc26.2.noarch texlive-xunicode-svn30466.0.981-33.fc26.2.noarch texlive-attachfile-svn38830-33.fc26.2.noarch texlive-fontspec-svn41262-33.fc26.2.noarch texlive-fancyvrb-svn18492.2.8-33.fc26.2.noarch texlive-pst-pdf-bin-svn7838.0-33.20160520.fc26.2.noarch texlive-xcolor-svn41044-33.fc26.2.noarch texlive-pdfpages-svn40638-33.fc26.2.noarch texlive-sansmathaccent-svn30187.0-33.fc26.2.noarch texlive-ucs-svn35853.2.2-33.fc26.2.noarch texlive-dvipdfmx-bin-svn40273-33.20160520.fc26.2.s390x libotf-0.9.13-8.fc26.s390x
go-srpm-macros-2-8.fc26.noarch
pcre-devel-8.41-3.fc26.s390x mesa-libwayland-egl-devel-17.2.4-2.fc26.s390x ghostscript-9.20-10.fc26.s390x libcephfs_jni-devel-10.2.7-2.fc26.s390x libXdamage-devel-1.1.4-9.fc26.s390x freetype-devel-2.7.1-9.fc26.s390x ncurses-devel-6.0-8.20170212.fc26.s390x fontconfig-devel-2.12.6-4.fc26.s390x cairo-devel-1.14.10-1.fc26.s390x libselinux-devel-2.6-7.fc26.s390x guile-devel-2.0.14-1.fc26.s390x libcap-ng-devel-0.7.8-3.fc26.s390x bash-completion-2.6-1.fc26.noarch libXevie-1.0.3-12.fc26.s390x
kernel-4.13.13-200.fc26.s390x
audit-2.8.1-1.fc26.s390x
gcc-objc-7.2.1-2.fc26.s390x
gcc-go-7.2.1-2.fc26.s390x python-firewall-0.4.4.5-1.fc26.noarch python3-html5lib-0.999-13.fc26.noarch python2-simplejson-3.10.0-3.fc26.s390x flex-2.6.1-3.fc26.s390x
telnet-0.17-69.fc26.s390x
gpg-pubkey-8e1431d5-53bcbac7 emacs-filesystem-25.3-3.fc26.noarch fontawesome-fonts-4.7.0-2.fc26.noarch fontawesome-fonts-web-4.7.0-2.fc26.noarch tzdata-java-2017c-1.fc26.noarch rpmconf-base-1.0.19-1.fc26.noarch
glibc-2.25-12.fc26.s390x
info-6.3-3.fc26.s390x
sqlite-libs-3.20.1-1.fc26.s390x texlive-lib-2016-33.20160520.fc26.1.s390x sed-4.4-1.fc26.s390x
libicu-57.1-7.fc26.s390x
libcap-ng-0.7.8-3.fc26.s390x
nettle-3.3-2.fc26.s390x
libidn2-2.0.4-1.fc26.s390x
lcms2-2.8-3.fc26.s390x
dbus-libs-1.11.18-1.fc26.s390x perl-Exporter-5.72-367.fc26.noarch
unzip-6.0-34.fc26.s390x
iproute-4.11.0-1.fc26.s390x
zip-3.0-18.fc26.s390x
perl-constant-1.33-368.fc26.noarch perl-MIME-Base64-3.15-366.fc26.s390x lua-posix-33.3.1-4.fc26.s390x
bzip2-1.0.6-22.fc26.s390x
libstdc++-devel-7.2.1-2.fc26.s390x
hyphen-2.8.8-6.fc26.s390x
libdvdread-5.0.3-4.fc26.s390x libcollection-0.7.0-34.fc26.s390x libdvdnav-5.0.3-5.fc26.s390x perl-version-0.99.18-1.fc26.s390x perl-Encode-2.88-6.fc26.s390x
automake-1.15-9.fc26.noarch plymouth-core-libs-0.9.3-0.7.20160620git0e65b86c.fc26.s390x hesiod-3.2.1-7.fc26.s390x
jasper-libs-2.0.14-1.fc26.s390x
mozjs17-17.0.0-18.fc26.s390x
fontconfig-2.12.6-4.fc26.s390x
harfbuzz-1.4.4-1.fc26.s390x
alsa-lib-1.1.4.1-1.fc26.s390x
make-4.2.1-2.fc26.s390x gobject-introspection-1.52.1-1.fc26.s390x hicolor-icon-theme-0.15-5.fc26.noarch gdk-pixbuf2-2.36.9-1.fc26.s390x
libgusb-0.2.11-1.fc26.s390x
libtalloc-2.1.10-2.fc26.s390x
libdhash-0.5.0-34.fc26.s390x python2-bcrypt-3.1.4-2.fc26.s390x
PyYAML-3.12-3.fc26.s390x nss-softokn-freebl-3.34.0-1.0.fc26.s390x kernel-modules-4.13.16-202.fc26.s390x git-2.13.6-2.fc26.s390x
gnupg2-smime-2.2.3-1.fc26.s390x openssl-devel-1.1.0g-1.fc26.s390x python2-dnf-plugins-extras-common-2.0.4-1.fc26.noarch copy-jdk-configs-3.3-2.fc26.noarch glusterfs-client-xlators-3.10.8-1.fc26.s390x libcurl-7.53.1-13.fc26.s390x bind-libs-lite-9.11.1-4.P3.fc26.s390x glusterfs-extra-xlators-3.10.8-1.fc26.s390x python3-setuptools-37.0.0-1.fc26.noarch kernel-core-4.14.8-200.fc26.s390x pkgconf-1.3.12-1.fc26.s390x NetworkManager-1.8.2-4.fc26.s390x libjpeg-turbo-devel-1.5.3-1.fc26.s390x lua-5.3.4-7.fc26.s390x
boost-thread-1.63.0-10.fc26.s390x
wget-1.19.2-2.fc26.s390x
libwebp-0.6.1-1.fc26.s390x kernel-devel-4.14.8-200.fc26.s390x python3-lxml-4.1.1-1.fc26.s390x python3-ordered-set-2.0.0-6.fc26.noarch python3-rpmconf-1.0.19-1.fc26.noarch python-offtrac-0.1.0-9.fc26.noarch python2-pycparser-2.14-10.fc26.noarch python2-sphinx-theme-alabaster-0.7.9-3.fc26.noarch python2-pysocks-1.6.7-1.fc26.noarch lua-lpeg-1.0.1-2.fc26.s390x
poppler-0.52.0-10.fc26.s390x
libproxy-0.4.15-2.fc26.s390x crontabs-1.11-14.20150630git.fc26.noarch java-1.8.0-openjdk-headless-1.8.0.151-1.b12.fc26.s390x libev-4.24-2.fc26.s390x
libsigsegv-2.11-1.fc26.s390x fedora-cert-0.6.0.1-2.fc26.noarch
drpm-0.3.0-6.fc26.s390x createrepo_c-libs-0.10.0-9.fc26.s390x python2-cccolutils-1.5-3.fc26.s390x m17n-lib-1.7.0-6.fc26.s390x
lsscsi-0.28-4.fc26.s390x
python2-koji-1.14.0-1.fc26.noarch python3-koji-1.14.0-1.fc26.noarch python3-gpg-1.8.0-12.fc26.s390x sg3_utils-libs-1.42-1.fc26.s390x
SDL2-2.0.7-2.fc26.s390x
util-linux-2.30.2-1.fc26.s390x rpcbind-0.2.4-8.rc2.fc26.s390x s390utils-mon_statd-1.36.1-3.fc26.s390x GConf2-3.2.6-17.fc26.s390x systemd-container-233-7.fc26.s390x usermode-1.111-9.fc26.s390x
pcre-utf32-8.41-3.fc26.s390x
libXt-1.1.5-4.fc26.s390x
libXpm-3.5.12-2.fc26.s390x
at-spi2-core-2.24.1-1.fc26.s390x
cairo-1.14.10-1.fc26.s390x texlive-kpathsea-bin-svn40473-33.20160520.fc26.2.s390x texlive-ifluatex-svn41346-33.fc26.2.noarch texlive-babel-svn40706-33.fc26.2.noarch texlive-colortbl-svn29803.v1.0a-33.fc26.2.noarch texlive-marvosym-svn29349.2.2a-33.fc26.2.noarch texlive-euler-svn17261.2.5-33.fc26.2.noarch texlive-latexconfig-svn40274-33.fc26.2.noarch texlive-plain-svn40274-33.fc26.2.noarch texlive-texconfig-bin-svn29741.0-33.20160520.fc26.2.noarch giflib-4.1.6-16.fc26.s390x texlive-microtype-svn41127-33.fc26.2.noarch texlive-eurosym-svn17265.1.4_subrfix-33.fc26.2.noarch texlive-symbol-svn31835.0-33.fc26.2.noarch texlive-chngcntr-svn17157.1.0a-33.fc26.2.noarch texlive-euenc-svn19795.0.1h-33.fc26.2.noarch texlive-luatex-svn40963-33.fc26.2.noarch texlive-knuth-local-svn38627-33.fc26.2.noarch texlive-mparhack-svn15878.1.4-33.fc26.2.noarch texlive-rcs-svn15878.0-33.fc26.2.noarch texlive-texlive-msg-translations-svn41431-33.fc26.2.noarch texlive-updmap-map-svn41159-33.fc26.2.noarch texlive-geometry-svn19716.5.6-33.fc26.2.noarch texlive-memoir-svn41203-33.fc26.2.noarch texlive-l3kernel-svn41246-33.fc26.2.noarch texlive-pst-eps-svn15878.1.0-33.fc26.2.noarch texlive-pst-text-svn15878.1.00-33.fc26.2.noarch texlive-amscls-svn36804.0-33.fc26.2.noarch texlive-pst-slpe-svn24391.1.31-33.fc26.2.noarch texlive-extsizes-svn17263.1.4a-33.fc26.2.noarch texlive-xetex-def-svn40327-33.fc26.2.noarch texlive-collection-latex-svn41011-33.20160520.fc26.2.noarch gstreamer1-plugins-base-1.12.3-1.fc26.s390x fpc-srpm-macros-1.1-2.fc26.noarch xorg-x11-proto-devel-7.7-22.fc26.noarch urw-fonts-2.4-23.fc26.noarch
atk-devel-2.24.0-1.fc26.s390x ImageMagick-libs-6.9.9.22-1.fc26.s390x libxcb-devel-1.12-3.fc26.s390x libXrandr-devel-1.5.1-2.fc26.s390x libcom_err-devel-1.43.4-2.fc26.s390x dbus-devel-1.11.18-1.fc26.s390x libepoxy-devel-1.4.3-1.fc26.s390x libicu-devel-57.1-7.fc26.s390x p11-kit-devel-0.23.9-2.fc26.s390x rpm-build-4.13.0.2-1.fc26.s390x libssh2-devel-1.8.0-5.fc26.s390x graphviz-2.40.1-4.fc26.s390x
zlib-static-1.2.11-2.fc26.s390x mesa-libgbm-devel-17.2.4-2.fc26.s390x dracut-config-rescue-046-3.1.fc26.s390x screen-4.6.2-1.fc26.s390x python-osbs-client-0.39.1-1.fc26.noarch gcc-gdb-plugin-7.2.1-2.fc26.s390x pyparsing-2.1.10-3.fc26.noarch python3-pyasn1-0.2.3-1.fc26.noarch python2-html5lib-0.999-13.fc26.noarch teamd-1.27-1.fc26.s390x
hardlink-1.3-1.fc26.s390x
chrpath-0.16-4.fc26.s390x
libgcc-7.2.1-2.fc26.s390x
python-rpm-macros-3-20.fc26.noarch texlive-pdftex-doc-svn41149-33.fc26.2.noarch glibc-common-2.25-12.fc26.s390x
libstdc++-7.2.1-2.fc26.s390x
nspr-4.17.0-1.fc26.s390x
grep-3.1-1.fc26.s390x
libgcrypt-1.7.9-1.fc26.s390x
libacl-2.2.52-15.fc26.s390x
cpio-2.12-4.fc26.s390x
libatomic_ops-7.4.4-2.fc26.s390x
p11-kit-0.23.9-2.fc26.s390x
gc-7.6.0-2.fc26.s390x
psmisc-22.21-9.fc26.s390x
systemd-libs-233-7.fc26.s390x
xz-5.2.3-2.fc26.s390x
perl-libs-5.24.3-395.fc26.s390x
kmod-libs-24-1.fc26.s390x
libpcap-1.8.1-3.fc26.s390x
perl-macros-5.24.3-395.fc26.s390x perl-parent-0.236-2.fc26.noarch perl-Text-Unidecode-1.30-2.fc26.noarch newt-0.52.20-1.fc26.s390x
libcomps-0.1.8-3.fc26.s390x
libfontenc-1.1.3-4.fc26.s390x
ipcalc-0.2.0-1.fc26.s390x
libnfnetlink-1.0.1-9.fc26.s390x libref_array-0.1.5-34.fc26.s390x perl-Term-Cap-1.17-366.fc26.noarch perl-Digest-1.17-367.fc26.noarch perl-SelfLoader-1.23-395.fc26.noarch perl-Pod-Simple-3.35-2.fc26.noarch perl-URI-1.71-6.fc26.noarch
cpp-7.2.1-2.fc26.s390x
attr-2.4.47-18.fc26.s390x
gmp-c++-6.1.2-4.fc26.s390x xapian-core-libs-1.4.4-1.fc26.s390x system-python-3.6.3-2.fc26.s390x harfbuzz-icu-1.4.4-1.fc26.s390x libtevent-0.9.34-1.fc26.s390x
http-parser-2.7.1-5.fc26.s390x
libsodium-1.0.14-1.fc26.s390x python-gssapi-1.2.0-5.fc26.s390x nss-softokn-3.34.0-1.0.fc26.s390x
gnupg2-2.2.3-1.fc26.s390x
nss-devel-3.34.0-1.0.fc26.s390x vim-minimal-8.0.1360-1.fc26.s390x perl-libnet-3.11-1.fc26.noarch kernel-devel-4.13.16-202.fc26.s390x python2-libs-2.7.14-4.fc26.s390x libwayland-client-1.13.0-3.fc26.s390x python3-dnf-2.7.5-2.fc26.noarch glusterfs-fuse-3.10.8-1.fc26.s390x pcre2-utf32-10.23-11.fc26.s390x kernel-modules-4.14.8-200.fc26.s390x pkgconf-pkg-config-1.3.12-1.fc26.s390x NetworkManager-ppp-1.8.2-4.fc26.s390x wayland-devel-1.13.0-3.fc26.s390x kernel-4.14.8-200.fc26.s390x boost-random-1.63.0-10.fc26.s390x libmicrohttpd-0.9.58-1.fc26.s390x
mailx-12.5-24.fc26.s390x NetworkManager-glib-1.8.2-4.fc26.s390x libcroco-0.6.12-1.fc26.s390x
libssh2-1.8.0-5.fc26.s390x
json-glib-1.2.6-1.fc26.s390x
libevent-2.0.22-3.fc26.s390x gdk-pixbuf2-modules-2.36.9-1.fc26.s390x colord-libs-1.3.5-1.fc26.s390x python3-magic-5.30-11.fc26.noarch python3-gobject-base-3.24.1-1.fc26.s390x python3-pyroute2-0.4.13-1.fc26.noarch python3-pysocks-1.6.7-1.fc26.noarch python2-click-6.7-3.fc26.noarch python-munch-2.1.0-2.fc26.noarch python2-ply-3.9-3.fc26.noarch python2-snowballstemmer-1.2.1-3.fc26.noarch python-magic-5.30-11.fc26.noarch python-beautifulsoup4-4.6.0-1.fc26.noarch python2-gitdb-2.0.3-1.fc26.noarch librados-devel-10.2.7-2.fc26.s390x libcacard-2.5.3-1.fc26.s390x
libmodman-2.0.1-13.fc26.s390x
zziplib-0.13.62-8.fc26.s390x lksctp-tools-1.0.16-6.fc26.s390x
procmail-3.22-44.fc26.s390x
libthai-0.1.25-2.fc26.s390x
libpipeline-1.4.1-3.fc26.s390x python2-pycurl-7.43.0-8.fc26.s390x deltarpm-3.6-19.fc26.s390x subversion-libs-1.9.7-1.fc26.s390x python-krbV-1.0.90-13.fc26.s390x
m17n-db-1.7.0-8.fc26.noarch linux-atm-libs-2.5.1-17.fc26.s390x python2-rpm-4.13.0.2-1.fc26.s390x python2-librepo-1.8.0-1.fc26.s390x python2-dnf-plugins-core-2.1.5-1.fc26.noarch qrencode-libs-3.4.4-1.fc26.s390x s390utils-iucvterm-1.36.1-3.fc26.s390x libsmartcols-2.30.2-1.fc26.s390x
dbus-1.11.18-1.fc26.s390x
systemd-udev-233-7.fc26.s390x device-mapper-event-1.02.137-6.fc26.s390x polkit-0.113-8.fc26.s390x
mock-1.4.7-2.fc26.noarch
libwmf-lite-0.2.8.4-53.fc26.s390x libXcomposite-0.4.4-9.fc26.s390x libXcursor-1.1.14-8.fc26.s390x at-spi2-atk-2.24.1-1.fc26.s390x
pango-1.40.12-1.fc26.s390x texlive-metafont-bin-svn40987-33.20160520.fc26.2.s390x texlive-url-svn32528.3.4-33.fc26.2.noarch texlive-fp-svn15878.0-33.fc26.2.noarch texlive-latex-fonts-svn28888.0-33.fc26.2.noarch texlive-mptopdf-bin-svn18674.0-33.20160520.fc26.2.noarch texlive-fancybox-svn18304.1.4-33.fc26.2.noarch texlive-lua-alt-getopt-svn29349.0.7.0-33.fc26.2.noarch texlive-tex-bin-svn40987-33.20160520.fc26.2.s390x texlive-texconfig-svn40768-33.fc26.2.noarch texlive-wasy2-ps-svn35830.0-33.fc26.2.noarch texlive-psfrag-svn15878.3.04-33.fc26.2.noarch texlive-helvetic-svn31835.0-33.fc26.2.noarch texlive-times-svn35058.0-33.fc26.2.noarch texlive-cite-svn36428.5.5-33.fc26.2.noarch texlive-fancyhdr-svn15878.3.1-33.fc26.2.noarch texlive-luatex-bin-svn41091-33.20160520.fc26.2.s390x texlive-lm-math-svn36915.1.959-33.fc26.2.noarch texlive-ntgclass-svn15878.2.1a-33.fc26.2.noarch texlive-sansmath-svn17997.1.1-33.fc26.2.noarch texlive-textcase-svn15878.0-33.fc26.2.noarch texlive-unicode-data-svn39808-33.fc26.2.noarch texlive-breakurl-svn29901.1.40-33.fc26.2.noarch texlive-latex-svn40218-33.fc26.2.noarch texlive-lualatex-math-svn40621-33.fc26.2.noarch texlive-pst-coil-svn37377.1.07-33.fc26.2.noarch texlive-pst-plot-svn41242-33.fc26.2.noarch texlive-unicode-math-svn38462-33.fc26.2.noarch texlive-pst-blur-svn15878.2.0-33.fc26.2.noarch texlive-cm-super-svn15878.0-33.fc26.2.noarch texlive-wasysym-svn15878.2.0-33.fc26.2.noarch texlive-collection-fontsrecommended-svn35830.0-33.20160520.fc26.2.noarch libXv-1.0.11-2.fc26.s390x ghc-srpm-macros-1.4.2-5.fc26.noarch latex2html-2017.2-2.fc26.noarch libXau-devel-1.0.8-7.fc26.s390x libXcursor-devel-1.1.14-8.fc26.s390x graphite2-devel-1.3.10-1.fc26.s390x pixman-devel-0.34.0-3.fc26.s390x wayland-protocols-devel-1.9-1.fc26.noarch mesa-libGLES-devel-17.2.4-2.fc26.s390x redhat-rpm-config-63-1.fc26.noarch vte291-devel-0.48.4-1.fc26.s390x ceph-devel-compat-10.2.7-2.fc26.s390x lzo-devel-2.08-9.fc26.s390x libiscsi-devel-1.15.0-3.fc26.s390x libfdt-devel-1.4.5-1.fc26.s390x
dnsmasq-2.76-5.fc26.s390x
avahi-autoipd-0.6.32-7.fc26.s390x rpm-plugin-systemd-inhibit-4.13.0.2-1.fc26.s390x gcc-c++-7.2.1-2.fc26.s390x python2-ndg_httpsclient-0.4.0-7.fc26.noarch gettext-0.19.8.1-9.fc26.s390x
btrfs-progs-4.9.1-2.fc26.s390x fedora-logos-26.0.1-1.fc26.s390x
dejagnu-1.6-2.fc26.noarch
libaio-devel-0.3.110-7.fc26.s390x dos2unix-7.3.4-2.fc26.s390x distribution-gpg-keys-1.15-1.fc26.noarch python-sphinx-locale-1.5.5-1.fc26.noarch python2-rpm-macros-3-20.fc26.noarch libxml2-2.9.4-2.fc26.s390x
popt-1.16-12.fc26.s390x
tar-1.29-5.fc26.s390x
avahi-libs-0.6.32-7.fc26.s390x
m4-1.4.18-3.fc26.s390x
perl-Socket-2.024-2.fc26.s390x perl-Time-Local-1.250-2.fc26.noarch libmetalink-0.1.3-2.fc26.s390x
jbigkit-libs-2.1-6.fc26.s390x
netpbm-10.80.00-2.fc26.s390x perl-Digest-MD5-2.55-3.fc26.s390x perl-Getopt-Long-2.49.1-2.fc26.noarch libglvnd-opengl-1.0.0-1.fc26.s390x libattr-devel-2.4.47-18.fc26.s390x teckit-2.5.1-16.fc26.s390x
python3-six-1.10.0-9.fc26.noarch python3-libcomps-0.1.8-3.fc26.s390x gtk-update-icon-cache-3.22.21-2.fc26.s390x python3-3.6.3-2.fc26.s390x python3-pyparsing-2.1.10-3.fc26.noarch python2-markupsafe-0.23-13.fc26.s390x python2-mock-2.0.0-4.fc26.noarch python2-yubico-1.3.2-7.fc26.noarch python2-smmap-2.0.3-1.fc26.noarch librbd-devel-10.2.7-2.fc26.s390x
pigz-2.3.4-2.fc26.s390x
gcc-7.2.1-2.fc26.s390x
libnghttp2-1.21.1-1.fc26.s390x
cups-libs-2.2.2-7.fc26.s390x
libnfsidmap-0.27-1.fc26.s390x
ykpers-1.18.0-2.fc26.s390x python3-librepo-1.8.0-1.fc26.s390x systemtap-runtime-3.2-2.fc26.s390x geoclue2-2.4.5-4.fc26.s390x
initscripts-9.72-1.fc26.s390x plymouth-0.9.3-0.7.20160620git0e65b86c.fc26.s390x ebtables-2.0.10-22.fc26.s390x
gssproxy-0.7.0-9.fc26.s390x
libXext-1.3.3-5.fc26.s390x
mesa-libEGL-17.2.4-2.fc26.s390x texlive-texlive.infra-bin-svn40312-33.20160520.fc26.2.s390x texlive-thumbpdf-svn34621.3.16-33.fc26.2.noarch texlive-carlisle-svn18258.0-33.fc26.2.noarch texlive-gsftopk-svn40768-33.fc26.2.noarch texlive-pdftex-svn41149-33.fc26.2.noarch texlive-crop-svn15878.1.5-33.fc26.2.noarch texlive-pxfonts-svn15878.0-33.fc26.2.noarch texlive-enctex-svn34957.0-33.fc26.2.noarch texlive-kastrup-svn15878.0-33.fc26.2.noarch texlive-pspicture-svn15878.0-33.fc26.2.noarch texlive-varwidth-svn24104.0.92-33.fc26.2.noarch texlive-currfile-svn40725-33.fc26.2.noarch texlive-pst-grad-svn15878.1.06-33.fc26.2.noarch texlive-latex-bin-svn41438-33.fc26.2.noarch texlive-ltxmisc-svn21927.0-33.fc26.2.noarch lasi-1.1.2-7.fc26.s390x adwaita-icon-theme-3.24.0-2.fc26.noarch xz-devel-5.2.3-2.fc26.s390x xorg-x11-fonts-Type1-7.5-17.fc26.noarch libXi-devel-1.7.9-2.fc26.s390x at-spi2-atk-devel-2.24.1-1.fc26.s390x pango-devel-1.40.12-1.fc26.s390x libcacard-devel-2.5.3-1.fc26.s390x libseccomp-devel-2.3.2-1.fc26.s390x subversion-1.9.7-1.fc26.s390x
sudo-1.8.21p2-1.fc26.s390x
pykickstart-2.35-2.fc26.noarch
e2fsprogs-1.43.4-2.fc26.s390x libstdc++-static-7.2.1-2.fc26.s390x libbsd-0.8.3-3.fc26.s390x
c-ares-1.13.0-1.fc26.s390x
python2-pyxdg-0.25-12.fc26.noarch nss-softokn-freebl-devel-3.34.0-1.0.fc26.s390x python2-rpkg-1.51-2.fc26.noarch
strace-4.20-1.fc26.s390x
valgrind-3.13.0-12.fc26.s390x libsss_idmap-1.16.0-4.fc26.s390x gnutls-c++-3.5.16-4.fc26.s390x libwayland-server-1.13.0-3.fc26.s390x dhcp-client-4.3.5-10.fc26.s390x bind-libs-9.11.1-4.P3.fc26.s390x man-pages-4.09-4.fc26.noarch
gpg-pubkey-a29cb19c-53bcbba6
quota-nls-4.03-9.fc26.noarch qt5-srpm-macros-5.8.0-2.fc26.noarch xz-libs-5.2.3-2.fc26.s390x
gmp-6.1.2-4.fc26.s390x
audit-libs-2.8.1-1.fc26.s390x
file-5.30-11.fc26.s390x
libusbx-1.0.21-2.fc26.s390x
binutils-2.27-28.fc26.s390x
perl-Errno-1.25-395.fc26.s390x perl-HTTP-Tiny-0.070-2.fc26.noarch xml-common-0.6.3-45.fc26.noarch
opus-1.2.1-1.fc26.s390x
kernel-devel-4.13.13-200.fc26.s390x perl-podlators-4.09-2.fc26.noarch flac-libs-1.3.2-2.fc26.s390x libacl-devel-2.2.52-15.fc26.s390x coreutils-common-8.27-7.fc26.s390x cracklib-2.9.6-5.fc26.s390x
pyliblzma-0.5.3-17.fc26.s390x
libnotify-0.7.7-2.fc26.s390x
python3-idna-2.5-1.fc26.noarch python3-pyOpenSSL-16.2.0-6.fc26.noarch python2-pbr-1.10.0-4.fc26.noarch
pyusb-1.0.0-4.fc26.noarch
python2-fedora-0.9.0-6.fc26.noarch librbd1-10.2.7-2.fc26.s390x
pcre-cpp-8.41-3.fc26.s390x
glibc-devel-2.25-12.fc26.s390x
libnfs-1.9.8-3.fc26.s390x
libsolv-0.6.30-2.fc26.s390x python3-pycurl-7.43.0-8.fc26.s390x libyubikey-1.13-3.fc26.s390x
rpmlint-1.10-5.fc26.noarch
python2-pygpgme-0.3-22.fc26.s390x s390utils-base-1.36.1-3.fc26.s390x
ppp-2.4.7-11.fc26.s390x s390utils-cpuplugd-1.36.1-3.fc26.s390x nfs-utils-2.1.1-6.rc6.fc26.s390x libXrender-0.9.10-2.fc26.s390x libglvnd-gles-1.0.0-1.fc26.s390x texlive-texlive.infra-svn41280-33.fc26.2.noarch texlive-lm-svn28119.2.004-33.fc26.2.noarch texlive-babelbib-svn25245.1.31-33.fc26.2.noarch texlive-index-svn24099.4.1beta-33.fc26.2.noarch texlive-pdftex-bin-svn40987-33.20160520.fc26.2.s390x texlive-csquotes-svn39538-33.fc26.2.noarch texlive-rsfs-svn15878.0-33.fc26.2.noarch texlive-etex-svn37057.0-33.fc26.2.noarch texlive-knuth-lib-svn35820.0-33.fc26.2.noarch texlive-pst-math-svn34786.0.63-33.fc26.2.noarch texlive-utopia-svn15878.0-33.fc26.2.noarch texlive-eso-pic-svn37925.2.0g-33.fc26.2.noarch texlive-pst-fill-svn15878.1.01-33.fc26.2.noarch texlive-latex-bin-bin-svn14050.0-33.20160520.fc26.2.noarch texlive-jknapltx-svn19440.0-33.fc26.2.noarch texlive-collection-latexrecommended-svn35765.0-33.20160520.fc26.2.noarch adwaita-cursor-theme-3.24.0-2.fc26.noarch xorg-x11-fonts-ISO8859-1-100dpi-7.5-17.fc26.noarch libXcomposite-devel-0.4.4-9.fc26.s390x at-spi2-core-devel-2.24.1-1.fc26.s390x harfbuzz-devel-1.4.4-1.fc26.s390x rpmdevtools-8.10-2.fc26.noarch
texi2html-5.0-5.fc26.noarch
libnfs-devel-1.9.8-3.fc26.s390x firewalld-0.4.4.5-1.fc26.noarch wpa_supplicant-2.6-12.fc26.s390x systemtap-sdt-devel-3.2-2.fc26.s390x newt-python-0.52.20-1.fc26.s390x perl-Mozilla-CA-20160104-4.fc26.noarch pth-2.0.7-28.fc26.s390x
python3-pyxdg-0.25-12.fc26.noarch nss-softokn-devel-3.34.0-1.0.fc26.s390x fedpkg-1.30-4.fc26.noarch
timedatex-0.4-3.fc26.s390x
libjpeg-turbo-1.5.3-1.fc26.s390x glusterfs-cli-3.10.8-1.fc26.s390x libsss_nss_idmap-1.16.0-4.fc26.s390x
gdb-8.0.1-33.fc26.s390x
dnf-yum-2.7.5-2.fc26.noarch perl-Data-Dumper-2.161-3.fc26.s390x python-async-0.6.1-9.fc22.s390x poppler-data-0.4.7-7.fc26.noarch ocaml-srpm-macros-4-2.fc26.noarch libuuid-2.30.2-1.fc26.s390x
libgpg-error-1.25-2.fc26.s390x
libassuan-2.4.3-2.fc26.s390x
graphite2-1.3.10-1.fc26.s390x perl-Text-Tabs+Wrap-2013.0523-366.fc26.noarch perl-Error-0.17024-8.fc26.noarch
which-2.21-2.fc26.s390x
libXau-1.0.8-7.fc26.s390x
orc-0.4.27-1.fc26.s390x
perl-Pod-Perldoc-3.28-1.fc26.noarch libsndfile-1.0.28-6.fc26.s390x
patch-2.7.5-4.fc26.s390x
gzip-1.8-2.fc26.s390x
python-ipaddress-1.0.16-4.fc26.noarch yum-metadata-parser-1.1.4-18.fc26.s390x python3-dbus-1.2.4-6.fc26.s390x python3-cryptography-2.0.2-2.fc26.s390x python3-kickstart-2.35-2.fc26.noarch python2-imagesize-0.7.1-5.fc26.noarch python2-jinja2-2.9.6-1.fc26.noarch libradosstriper-devel-10.2.7-2.fc26.s390x soundtouch-1.9.2-4.fc26.s390x glibc-headers-2.25-12.fc26.s390x
libndp-1.6-2.fc26.s390x
rpm-4.13.0.2-1.fc26.s390x
rest-0.8.0-2.fc26.s390x
libvisual-0.4.0-21.fc26.s390x python2-hawkey-0.11.1-1.fc26.s390x dnf-plugins-core-2.1.5-1.fc26.noarch fakeroot-libs-1.22-1.fc26.s390x device-mapper-event-libs-1.02.137-6.fc26.s390x cyrus-sasl-2.1.26-32.fc26.s390x kernel-modules-4.13.13-200.fc26.s390x cronie-anacron-1.5.1-5.fc26.s390x libpath_utils-0.2.1-34.fc26.s390x libX11-common-1.6.5-2.fc26.noarch
libXft-2.3.2-5.fc26.s390x
gtk2-2.24.31-4.fc26.s390x texlive-etoolbox-svn38031.2.2a-33.fc26.2.noarch texlive-multido-svn18302.1.42-33.fc26.2.noarch texlive-glyphlist-svn28576.0-33.fc26.2.noarch texlive-setspace-svn24881.6.7a-33.fc26.2.noarch texlive-mathtools-svn38833-33.fc26.2.noarch texlive-ncntrsbk-svn31835.0-33.fc26.2.noarch texlive-dvisvgm-def-svn41011-33.fc26.2.noarch texlive-ifetex-svn24853.1.2-33.fc26.2.noarch texlive-parskip-svn19963.2.0-33.fc26.2.noarch texlive-bera-svn20031.0-33.fc26.2.noarch texlive-pgf-svn40966-33.fc26.2.noarch texlive-auto-pst-pdf-svn23723.0.6-33.fc26.2.noarch texlive-ctable-svn38672-33.fc26.2.noarch texlive-typehtml-svn17134.0-33.fc26.2.noarch mesa-libGLES-17.2.4-2.fc26.s390x
vte291-0.48.4-1.fc26.s390x
libdrm-devel-2.4.88-1.fc26.s390x libcephfs_jni1-10.2.7-2.fc26.s390x bzip2-devel-1.0.6-22.fc26.s390x expat-devel-2.2.4-1.fc26.s390x libsepol-devel-2.6-2.fc26.s390x glib2-static-2.52.3-2.fc26.s390x virglrenderer-devel-0.6.0-1.20170210git76b3da97b.fc26.s390x yum-utils-1.1.31-512.fc26.noarch
parted-3.2-24.fc26.s390x python3-beautifulsoup4-4.6.0-1.fc26.noarch python-bunch-1.0.1-10.fc26.noarch perl-Time-HiRes-1.9746-1.fc26.s390x
lz4-1.8.0-1.fc26.s390x
nss-util-3.34.0-1.0.fc26.s390x openssh-clients-7.5p1-4.fc26.s390x
chrony-3.2-1.fc26.s390x
dnf-conf-2.7.5-2.fc26.noarch glusterfs-server-3.10.8-1.fc26.s390x sssd-client-1.16.0-4.fc26.s390x
man-db-2.7.6.1-8.fc26.s390x bodhi-client-2.12.2-3.fc26.noarch perl-Module-CoreList-5.20171120-1.fc26.noarch hawkey-0.6.4-3.fc25.s390x python-srpm-macros-3-20.fc26.noarch perl-srpm-macros-1-21.fc26.noarch
expat-2.2.4-1.fc26.s390x
chkconfig-1.10-1.fc26.s390x
findutils-4.6.0-12.fc26.s390x mesa-libwayland-egl-17.2.4-2.fc26.s390x procps-ng-3.3.10-13.fc26.s390x mesa-libglapi-17.2.4-2.fc26.s390x perl-Unicode-Normalize-1.25-366.fc26.s390x perl-IO-Socket-IP-0.39-1.fc26.noarch hunspell-en-US-0.20140811.1-6.fc26.noarch libxcb-1.12-3.fc26.s390x
libgo-devel-7.2.1-2.fc26.s390x perl-Pod-Escapes-1.07-366.fc26.noarch perl-Pod-Usage-1.69-2.fc26.noarch libtheora-1.1.1-15.fc26.s390x
tcp_wrappers-7.6-85.fc26.s390x
coreutils-8.27-7.fc26.s390x
libmount-2.30.2-1.fc26.s390x python2-iniparse-0.4-24.fc26.noarch python2-decorator-4.0.11-2.fc26.noarch ModemManager-glib-1.6.10-1.fc26.s390x python3-decorator-4.0.11-2.fc26.noarch python3-cffi-1.9.1-2.fc26.s390x python-bugzilla-cli-2.1.0-1.fc26.noarch python2-funcsigs-1.0.2-5.fc26.noarch python2-babel-2.3.4-5.fc26.noarch python-bugzilla-2.1.0-1.fc26.noarch libradosstriper1-10.2.7-2.fc26.s390x snappy-1.1.4-3.fc26.s390x
dtc-1.4.5-1.fc26.s390x
libmpcdec-1.2.6-17.fc26.s390x
rpm-libs-4.13.0.2-1.fc26.s390x python-urlgrabber-3.10.1-11.fc26.noarch sysfsutils-2.1.0-20.fc26.s390x python3-hawkey-0.11.1-1.fc26.s390x python3-dnf-plugins-core-2.1.5-1.fc26.noarch ethtool-4.13-1.fc26.s390x
iputils-20161105-5.fc26.s390x plymouth-scripts-0.9.3-0.7.20160620git0e65b86c.fc26.s390x cronie-1.5.1-5.fc26.s390x
libini_config-1.3.1-34.fc26.s390x
libX11-1.6.5-2.fc26.s390x
libglvnd-egl-1.0.0-1.fc26.s390x texlive-kpathsea-svn41139-33.fc26.2.noarch texlive-thumbpdf-bin-svn6898.0-33.20160520.fc26.2.noarch texlive-subfig-svn15878.1.3-33.fc26.2.noarch texlive-gsftopk-bin-svn40473-33.20160520.fc26.2.s390x texlive-tex-ini-files-svn40533-33.fc26.2.noarch texlive-qstest-svn15878.0-33.fc26.2.noarch texlive-palatino-svn31835.0-33.fc26.2.noarch texlive-ec-svn25033.1.0-33.fc26.2.noarch texlive-iftex-svn29654.0.2-33.fc26.2.noarch texlive-pslatex-svn16416.0-33.fc26.2.noarch texlive-algorithms-svn38085.0.1-33.fc26.2.noarch texlive-filehook-svn24280.0.5d-33.fc26.2.noarch texlive-pst-node-svn40743-33.fc26.2.noarch texlive-rotating-svn16832.2.16b-33.fc26.2.noarch texlive-seminar-svn34011.1.62-33.fc26.2.noarch gtk3-3.22.21-2.fc26.s390x
libuuid-devel-2.30.2-1.fc26.s390x java-1.8.0-openjdk-1.8.0.151-1.b12.fc26.s390x libXinerama-devel-1.1.3-7.fc26.s390x emacs-common-25.3-3.fc26.s390x gtk3-devel-3.22.21-2.fc26.s390x fedora-packager-0.6.0.1-2.fc26.noarch libxml2-devel-2.9.4-2.fc26.s390x snappy-devel-1.1.4-3.fc26.s390x python2-dnf-plugin-migrate-2.1.5-1.fc26.noarch authconfig-7.0.1-2.fc26.s390x newt-python3-0.52.20-1.fc26.s390x python-decoratortools-1.8-13.fc26.noarch python-systemd-doc-234-1.fc26.s390x openssl-libs-1.1.0g-1.fc26.s390x git-core-2.13.6-2.fc26.s390x python3-dnf-plugin-system-upgrade-2.0.4-1.fc26.noarch glusterfs-libs-3.10.8-1.fc26.s390x ca-certificates-2017.2.20-1.0.fc26.noarch unbound-libs-1.6.7-1.fc26.s390x libsss_certmap-1.16.0-4.fc26.s390x glusterfs-api-devel-3.10.8-1.fc26.s390x selinux-policy-targeted-3.13.1-260.17.fc26.noarch publicsuffix-list-dafsa-20171028-1.fc26.noarch gpg-pubkey-a0a7badb-52844296
gpg-pubkey-e372e838-56fd7943
gpg-pubkey-3b921d09-57a87096 google-roboto-slab-fonts-1.100263-0.5.20150923git.fc26.noarch libreport-filesystem-2.9.1-3.fc26.s390x glibc-all-langpacks-2.25-12.fc26.s390x libcom_err-1.43.4-2.fc26.s390x
libffi-3.1-12.fc26.s390x
keyutils-libs-1.5.10-1.fc26.s390x
diffutils-3.5-3.fc26.s390x
apr-util-1.5.4-6.fc26.s390x
bluez-libs-5.46-6.fc26.s390x
libksba-1.3.5-3.fc26.s390x
ncurses-6.0-8.20170212.fc26.s390x
gsm-1.0.17-1.fc26.s390x
libteam-1.27-1.fc26.s390x perl-Fedora-VSP-0.001-5.fc26.noarch libusb-0.1.5-8.fc26.s390x
acl-2.2.52-15.fc26.s390x
dwz-0.12-3.fc26.s390x
libblkid-2.30.2-1.fc26.s390x
polkit-libs-0.113-8.fc26.s390x dbus-python-1.2.4-6.fc26.s390x gts-0.7.6-30.20121130.fc26.s390x libfdisk-2.30.2-1.fc26.s390x python3-pycparser-2.14-10.fc26.noarch python3-bugzilla-2.1.0-1.fc26.noarch python2-docutils-0.13.1-4.fc26.noarch pytz-2016.10-4.fc26.noarch python2-requests-2.13.0-1.fc26.noarch libcephfs-devel-10.2.7-2.fc26.s390x ncurses-c++-libs-6.0-8.20170212.fc26.s390x GeoIP-1.6.11-1.fc26.s390x
liblockfile-1.09-5.fc26.s390x rpm-plugin-selinux-4.13.0.2-1.fc26.s390x systemtap-devel-3.2-2.fc26.s390x libsysfs-2.1.0-20.fc26.s390x
libdnf-0.11.1-1.fc26.s390x
libgfortran-7.2.1-2.fc26.s390x mesa-libgbm-17.2.4-2.fc26.s390x
dracut-046-3.1.fc26.s390x
lvm2-libs-2.02.168-6.fc26.s390x
libXfixes-5.0.3-2.fc26.s390x
brlapi-0.6.6-5.fc26.s390x texlive-metafont-svn40793-33.fc26.2.noarch texlive-graphics-cfg-svn40269-33.fc26.2.noarch texlive-mptopdf-svn41282-33.fc26.2.noarch texlive-makeindex-bin-svn40473-33.20160520.fc26.2.s390x texlive-texlive-scripts-bin-svn29741.0-33.20160520.fc26.2.noarch texlive-sauerj-svn15878.0-33.fc26.2.noarch texlive-txfonts-svn15878.0-33.fc26.2.noarch texlive-filecontents-svn24250.1.3-33.fc26.2.noarch texlive-lualibs-svn40370-33.fc26.2.noarch texlive-section-svn20180.0-33.fc26.2.noarch texlive-ucharcat-svn38907-33.fc26.2.noarch texlive-hyperref-svn41396-33.fc26.2.noarch texlive-pst-3d-svn17257.1.10-33.fc26.2.noarch texlive-oberdiek-svn41346-33.fc26.2.noarch texlive-ae-svn15878.1.4-33.fc26.2.noarch texlive-collection-basic-svn41149-33.20160520.fc26.2.noarch gnat-srpm-macros-4-2.fc26.noarch glib2-devel-2.52.3-2.fc26.s390x netpbm-progs-10.80.00-2.fc26.s390x libXxf86vm-devel-1.1.4-4.fc26.s390x nettle-devel-3.3-2.fc26.s390x cairo-gobject-devel-1.14.10-1.fc26.s390x fedora-rpm-macros-26-2.fc26.noarch elfutils-devel-0.169-1.fc26.s390x libidn-devel-1.33-2.fc26.s390x
s390utils-1.36.1-3.fc26.s390x gcc-gfortran-7.2.1-2.fc26.s390x
libtool-2.4.6-17.fc26.s390x python3-cssselect-0.9.2-4.fc26.noarch python2-cssselect-0.9.2-4.fc26.noarch bison-3.0.4-6.fc26.s390x
rootfiles-8.1-20.fc26.noarch git-core-doc-2.13.6-2.fc26.s390x vim-enhanced-8.0.1360-1.fc26.s390x glusterfs-3.10.8-1.fc26.s390x boost-system-1.63.0-10.fc26.s390x gnutls-dane-3.5.16-4.fc26.s390x pkgconf-m4-1.3.12-1.fc26.noarch libcurl-devel-7.53.1-13.fc26.s390x python3-urllib3-1.20-2.fc26.noarch libsss_autofs-1.16.0-4.fc26.s390x
=== TEST BEGIN ===
Using CC: /home/fam/bin/cc
Install prefix /var/tmp/patchew-tester-tmp-zu_flv2_/src/install BIOS directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/share/qemu firmware path /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/share/qemu-firmware binary directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/bin
library directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/lib module directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/lib/qemu libexec directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/libexec include directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/include config directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/etc
local state directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/var
Manual directory /var/tmp/patchew-tester-tmp-zu_flv2_/src/install/share/man ELF interp prefix /usr/gnemul/qemu-%M
Source path /var/tmp/patchew-tester-tmp-zu_flv2_/src GIT binary git GIT submodules ui/keycodemapdb capstone C compiler /home/fam/bin/cc Host C compiler cc C++ compiler c++ Objective-C compiler /home/fam/bin/cc ARFLAGS rv CFLAGS -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g QEMU_CFLAGS -I/usr/include/pixman-1 -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DNCURSES_WIDECHAR -D_GNU_SOURCE -D_DEFAULT_SOURCE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/libdrm -I$(SRC_PATH)/capstone/include LDFLAGS -Wl,--warn-common -m64 -g make make install install python python -B smbd /usr/sbin/smbd module support no host CPU s390x host big endian yes target list aarch64-softmmu alpha-softmmu arm-softmmu cris-softmmu i386-softmmu lm32-softmmu m68k-softmmu microblazeel-softmmu microblaze-softmmu mips64el-softmmu mips64-softmmu mipsel-softmmu mips-softmmu moxie-softmmu nios2-softmmu or1k-softmmu ppc64-softmmu ppcemb-softmmu ppc-softmmu s390x-softmmu sh4eb-softmmu sh4-softmmu sparc64-softmmu sparc-softmmu tricore-softmmu unicore32-softmmu x86_64-softmmu xtensaeb-softmmu xtensa-softmmu aarch64-linux-user alpha-linux-user armeb-linux-user arm-linux-user cris-linux-user hppa-linux-user i386-linux-user m68k-linux-user microblazeel-linux-user microblaze-linux-user mips64el-linux-user mips64-linux-user mipsel-linux-user mips-linux-user mipsn32el-linux-user mipsn32-linux-user nios2-linux-user or1k-linux-user ppc64abi32-linux-user ppc64le-linux-user ppc64-linux-user ppc-linux-user s390x-linux-user sh4eb-linux-user sh4-linux-user sparc32plus-linux-user sparc64-linux-user sparc-linux-user tilegx-linux-user x86_64-linux-user gprof enabled no sparse enabled no strip binaries yes profiler no static build no SDL support yes (2.0.7) GTK support yes (3.22.21) GTK GL support yes VTE support yes (0.48.4) TLS priority NORMAL GNUTLS support yes GNUTLS rnd yes libgcrypt no libgcrypt kdf no nettle yes (3.3) nettle kdf yes libtasn1 yes curses support yes virgl support yes curl support yes mingw32 support no Audio drivers oss
Block whitelist (rw)
Block whitelist (ro)
VirtFS support yes
Multipath support no
VNC support yes VNC SASL support yes VNC JPEG support yes VNC PNG support yes xen support no brlapi support yes bluez support yes Documentation yes PIE no vde support no netmap support no Linux AIO support yes ATTR/XATTR support yes Install blobs yes KVM support yes HAX support no TCG support yes TCG debug enabled no TCG interpreter no malloc trim support yes RDMA support no fdt support yes preadv support yes fdatasync yes madvise yes posix_madvise yes
libcap-ng support yes
vhost-net support yes
vhost-scsi support yes
vhost-vsock support yes
vhost-user support yes
Trace backends log spice support no rbd support yes xfsctl support no smartcard support yes libusb yes usb net redir yes OpenGL support yes OpenGL dmabufs yes libiscsi support yes libnfs support yes
build guest agent yes
QGA VSS support no
QGA w32 disk info no
QGA MSI support no
seccomp support yes
coroutine backend ucontext
coroutine pool yes
debug stack usage no
crypto afalg no
GlusterFS support yes
gcov gcov gcov enabled no TPM support yes libssh2 support yes TPM passthrough no TPM emulator yes QOM debugging yes Live block migration yes lzo support yes snappy support yes bzip2 support yes
NUMA host support no
tcmalloc support no
jemalloc support no
avx2 optimization no
replication support yes
VxHS block device no
capstone git
GEN aarch64-softmmu/config-devices.mak.tmp GEN alpha-softmmu/config-devices.mak.tmp GEN arm-softmmu/config-devices.mak.tmp GEN cris-softmmu/config-devices.mak.tmp GEN cris-softmmu/config-devices.mak GEN i386-softmmu/config-devices.mak.tmp GEN alpha-softmmu/config-devices.mak GEN arm-softmmu/config-devices.mak GEN aarch64-softmmu/config-devices.mak GEN lm32-softmmu/config-devices.mak.tmp GEN m68k-softmmu/config-devices.mak.tmp GEN microblazeel-softmmu/config-devices.mak.tmp GEN m68k-softmmu/config-devices.mak GEN microblaze-softmmu/config-devices.mak.tmp GEN lm32-softmmu/config-devices.mak GEN i386-softmmu/config-devices.mak GEN mips64el-softmmu/config-devices.mak.tmp GEN mips64-softmmu/config-devices.mak.tmp GEN microblaze-softmmu/config-devices.mak GEN microblazeel-softmmu/config-devices.mak GEN mipsel-softmmu/config-devices.mak.tmp GEN mips-softmmu/config-devices.mak.tmp GEN mips64el-softmmu/config-devices.mak GEN moxie-softmmu/config-devices.mak.tmp GEN moxie-softmmu/config-devices.mak GEN nios2-softmmu/config-devices.mak.tmp GEN nios2-softmmu/config-devices.mak GEN or1k-softmmu/config-devices.mak.tmp GEN or1k-softmmu/config-devices.mak GEN ppc64-softmmu/config-devices.mak.tmp GEN mipsel-softmmu/config-devices.mak GEN mips64-softmmu/config-devices.mak GEN mips-softmmu/config-devices.mak GEN ppc64-softmmu/config-devices.mak GEN ppc-softmmu/config-devices.mak.tmp GEN ppcemb-softmmu/config-devices.mak.tmp GEN s390x-softmmu/config-devices.mak.tmp GEN sh4eb-softmmu/config-devices.mak.tmp GEN s390x-softmmu/config-devices.mak GEN sh4-softmmu/config-devices.mak.tmp GEN sh4eb-softmmu/config-devices.mak GEN ppcemb-softmmu/config-devices.mak GEN ppc-softmmu/config-devices.mak GEN sparc64-softmmu/config-devices.mak.tmp GEN sparc-softmmu/config-devices.mak.tmp GEN tricore-softmmu/config-devices.mak.tmp GEN sh4-softmmu/config-devices.mak GEN sparc-softmmu/config-devices.mak GEN unicore32-softmmu/config-devices.mak.tmp GEN tricore-softmmu/config-devices.mak GEN x86_64-softmmu/config-devices.mak.tmp GEN xtensaeb-softmmu/config-devices.mak.tmp GEN sparc64-softmmu/config-devices.mak GEN unicore32-softmmu/config-devices.mak GEN xtensa-softmmu/config-devices.mak.tmp GEN aarch64-linux-user/config-devices.mak.tmp GEN xtensaeb-softmmu/config-devices.mak GEN alpha-linux-user/config-devices.mak.tmp GEN x86_64-softmmu/config-devices.mak GEN aarch64-linux-user/config-devices.mak GEN xtensa-softmmu/config-devices.mak GEN armeb-linux-user/config-devices.mak.tmp GEN arm-linux-user/config-devices.mak.tmp GEN alpha-linux-user/config-devices.mak GEN cris-linux-user/config-devices.mak.tmp GEN hppa-linux-user/config-devices.mak.tmp GEN arm-linux-user/config-devices.mak GEN i386-linux-user/config-devices.mak.tmp GEN armeb-linux-user/config-devices.mak GEN cris-linux-user/config-devices.mak GEN hppa-linux-user/config-devices.mak GEN m68k-linux-user/config-devices.mak.tmp GEN microblazeel-linux-user/config-devices.mak.tmp GEN i386-linux-user/config-devices.mak GEN m68k-linux-user/config-devices.mak GEN microblaze-linux-user/config-devices.mak.tmp GEN microblazeel-linux-user/config-devices.mak GEN mips64el-linux-user/config-devices.mak.tmp GEN mips64-linux-user/config-devices.mak.tmp GEN mipsel-linux-user/config-devices.mak.tmp GEN mips64el-linux-user/config-devices.mak GEN mips64-linux-user/config-devices.mak GEN microblaze-linux-user/config-devices.mak GEN mips-linux-user/config-devices.mak.tmp GEN mipsel-linux-user/config-devices.mak GEN mipsn32el-linux-user/config-devices.mak.tmp GEN mipsn32-linux-user/config-devices.mak.tmp GEN nios2-linux-user/config-devices.mak.tmp GEN mips-linux-user/config-devices.mak GEN mipsn32el-linux-user/config-devices.mak GEN or1k-linux-user/config-devices.mak.tmp GEN ppc64abi32-linux-user/config-devices.mak.tmp GEN nios2-linux-user/config-devices.mak GEN mipsn32-linux-user/config-devices.mak GEN ppc64le-linux-user/config-devices.mak.tmp GEN ppc64-linux-user/config-devices.mak.tmp GEN ppc64abi32-linux-user/config-devices.mak GEN or1k-linux-user/config-devices.mak GEN ppc-linux-user/config-devices.mak.tmp GEN ppc64-linux-user/config-devices.mak GEN ppc64le-linux-user/config-devices.mak GEN s390x-linux-user/config-devices.mak.tmp GEN sh4eb-linux-user/config-devices.mak.tmp GEN sh4-linux-user/config-devices.mak.tmp GEN ppc-linux-user/config-devices.mak GEN sh4eb-linux-user/config-devices.mak GEN sparc32plus-linux-user/config-devices.mak.tmp GEN s390x-linux-user/config-devices.mak GEN sh4-linux-user/config-devices.mak GEN sparc64-linux-user/config-devices.mak.tmp GEN sparc-linux-user/config-devices.mak.tmp GEN tilegx-linux-user/config-devices.mak.tmp GEN sparc-linux-user/config-devices.mak GEN sparc64-linux-user/config-devices.mak GEN sparc32plus-linux-user/config-devices.mak GEN x86_64-linux-user/config-devices.mak.tmp GEN config-host.h GEN x86_64-linux-user/config-devices.mak GIT ui/keycodemapdb capstone GEN tilegx-linux-user/config-devices.mak GEN qemu-options.def GEN qmp-commands.h GEN qapi-types.h GEN qapi-visit.h GEN qapi-event.h GEN qmp-marshal.c GEN qapi-types.c GEN qapi-visit.c GEN qapi-event.c GEN qmp-introspect.h GEN qmp-introspect.c GEN trace/generated-tcg-tracers.h GEN trace/generated-helpers-wrappers.h GEN trace/generated-helpers.h GEN trace/generated-helpers.c GEN module_block.h GEN tests/test-qapi-types.h GEN tests/test-qapi-visit.h GEN tests/test-qmp-commands.h GEN tests/test-qapi-event.h GEN tests/test-qmp-introspect.h GEN trace-root.h GEN util/trace.h
Submodule 'capstone' (git://git.qemu.org/capstone.git) registered for path 'capstone' Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb'
GEN crypto/trace.h
GEN io/trace.h
Cloning into '/var/tmp/patchew-tester-tmp-zu_flv2_/src/capstone'...
GEN migration/trace.h
GEN block/trace.h
GEN chardev/trace.h
GEN hw/block/trace.h
GEN hw/block/dataplane/trace.h
GEN hw/char/trace.h
GEN hw/intc/trace.h
GEN hw/net/trace.h
GEN hw/virtio/trace.h
GEN hw/audio/trace.h
GEN hw/misc/trace.h
GEN hw/usb/trace.h
GEN hw/scsi/trace.h
GEN hw/nvram/trace.h
GEN hw/display/trace.h
GEN hw/input/trace.h
GEN hw/timer/trace.h
GEN hw/dma/trace.h
GEN hw/sparc/trace.h
GEN hw/sd/trace.h
GEN hw/isa/trace.h
GEN hw/mem/trace.h
GEN hw/i386/trace.h
GEN hw/i386/xen/trace.h
GEN hw/9pfs/trace.h
GEN hw/ppc/trace.h
GEN hw/pci/trace.h
GEN hw/s390x/trace.h
GEN hw/vfio/trace.h
GEN hw/acpi/trace.h
GEN hw/arm/trace.h
GEN hw/alpha/trace.h
GEN hw/xen/trace.h
GEN hw/ide/trace.h
GEN ui/trace.h
GEN audio/trace.h
GEN net/trace.h
GEN target/arm/trace.h
GEN target/i386/trace.h
GEN target/mips/trace.h
GEN target/sparc/trace.h
GEN target/s390x/trace.h
GEN target/ppc/trace.h
GEN qom/trace.h
GEN linux-user/trace.h
GEN qapi/trace.h
GEN accel/tcg/trace.h
GEN accel/kvm/trace.h
GEN nbd/trace.h
GEN scsi/trace.h
GEN trace-root.c
GEN util/trace.c
GEN crypto/trace.c
GEN io/trace.c
GEN migration/trace.c
GEN block/trace.c
GEN chardev/trace.c
GEN hw/block/trace.c
GEN hw/block/dataplane/trace.c
GEN hw/char/trace.c
GEN hw/intc/trace.c
GEN hw/net/trace.c
GEN hw/virtio/trace.c
GEN hw/audio/trace.c
GEN hw/misc/trace.c
GEN hw/usb/trace.c
GEN hw/scsi/trace.c
GEN hw/nvram/trace.c
GEN hw/display/trace.c
GEN hw/input/trace.c
GEN hw/timer/trace.c
GEN hw/dma/trace.c
GEN hw/sparc/trace.c
GEN hw/sd/trace.c
GEN hw/isa/trace.c
GEN hw/mem/trace.c
GEN hw/i386/trace.c
GEN hw/i386/xen/trace.c
GEN hw/9pfs/trace.c
GEN hw/ppc/trace.c
GEN hw/pci/trace.c
GEN hw/s390x/trace.c
GEN hw/vfio/trace.c
GEN hw/acpi/trace.c
GEN hw/arm/trace.c
GEN hw/alpha/trace.c
GEN hw/xen/trace.c
GEN hw/ide/trace.c
GEN ui/trace.c
GEN audio/trace.c
GEN net/trace.c
GEN target/arm/trace.c
GEN target/i386/trace.c
GEN target/mips/trace.c
GEN target/sparc/trace.c
GEN target/s390x/trace.c
GEN target/ppc/trace.c
GEN qom/trace.c
GEN linux-user/trace.c
GEN qapi/trace.c
GEN accel/tcg/trace.c
GEN accel/kvm/trace.c
GEN nbd/trace.c
GEN scsi/trace.c
GEN config-all-devices.mak
Cloning into '/var/tmp/patchew-tester-tmp-zu_flv2_/src/ui/keycodemapdb'...
GEN ui/input-keymap-linux-to-qcode.c
GEN ui/input-keymap-qcode-to-qnum.c
GEN ui/input-keymap-qnum-to-qcode.c
CC cs.o
GEN ui/input-keymap-qcode-to-linux.c
CC SStream.o
CC utils.o
CC MCInstrDesc.o
CC MCRegisterInfo.o
CC arch/ARM/ARMDisassembler.o
CC arch/ARM/ARMInstPrinter.o
CC arch/ARM/ARMMapping.o
CC arch/ARM/ARMModule.o
CC arch/AArch64/AArch64BaseInfo.o
CC arch/AArch64/AArch64Disassembler.o
CC arch/AArch64/AArch64InstPrinter.o
CC arch/AArch64/AArch64Mapping.o
CC arch/AArch64/AArch64Module.o
CC arch/Mips/MipsDisassembler.o
CC arch/Mips/MipsInstPrinter.o
CC arch/Mips/MipsMapping.o
CC arch/Mips/MipsModule.o
CC arch/PowerPC/PPCDisassembler.o
CC arch/PowerPC/PPCInstPrinter.o
CC arch/PowerPC/PPCMapping.o
CC arch/PowerPC/PPCModule.o
CC arch/Sparc/SparcDisassembler.o
CC arch/Sparc/SparcInstPrinter.o
CC arch/Sparc/SparcMapping.o
CC arch/Sparc/SparcModule.o
CC arch/SystemZ/SystemZDisassembler.o
CC arch/SystemZ/SystemZInstPrinter.o
CC arch/SystemZ/SystemZMapping.o
CC arch/SystemZ/SystemZModule.o
CC arch/SystemZ/SystemZMCTargetDesc.o
CC arch/X86/X86DisassemblerDecoder.o
CC arch/X86/X86Disassembler.o
CC arch/X86/X86IntelInstPrinter.o
CC arch/X86/X86ATTInstPrinter.o
CC arch/X86/X86Mapping.o
CC arch/X86/X86Module.o
CC arch/XCore/XCoreDisassembler.o
CC arch/XCore/XCoreInstPrinter.o
CC arch/XCore/XCoreMapping.o
CC arch/XCore/XCoreModule.o
CC MCInst.o
AR libcapstone.a
ar: creating /var/tmp/patchew-tester-tmp-zu_flv2_/src/build/capstone/libcapstone.a
make[1]: '/var/tmp/patchew-tester-tmp-zu_flv2_/src/build/capstone/libcapstone.a' is up to date.
CC tests/qemu-iotests/socket_scm_helper.o
GEN docs/version.texi
GEN qemu-monitor.texi
GEN qemu-options.texi
GEN qemu-img-cmds.texi
GEN qemu-monitor-info.texi
GEN qemu-img.1
GEN qemu-nbd.8
GEN qemu-ga.8
GEN docs/interop/qemu-qmp-qapi.texi
GEN docs/interop/qemu-ga-qapi.texi
GEN docs/qemu-block-drivers.7
GEN fsdev/virtfs-proxy-helper.1
GEN qga/qapi-generated/qga-qapi-types.h
GEN qga/qapi-generated/qga-qapi-visit.h
GEN qga/qapi-generated/qga-qmp-commands.h
GEN qga/qapi-generated/qga-qapi-types.c
GEN qga/qapi-generated/qga-qapi-visit.c
GEN qga/qapi-generated/qga-qmp-marshal.c
CC qmp-introspect.o
CC qapi-types.o
CC qapi-visit.o
CC qapi-event.o
CC qapi/qapi-visit-core.o
CC qapi/qapi-dealloc-visitor.o
CC qapi/qobject-input-visitor.o
CC qapi/qobject-output-visitor.o
CC qapi/qmp-registry.o
CC qapi/qmp-dispatch.o
CC qapi/string-input-visitor.o
CC qapi/string-output-visitor.o
CC qapi/opts-visitor.o
CC qapi/qapi-clone-visitor.o
CC qapi/qmp-event.o
CC qapi/qapi-util.o
CC qobject/qnull.o
CC qobject/qnum.o
CC qobject/qstring.o
CC qobject/qdict.o
CC qobject/qlist.o
CC qobject/qbool.o
CC qobject/qlit.o
CC qobject/qjson.o
CC qobject/qobject.o
CC qobject/json-lexer.o
CC qobject/json-streamer.o
CC qobject/json-parser.o
CC trace/control.o
CC trace/qmp.o
CC util/osdep.o
CC util/cutils.o
CC util/unicode.o
CC util/qemu-timer-common.o
CC util/bufferiszero.o
CC util/lockcnt.o
CC util/aiocb.o
CC util/async.o
CC util/thread-pool.o
CC util/qemu-timer.o
CC util/main-loop.o
CC util/iohandler.o
CC util/aio-posix.o
CC util/compatfd.o
CC util/event_notifier-posix.o
CC util/mmap-alloc.o
CC util/oslib-posix.o
CC util/qemu-openpty.o
CC util/qemu-thread-posix.o
CC util/memfd.o
CC util/envlist.o
CC util/path.o
CC util/module.o
CC util/host-utils.o
CC util/bitmap.o
CC util/bitops.o
CC util/hbitmap.o
CC util/fifo8.o
CC util/acl.o
CC util/cacheinfo.o
CC util/error.o
CC util/qemu-error.o
CC util/id.o
CC util/iov.o
CC util/qemu-config.o
CC util/qemu-sockets.o
CC util/uri.o
CC util/notify.o
CC util/qemu-option.o
CC util/qemu-progress.o
CC util/keyval.o
CC util/hexdump.o
CC util/crc32c.o
CC util/uuid.o
CC util/throttle.o
CC util/getauxval.o
CC util/readline.o
CC util/rcu.o
CC util/qemu-coroutine.o
CC util/qemu-coroutine-lock.o
CC util/qemu-coroutine-io.o
CC util/qemu-coroutine-sleep.o
CC util/coroutine-ucontext.o
CC util/buffer.o
CC util/timed-average.o
CC util/base64.o
CC util/log.o
CC util/pagesize.o
CC util/qdist.o
CC util/qht.o
CC util/range.o
CC util/stats64.o
CC util/systemd.o
CC trace-root.o
CC util/trace.o
CC crypto/trace.o
CC io/trace.o
CC migration/trace.o
CC block/trace.o
CC chardev/trace.o
CC hw/block/trace.o
CC hw/block/dataplane/trace.o
CC hw/char/trace.o
CC hw/intc/trace.o
CC hw/net/trace.o
CC hw/virtio/trace.o
CC hw/audio/trace.o
CC hw/misc/trace.o
CC hw/usb/trace.o
CC hw/scsi/trace.o
CC hw/nvram/trace.o
CC hw/display/trace.o
CC hw/input/trace.o
CC hw/timer/trace.o
CC hw/dma/trace.o
CC hw/sparc/trace.o
CC hw/sd/trace.o
CC hw/isa/trace.o
CC hw/mem/trace.o
CC hw/i386/trace.o
CC hw/i386/xen/trace.o
CC hw/9pfs/trace.o
CC hw/ppc/trace.o
CC hw/pci/trace.o
CC hw/s390x/trace.o
CC hw/vfio/trace.o
CC hw/acpi/trace.o
CC hw/arm/trace.o
CC hw/alpha/trace.o
CC hw/xen/trace.o
CC hw/ide/trace.o
CC ui/trace.o
CC audio/trace.o
CC net/trace.o
CC target/arm/trace.o
CC target/i386/trace.o
CC target/mips/trace.o
CC target/sparc/trace.o
CC target/s390x/trace.o
CC target/ppc/trace.o
CC qom/trace.o
CC linux-user/trace.o
CC qapi/trace.o
CC accel/tcg/trace.o
CC accel/kvm/trace.o
CC nbd/trace.o
CC scsi/trace.o
CC crypto/pbkdf-stub.o
CC stubs/arch-query-cpu-def.o
CC stubs/arch-query-cpu-model-expansion.o
CC stubs/arch-query-cpu-model-comparison.o
CC stubs/arch-query-cpu-model-baseline.o
CC stubs/bdrv-next-monitor-owned.o
CC stubs/blk-commit-all.o
CC stubs/blockdev-close-all-bdrv-states.o
CC stubs/clock-warp.o
CC stubs/cpu-get-clock.o
CC stubs/cpu-get-icount.o
CC stubs/dump.o
CC stubs/error-printf.o
CC stubs/fdset.o
CC stubs/gdbstub.o
CC stubs/get-vm-name.o
CC stubs/iothread.o
CC stubs/iothread-lock.o
CC stubs/is-daemonized.o
CC stubs/linux-aio.o
CC stubs/machine-init-done.o
CC stubs/migr-blocker.o
CC stubs/change-state-handler.o
CC stubs/monitor.o
CC stubs/notify-event.o
CC stubs/qtest.o
CC stubs/replay.o
CC stubs/runstate-check.o
CC stubs/set-fd-handler.o
CC stubs/slirp.o
CC stubs/sysbus.o
CC stubs/tpm.o
CC stubs/trace-control.o
CC stubs/uuid.o
CC stubs/vm-stop.o
CC stubs/vmstate.o
CC stubs/qmp_pc_dimm.o
CC stubs/target-monitor-defs.o
CC stubs/target-get-monitor-def.o
CC stubs/pc_madt_cpu_entry.o
CC stubs/vmgenid.o
CC stubs/xen-common.o
CC stubs/xen-hvm.o
CC stubs/pci-host-piix.o
CC qemu-keymap.o
CC ui/input-keymap.o
CC contrib/ivshmem-client/ivshmem-client.o
CC contrib/ivshmem-client/main.o
CC contrib/ivshmem-server/ivshmem-server.o
CC contrib/ivshmem-server/main.o
CC qemu-nbd.o
CC block.o
CC blockjob.o
CC qemu-io-cmds.o
CC replication.o
CC block/raw-format.o
CC block/qcow.o
CC block/vdi.o
CC block/vmdk.o
CC block/cloop.o
CC block/bochs.o
CC block/vpc.o
CC block/vvfat.o
CC block/dmg.o
CC block/qcow2.o
CC block/qcow2-refcount.o
CC block/qcow2-cluster.o
CC block/qcow2-snapshot.o
CC block/qcow2-cache.o
CC block/qcow2-bitmap.o
CC block/qed.o
CC block/qed-l2-cache.o
CC block/qed-table.o
CC block/qed-cluster.o
CC block/qed-check.o
CC block/vhdx.o
CC block/vhdx-endian.o
CC block/vhdx-log.o
CC block/quorum.o
CC block/parallels.o
CC block/blkdebug.o
CC block/blkverify.o
CC block/blkreplay.o
CC block/block-backend.o
CC block/snapshot.o
CC block/qapi.o
CC block/file-posix.o
CC block/linux-aio.o
CC block/null.o
CC block/mirror.o
CC block/commit.o
CC block/io.o
CC block/throttle-groups.o
CC block/nbd.o
CC block/nbd-client.o
CC block/sheepdog.o
CC block/iscsi-opts.o
CC block/accounting.o
CC block/dirty-bitmap.o
CC block/write-threshold.o
CC block/backup.o
CC block/replication.o
CC block/throttle.o
CC block/crypto.o
CC nbd/server.o
CC nbd/client.o
CC nbd/common.o
CC scsi/utils.o
CC scsi/pr-manager.o
CC scsi/pr-manager-helper.o
CC block/iscsi.o
CC block/nfs.o
CC block/curl.o
CC block/rbd.o
CC block/gluster.o
CC block/ssh.o
/var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c: In function ‘iscsi_co_block_status’:
/var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c:755:14: error: ‘iTask.task’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (iTask.task != NULL) {
~~~~~^~~~~cc1: all warnings being treated as errors
make: *** [/var/tmp/patchew-tester-tmp-zu_flv2_/src/rules.mak:66: block/iscsi.o] Error 1
make: *** Waiting for unfinished jobs....
=== OUTPUT END ===
Test command exited with code: 2
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [email protected]
Quoted 10 lines · On Sat, 01/06 22:03, [email protected] wrote:
/var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c: In function ‘iscsi_co_block_status’:/var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c:755:14: error: ‘iTask.task’ may be used uninitialized in this function [-Werror=maybe-uninitialized]if (iTask.task != NULL) { ~~~~~^~~~~cc1: all warnings being treated as errors
make: *** [/var/tmp/patchew-tester-tmp-zu_flv2_/src/rules.mak:66:block/iscsi.o] Error 1
make: *** Waiting for unfinished jobs....
=== OUTPUT END ===Test command exited with code: 2
Seems introduced by e38bc23454ef763deb4405ebdee6a1081aa00bc8. I think the easy fix is to initialize iTask.task to NULL.
Fam
Quoted 10 lines · Fam Zheng
Quoted 9 lines · On Sat, 01/06 22:03, [email protected] wrote:
/var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c: In function ‘iscsi_co_block_status’:/var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c:755:14: error: ‘iTask.task’ may be used uninitialized in this function [-Werror=maybe-uninitialized]if (iTask.task != NULL) { ~~~~~^~~~~cc1: all warnings being treated as errors
make: *** [/var/tmp/patchew-tester-tmp-zu_flv2_/src/rules.mak:66:block/iscsi.o] Error 1
make: *** Waiting for unfinished jobs....
=== OUTPUT END ===
Quoted 4 lines
Quoted 1 line
Test command exited with code: 2
Seems introduced by
e38bc23454ef763deb4405ebdee6a1081aa00bc8. I think the easy fix is to initialize iTask.task to NULL.
I've posted a fix for this:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01132.html
Fam
ping
Quoted 96 lines · Eric Blake
There are patches floating around to add
NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a byte granularity rather than sectors.These patches have been around for a while, but it's time to finish it now that 2.12 is open for patches.
Based-on: <[email protected]> (Kevin's [PULL v3 00/35] Block layer patches)
The overall conversion currently looks like:
part 1:bdrv_is_allocated(merged, commit51b0a488, 2.10) part 2: dirty-bitmap (merged, commitca759622, 2.11) part 3:bdrv_get_block_status(merged, commitf0a9c18f, 2.11) part 4: .bdrv_co_block_status (this series, v5 was here [1])[1] https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg01246.html
Available as a tag at:
git fetchgit://repo.or.cz/qemu/ericb.gitnbd-byte-callback-v7Since v6:
- add R-bs
- improve some commit messages, comments, and variable types [Fam]
- fix conversion bugs [Vladimir]
- rebase to master (well, Kevin's pull request) [Jeff]001/20:[----] [--] 'block: Add .bdrv_co_block_status() callback' 002/20:[----] [--] 'block: Switch passthrough drivers to .bdrv_co_block_status()' 003/20:[----] [--] 'file-posix: Switch to .bdrv_co_block_status()' 004/20:[----] [--] 'gluster: Switch to .bdrv_co_block_status()' 005/20:[----] [--] 'iscsi: Switch
cluster_sectorsto byte-based' 006/20:[0004] [FC] 'iscsi: Switchiscsi_allocmap_update()to byte-based' 007/20:[0006] [FC] 'iscsi: Switch to .bdrv_co_block_status()' 008/20:[----] [--] 'null: Switch to .bdrv_co_block_status()' 009/20:[0002] [FC] 'parallels: Switch to .bdrv_co_block_status()' 010/20:[----] [--] 'qcow: Switch to .bdrv_co_block_status()' 011/20:[----] [--] 'qcow2: Switch to .bdrv_co_block_status()' 012/20:[----] [--] 'qed: Switch to .bdrv_co_block_status()' 013/20:[----] [--] 'raw: Switch to .bdrv_co_block_status()' 014/20:[0012] [FC] 'sheepdog: Switch to .bdrv_co_block_status()' 015/20:[----] [--] 'vdi: Avoid bitrot of debugging code' 016/20:[----] [--] 'vdi: Switch to .bdrv_co_block_status()' 017/20:[----] [--] 'vmdk: Switch to .bdrv_co_block_status()' 018/20:[0002] [FC] 'vpc: Switch to .bdrv_co_block_status()' 019/20:[----] [--] 'vvfat: Switch to .bdrv_co_block_status()' 020/20:[----] [--] 'block: Drop unused .bdrv_co_get_block_status()'Eric Blake (20):
block: Add .bdrv_co_block_status() callback
block: Switch passthrough drivers to .bdrv_co_block_status()
file-posix: Switch to .bdrv_co_block_status()
gluster: Switch to .bdrv_co_block_status()
iscsi: Switchcluster_sectorsto byte-based
iscsi: Switchiscsi_allocmap_update()to byte-based
iscsi: Switch to .bdrv_co_block_status()
null: Switch to .bdrv_co_block_status()
parallels: Switch to .bdrv_co_block_status()
qcow: Switch to .bdrv_co_block_status()
qcow2: Switch to .bdrv_co_block_status()
qed: Switch to .bdrv_co_block_status()raw: Switch to .bdrv_co_block_status() sheepdog: Switch to .bdrv_co_block_status() vdi: Avoid bitrot of debugging code vdi: Switch to .bdrv_co_block_status() vmdk: Switch to .bdrv_co_block_status() vpc: Switch to .bdrv_co_block_status() vvfat: Switch to .bdrv_co_block_status() block: Drop unused .bdrv_co_get_block_status()include/block/block.h | 14 ++--- include/block/block_int.h | 51 +++++++++------ block/io.c | 86 +++++++++++-------------- block/blkdebug.c | 20 +++--- block/commit.c | 2 +- block/file-posix.c | 62 +++++++++--------- block/gluster.c | 70 ++++++++++----------- block/iscsi.c | 157 ++++++++++++++++++++++++---------------------- block/mirror.c | 2 +- block/null.c | 23 +++---- block/parallels.c | 22 ++++--- block/qcow.c | 27 ++++---- block/qcow2.c | 24 +++---- block/qed.c | 84 +++++++++---------------- block/raw-format.c | 16 ++--- block/sheepdog.c | 26 ++++---- block/throttle.c | 2 +- block/vdi.c | 45 +++++++------ block/vmdk.c | 38 +++++------ block/vpc.c | 45 ++++++------- block/vvfat.c | 16 +++-- 21 files changed, 404 insertions(+), 428 deletions(-)
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org