Skip to content

add byte-based block_status driver callbacks

Eric Blake qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest21 patches 20 repliesIn review
  2. v720 patches 7 repliesSuperseded
  3. v620 patches 36 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v520 patches5 repliesSuperseded
v420 patches35 repliesSuperseded
v320 patches3 repliesSuperseded
v220 patches0 repliesSuperseded

Changes in v8 from the cover letter

- rebase to master (more iscsi context changes, nvme driver is new)
- add a few more R-bys

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21block: Add .bdrv_co_block_status() callbackblock/io.c include/block/block.h include/block/block_int.h+41 -210 replies
2/21nvme: Drop pointless .bdrv_co_get_block_status()block/nvme.c+0 -141 reply
3/21block: Switch passthrough drivers to .bdrv_co_block_status()block/blkdebug.c block/commit.c block/io.c +3 more+50 -400 replies
4/21file-posix: Switch to .bdrv_co_block_status()block/file-posix.c+29 -330 replies
5/21gluster: Switch to .bdrv_co_block_status()block/gluster.c+34 -360 replies
6/21iscsi: Switch cluster_sectors to byte-basedblock/iscsi.c+35 -210 replies
7/21iscsi: Switch iscsi_allocmap_update() to byte-basedblock/iscsi.c+44 -460 replies
8/21iscsi: Switch to .bdrv_co_block_status()block/iscsi.c+32 -352 replies
9/21null: Switch to .bdrv_co_block_status()block/null.c+12 -1111 replies
10/21parallels: Switch to .bdrv_co_block_status()block/parallels.c+15 -70 replies
11/21qcow: Switch to .bdrv_co_block_status()block/qcow.c+16 -110 replies
12/21qcow2: Switch to .bdrv_co_block_status()block/qcow2.c+13 -110 replies
13/21qed: Switch to .bdrv_co_block_status()block/qed.c+28 -560 replies
14/21raw: Switch to .bdrv_co_block_status()block/raw-format.c+8 -80 replies
15/21sheepdog: Switch to .bdrv_co_block_status()block/sheepdog.c+13 -130 replies
16/21vdi: Avoid bitrot of debugging codeblock/vdi.c+9 -30 replies
17/21vdi: Switch to .bdrv_co_block_status()block/vdi.c+13 -200 replies
18/21vmdk: Switch to .bdrv_co_block_status()block/vmdk.c+14 -240 replies
19/21vpc: Switch to .bdrv_co_block_status()block/vpc.c+23 -222 replies
20/21vvfat: Switch to .bdrv_co_block_status()block/vvfat.c+7 -93 replies
21/21block: Drop unused .bdrv_co_get_block_status()block/io.c include/block/block_int.h+10 -430 replies

Reviews trailers per patch

20 of 21 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyFam ZhengPaolo BonziniStefan WeilPhilippe Mathieu-DaudéJeff Cody
1/21R-b R-b
2/21
3/21R-b R-b
4/21R-b R-b
5/21R-b R-b
6/21R-b A-b
7/21R-b A-b
8/21R-b
9/21R-b R-b
10/21R-b R-b
11/21R-b R-b
12/21R-b R-b
13/21R-b R-b
14/21R-b R-b
15/21R-b R-b R-b
16/21R-b R-b R-b R-b
17/21R-b R-b
18/21R-b R-b
19/21R-b R-b
20/21R-b R-b
21/21R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v8 thread

Cover letter [Qemu-devel] [PATCH v8 00/21] add byte-based block_status driver callbacks

There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a byte granularity rather than sectors.

These patches have been around for a while, but it's time to finish it now that 2.12 is open for patches.

Based-on: <[email protected]> (Kevin's [PULL 00/55] Block layer patches)

The overall conversion currently looks like:
part 1: bdrv_is_allocated (merged, commit 51b0a488, 2.10) part 2: dirty-bitmap (merged, commit ca759622, 2.11) part 3: bdrv_get_block_status (merged, commit f0a9c18f, 2.11) part 4: .bdrv_co_block_status (this series, v7 was here [1])

[1] https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg00954.html

Available as a tag at:
git fetch git://repo.or.cz/qemu/ericb.git nbd-byte-callback-v8

Since v7:
- rebase to master (more iscsi context changes, nvme driver is new)
- add a few more R-bys

Eric Blake (21):
block: Add .bdrv_co_block_status() callback
nvme: Drop pointless .bdrv_co_get_block_status()
block: Switch passthrough drivers to .bdrv_co_block_status()
file-posix: Switch to .bdrv_co_block_status()
gluster: Switch to .bdrv_co_block_status()
iscsi: Switch cluster_sectors to byte-based
iscsi: Switch iscsi_allocmap_update() to byte-based
iscsi: Switch to .bdrv_co_block_status()
null: Switch to .bdrv_co_block_status()
parallels: Switch to .bdrv_co_block_status()
qcow: Switch to .bdrv_co_block_status()
qcow2: Switch to .bdrv_co_block_status()
qed: Switch to .bdrv_co_block_status()

  raw: Switch to .bdrv_co_block_status()
  sheepdog: Switch to .bdrv_co_block_status()
  vdi: Avoid bitrot of debugging code
  vdi: Switch to .bdrv_co_block_status()
  vmdk: Switch to .bdrv_co_block_status()
  vpc: Switch to .bdrv_co_block_status()
  vvfat: Switch to .bdrv_co_block_status()
  block: Drop unused .bdrv_co_get_block_status()
 include/block/block.h     |  14 ++---
 include/block/block_int.h |  51 +++++++++------
 block/io.c                |  86 +++++++++++--------------
 block/blkdebug.c          |  20 +++---
 block/commit.c            |   2 +-
 block/file-posix.c        |  62 +++++++++---------
 block/gluster.c           |  70 ++++++++++-----------
 block/iscsi.c             | 157 ++++++++++++++++++++++++----------------------
 block/mirror.c            |   2 +-
 block/null.c              |  23 +++----
 block/nvme.c              |  14 -----
 block/parallels.c         |  22 ++++---
 block/qcow.c              |  27 ++++----
 block/qcow2.c             |  24 +++----
 block/qed.c               |  84 +++++++++----------------
 block/raw-format.c        |  16 ++---
 block/sheepdog.c          |  26 ++++----
 block/throttle.c          |   2 +-
 block/vdi.c               |  45 +++++++------
 block/vmdk.c              |  38 +++++------
 block/vpc.c               |  45 ++++++-------
 block/vvfat.c             |  16 +++--
 22 files changed, 404 insertions(+), 442 deletions(-)
Signature · 1 line
2.14.3