Skip to contentSkip to conversation

make RUNTIME_TESTS a menuconfig to ease disabling it all

PATCH Applied Vincent Legoll 3 participants 8 messages Dec 9, 2017 – Jan 8, 2018 Library code

v1 of 2 Applied 1/1 Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all

No need to get into the submenu to disable all related config entries.

This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.

This is only intended to change menuconfig UI, not change the config dependencies.

---
 lib/Kconfig.debug | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
lib/Kconfig.debug +5 -2
index 947d3e2ed5c2..9436714254b7 100644
@@ -1660,7 +1660,10 @@ config DMA_API_DEBUG
 
 	  If unsure, say N.
 
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+	bool "Runtime Testing"
+
+if RUNTIME_TESTING_MENU
 
 config LKDTM
 	tristate "Linux Kernel Dump Test Tool Module"
@@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL
 
 	  If unsure, say N.
 
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
 
 config MEMTEST
 	bool "Memtest"
Signature · 1 line
2.14.1
#1 lore raw
Quoted 9 lines · Vincent Legoll

No need to get into the submenu to disable all related config entries.

This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.

This is only intended to change menuconfig UI, not change the config dependencies.

Wouldn't you need a "default y" applied to the menuconfig to achieve this?

With this patch applied defconfigs that enable LKDTM by default will no longer do so (default_defconfig from arch/s390 is an example although there are others).

Daniel.

Quoted 32 lines
---
  lib/Kconfig.debug | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)
lib/Kconfig.debug +5 -2
index 947d3e2ed5c2..9436714254b7 100644
@@ -1660,7 +1660,10 @@ config DMA_API_DEBUG
 
  	  If unsure, say N.
 
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+	bool "Runtime Testing"
+
+if RUNTIME_TESTING_MENU
 
  config LKDTM
  	tristate "Linux Kernel Dump Test Tool Module"
@@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL
 
  	  If unsure, say N.
 
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
 
  config MEMTEST
  	bool "Memtest"
#2 lore raw

Hello,

Quoted 5 lines · Daniel Thompson

Wouldn't you need a "default y" applied to the menuconfig to achieve this?

With this patch applied defconfigs that enable LKDTM by default will no longer do so (default_defconfig from arch/s390 is an example although there are others).

Yes, you're right, I'll resend a v2 with the default y added

Thanks

Signature · 1 line
Vincent Legoll
#3 lore raw

PATCH v2 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all

Is this one better ?

#4 lore raw

PATCH 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all

No need to get into the submenu to disable all related config entries.

This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.

This is only intended to change menuconfig UI, not change the config dependencies.

v2: added "default y" to avoid breaking existing configs

---
 lib/Kconfig.debug | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
lib/Kconfig.debug +5 -2
index 9d5b78aad4c5..ef6db62a5deb 100644
@@ -1627,7 +1627,10 @@ config DMA_API_DEBUG
 
 	  If unsure, say N.
 
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+	bool "Runtime Testing"
+
+if RUNTIME_TESTING_MENU
 
 config LKDTM
 	tristate "Linux Kernel Dump Test Tool Module"
@@ -1915,7 +1918,7 @@ config TEST_DEBUG_VIRTUAL
 
 	  If unsure, say N.
 
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
 
 config MEMTEST
 	bool "Memtest"
Signature · 1 line
2.14.1
#5 lore raw

PATCH v2 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all

Argh, sorry for the forgotten "git add", hopefuly this one will be good

#6 lore raw

PATCH 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all

No need to get into the submenu to disable all related config entries.

This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.

This is only intended to change menuconfig UI, not change the config dependencies.

v2: added "default y" to avoid breaking existing configs

---
 lib/Kconfig.debug | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
lib/Kconfig.debug +6 -2
index 9d5b78aad4c5..732f7b09ad6f 100644
@@ -1627,7 +1627,11 @@ config DMA_API_DEBUG
 
 	  If unsure, say N.
 
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+	bool "Runtime Testing"
+	default y
+
+if RUNTIME_TESTING_MENU
 
 config LKDTM
 	tristate "Linux Kernel Dump Test Tool Module"
@@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL
 
 	  If unsure, say N.
 
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
 
 config MEMTEST
 	bool "Memtest"
Signature · 1 line
2.14.1
#7 lore raw
Quoted 7 lines · Vincent Legoll

No need to get into the submenu to disable all related config entries.

This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.

Quoted 6 lines

This is only intended to change menuconfig UI, not change the config dependencies.

v2: added "default y" to avoid breaking existing configs

Thanks.

Quoted 31 lines
---
 lib/Kconfig.debug | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
lib/Kconfig.debug +6 -2
index 9d5b78aad4c5..732f7b09ad6f 100644
@@ -1627,7 +1627,11 @@ config DMA_API_DEBUG
 
 	  If unsure, say N.
 
-menu "Runtime Testing"
+menuconfig RUNTIME_TESTING_MENU
+	bool "Runtime Testing"
+	default y
+
+if RUNTIME_TESTING_MENU
 
 config LKDTM
 	tristate "Linux Kernel Dump Test Tool Module"
@@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL
 
 	  If unsure, say N.
 
-endmenu # runtime tests
+endif # RUNTIME_TESTING_MENU
 
 config MEMTEST
 	bool "Memtest"
Signature · 1 line
~Randy