make RUNTIME_TESTS a menuconfig to ease disabling it all
PATCH 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries.
This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change the config dependencies.
--- lib/Kconfig.debug | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
lib/Kconfig.debug +5 -2
@@ -1660,7 +1660,10 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module"
@@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest"
Signature · 1 line
2.14.1
Quoted 9 lines · Vincent Legoll
No need to get into the submenu to disable all related config entries.
This makes it easier to disable all
RUNTIME_TESTSconfig options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.This is only intended to change menuconfig UI, not change the config dependencies.
Wouldn't you need a "default y" applied to the menuconfig to achieve this?
With this patch applied defconfigs that enable LKDTM by default will no longer do so (default_defconfig from arch/s390 is an example although there are others).
Daniel.
Quoted 32 lines
Signed-off-by Vincent Legoll <[email protected]>--- lib/Kconfig.debug | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)lib/Kconfig.debug +5
-2@@ -1660,7 +1660,10 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module"@@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest"
Hello,
Quoted 5 lines · Daniel Thompson
Wouldn't you need a "default y" applied to the menuconfig to achieve this?
With this patch applied defconfigs that enable LKDTM by default will no longer do so (
default_defconfigfromarch/s390is an example although there are others).
Yes, you're right, I'll resend a v2 with the default y added
Thanks
Signature · 1 line
Vincent Legoll
PATCH v2 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all
Is this one better ?
PATCH 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries.
This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change the config dependencies.
v2: added "default y" to avoid breaking existing configs
--- lib/Kconfig.debug | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
lib/Kconfig.debug +5 -2
@@ -1627,7 +1627,10 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module"
@@ -1915,7 +1918,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest"
Signature · 1 line
2.14.1
PATCH v2 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all
Argh, sorry for the forgotten "git add", hopefuly this one will be good
PATCH 1/1 make RUNTIME_TESTS a menuconfig to ease disabling it all
No need to get into the submenu to disable all related config entries.
This makes it easier to disable all RUNTIME_TESTS config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change the config dependencies.
v2: added "default y" to avoid breaking existing configs
--- lib/Kconfig.debug | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
lib/Kconfig.debug +6 -2
@@ -1627,7 +1627,11 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + default y + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module"
@@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest"
Signature · 1 line
2.14.1
Quoted 7 lines · Vincent Legoll
No need to get into the submenu to disable all related config entries.
This makes it easier to disable all
RUNTIME_TESTSconfig options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu.
Quoted 6 lines
This is only intended to change menuconfig UI, not change the config dependencies.
v2: added "default y" to avoid breaking existing configs
Signed-off-by Vincent Legoll <[email protected]>
Thanks.
Quoted 31 lines
--- lib/Kconfig.debug | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)lib/Kconfig.debug +6
-2@@ -1627,7 +1627,11 @@ config DMA_API_DEBUG If unsure, say N. -menu "Runtime Testing" +menuconfig RUNTIME_TESTING_MENU + bool "Runtime Testing" + default y + +if RUNTIME_TESTING_MENU config LKDTM tristate "Linux Kernel Dump Test Tool Module"@@ -1915,7 +1919,7 @@ config TEST_DEBUG_VIRTUAL If unsure, say N. -endmenu # runtime tests +endif # RUNTIME_TESTING_MENU config MEMTEST bool "Memtest"
Signature · 1 line
~Randy